mongoid 2.4.0 → 2.4.12

data/CHANGELOG.md

@@ -3,7 +3,335 @@
 For instructions on upgrading to newer versions, visit
 [mongoid.org](http://mongoid.org/docs/upgrading.html).
 
-## 2.4.0 \[ In Development \] \[ Branch: master \]
+## 2.4.12
+
+### Resolved Issues
+
+* \#2178 Ensure destroy callbacks are run post replacement of an embeds one
+  relation.
+
+* \#2169 Allow saves to pass when documents are destroyed after the save
+  in a callback.
+
+* \#2144 Uniqueness validation on paranoid documents now properly scopes.
+
+* \#2127 Don't unbind parents of embedded documents mid nested
+  attributes deletion.
+
+## 2.4.11
+
+### Resolved Issues
+
+* This release forces a cap on the mongo driver version at 1.6.2 due to
+  changes in the `Mongo::Connection.from_uri` API not allowing valid
+  connection options anymore.
+
+* \#2040 Fixed bad interpolation for locale presence validation.
+
+* \#2038 Allow inverse relations to be determined by foreign keys alone
+  if defined on both sides, not just an inverse_of declaration.
+
+* \#2023 Allow serilialization of dynamic types that conflict with core
+  Ruby methods to still be serialized.
+
+* \#2008 Presence validation should hit the db to check validity if the
+  relation in memory is blank.
+
+* \#2006 Allow excluding only the _id field post execution of an #only call.
+
+## 2.4.10
+
+### Resolved Issues
+
+* \#2003 Don't fail on document generation when an embedded document was
+  stored as nil in the database.
+
+* \#1997 Don't delete paranoid embedded docs via nested attributes when
+  a before_destroy callback returns false.
+
+* \#1994 `dependent: :delete` only hits the database once now for one to
+  many and many to many relations instead of once for each document.
+
+* \#1987 Don't double-insert documents into identity map when eager loading
+  twice inside the unit of work.
+
+* \#1976 Don't execute eager load queries when base query is empty.
+
+* \#1953 Uniqueness validation now works on localized fields.
+
+* \#1936 Allow setting n levels deep embedded documents atomically without
+  conflicting mods when not using nested attributes or documents themselves
+  in an update call from the parent.
+
+* \#1957/\#1954 Ensure database name is set with inheritance.
+  (Hans Hasselberg)
+
+## 2.4.9
+
+### Resolved Issues
+
+* \#1943 Ensure numericality validation works for big decimals.
+
+* \#1938 Length validation now works with localized fields.
+
+* \#1936 Conflicting pushes with other pushes is now properly handled.
+
+* \#1933 `Proxy#extend` should delegate through to the target, where
+  extending the proxy itself is now handled through `Proxy#proxy_extend`.
+
+* \#1930 Ensure complex criteria are expanded in all where clauses.
+  (Hans Hasselberg)
+
+* \#1928 Deletion of embedded documents via nested attributes now performs
+  a $pull with id match criteria instead of a $pullAll to cover all cases.
+  Previously newly added defaults to documents that had already persisted
+  could not be deleted in this matter since the doc did not match what was
+  in the database.
+
+* \#1924/\#1917 Fix pushing to embedded relations with default scopes not
+  scoping on the new document. (Hans Hasselberg)
+
+* \#1922/\#1919 Dropping collections unmemoizes the internally wrapped
+  collection, in order to ensure when defining capped collections that
+  they are always recreated as capped. (Hans Hasselberg)
+
+* \#1916/\#1913 Uniqueness validation no longer is affected by the default
+  scope. (Hans Hasselberg)
+
+* \#1778 Ensure foreign keys are always set regardless of binding state.
+
+## 2.4.8
+
+### Resolved Issues
+
+* \#1892 When getting not master operation error, Mongoid should reconnect
+  before retrying the operation.
+
+* \#1887 Don't cascade callbacks to children that don't have the callback
+  defined.
+
+* \#1882 Don't expand duplicate id criterion into an $and with duplicate
+  selections.
+
+* \#1878 Fixed default application values not to apply in certain `only`
+  or `without` selection on iteration, not just `first` and `last`.
+
+* \#1874 Fixed the reject all blank proc constant to handle values
+  properly with a destroy non blank value. (Stefan Daschek)
+
+* \#1869/\#1868 Delayed atomic sets now uses the atomic path instead of
+  the metadata name to fix multiple level embedding issues.
+  (Chris Micacchi provided specs)
+
+* \#1866 Post processed defaults (procs) should be applied post binding
+  of the child in a relation.build.
+
+## 2.4.7
+
+### Resolved Issues
+
+* Ensure reloading of embedded documents retains reference to the parent.
+
+* \#1837 Always pass symbol options to the driver.
+
+* \#1836 Ensure relation counts pick up persisted document that have not
+  had the foreign key link persisted.
+
+* \#1820 Destroying embedded documents in an embeds_many should also
+  removed the document from the underlying _uncoped target and reindex
+  the relation.
+
+* \#1814 Don't cascade callbacks on after_initialize.
+
+* \#1800 Invalid options for the Mongo connection are now filtered out.
+
+* \#1785 Case equality has been fixed to handle instance checks properly.
+
+## 2.4.6
+
+### Resolved Issues
+
+* \#1772 Allow skip and limit to convert strings to integers. (Jean Boussier)
+
+* \#1767 Model#update_attributes accepts mass assignment options again.
+  (Hans Hasselberg)
+
+* \#1762 Criteria#any_of now properly handles localized fields.
+
+* \#1758 Metadata now returns self on options for external library support.
+
+* \#1757 Ensure serialization converts any attribute types to the type
+  defined by the field.
+
+* \#1756 Serializable hash options should pass through to embedded docs.
+
+## 2.4.5
+
+### Resolved Issues
+
+* \#1751 Mongoid's logger now responds to level for Ruby logging API
+  compatibility.
+
+* \#1744/#1750 Sorting works now for localized fields in embedded documents
+  using the criteria API. (Hans Hasselberg)
+
+* \#1746 Presence validation now shows which locales were empty for
+  localized fields. (Cyril Mougel)
+
+* \#1727 Allow dot notation in embedded criteria to work on both embeds one
+  and embeds many. (Lyle Underwood)
+
+* \#1723 Initialize callbacks should cascade through children without needing
+  to determine if the child is changed.
+
+* \#1715 Serializable hashes are now consistent on inclusion of embedded
+  documents per or post save.
+
+* \#1713 Fixing === checks when comparing a class with an instance of a
+  subclass.
+
+* \#1495 Callbacks no longer get the 'super called outside of method` errors on
+  busted 1.8.7 rubies.
+
+## 2.4.4
+
+### Resolved Issues
+
+* \#1705 Allow changing the order of many to many foreign keys.
+
+* \#1703 Updated at is now versioned again. (Lucas Souza)
+
+* \#1686 Set the base metadata on unbind as well as bind for belongs to
+  relations.
+
+* \#1681 Attempt to create indexes for models without namespacing if the
+  namespace does not exist for the subdirectory.
+
+* \#1676 Allow eager loading to work as a default scope.
+
+* \#1665/#1672 Expand complex criteria in nested criteria selectors, like
+  #matches. (Hans Hasselberg)
+
+* \#1668 Ensure Mongoid logger exists before calling warn. (Rémy Coutable)
+
+* \#1661 Ensure uniqueness validation works on cloned documents.
+
+* \#1659 Clear delayed atomic sets when resetting the same embedded relation.
+
+* \#1656/#1657 Don't hit database for uniqueness validation if BOTH scope
+  and attribute hasn't changed. (priyaaank)
+
+* \#1205/#1642 When limiting fields returned from the database via
+  `Criteria#only` and `Criteria#without` and then subsequently saving
+  the document. Default values no longer override excluded fields.
+
+## 2.4.3
+
+### Resolved Issues
+
+* \#1647 DateTime serialization when already in UTC does not convert to
+  local time.
+
+* \#1640 Update consumers should be tied to the name of the collection
+  they persist to, not the name of the class.
+
+* \#1636 Scopes no longer modify parent class scopes when subclassing.
+  (Hans Hasselberg)
+
+* \#1629 $all and $in criteria on embedded many relations now properly
+  handles regex searches and elements of varying length. (Douwe Maan)
+
+* \#1623 Default scopes no longer break Mongoid::Versioning.
+  (Hans Hasselberg)
+
+* \#1605 Fix regression of rescue responses, Rails 3.2
+
+## 2.4.2
+
+### Resolved Issues
+
+* \#1627 Validating format now works properly with localized fields.
+  (Douwe Maan)
+
+* \#1617 Relation proxy methods now show up in Mongoid's list of
+  prohibited fields.
+
+* \#1615 Allow a single configuration of host and port for all spec runs,
+  overridden by setting MONGOID_SPEC_HOST and MONGOID_SPEC_PORT env vars.
+
+* \#1610 When versioning paranoid documents and max version is set, hard
+  delete old versions from the embedded relation.
+
+* \#1609 Allow connection retry during cursor iteration as well as all other
+  operations.
+
+* \#1608 Guard against no method errors when passing ids in nested attributes
+  and the documents do not exist.
+
+* \#1605 Remove deprecation warning on rescue responses, Rails 3.2
+
+* \#1602 Preserve structure of $and and $or queries when typecasting.
+
+* \#1600 Uniqueness validation no longer errors when provided a relation.
+
+* \#1599 Make sure enumerable targets yield to what is in memory first when
+  performing #each, not always the unloaded first.
+
+* \#1597 Fix the ability to change the order of array fields with the same
+  elements.
+
+* \#1590 Allow proper serialization of boolean values in criteria where the
+  field is nested inside an array.
+
+## 2.4.1
+
+### Resolved Issues
+
+* \#1593 Arrays on embedded documents now properly atomically update when
+  modified from original version.
+
+* \#1592 Don't swallow exceptions from index generation in the create_indexes
+  rake task.
+
+* \#1589 Allow assignment of empty array to HABTM when no documents are yet
+  loaded into memory.
+
+* \#1587 When a previous value for an array field was an explicit nil, it can
+  now be reset atomically with new values.
+
+* \#1585 `Model#respond_to?` returns true now for the setter when allowing
+  dynamic fields.
+
+* \#1582 Allow nil values to be set in arrays.
+
+* \#1580 Allow arrays to be set to nil post save, and not just empty.
+
+* \#1579 Don't call #to_a on individual set field elements in criterion.
+
+* \#1576 Don't hit database on uniqueness validation if the field getting
+  validated has not changed.
+
+* \#1571 Aliased fields get all the dirty attribute methods and all getters and
+  setters for both the original name and the alias. (Hans Hasselberg)
+
+* \#1568 Fallback to development environment with warning when no env configured.
+
+* \#1565 For fields and foreign keys with non-standard Ruby or database names,
+  use define_method instead of class_eval for creating the accessors and
+  dirty methods.
+
+* \#1557 Internal strategy class no longer conflicts with models.
+
+* \#1551 Parent documents now return `true` for `Model#changed?` if only child
+  (embedded) documents have changed.
+
+* \#1547 Resetting persisted children from a parent save when new waits until post
+  callbacks, mirroring update functionality.
+
+* \#1536 Eager loading now happens when calling `first` or `last` on a
+  criteria if inclusions are specified.
+
+## 2.4.0
 
 ### New Features
 

data/Rakefile

@@ -2,7 +2,6 @@ require "bundler"
 Bundler.setup
 
 require "rake"
-require "rdoc/task"
 require "rspec"
 require "rspec/core/rake_task"
 
@@ -37,13 +36,5 @@ RSpec::Core::RakeTask.new('spec:progress') do |spec|
   spec.pattern = "spec/**/*_spec.rb"
 end
 
-RDoc::Task.new do |rdoc|
-  rdoc.rdoc_dir = "rdoc"
-  rdoc.title = "mongoid #{Mongoid::VERSION}"
-  rdoc.rdoc_files.include("README*")
-  rdoc.rdoc_files.include("CHANGELOG*")
-  rdoc.rdoc_files.include("lib/**/*.rb")
-end
-
 task :spec => [ "spec:functional", "spec:unit" ]
 task :default => :spec

data/lib/config/locales/bg.yml

@@ -58,3 +58,4 @@ bg:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/de.yml

@@ -58,3 +58,4 @@ de:
         scope_overwrite:
           "Scope :%{scope_name} kann nicht erzeugt werden, da bereits eine Methode
           %{model_name}.%{scope_name} existiert."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/en-GB.yml

@@ -61,3 +61,4 @@ en-GB:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/en.yml

@@ -61,3 +61,4 @@ en:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/es.yml

@@ -56,3 +56,4 @@ es:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/fr.yml

@@ -59,3 +59,4 @@ fr:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/hi.yml

@@ -50,3 +50,4 @@ en:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/hu.yml

@@ -61,3 +61,4 @@ hu:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/id.yml

@@ -59,3 +59,4 @@ id:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/it.yml

@@ -56,3 +56,4 @@ it:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/ja.yml

@@ -54,3 +54,4 @@ ja:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/kr.yml

@@ -51,3 +51,4 @@ kr:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/nl.yml

@@ -58,3 +58,4 @@ nl:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/pl.yml

@@ -56,3 +56,4 @@ pl:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/pt-BR.yml

@@ -57,3 +57,4 @@ pt-BR:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/pt.yml

@@ -57,3 +57,4 @@ pt:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/ro.yml

@@ -63,3 +63,4 @@ ro:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/ru.yml

@@ -58,3 +58,4 @@ ru:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/sv.yml

@@ -57,3 +57,4 @@ sv:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/vi.yml

@@ -59,3 +59,4 @@ vi:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/config/locales/zh-CN.yml

@@ -50,3 +50,4 @@ zh-CN:
         scope_overwrite:
           "Cannot create scope :%{scope_name}, because of existing method
           %{model_name}.%{scope_name}."
+        blank_on_locale: "can't be blank in %{location}"

data/lib/mongoid/atomic/modifiers.rb

@@ -26,18 +26,33 @@ module Mongoid #:nodoc:
         end
       end
 
-      # Adds pull modifiers to the modifiers hash.
+      # Adds pull all modifiers to the modifiers hash.
       #
-      # @example Add pull operations.
-      #   modifiers.pull({ "addresses" => { "street" => "Bond" }})
+      # @example Add pull all operations.
+      #   modifiers.pull_all({ "addresses" => { "street" => "Bond" }})
       #
-      # @param [ Hash ] modifications The pull modifiers.
+      # @param [ Hash ] modifications The pull all modifiers.
       #
-      # @since 2.2.0
+      # @since 3.0.0
+      def pull_all(modifications)
+        modifications.each_pair do |field, value|
+          add_operation(pull_alls, field, value)
+          pull_fields[field.split(".", 2)[0]] = field
+        end
+      end
+
+      # Adds pull all modifiers to the modifiers hash.
+      #
+      # @example Add pull all operations.
+      #   modifiers.pull({ "addresses" => { "_id" => { "$in" => [ 1, 2, 3 ]}}})
+      #
+      # @param [ Hash ] modifications The pull all modifiers.
+      #
+      # @since 3.0.0
       def pull(modifications)
         modifications.each_pair do |field, value|
-          add_operation(pulls, field, value)
-          pull_fields << field.split(".", 2)[0]
+          pulls[field] = value
+          pull_fields[field.split(".", 2)[0]] = field
         end
       end
 
@@ -51,6 +66,7 @@ module Mongoid #:nodoc:
       # @since 2.1.0
       def push(modifications)
         modifications.each_pair do |field, value|
+          push_fields[field] = field
           mods = push_conflict?(field) ? conflicting_pushes : pushes
           add_operation(mods, field, Array.wrap(value))
         end
@@ -69,7 +85,7 @@ module Mongoid #:nodoc:
           next if field == "_id"
           mods = set_conflict?(field) ? conflicting_sets : sets
           add_operation(mods, field, value)
-          set_fields << field.split(".", 2)[0]
+          set_fields[field.split(".", 2)[0]] = field
         end
       end
 
@@ -133,7 +149,7 @@ module Mongoid #:nodoc:
       #
       # @since 2.2.0
       def set_conflict?(field)
-        pull_fields.include?(field.split(".", 2)[0])
+        pull_fields.has_key?(field.split(".", 2)[0])
       end
 
       # Is the operation going to be a conflict for a $push?
@@ -148,7 +164,8 @@ module Mongoid #:nodoc:
       # @since 2.2.0
       def push_conflict?(field)
         name = field.split(".", 2)[0]
-        set_fields.include?(name) || pull_fields.include?(name)
+        set_fields.has_key?(name) || pull_fields.has_key?(name) ||
+          (push_fields.keys.count { |item| item =~ /#{name}/ } > 1)
       end
 
       # Get the conflicting pull modifications.
@@ -208,7 +225,19 @@ module Mongoid #:nodoc:
       #
       # @since 2.2.0
       def pull_fields
-        @pull_fields ||= []
+        @pull_fields ||= {}
+      end
+
+      # Get the names of the fields that need to be pushed.
+      #
+      # @example Get the push fields.
+      #   modifiers.push_fields
+      #
+      # @return [ Array<String> ] The push fields.
+      #
+      # @since 2.2.0
+      def push_fields
+        @push_fields ||= {}
       end
 
       # Get the names of the fields that need to be set.
@@ -220,21 +249,33 @@ module Mongoid #:nodoc:
       #
       # @since 2.2.0
       def set_fields
-        @set_fields ||= []
+        @set_fields ||= {}
       end
 
       # Get the $pullAll operations or intialize a new one.
       #
       # @example Get the $pullAll operations.
-      #   modifiers.pulls
+      #   modifiers.pull_alls
       #
       # @return [ Hash ] The $pullAll operations.
       #
-      # @since 2.1.0
-      def pulls
+      # @since 3.0.0
+      def pull_alls
         self["$pullAll"] ||= {}
       end
 
+      # Get the $pull operations or intialize a new one.
+      #
+      # @example Get the $pull operations.
+      #   modifiers.pulls
+      #
+      # @return [ Hash ] The $pull operations.
+      #
+      # @since 3.0.0
+      def pulls
+        self["$pull"] ||= {}
+      end
+
       # Get the $pushAll operations or intialize a new one.
       #
       # @example Get the $pushAll operations.

data/lib/mongoid/atomic.rb

@@ -160,15 +160,18 @@ module Mongoid #:nodoc:
     #
     # @since 2.2.0
     def atomic_pulls
-      delayed_atomic_pulls.inject({}) do |pulls, (name, docs)|
-        pulls.tap do |pull|
-          docs.each do |doc|
-            (pull[doc.atomic_path] ||= []).push(doc.as_document)
-            doc.destroyed = true
-            doc.flagged_for_destroy = false
-          end
+      pulls = {}
+      delayed_atomic_pulls.each_pair do |_, docs|
+        path = nil
+        ids = docs.map do |doc|
+          path ||= doc.atomic_path
+          doc.destroyed = true
+          doc.flagged_for_destroy = false
+          doc.id
         end
+        pulls[path] = { "_id" => { "$in" => ids }} and path = nil
       end
+      pulls
     end
 
     # Get all the push attributes that need to occur.
@@ -249,6 +252,9 @@ module Mongoid #:nodoc:
     # @example Get the atomic paths.
     #   document.atomic_paths
     #
+    # @todo: Durran: Should probably raise error for embedded docs w/o
+    #   metadata.
+    #
     # @return [ Object ] The associated path.
     #
     # @since 2.1.0
@@ -273,7 +279,7 @@ module Mongoid #:nodoc:
       mods.push(doc.atomic_pushes)
       mods.push(doc.atomic_array_pushes)
       mods.add_to_set(doc.atomic_array_add_to_sets)
-      mods.pull(doc.atomic_array_pulls)
+      mods.pull_all(doc.atomic_array_pulls)
     end
   end
 end

data/lib/mongoid/attributes.rb

@@ -77,7 +77,7 @@ module Mongoid #:nodoc:
     def respond_to?(*args)
       (Mongoid.allow_dynamic_fields &&
         attributes &&
-        attributes.has_key?(args.first.to_s)
+        attributes.has_key?(args.first.to_s.reader)
       ) || super
     end