mongoid-versioning 1.2.0 → 2.0.0

data/spec/mongoid/relations/macros_spec.rb

@@ -1,16 +1,16 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Relations::Macros do
-  describe ".embedded_in" do
-    context "when the document is versioned" do
-      it "raises an error" do
-        expect {
+  describe '.embedded_in' do
+    context 'when the document is versioned' do
+      it 'raises an error' do
+        expect do
           Class.new do
             include Mongoid::Document
             include Mongoid::Versioning
             embedded_in :parent_class
           end
-        }.to raise_error(Mongoid::Errors::VersioningNotOnRoot)
+        end.to raise_error(Mongoid::Errors::VersioningNotOnRoot)
       end
     end
   end

data/spec/mongoid/relations/metadata_spec.rb

@@ -1,10 +1,8 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Relations::Metadata do
-  describe "#versioned?" do
-
-    context "when versioned is true" do
-
+  describe '#versioned?' do
+    context 'when versioned is true' do
       let(:metadata) do
         described_class.new(
           name: :versions,
@@ -13,13 +11,12 @@ describe Mongoid::Relations::Metadata do
         )
       end
 
-      it "returns true" do
+      it 'returns true' do
         expect(metadata).to be_versioned
       end
     end
 
-    context "when versioned is false" do
-
+    context 'when versioned is false' do
       let(:metadata) do
         described_class.new(
           name: :versions,
@@ -28,13 +25,12 @@ describe Mongoid::Relations::Metadata do
         )
       end
 
-      it "returns false" do
+      it 'returns false' do
         expect(metadata).not_to be_versioned
       end
     end
 
-    context "when versioned is nil" do
-
+    context 'when versioned is nil' do
       let(:metadata) do
         described_class.new(
           name: :versions,
@@ -42,7 +38,7 @@ describe Mongoid::Relations::Metadata do
         )
       end
 
-      it "returns false" do
+      it 'returns false' do
         expect(metadata).not_to be_versioned
       end
     end

data/spec/mongoid/versioning_spec.rb

@@ -1,11 +1,8 @@
-require_relative "../spec_helper"
+require_relative '../spec_helper'
 
 describe Mongoid::Versioning do
-
-  describe ".max_versions" do
-
-    context "when provided an integer" do
-
+  describe '.max_versions' do
+    context 'when provided an integer' do
       before do
         WikiPage.max_versions(10)
       end
@@ -14,105 +11,95 @@ describe Mongoid::Versioning do
         WikiPage.max_versions(5)
       end
 
-      it "sets the class version max" do
+      it 'sets the class version max' do
         expect(WikiPage.version_max).to eq(10)
       end
     end
 
-    context "when provided a string" do
-
+    context 'when provided a string' do
       before do
-        WikiPage.max_versions("10")
+        WikiPage.max_versions('10')
       end
 
       after do
         WikiPage.max_versions(5)
       end
 
-      it "sets the class version max" do
+      it 'sets the class version max' do
         expect(WikiPage.version_max).to eq(10)
       end
     end
   end
 
-  describe "#version" do
-
-    context "when there is no default scope" do
-
-      context "when the document is new" do
-
-        it "returns 1" do
+  describe '#version' do
+    context 'when there is no default scope' do
+      context 'when the document is new' do
+        it 'returns 1' do
           expect(WikiPage.new.version).to eq(1)
         end
       end
 
-      context "when the document is persisted once" do
-
+      context 'when the document is persisted once' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
-        it "returns 1" do
+        it 'returns 1' do
           expect(page.version).to eq(1)
         end
       end
 
-      context "when the document is persisted more than once" do
-
+      context 'when the document is persisted more than once' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
         before do
-          3.times { |n| page.update_attribute(:title, "#{n}") }
+          3.times { |n| page.update_attribute(:title, n.to_s) }
         end
 
-        it "returns the number of versions" do
+        it 'returns the number of versions' do
           expect(page.version).to eq(4)
         end
       end
 
-      context "when maximum versions is defined" do
-
+      context 'when maximum versions is defined' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
-        context "when saving over the max versions limit" do
-
+        context 'when saving over the max versions limit' do
           before do
-            10.times { |n| page.update_attribute(:title, "#{n}") }
+            10.times { |n| page.update_attribute(:title, n.to_s) }
           end
 
-          it "returns the number of versions" do
+          it 'returns the number of versions' do
             expect(page.version).to eq(11)
           end
         end
       end
 
-      context "when performing versionless saves" do
-
+      context 'when performing versionless saves' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
         before do
           10.times do |n|
-            page.versionless { |doc| doc.update_attribute(:title, "#{n}") }
+            page.versionless { |doc| doc.update_attribute(:title, n.to_s) }
           end
         end
 
-        it "does not increment the version number" do
+        it 'does not increment the version number' do
           expect(page.version).to eq(1)
         end
       end
     end
 
-    context "when there is a default scope" do
-
+    context 'when there is a default scope' do
       before :all do
         class WikiPage
-          default_scope -> { where(author: "Jim") }
+          default_scope -> { where(author: 'Jim') }
         end
       end
 
@@ -120,116 +107,107 @@ describe Mongoid::Versioning do
         WikiPage.default_scoping = nil
       end
 
-      context "when the document is new" do
-
-        it "returns 1" do
+      context 'when the document is new' do
+        it 'returns 1' do
           expect(WikiPage.new.version).to eq(1)
         end
       end
 
-      context "when the document is persisted once" do
-
+      context 'when the document is persisted once' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
-        it "returns 1" do
+        it 'returns 1' do
           expect(page.version).to eq(1)
         end
       end
 
-      context "when the document is persisted more than once" do
-
+      context 'when the document is persisted more than once' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
         before do
-          3.times { |n| page.update_attribute(:title, "#{n}") }
+          3.times { |n| page.update_attribute(:title, n.to_s) }
         end
 
-        it "returns the number of versions" do
+        it 'returns the number of versions' do
           expect(page.version).to eq(4)
         end
       end
 
-      context "when maximum versions is defined" do
-
+      context 'when maximum versions is defined' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
-        context "when saving over the max versions limit" do
-
+        context 'when saving over the max versions limit' do
           before do
-            10.times { |n| page.update_attribute(:title, "#{n}") }
+            10.times { |n| page.update_attribute(:title, n.to_s) }
           end
 
-          it "returns the number of versions" do
+          it 'returns the number of versions' do
             expect(page.version).to eq(11)
           end
         end
       end
 
-      context "when performing versionless saves" do
-
+      context 'when performing versionless saves' do
         let(:page) do
-          WikiPage.create(title: "1")
+          WikiPage.create(title: '1')
         end
 
         before do
           10.times do |n|
-            page.versionless { |doc| doc.update_attribute(:title, "#{n}") }
+            page.versionless { |doc| doc.update_attribute(:title, n.to_s) }
           end
         end
 
-        it "does not increment the version number" do
+        it 'does not increment the version number' do
           expect(page.version).to eq(1)
         end
       end
     end
 
-    context "when not using the default database" do
-
-      let(:title) { "my new wiki" }
+    context 'when not using the default database' do
+      let(:title) { 'my new wiki' }
 
       let!(:page) do
-        WikiPage.with(database: database_id_alt).create!(description: "1",title: title)
+        WikiPage.with(database: database_id_alt).create!(description: '1', title: title)
       end
 
-      context "when the document is persisted once" do
-
-        it "returns 1" do
+      context 'when the document is persisted once' do
+        it 'returns 1' do
           expect(page.version).to eq(1)
         end
 
-        it "does not persist to default database" do
-          expect {
+        it 'does not persist to default database' do
+          expect do
             WikiPage.find_by(title: title)
-          }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          end.to raise_error(Mongoid::Errors::DocumentNotFound)
         end
 
-        it "persists to specified database" do
+        it 'persists to specified database' do
           expect(WikiPage.with(database: database_id_alt).find_by(title: title)).not_to be_nil
         end
       end
 
-      context "when the document is persisted more than once" do
-
+      context 'when the document is persisted more than once' do
         before do
-          3.times { |n| page.with(database: database_id_alt).update_attribute(:description, "#{n}") }
+          3.times { |n| page.with(database: database_id_alt).update_attribute(:description, n.to_s) }
         end
 
-        it "returns the number of versions" do
+        it 'returns the number of versions' do
           expect(page.version).to eq(4)
         end
 
-        it "persists to specified database" do
-          expect(WikiPage.with(database: database_id_alt).find_by(:title => title)).not_to be_nil
+        it 'persists to specified database' do
+          expect(WikiPage.with(database: database_id_alt).find_by(title: title)).not_to be_nil
         end
 
-        it "persists the versions to specified database" do
-          expect(WikiPage.with(database: database_id_alt).find_by(:title => title).version).to eq(4)
+        it 'persists the versions to specified database' do
+          expect(WikiPage.with(database: database_id_alt).find_by(title: title).version).to eq(4)
         end
       end
 
@@ -239,107 +217,98 @@ describe Mongoid::Versioning do
     end
   end
 
-  describe "#versionless" do
-
+  describe '#versionless' do
     let(:page) do
       WikiPage.new(created_at: Time.now.utc)
     end
 
-    context "when executing the block" do
-
-      it "sets versionless to true" do
+    context 'when executing the block' do
+      it 'sets versionless to true' do
         page.versionless do |doc|
           expect(doc.send(:versionless?)).to be_truthy
         end
       end
     end
 
-    context "when the block finishes" do
-
-      it "sets versionless to false" do
+    context 'when the block finishes' do
+      it 'sets versionless to false' do
         page.versionless
         expect(page.send(:versionless?)).to be_falsy
       end
     end
   end
 
-  describe "#versions" do
-
+  describe '#versions' do
     let(:page) do
-      WikiPage.create(title: "1", description: "test") do |wiki|
-        wiki.author = "woodchuck"
+      WikiPage.create(title: '1', description: 'test') do |wiki|
+        wiki.author = 'woodchuck'
       end
     end
 
-    context "when saving the document " do
-
-      context "when the document has changed" do
-
+    context 'when saving the document ' do
+      context 'when the document has changed' do
         before do
-          page.update_attribute(:title, "2")
+          page.update_attribute(:title, '2')
         end
 
         let(:version) do
           page.versions.first
         end
 
-        it "creates a new version" do
-          expect(version.title).to eq("1")
+        it 'creates a new version' do
+          expect(version.title).to eq('1')
         end
 
-        it "properly versions the localized fields" do
-          expect(version.description).to eq("test")
+        it 'properly versions the localized fields' do
+          expect(version.description).to eq('test')
         end
 
-        it "only creates 1 new version" do
+        it 'only creates 1 new version' do
           expect(page.versions.count).to eq(1)
         end
 
-        it "does not version the _id" do
+        it 'does not version the _id' do
           expect(version._id).to be_nil
         end
 
-        it "does version the updated_at timestamp" do
+        it 'does version the updated_at timestamp' do
           expect(version.updated_at).not_to be_nil
         end
 
-        context "when only updated_at was changed" do
-
+        context 'when only updated_at was changed' do
           before do
             page.update_attributes(updated_at: Time.now)
           end
 
-          it "does not generate another version" do
+          it 'does not generate another version' do
             expect(page.versions.count).to eq(1)
           end
         end
 
-        it "does not embed versions within versions" do
+        it 'does not embed versions within versions' do
           expect(version.versions).to be_empty
         end
 
-        it "versions protected fields" do
-          expect(version.author).to eq("woodchuck")
+        it 'versions protected fields' do
+          expect(version.author).to eq('woodchuck')
         end
 
-        context "when saving multiple times" do
-
+        context 'when saving multiple times' do
           before do
-            page.update_attribute(:title, "3")
+            page.update_attribute(:title, '3')
           end
 
-          it "does not embed versions within versions" do
+          it 'does not embed versions within versions' do
             expect(version.versions).to be_empty
           end
 
-          it "does not embed versions multiple levels deep" do
+          it 'does not embed versions multiple levels deep' do
             expect(page.versions.last.versions).to be_empty
           end
         end
       end
 
-      context "when the document has not changed" do
-
+      context 'when the document has not changed' do
         before do
           page.save
         end
@@ -348,65 +317,58 @@ describe Mongoid::Versioning do
           page.versions.first
         end
 
-        it "does not create a new version" do
+        it 'does not create a new version' do
           expect(version).to be_nil
         end
       end
 
-      context "when saving over the number of maximum versions" do
-
-        context "when the document is paranoid" do
-
+      context 'when saving over the number of maximum versions' do
+        context 'when the document is paranoid' do
           let!(:post) do
-            ParanoidPost.create(title: "test")
+            ParanoidPost.create(title: 'test')
           end
 
           before do
             3.times do |n|
-              post.update_attribute(:title, "#{n}")
+              post.update_attribute(:title, n.to_s)
             end
           end
 
-          it "only versions the maximum amount" do
+          it 'only versions the maximum amount' do
             expect(post.versions.target.size).to eq(2)
           end
 
-          it "persists the changes" do
+          it 'persists the changes' do
             expect(post.reload.versions.target.size).to eq(2)
           end
         end
 
-        context "when saving in succession" do
-
+        context 'when saving in succession' do
           before do
             10.times do |n|
-              page.update_attribute(:title, "#{n}")
+              page.update_attribute(:title, n.to_s)
             end
           end
 
-          let(:versions) do
-            page.versions
-          end
-
-          it "only versions the maximum amount" do
-            expect(versions.count).to eq(5)
+          it 'only versions the maximum amount' do
+            expect(page.reload.versions.count).to eq(5)
           end
 
-          it "shifts the versions in order" do
-            expect(versions.last.title).to eq("8")
+          it 'shifts the versions in order' do
+            expect(page.reload.versions.last.title).to eq('8')
           end
 
-          it "persists the version shifts" do
-            expect(page.reload.versions.last.title).to eq("8")
+          it 'persists the version shifts' do
+            expect(page.reload.versions.last.title).to eq('8')
+            expect(page.reload.versions.first.title).to eq('4')
           end
         end
 
-        context "when saving in batches" do
-
+        context 'when saving in batches' do
           before do
             2.times do
               5.times do |n|
-                WikiPage.find(page.id).update_attributes(title: "#{n}")
+                WikiPage.find(page.id).update_attributes(title: n.to_s)
               end
             end
           end
@@ -419,40 +381,37 @@ describe Mongoid::Versioning do
             from_db.versions
           end
 
-          it "only versions the maximum amount" do
+          it 'only versions the maximum amount' do
             expect(versions.count).to eq(5)
           end
         end
       end
 
-      context "when persisting versionless" do
-
+      context 'when persisting versionless' do
         before do
-          page.versionless { |doc| doc.update_attribute(:title, "2") }
+          page.versionless { |doc| doc.update_attribute(:title, '2') }
         end
 
-        it "does not version the document" do
+        it 'does not version the document' do
           expect(page.versions.count).to eq(0)
         end
       end
 
-      context "when deleting versions" do
-
+      context 'when deleting versions' do
         let(:comment) do
           Comment.new(title: "Don't delete me!")
         end
 
         let!(:orphaned) do
-          Comment.create(title: "Annie")
+          Comment.create(title: 'Annie')
         end
 
         before do
           page.comments << comment
-          page.update_attribute(:title, "5")
+          page.update_attribute(:title, '5')
         end
 
-        context "when the version had a dependent relation" do
-
+        context 'when the version had a dependent relation' do
           before do
             page.versions.delete_all
           end
@@ -461,34 +420,33 @@ describe Mongoid::Versioning do
             Comment.find(comment.id)
           end
 
-          it "does not perform dependent cascading" do
+          it 'does not perform dependent cascading' do
             expect(from_db).to eq(comment)
           end
 
-          it "does not delete related orphans" do
+          it 'does not delete related orphans' do
             expect(Comment.find(orphaned.id)).to eq(orphaned)
           end
 
-          it "deletes the version" do
+          it 'deletes the version' do
             expect(page.versions).to be_empty
           end
 
-          it "persists the deletion" do
+          it 'persists the deletion' do
             expect(page.reload.versions).to be_empty
           end
 
-          it "retains the root relation" do
-            expect(page.reload.comments).to eq([ comment ])
+          it 'retains the root relation' do
+            expect(page.reload.comments).to eq([comment])
           end
         end
       end
     end
   end
 
-  context "when appending a self referencing document with versions" do
-
+  context 'when appending a self referencing document with versions' do
     let(:page) do
-      WikiPage.create(title: "1")
+      WikiPage.create(title: '1')
     end
 
     let(:child) do
@@ -499,12 +457,12 @@ describe Mongoid::Versioning do
       page.child_pages << child
     end
 
-    it "allows the document to be added" do
-      expect(page.child_pages).to eq([ child ])
+    it 'allows the document to be added' do
+      expect(page.child_pages).to eq([child])
     end
 
-    it "persists the changes" do
-      expect(page.reload.child_pages).to eq([ child ])
+    it 'persists the changes' do
+      expect(page.reload.child_pages).to eq([child])
     end
   end
 end