mongoid-rspec 3.0.0 → 4.1.0

data/spec/models/site.rb

@@ -3,7 +3,11 @@ class Site
 
   field :name
 
-  has_many :users, inverse_of: :site, order: :email.desc, counter_cache: true
+  if Mongoid::Compatibility::Version.mongoid6_or_older?
+    has_many :users, inverse_of: :site, order: :email.desc, counter_cache: true
+  else
+    has_many :users, inverse_of: :site, order: :email.desc
+  end
 
   validates :name, presence: true, uniqueness: true
 end

data/spec/models/user.rb

@@ -13,21 +13,22 @@ class User
   belongs_to :site, inverse_of: :users
   has_many :articles, foreign_key: :author_id, order: :title
   has_many :comments, dependent: :destroy, autosave: true
-  has_and_belongs_to_many :children, class_name: "User"
-  has_one :record, autobuild: true
+  has_many :messages, dependent: :destroy
+  has_and_belongs_to_many :children, class_name: 'User'
+  has_one :record, autobuild: true, inverse_of: :user
 
-  embeds_one :profile
+  embeds_one :profile, inverse_of: :user
 
-  validates :login, presence: true, uniqueness: { scope: :site }, format: { with: /\A[\w\-]+\z/ }, exclusion: { in: ["super", "index", "edit"] }
-  validates :email, uniqueness: { case_sensitive: false, scope: :site, message: "is already taken" }, confirmation: true
-  validates :role, presence: true, inclusion: { in: ["admin", "moderator", "member"] }
+  validates :login, presence: true, uniqueness: { scope: :site }, format: { with: /\A[\w\-]+\z/ }, exclusion: { in: %w[super index edit] }
+  validates :email, uniqueness: { case_sensitive: false, scope: :site, message: 'is already taken' }, confirmation: true
+  validates :role, presence: true, inclusion: { in: %w[admin moderator member] }
   validates :profile, presence: true, associated: true
-  validates :age, presence: true, numericality: true, inclusion: { in: 23..42 }, on: [:create, :update]
-  validates :password, presence: true, on: [:create, :update]
-  validates :password, exclusion: { in: ->(user) { ['password'] } }
-  validates :password, confirmation: { message: "Password confirmation must match given password" }
+  validates :age, presence: true, numericality: true, inclusion: { in: 23..42 }, on: %i[create update]
+  validates :password, presence: true, on: %i[create update]
+  validates :password, exclusion: { in: ->(_user) { ['password'] } }
+  validates :password, confirmation: { message: 'Password confirmation must match given password' }
   validates :provider_uid, presence: true
-  validates :locale, inclusion: { in: ->(user) { [:en, :ru] } }
+  validates :locale, inclusion: { in: ->(_user) { %i[en ru] } }
 
   accepts_nested_attributes_for :articles, :comments
 

data/spec/spec_helper.rb

@@ -1,24 +1,23 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "lib"))
-MODELS = File.join(File.dirname(__FILE__), "models")
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), 'lib'))
+MODELS = File.join(File.dirname(__FILE__), 'models')
 $LOAD_PATH.unshift(MODELS)
-VALIDATORS = File.join(File.dirname(__FILE__), "validators")
+VALIDATORS = File.join(File.dirname(__FILE__), 'validators')
 $LOAD_PATH.unshift(VALIDATORS)
 
-require "rubygems"
-require "bundler"
+require 'rubygems'
+require 'bundler'
 Bundler.setup
 
 require 'mongoid'
-require 'rspec'
 require 'rspec/core'
 require 'rspec/expectations'
+require 'mongoid/compatibility'
 
-Mongoid.configure do |config|
-  config.connect_to("mongoid-rspec-test")
-end
+Mongoid::Config.connect_to('mongoid-rspec-test') if Mongoid::Compatibility::Version.mongoid3_or_newer?
+Mongo::Logger.logger.level = ::Logger::INFO if Mongoid::Compatibility::Version.mongoid5_or_newer?
 
-Dir[ File.join(MODELS, "*.rb") ].sort.each { |file| require File.basename(file) }
+Dir[File.join(MODELS, '*.rb')].sort.each { |file| require File.basename(file) }
 
 require 'mongoid-rspec'
 

data/spec/unit/accept_nested_attributes_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe "AcceptsNestedAttributes" do
+RSpec.describe 'AcceptsNestedAttributes' do
   describe User do
     it { is_expected.to accept_nested_attributes_for(:articles) }
     it { is_expected.to accept_nested_attributes_for(:comments) }

data/spec/unit/associations_spec.rb

@@ -1,14 +1,16 @@
 require 'spec_helper'
 
-RSpec.describe "Associations" do
+RSpec.describe 'Associations' do
   describe User do
-    it { is_expected.to have_many(:articles).with_foreign_key(:author_id).ordered_by(:title) }
+    if Mongoid::Compatibility::Version.mongoid6_or_newer?
+      it { is_expected.to have_many(:articles).with_foreign_key(:author_id).ordered_by(:title) }
+    end
 
-    it { is_expected.to have_one(:record).with_autobuild }
+    it { is_expected.to have_one(:record).as_inverse_of(:user).with_autobuild }
 
     it { is_expected.to have_many(:comments).with_dependent(:destroy).with_autosave }
 
-    it { is_expected.to embed_one(:profile) }
+    it { is_expected.to embed_one(:profile).as_inverse_of(:user) }
 
     it { is_expected.to have_and_belong_to_many(:children).of_type(User) }
   end
@@ -19,8 +21,8 @@ RSpec.describe "Associations" do
 
   describe Article do
     it { is_expected.to belong_to(:author).of_type(User).as_inverse_of(:articles).with_index }
-    it { is_expected.to embed_many(:comments).with_cascading_callbacks }
-    it { is_expected.to embed_one(:permalink) }
+    it { is_expected.to embed_many(:comments).as_inverse_of(:article).with_cascading_callbacks }
+    it { is_expected.to embed_one(:permalink).as_inverse_of(:linkable) }
   end
 
   describe Comment do
@@ -37,6 +39,16 @@ RSpec.describe "Associations" do
   end
 
   describe Site do
-    it { is_expected.to have_many(:users).as_inverse_of(:site).ordered_by(:email.desc).with_counter_cache }
+    if Mongoid::Compatibility::Version.mongoid6_or_older?
+      it { is_expected.to have_many(:users).as_inverse_of(:site).ordered_by(:email.desc).with_counter_cache }
+    elsif Mongoid::Compatibility::Version.mongoid7_or_newer?
+      it { is_expected.to have_many(:users).as_inverse_of(:site).ordered_by(:email.desc) }
+    end
+  end
+
+  describe Message do
+    if Mongoid::Compatibility::Version.mongoid6_or_newer?
+      it { is_expected.to belong_to(:user).with_optional }
+    end
   end
 end

data/spec/unit/be_dynamic_document_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+RSpec.describe Mongoid::Matchers::BeDynamicDocument do
+  context 'when model does\'t include Mongoid::Document' do
+    subject do
+      Class.new
+    end
+
+    it { is_expected.not_to be_mongoid_document }
+  end
+
+  context 'when model doesn\'t include Mongoid::Document' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+      end
+    end
+
+    it { is_expected.to be_mongoid_document }
+  end
+end

data/spec/unit/be_mongoid_document_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+if Mongoid::Compatibility::Version.mongoid4_or_newer?
+  RSpec.describe Mongoid::Matchers::BeMongoidDocument do
+    context 'when model does\'t include Mongoid::Attributes::Dynamic' do
+      subject do
+        Class.new do
+          include Mongoid::Document
+        end
+      end
+
+      it { is_expected.not_to be_dynamic_document }
+    end
+
+    context 'when model doesn\'t include Mongoid::Attributes::Dynamic' do
+      subject do
+        Class.new do
+          include Mongoid::Document
+          include Mongoid::Attributes::Dynamic
+        end
+      end
+
+      it { is_expected.to be_dynamic_document }
+    end
+  end
+end

data/spec/unit/be_stored_in.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+RSpec.describe Mongoid::Matchers::BeStoredIn do
+  subject do
+    Class.new do
+      include Mongoid::Document
+      store_in collection: 'citizens', database: 'other', client: 'secondary'
+    end
+  end
+
+  it 'detects storage options' do
+    is_expected.to be_stored_in(collection: 'citizens', database: 'other', client: 'secondary')
+  end
+
+  it 'detects even part of storage options' do
+    is_expected.to be_stored_in(database: 'other')
+    is_expected.to be_stored_in(client: 'secondary')
+    is_expected.to be_stored_in(collection: 'citizens')
+    is_expected.to be_stored_in(collection: 'citizens', database: 'other')
+    is_expected.to be_stored_in(database: 'other', client: 'secondary')
+    is_expected.to be_stored_in(collection: 'citizens', client: 'secondary')
+  end
+
+  it 'detects differences' do
+    is_expected.not_to be_stored_in(collection: 'aliens')
+  end
+
+  context 'when models has storage options defined via blocks, procs or lambdas' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        store_in database: -> { Thread.current[:database] }
+      end
+    end
+
+    before do
+      Thread.current[:database] = 'db1981'
+    end
+
+    it 'detects storage options' do
+      is_expected.to be_stored_in(database: 'db1981')
+    end
+
+    it 'reflects changes in storage options' do
+      is_expected.to be_stored_in(database: 'db1981')
+      Thread.current[:database] = 'db2200'
+      is_expected.to be_stored_in(database: 'db2200')
+    end
+
+    it 'detects differences' do
+      is_expected.not_to be_stored_in(database: 'other')
+    end
+  end
+end

data/spec/unit/document_spec.rb

@@ -1,26 +1,17 @@
 require 'spec_helper'
 
-RSpec.describe "Document" do
+RSpec.describe 'Document' do
   describe User do
     it { is_expected.to have_fields(:email, :login) }
-    it { is_expected.to be_timestamped_document }
-    it { is_expected.to be_timestamped_document.with(:created) }
-    it { is_expected.not_to be_timestamped_document.with(:updated) }
   end
 
   describe Article do
-    it { is_expected.to have_field(:published).of_type(Mongoid::Boolean).with_default_value_of(false) }
-    it { is_expected.to have_field(:allow_comments).of_type(Mongoid::Boolean).with_default_value_of(true) }
+    klass_boolean = Mongoid::Compatibility::Version.mongoid4_or_newer? ? Mongoid::Boolean : Boolean
+    it { is_expected.to have_field(:published).of_type(klass_boolean).with_default_value_of(false) }
+    it { is_expected.to have_field(:allow_comments).of_type(klass_boolean).with_default_value_of(true) }
     it { is_expected.to belong_to(:author) }
     it { is_expected.to have_field(:title).localized }
-    it { is_expected.not_to have_field(:allow_comments).of_type(Mongoid::Boolean).with_default_value_of(false) }
+    it { is_expected.not_to have_field(:allow_comments).of_type(klass_boolean).with_default_value_of(false) }
     it { is_expected.not_to have_field(:number_of_comments).of_type(Integer).with_default_value_of(1) }
-    it { is_expected.to be_mongoid_document }
-    it { is_expected.to be_timestamped_document }
-  end
-
-  describe Log do
-    it { is_expected.to be_mongoid_document }
-    it { is_expected.to be_dynamic_document }
   end
 end

data/spec/unit/have_index_for_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+RSpec.describe Mongoid::Matchers::HaveIndexFor do
+  subject do
+    Class.new do
+      include Mongoid::Document
+
+      field :fizz, as: :buzz, type: String
+
+      index(foo: 1)
+      index({ bar: 1 }, unique: true, background: true, drop_dups: true)
+      index(foo: 1, bar: -1)
+      index('baz._id' => 1)
+      index(buzz: 1)
+    end
+  end
+
+  it 'detects an index for singular field key' do
+    is_expected.to have_index_for(foo: 1)
+  end
+
+  it 'detects an index for multipple fields key' do
+    is_expected.to have_index_for(foo: 1, bar: -1)
+  end
+
+  it 'detects an index with options' do
+    is_expected
+      .to have_index_for(bar: 1)
+      .with_options(unique: true, background: true, drop_dups: true)
+  end
+
+  it 'detects an index with only part of options' do
+    is_expected
+      .to have_index_for(bar: 1)
+      .with_options(unique: true)
+  end
+
+  it 'detects an index for string key' do
+    is_expected.to have_index_for('baz._id' => 1)
+  end
+
+  it 'detect an index for aliased fields' do
+    is_expected.to have_index_for(fizz: 1)
+    is_expected.to have_index_for(buzz: 1) if Mongoid::Compatibility::Version.mongoid4_or_newer?
+  end
+end

data/spec/unit/have_timestamps_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+RSpec.describe Mongoid::Matchers::HaveTimestamps do
+  context 'when model includes Mongoid::Timestamps' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Timestamps
+      end
+    end
+
+    it { is_expected.to have_timestamps }
+  end
+
+  context 'when model includes Mongoid::Timestamps::Short' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Timestamps::Short
+      end
+    end
+
+    it { is_expected.to have_timestamps.shortened }
+  end
+
+  context 'when model includes Mongoid::Timestamps::Updated' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Timestamps::Updated
+      end
+    end
+
+    it { is_expected.to have_timestamps.for(:updating) }
+  end
+
+  context 'when model includes Mongoid::Timestamps::Updated::Short' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Timestamps::Updated::Short
+      end
+    end
+
+    it { is_expected.to have_timestamps.for(:updating).shortened }
+    it { is_expected.to have_timestamps.shortened.for(:updating) }
+  end
+
+  context 'when model includes Mongoid::Timestamps::Created' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Timestamps::Created
+      end
+    end
+
+    it { is_expected.to have_timestamps.for(:creating) }
+  end
+
+  context 'when model includes Mongoid::Timestamps::Created::Short' do
+    subject do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Timestamps::Created::Short
+      end
+    end
+
+    it { is_expected.to have_timestamps.for(:creating).shortened }
+    it { is_expected.to have_timestamps.shortened.for(:creating) }
+  end
+end

data/spec/unit/validations_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe "Validations" do
+RSpec.describe 'Validations' do
   describe Site do
     it { is_expected.to validate_presence_of(:name) }
     it { is_expected.to validate_uniqueness_of(:name) }
@@ -9,45 +9,53 @@ RSpec.describe "Validations" do
   describe User do
     it { is_expected.to validate_presence_of(:login) }
     it { is_expected.to validate_uniqueness_of(:login).scoped_to(:site) }
-    it { is_expected.to validate_uniqueness_of(:email).case_insensitive.with_message("is already taken") }
-    it { is_expected.to validate_format_of(:login).to_allow("valid_login").not_to_allow("invalid login") }
+    it { is_expected.to validate_uniqueness_of(:email).case_insensitive.with_message('is already taken') }
+    it { is_expected.to validate_format_of(:login).to_allow('valid_login').not_to_allow('invalid login') }
     it { is_expected.to validate_associated(:profile) }
-    it { is_expected.to validate_exclusion_of(:login).to_not_allow("super", "index", "edit") }
-    it { is_expected.to validate_exclusion_of(:password).to_not_allow("password") }
-    it { is_expected.to validate_inclusion_of(:role).to_allow("admin", "member") }
-    it { is_expected.to validate_inclusion_of(:role).to_allow(["admin", "member"]) }
+    it { is_expected.to validate_exclusion_of(:login).to_not_allow('super', 'index', 'edit') }
+    it { is_expected.to validate_exclusion_of(:password).to_not_allow('password') }
+    it { is_expected.to validate_inclusion_of(:role).to_allow('admin', 'member') }
+    it { is_expected.to validate_inclusion_of(:role).to_allow(%w[admin member]) }
     it { is_expected.to validate_confirmation_of(:email) }
     it { is_expected.to validate_presence_of(:age).on(:create, :update) }
     it { is_expected.to validate_numericality_of(:age).on(:create, :update) }
-    it { is_expected.to validate_inclusion_of(:age).to_allow(23..42).on([:create, :update]) }
+    it { is_expected.to validate_inclusion_of(:age).to_allow(23..42).on(%i[create update]) }
     it { is_expected.to validate_presence_of(:password).on(:create) }
-    it { is_expected.to validate_confirmation_of(:password).with_message("Password confirmation must match given password") }
+    it { is_expected.to validate_confirmation_of(:password).with_message('Password confirmation must match given password') }
     it { is_expected.to validate_presence_of(:provider_uid).on(:create) }
-    it { is_expected.to validate_inclusion_of(:locale).to_allow([:en, :ru]) }
+    it { is_expected.to validate_inclusion_of(:locale).to_allow(%i[en ru]) }
   end
 
   describe Profile do
     it { is_expected.to validate_numericality_of(:age).greater_than(0) }
+    it { is_expected.not_to validate_numericality_of(:age).greater_than(0).only_integer(true) }
     it { is_expected.to validate_acceptance_of(:terms_of_service) }
-    it { is_expected.to validate_length_of(:hobbies).with_minimum(1).with_message("requires at least one hobby") }
+    it { is_expected.to validate_length_of(:hobbies).with_minimum(1).with_message('requires at least one hobby') }
   end
 
   describe Article do
     it { is_expected.to validate_length_of(:title).within(8..16) }
     it { is_expected.not_to validate_length_of(:content).greater_than(200).less_than(16) }
     it { is_expected.to validate_length_of(:content).greater_than(200) }
-    it { is_expected.to validate_inclusion_of(:status).to_allow([:pending]).on( :create ) }
-    it { is_expected.to validate_inclusion_of(:status).to_allow([:approved, :rejected]).on( :update ) }
+    it { is_expected.to validate_inclusion_of(:status).to_allow([:pending]).on(:create) }
+    it { is_expected.to validate_inclusion_of(:status).to_allow(%i[approved rejected]).on(:update) }
+    it { is_expected.to validate_absence_of(:deletion_date) } if Mongoid::Compatibility::Version.mongoid4_or_newer?
   end
 
   describe MovieArticle do
     it { is_expected.to validate_numericality_of(:rating).greater_than(0) }
-    it { is_expected.to validate_numericality_of(:rating).to_allow(:greater_than => 0).less_than_or_equal_to(5) }
-    it { is_expected.to validate_numericality_of(:classification).to_allow(:even => true, :only_integer => true, :nil => false) }
+    it { is_expected.to validate_numericality_of(:rating).to_allow(greater_than: 0).less_than_or_equal_to(5) }
+    it { is_expected.to validate_numericality_of(:classification).to_allow(even: true, only_integer: true, nil: false) }
   end
 
   describe Person do
     it { is_expected.to custom_validate(:ssn).with_validator(SsnValidator) }
     it { is_expected.not_to custom_validate(:name) }
   end
+
+  describe Message do
+    it { is_expected.to validate_uniqueness_of(:identifier).with_message('uniqueness') }
+    it { is_expected.to validate_presence_of(:from).with_message('required') }
+    it { is_expected.to validate_format_of(:to).with_message('format') }
+  end
 end

data/spec/validators/ssn_validator.rb

@@ -1,16 +1,16 @@
-class SsnValidator <  ActiveModel::EachValidator
-
+class SsnValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     unless valid_ssn?(record, attribute, value)
       record.errors[attribute] << "#{value} is not a valid Social Security Number"
     end
   end
 
-  def self.kind() :custom end
+  def self.kind
+    :custom
+  end
 
-  def valid_ssn?(record, attribute, value)
+  def valid_ssn?(_record, _attribute, _value)
     # irrelevant here how validation is done
     true
   end
-
-end
+end