mongoid-publishable 0.0.1 → 0.0.2

data/lib/mongoid/publishable/callbacks.rb

@@ -15,17 +15,35 @@ module Mongoid
       end
       
       module ClassMethods
+        # setter for the callbacks
+        def after_publish_callbacks=(values)
+          @after_publish_callbacks = CallbackCollection.new(values)
+        end
+        
         # returns the list of callbacks
         def after_publish_callbacks
           @after_publish_callbacks ||= CallbackCollection.new
         end
         
+        def add_after_publish_callback(callback)
+          after_publish_callbacks << callback
+          subclasses.each do |subclass|
+            subclass.add_after_publish_callback(callback)
+          end
+        end
+        
         # adds a callback to the list
         def after_publish(*args, &block)
           Callback.new(*args, &block).tap do |callback|
-            after_publish_callbacks << callback
+            add_after_publish_callback(callback)
           end
         end
+        
+        # pass the callbacks down to the sub-class
+        def inherited(subclass)
+          subclass.after_publish_callbacks = after_publish_callbacks
+          super
+        end
       end
       
       module InstanceMethods        

data/lib/mongoid/publishable/version.rb

@@ -1,5 +1,5 @@
 module Mongoid
   module Publishable
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/spec/mongoid/publishable/callbacks_spec.rb

@@ -9,6 +9,12 @@ describe Mongoid::Publishable::Callbacks do
       CallbackableObject
     end
     
+    before(:each) do
+      [CallbackableObject, CallbackableSubobject].each do |klass|
+        klass.after_publish_callbacks.replace []
+      end
+    end
+    
     describe "::after_publish_callbacks" do
       it "should return an object that responds to #process" do
         expect(subject.after_publish_callbacks).to respond_to :process
@@ -17,7 +23,6 @@ describe Mongoid::Publishable::Callbacks do
   
     describe "::after_publish" do
       it "should increment the callbacks by 1" do
-        subject.after_publish_callbacks.replace []
         expect(subject.after_publish_callbacks.size).to eq 0
         subject.after_publish(:method_name)
         expect(subject.after_publish_callbacks.size).to eq 1
@@ -34,11 +39,35 @@ describe Mongoid::Publishable::Callbacks do
         callback = subject.after_publish(:method_name)
         expect(callback).to respond_to :process
       end
+      
+      it "should be inherited by any sub-classes" do
+        expect(CallbackableSubobject.after_publish_callbacks.size).to eq 0
+        CallbackableObject.after_publish(:method_name)
+        expect(CallbackableSubobject.after_publish_callbacks.size).to eq 1
+      end
     end
 
   end # class
   
-  context "an instance class that's included Mongoid::Publishable::Callbacks" do
+  context "a sub-class of a class that's included Mongoid::Publishable::Callbacks" do
+    
+    before(:each) do
+      [CallbackableObject, CallbackableSubobject].each do |klass|
+        klass.after_publish_callbacks.replace []
+      end
+    end
+    
+    describe "defining a callback" do
+      it "should not be defined on the parent class" do
+        expect(CallbackableObject.after_publish_callbacks.size).to eq 0
+        CallbackableSubobject.after_publish(:method_name)
+        expect(CallbackableObject.after_publish_callbacks.size).to eq 0
+      end
+    end
+
+  end
+  
+  context "an instance of a class that's included Mongoid::Publishable::Callbacks" do
 
     subject do
       CallbackableObject.new

data/spec/support/models/callbackable_object.rb

@@ -1,6 +1,6 @@
 require "mongoid/publishable/callbacks"
 
 class CallbackableObject
-  def self.after_save(*args); end
+  include Mongoid::Document
   include Mongoid::Publishable::Callbacks
 end

data/spec/support/models/callbackable_subobject.rb

@@ -0,0 +1,2 @@
+class CallbackableSubobject < CallbackableObject
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-publishable
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -129,6 +129,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/env.rb
 - spec/support/models/callbackable_object.rb
+- spec/support/models/callbackable_subobject.rb
 - spec/support/models/publishable_object.rb
 - spec/support/models/publisher.rb
 - spec/support/models/queuing_controller.rb
@@ -168,6 +169,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/env.rb
 - spec/support/models/callbackable_object.rb
+- spec/support/models/callbackable_subobject.rb
 - spec/support/models/publishable_object.rb
 - spec/support/models/publisher.rb
 - spec/support/models/queuing_controller.rb