mongoid-normalize-strings 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 09316e83b81f79f4ab988a563f2c0329dd16edd7
-  data.tar.gz: 3667ea07595b313ce0bf91d0bae2f290c3230858
+  metadata.gz: 9b9be0339d3e3d5e725d876319b9f7e0edaea3fd
+  data.tar.gz: 747ecbfb2499bbf8f4c87e9855917170e365c185
 SHA512:
-  metadata.gz: a69f52d9a15d765050d1ec8829011ae2662eff1387104810f6d44f044b8ccc0a5db28fea69bce8cdd0cc74c546ee3f90f0cfdc7cad7e5efd158c0c84aa697c11
-  data.tar.gz: 7c4e9e931a38e563a40b126a369c96dee396c33e6d52bc711f8eff909f6ceba39b15ad8741e2b7d3ec86ce8b4110dcb773c8f126e33da08824c9ed820d88755c
+  metadata.gz: 7aa5176a0c512f6ecb87bea7ba82c45d60fb4657b3d2656ab227ce6b597d30f7875dec3667c6cb6241efb6e87f2bd8747d9f051ddc4c9daa7c59edd04f1478a5
+  data.tar.gz: e172ac25a50d3dc73a457c5104e0c7d5120a2d9d36bbb2a4b1de8a8577edbb63443e234487d682d07adc86fc8fa9ef29fc46d66a678a677785d1b89553af8a6a

data/README.md

@@ -19,13 +19,17 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-class Person
+class City
   include Mongoid::Document
   include Mongoid::NormalizeStrings
 
   field :name, type: String
   normalize :name
 end
+
+city = City.create(name: 'Córdoba')
+city.name # => 'Córdoba'
+city.name_normalized # => 'cordoba'
 ```
 
 ## Contributing

data/lib/mongoid-normalize-strings/normalize.rb

@@ -17,7 +17,13 @@ module Mongoid
       # Returns normalized_fields Class intance variable
       #
       def normalized_fields
-        self.superclass == Object ? @normalized_fields : self.superclass.normalized_fields
+        normalized_fields = (@normalized_fields || Set.new)
+
+        if self.superclass.methods.include? :normalized_fields
+          normalized_fields + self.superclass.normalized_fields
+        else
+          normalized_fields
+        end
       end
     end
 

data/lib/mongoid-normalize-strings/version.rb

@@ -1,5 +1,5 @@
 module Mongoid
   module NormalizeStrings
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/spec/normalize_spec.rb

@@ -9,23 +9,48 @@ describe Mongoid::NormalizeStrings do
     normalize :name
   end
 
-  it 'normalize fields after create' do
-    city = City.create(name: 'Córdoba')
-    expect(city.name_normalized).to eq('cordoba')
-  end
+  describe 'hooks' do
+    it 'normalize fields after create' do
+      city = City.create(name: 'Córdoba')
+      expect(city.name_normalized).to eq('cordoba')
+    end
 
-  it 'normalize fields after save' do
-    city = City.create(name: 'Córdoba')
-    city.name = 'Ávila'
-    city.save
-    expect(city.reload.name_normalized).to eq('avila')
+    it 'normalize fields after save' do
+      city = City.create(name: 'Córdoba')
+      city.name = 'Ávila'
+      city.save
+      expect(city.reload.name_normalized).to eq('avila')
+    end
   end
 
-  it 'support one level of heritage' do
-    class Aux < City
+  describe 'inheritance' do
+    context 'when superclass has normalized_fields' do
+      it 'return superclass + class normalized fields' do
+        class MyCity < City
+          field :state
+          normalize :state
+        end
+
+        expect(City.normalized_fields).to match_array([:name])
+        expect(MyCity.normalized_fields).to match_array([:name, :state])
+      end
     end
 
-    expect(City.normalized_fields).to match_array([:name])
-    expect(Aux.normalized_fields).to match_array([:name])
+    context 'when superclass has not normalized_fields' do
+      it 'return class normalized_fields' do
+        class A
+          include Mongoid::Document
+        end
+
+        class B < A
+          include Mongoid::NormalizeStrings
+
+          field :name
+          normalize :name
+        end
+
+        expect(B.normalized_fields).to match_array([:name])
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-normalize-strings
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Rafael Jurado