mongoid-history 0.8.0 → 0.8.5

data/spec/integration/nested_embedded_polymorphic_documents_spec.rb

@@ -1,127 +1,115 @@
-require 'spec_helper'
-
-describe Mongoid::History::Tracker do
-  before :all do
-    class Modelone
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :name, type: String
-      belongs_to :user
-      embeds_one :one_embedded, as: :embedable
-
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true
-    end
-
-    class Modeltwo
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :name, type: String
-      belongs_to :user
-      embeds_one :one_embedded, as: :embedable
-
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true
-    end
-
-    class OneEmbedded
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :name
-      embeds_many :embedded_twos, store_as: :ems
-      embedded_in :embedable, polymorphic: true
-
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true,
-                    scope: %i[modelone modeltwo]
-    end
-
-    class EmbeddedTwo
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :name
-      embedded_in :one_embedded
-
-      track_history on: :all,
-                    modifier_field: :modifier,
-                    version_field: :version,
-                    track_create: true,
-                    track_update: true,
-                    track_destroy: true,
-                    scope: %i[modelone modeltwo]
-    end
-
-    class User
-      include Mongoid::Document
-      has_many :modelones
-      has_many :modeltwos
-    end
-  end
-
-  it 'tracks history for nested embedded documents with polymorphic relations' do
-    user = User.new
-    user.save!
-
-    modelone = user.modelones.build(name: 'modelone')
-    modelone.save!
-    modelone.build_one_embedded(name: 'modelone_one_embedded').save!
-    expect(modelone.history_tracks.count).to eq(2)
-    expect(modelone.one_embedded.history_tracks.count).to eq(1)
-
-    modelone.reload
-    modelone.one_embedded.update_attribute(:name, 'modelone_embedded_one!')
-    expect(modelone.history_tracks.count).to eq(3)
-    expect(modelone.one_embedded.history_tracks.count).to eq(2)
-    expect(modelone.history_tracks.last.action).to eq('update')
-
-    modelone.build_one_embedded(name: 'Lorem ipsum').save!
-    expect(modelone.history_tracks.count).to eq(4)
-    expect(modelone.one_embedded.history_tracks.count).to eq(1)
-    expect(modelone.one_embedded.history_tracks.last.action).to eq('create')
-    expect(modelone.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
-
-    embedded_one1 = modelone.one_embedded.embedded_twos.create(name: 'modelone_one_embedded_1')
-    expect(modelone.history_tracks.count).to eq(5)
-    expect(modelone.one_embedded.history_tracks.count).to eq(2)
-    expect(embedded_one1.history_tracks.count).to eq(1)
-
-    modeltwo = user.modeltwos.build(name: 'modeltwo')
-    modeltwo.save!
-    modeltwo.build_one_embedded(name: 'modeltwo_one_embedded').save!
-    expect(modeltwo.history_tracks.count).to eq(2)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(1)
-
-    modeltwo.reload
-    modeltwo.one_embedded.update_attribute(:name, 'modeltwo_one_embedded!')
-    expect(modeltwo.history_tracks.count).to eq(3)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(2)
-    expect(modeltwo.history_tracks.last.action).to eq('update')
-
-    modeltwo.build_one_embedded(name: 'Lorem ipsum').save!
-    expect(modeltwo.history_tracks.count).to eq(4)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(1)
-    expect(modeltwo.one_embedded.history_tracks.last.action).to eq('create')
-    expect(modeltwo.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
-
-    embedded_one2 = modeltwo.one_embedded.embedded_twos.create(name: 'modeltwo_one_embedded_1')
-    expect(modeltwo.history_tracks.count).to eq(5)
-    expect(modeltwo.one_embedded.history_tracks.count).to eq(2)
-    expect(embedded_one2.history_tracks.count).to eq(1)
-  end
-end
+require 'spec_helper'
+
+describe Mongoid::History::Tracker do
+  before :each do
+    class ModelOne
+      include Mongoid::Document
+      include Mongoid::History::Trackable
+
+      field :name, type: String
+      belongs_to :user
+      embeds_one :one_embedded, as: :embedable
+
+      track_history
+    end
+
+    class ModelTwo
+      include Mongoid::Document
+      include Mongoid::History::Trackable
+
+      field :name, type: String
+      belongs_to :user
+      embeds_one :one_embedded, as: :embedable
+
+      track_history
+    end
+
+    class OneEmbedded
+      include Mongoid::Document
+      include Mongoid::History::Trackable
+
+      field :name
+      embeds_many :embedded_twos, store_as: :ems
+      embedded_in :embedable, polymorphic: true
+
+      track_history scope: %i[model_one model_two]
+    end
+
+    class EmbeddedTwo
+      include Mongoid::Document
+      include Mongoid::History::Trackable
+
+      field :name
+      embedded_in :one_embedded
+
+      track_history scope: %i[model_one model_two]
+    end
+
+    class User
+      include Mongoid::Document
+
+      has_many :model_ones
+      has_many :model_twos
+    end
+  end
+
+  after :each do
+    Object.send(:remove_const, :ModelOne)
+    Object.send(:remove_const, :ModelTwo)
+    Object.send(:remove_const, :OneEmbedded)
+    Object.send(:remove_const, :EmbeddedTwo)
+    Object.send(:remove_const, :User)
+  end
+
+  let (:user) { User.create! }
+
+  it 'tracks history for nested embedded documents with polymorphic relations' do
+    user = User.create!
+
+    model_one = user.model_ones.build(name: 'model_one', modifier: user)
+    model_one.save!
+    model_one.build_one_embedded(name: 'model_one_one_embedded', modifier: user).save!
+    expect(model_one.history_tracks.count).to eq(2)
+    expect(model_one.one_embedded.history_tracks.count).to eq(1)
+
+    model_one.reload
+    model_one.one_embedded.update_attributes!(name: 'model_one_embedded_one!')
+    expect(model_one.history_tracks.count).to eq(3)
+    expect(model_one.one_embedded.history_tracks.count).to eq(2)
+    expect(model_one.history_tracks.last.action).to eq('update')
+
+    model_one.build_one_embedded(name: 'Lorem ipsum', modifier: user).save!
+    expect(model_one.history_tracks.count).to eq(4)
+    expect(model_one.one_embedded.history_tracks.count).to eq(1)
+    expect(model_one.one_embedded.history_tracks.last.action).to eq('create')
+    expect(model_one.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
+
+    embedded_one1 = model_one.one_embedded.embedded_twos.create!(name: 'model_one_one_embedded_1', modifier: user)
+    expect(model_one.history_tracks.count).to eq(5)
+    expect(model_one.one_embedded.history_tracks.count).to eq(2)
+    expect(embedded_one1.history_tracks.count).to eq(1)
+
+    model_two = user.model_twos.build(name: 'model_two', modifier: user)
+    model_two.save!
+    model_two.build_one_embedded(name: 'model_two_one_embedded', modifier: user).save!
+    expect(model_two.history_tracks.count).to eq(2)
+    expect(model_two.one_embedded.history_tracks.count).to eq(1)
+
+    model_two.reload
+    model_two.one_embedded.update_attributes!(name: 'model_two_one_embedded!')
+    expect(model_two.history_tracks.count).to eq(3)
+    expect(model_two.one_embedded.history_tracks.count).to eq(2)
+    expect(model_two.history_tracks.last.action).to eq('update')
+
+    model_two.build_one_embedded(name: 'Lorem ipsum', modifier: user).save!
+    expect(model_two.history_tracks.count).to eq(4)
+    expect(model_two.one_embedded.history_tracks.count).to eq(1)
+    expect(model_two.one_embedded.history_tracks.last.action).to eq('create')
+    expect(model_two.one_embedded.history_tracks.last.association_chain.last['name']).to eq('one_embedded')
+
+    embedded_one2 = model_two.one_embedded.embedded_twos.create!(name: 'model_two_one_embedded_1', modifier: user)
+    expect(model_two.history_tracks.count).to eq(5)
+    expect(model_two.one_embedded.history_tracks.count).to eq(2)
+    expect(embedded_one2.history_tracks.count).to eq(1)
+  end
+end

data/spec/integration/subclasses_spec.rb

@@ -1,29 +1,47 @@
-require 'spec_helper'
-
-describe Mongoid::History::Tracker do
-  before :all do
-    class Element
-      include Mongoid::Document
-      include Mongoid::Timestamps
-      include Mongoid::History::Trackable
-
-      field :body
-
-      track_history on: [:body], track_create: true, track_update: true, track_destroy: true
-    end
-
-    class Prompt < Element
-    end
-  end
-
-  it 'tracks subclass create and update' do
-    prompt = Prompt.new
-    expect { prompt.save! }.to change(Tracker, :count).by(1)
-    expect { prompt.update_attributes!(body: 'one') }.to change(Tracker, :count).by(1)
-    prompt.undo!
-    expect(prompt.body).to be_blank
-    prompt.redo! nil, 2
-    expect(prompt.body).to eq('one')
-    expect { prompt.destroy }.to change(Tracker, :count).by(1)
-  end
-end
+require 'spec_helper'
+
+describe Mongoid::History::Tracker do
+  before :each do
+    class Element
+      include Mongoid::Document
+      include Mongoid::Timestamps
+      include Mongoid::History::Trackable
+
+      track_history
+
+      field :body
+
+      # force preparation of options
+      history_trackable_options
+    end
+
+    class Prompt < Element
+      field :head
+    end
+
+    class User
+      include Mongoid::Document
+    end
+  end
+
+  after :each do
+    Object.send(:remove_const, :Element)
+    Object.send(:remove_const, :Prompt)
+    Object.send(:remove_const, :User)
+  end
+
+  let(:user) { User.create! }
+
+  it 'tracks subclass create and update' do
+    prompt = Prompt.new(modifier: user)
+    expect { prompt.save! }.to change(Tracker, :count).by(1)
+    expect { prompt.update_attributes!(body: 'one', head: 'two') }.to change(Tracker, :count).by(1)
+    prompt.undo! user
+    expect(prompt.body).to be_blank
+    expect(prompt.head).to be_blank
+    prompt.redo! user, 2
+    expect(prompt.body).to eq('one')
+    expect(prompt.head).to eq('two')
+    expect { prompt.destroy }.to change(Tracker, :count).by(1)
+  end
+end

data/spec/integration/track_history_order_spec.rb

@@ -1,52 +1,84 @@
-require 'spec_helper'
-
-describe Mongoid::History::Tracker do
-  it 'should not track fields when track_history not called' do
-    class NotModel
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :foo
-    end
-
-    expect(NotModel.respond_to?(:tracked?)).to be false
-  end
-
-  it 'should track fields when track_history called inside class and before fields' do
-    class InsideBeforeModel
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      track_history on: :fields
-
-      field :foo
-    end
-
-    expect(InsideBeforeModel.tracked?(:foo)).to be true
-  end
-
-  it 'should track fields when track_history called inside class and after fields' do
-    class InsideAfterModel
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :foo
-
-      track_history on: :fields
-    end
-
-    expect(InsideAfterModel.tracked?(:foo)).to be true
-  end
-
-  it 'should track fields when track_history called outside class' do
-    class OutsideModel
-      include Mongoid::Document
-      include Mongoid::History::Trackable
-
-      field :foo
-    end
-
-    OutsideModel.track_history on: :fields
-    expect(OutsideModel.tracked?(:foo)).to be true
-  end
-end
+require 'spec_helper'
+
+describe Mongoid::History::Tracker do
+  context 'when track_history not called' do
+    before :each do
+      class NotModel
+        include Mongoid::Document
+        include Mongoid::History::Trackable
+
+        field :foo
+      end
+    end
+
+    after :each do
+      Object.send(:remove_const, :NotModel)
+    end
+
+    it 'should not track fields' do
+      expect(NotModel.respond_to?(:tracked?)).to be false
+    end
+  end
+
+  context 'boefore field' do
+    before :each do
+      class InsideBeforeModel
+        include Mongoid::Document
+        include Mongoid::History::Trackable
+
+        track_history on: :fields
+
+        field :foo
+      end
+    end
+
+    after :each do
+      Object.send(:remove_const, :InsideBeforeModel)
+    end
+
+    it 'should track fields' do
+      expect(InsideBeforeModel.tracked?(:foo)).to be true
+    end
+  end
+
+  context 'when track_history called inside class and after fields' do
+    before :each do
+      class InsideAfterModel
+        include Mongoid::Document
+        include Mongoid::History::Trackable
+
+        field :foo
+
+        track_history on: :fields
+      end
+    end
+
+    after :each do
+      Object.send(:remove_const, :InsideAfterModel)
+    end
+
+    it 'should track fields' do
+      expect(InsideAfterModel.tracked?(:foo)).to be true
+    end
+  end
+
+  context 'when track_history called outside class' do
+    before :each do
+      class OutsideModel
+        include Mongoid::Document
+        include Mongoid::History::Trackable
+
+        field :foo
+      end
+    end
+
+    after :each do
+      Object.send(:remove_const, :OutsideModel)
+    end
+
+    it 'should track fields' do
+      OutsideModel.track_history on: :fields
+      expect(OutsideModel.tracked?(:foo)).to be true
+    end
+  end
+end

data/spec/integration/validation_failure_spec.rb

@@ -1,63 +1,76 @@
-require 'spec_helper'
-
-describe Mongoid::History::Tracker do
-  before :all do
-    class Element
-      include Mongoid::Document
-      include Mongoid::Timestamps
-      include Mongoid::History::Trackable
-
-      field :title
-      field :body
-
-      validates :title, presence: true
-
-      has_many :items, dependent: :restrict
-
-      track_history on: [:body], track_create: true, track_update: true, track_destroy: true
-    end
-
-    class Item
-      include Mongoid::Document
-      include Mongoid::Timestamps
-
-      belongs_to :element
-    end
-
-    class Prompt < Element
-    end
-
-    @persisted_history_options = Mongoid::History.trackable_class_options
-  end
-
-  before(:each) { Mongoid::History.trackable_class_options = @persisted_history_options }
-
-  it 'does not track delete when parent class validation fails' do
-    prompt = Prompt.new(title: 'first')
-    expect { prompt.save! }.to change(Tracker, :count).by(1)
-    expect do
-      expect { prompt.update_attributes!(title: nil, body: 'one') }
-        .to raise_error(Mongoid::Errors::Validations)
-    end.to change(Tracker, :count).by(0)
-  end
-
-  it 'does not track delete when parent class restrict dependency fails' do
-    prompt = Prompt.new(title: 'first')
-    prompt.items << Item.new
-    expect { prompt.save! }.to change(Tracker, :count).by(1)
-    expect(prompt.version).to eq(1)
-    expect do
-      expect { prompt.destroy }.to raise_error(Mongoid::Errors::DeleteRestriction)
-    end.to change(Tracker, :count).by(0)
-  end
-
-  it 'does not track delete when restrict dependency fails' do
-    elem = Element.new(title: 'first')
-    elem.items << Item.new
-    expect { elem.save! }.to change(Tracker, :count).by(1)
-    expect(elem.version).to eq(1)
-    expect do
-      expect { elem.destroy }.to raise_error(Mongoid::Errors::DeleteRestriction)
-    end.to change(Tracker, :count).by(0)
-  end
-end
+require 'spec_helper'
+
+describe Mongoid::History::Tracker do
+  before :each do
+    class Element
+      include Mongoid::Document
+      include Mongoid::Timestamps
+      include Mongoid::History::Trackable
+
+      field :title
+      field :body
+
+      validates :title, presence: true
+
+      if Mongoid::Compatibility::Version.mongoid7_or_newer?
+        has_many :items, dependent: :restrict_with_exception
+      else
+        has_many :items, dependent: :restrict
+      end
+
+      track_history on: [:body]
+    end
+
+    class Item
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :element
+    end
+
+    class Prompt < Element
+    end
+
+    class User
+      include Mongoid::Document
+    end
+  end
+
+  after :each do
+    Object.send(:remove_const, :Element)
+    Object.send(:remove_const, :Item)
+    Object.send(:remove_const, :Prompt)
+    Object.send(:remove_const, :User)
+  end
+
+  let(:user) { User.create! }
+
+  it 'does not track delete when parent class validation fails' do
+    prompt = Prompt.new(title: 'first', modifier: user)
+    expect { prompt.save! }.to change(Tracker, :count).by(1)
+    expect do
+      expect { prompt.update_attributes!(title: nil, body: 'one') }
+        .to raise_error(Mongoid::Errors::Validations)
+    end.to change(Tracker, :count).by(0)
+  end
+
+  it 'does not track delete when parent class restrict dependency fails' do
+    prompt = Prompt.new(title: 'first', modifier: user)
+    prompt.items << Item.new
+    expect { prompt.save! }.to change(Tracker, :count).by(1)
+    expect(prompt.version).to eq(1)
+    expect do
+      expect { prompt.destroy }.to raise_error(Mongoid::Errors::DeleteRestriction)
+    end.to change(Tracker, :count).by(0)
+  end
+
+  it 'does not track delete when restrict dependency fails' do
+    elem = Element.new(title: 'first', modifier: user)
+    elem.items << Item.new
+    expect { elem.save! }.to change(Tracker, :count).by(1)
+    expect(elem.version).to eq(1)
+    expect do
+      expect { elem.destroy }.to raise_error(Mongoid::Errors::DeleteRestriction)
+    end.to change(Tracker, :count).by(0)
+  end
+end

data/spec/spec_helper.rb

@@ -1,25 +1,32 @@
-require 'coveralls'
-Coveralls.wear!
-
-$LOAD_PATH.push File.expand_path('../../lib', __FILE__)
-
-require 'active_support/all'
-require 'mongoid'
-require 'request_store'
-
-# Undefine RequestStore so that it may be stubbed in specific tests
-RequestStoreTemp = RequestStore
-Object.send(:remove_const, :RequestStore)
-
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
-
-require 'mongoid/history'
-
-RSpec.configure do |config|
-  config.raise_errors_for_deprecations!
-  config.before :all do
-    Mongoid.logger.level = Logger::INFO
-    Mongo::Logger.logger.level = Logger::INFO if Mongoid::Compatibility::Version.mongoid5? || Mongoid::Compatibility::Version.mongoid6?
-    Mongoid.belongs_to_required_by_default = false if Mongoid::Compatibility::Version.mongoid6?
-  end
-end
+require 'coveralls'
+Coveralls.wear!
+
+$LOAD_PATH.push File.expand_path('../../lib', __FILE__)
+
+require 'active_support/all'
+require 'mongoid'
+require 'request_store'
+
+# Undefine RequestStore so that it may be stubbed in specific tests
+RequestStoreTemp = RequestStore
+Object.send(:remove_const, :RequestStore)
+
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+require 'mongoid/history'
+
+RSpec.configure do |config|
+  config.raise_errors_for_deprecations!
+
+  config.before :all do
+    Mongoid.logger.level = Logger::INFO
+    Mongo::Logger.logger.level = Logger::INFO if Mongoid::Compatibility::Version.mongoid5_or_newer?
+    Mongoid.belongs_to_required_by_default = false if Mongoid::Compatibility::Version.mongoid6?
+  end
+
+  config.before :each do
+    Mongoid::History.reset!
+  end
+
+  config.include ErrorHelpers
+end

data/spec/support/error_helpers.rb

@@ -0,0 +1,7 @@
+module ErrorHelpers
+  def ignore_errors
+    yield
+  rescue StandardError => e
+    Mongoid.logger.debug "ignored error #{e}"
+  end
+end