mongoid-embedded-errors 3.0.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 129c9a68d1921837c6cd5942d64272049bbc8fd8f756c29b0a825faa4c1d1527
-  data.tar.gz: 57c35bcc8813866051d60d5139e5901169b8478ce4d5be291e862e0bb0604e17
+  metadata.gz: 5a086d5eabe3e2746bbf05833787ee55f8e4b838f666e3aea1c5780e860aa58c
+  data.tar.gz: 1f8a09d1d856795631b53f6cbfe1bf832f385a350ff9e8a4e6f7cc0f4c0815c5
 SHA512:
-  metadata.gz: 857c87ef479cc4eb0ea15462f9c6386d2eff11987d0a0f895bc3429f14ffd9242fcbce2292bb7de04f2588481fa76bbdc1d0d9874bd2b6a4bcffc02b5149f22a
-  data.tar.gz: 3935c4a3d82f9e343b21f2272c05d4e8cf642191d79be7b89e82116220c76ba73b56b1e24885824e5fe6c9f17312a4f083cf2714a8356cb2768c0f1b4b57b488
+  metadata.gz: 9a6735fbef90d1143c2e724cdc2d33d669e6c829425e7ca4e1f548e2b7b11db5f817d1579cf1a6ba308c1758e628e70afc53865a3b35e84cbe2b3efee42d83cf
+  data.tar.gz: 7828bf072974db784c32622002c80650f0debb0858c10f4749906e77cb1ce5daa7658f483614b51b683e66db6f62c5334b4b322282eea247ff481e1ee3976422

data/Appraisals

@@ -1,15 +1,7 @@
-appraise 'mongoid-4' do
-  gem 'mongoid', '~> 4.0'
-end
-
-appraise 'mongoid-5' do
-  gem 'mongoid', '~> 5.0'
-end
-
-appraise 'mongoid-6' do
-  gem 'mongoid', '~> 6.0'
-end
-
 appraise 'mongoid-7' do
   gem 'mongoid', '~> 7.0'
 end
+
+appraise 'mongoid-8' do
+  gem 'mongoid', '~> 8.0'
+end

data/CHANGELOG.md

@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ## [Unreleased]
 - TODO
 
+## [v4.0.0] - 2022-08-31
+- Fix rails 6 active model error deprecations (#22)
+- Added Mongoid 8 support
+- Dropped support for Mongoid 4, 5 and 6
+
 ## [v3.0.1] - 2020-09-29
 ### Added
 - Started 🔎 tracking changes in a changelog!
@@ -22,6 +27,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ## [v3.0.0] - 2020-09-29 [YANKED]
 - Yanked due to wrong dependencies in gemspec.
 
-[Unreleased]: https://github.com/glooko/mongoid-embedded-errors/compare/v3.0.1...HEAD
+[Unreleased]: https://github.com/glooko/mongoid-embedded-errors/compare/v4.0.0...HEAD
+[v4.0.0]: https://github.com/glooko/mongoid-embedded-errors/compare/v3.0.1...v4.0.0
 [v3.0.1]: https://github.com/glooko/mongoid-embedded-errors/compare/v3.0.0...v3.0.1
-[v3.0.0]: https://github.com/glooko/mongoid-embedded-errors/compare/f1ce0d8ed140de86c894b2fad7ad197504fefd5a...v3.0.0
+[v3.0.0]: https://github.com/glooko/mongoid-embedded-errors/compare/f1ce0d8ed140de86c894b2fad7ad197504fefd5a...v3.0.0

data/Gemfile

@@ -4,10 +4,13 @@ source 'https://rubygems.org'
 gemspec
 
 group :development do
+  gem 'rake'
+end
+
+group :test do
   gem 'appraisal'
-  gem 'database_cleaner'
+  gem 'database_cleaner-mongoid', '~> 2.0', '>= 2.0.1'
   gem 'guard-rspec'
   gem 'mutant-rspec'
-  gem 'rake'
   gem 'rspec'
 end

data/gemfiles/mongoid_7.gemfile

@@ -5,11 +5,14 @@ source "https://rubygems.org"
 gem "mongoid", "~> 7.0"
 
 group :development do
+  gem "rake"
+end
+
+group :test do
   gem "appraisal"
-  gem "database_cleaner"
+  gem "database_cleaner-mongoid", "~> 2.0", ">= 2.0.1"
   gem "guard-rspec"
   gem "mutant-rspec"
-  gem "rake"
   gem "rspec"
 end
 

data/gemfiles/mongoid_8.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "mongoid", "~> 8.0"
+
+group :development do
+  gem "rake"
+end
+
+group :test do
+  gem "appraisal"
+  gem "database_cleaner-mongoid", "~> 2.0", ">= 2.0.1"
+  gem "guard-rspec"
+  gem "mutant-rspec"
+  gem "rspec"
+end
+
+gemspec path: "../"

data/lib/mongoid/embedded_errors/version.rb

@@ -2,5 +2,5 @@
 
 module Mongoid; end
 module Mongoid::EmbeddedErrors
-  VERSION = '3.0.1'
+  VERSION = '4.0.0'
 end

data/lib/mongoid/embedded_errors.rb

@@ -19,8 +19,8 @@ module Mongoid::EmbeddedErrors
         # if there is an 'is invalid' message for the relation then let's work it:
         next unless Array(public_send(name)).any? { |doc| doc.errors.any? }
 
-        # first delete the unless 'is invalid' error for the relation
-        errs[name].delete 'is invalid'
+        # first delete the generic 'is invalid' error for the relation
+        errs.delete name.to_sym, :invalid
         errs.delete name.to_sym if errs[name].empty?
 
         # next, loop through each of the relations (pages, sections, etc...)
@@ -28,19 +28,21 @@ module Mongoid::EmbeddedErrors
           next unless rel.errors.any?
 
           # get each of their individual message and add them to the parent's errors:
-          rel.errors.each do |k, v|
+          rel.errors.each do |error|
+            attribute = error.attribute
+            message = error.message
             relation = if Gem::Version.new(Mongoid::VERSION) >= Gem::Version.new('7.0.0')
                          metadata.class
                        else
                          metadata.relation
                        end
             key = if relation.equal? EMBEDS_MANY
-                    "#{name}[#{i}].#{k}"
+                    "#{name}[#{i}].#{attribute}"
                   else
-                    "#{name}.#{k}"
+                    "#{name}.#{attribute}"
                   end.to_sym
             errs.delete(key)
-            errs.add key, v if v.present?
+            errs.add key, message if message.present?
           end
         end
       end

data/mongoid-embedded-errors.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
-  gem.add_dependency             'mongoid', '>=4.0', '<8.0.0'
+  gem.add_dependency             'mongoid', '>=7.0', '<9.0.0'
   gem.add_development_dependency 'rubocop', '~> 0.92'
   gem.add_development_dependency 'rubocop-rspec', '~> 1.43'
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 
 require 'bundler/setup'
 require 'mongoid-embedded-errors'
-require 'database_cleaner'
+require 'database_cleaner-mongoid'
 
 current_path = File.dirname(__FILE__)
 SPEC_MODELS_PATH = File.join(current_path, 'support/**/*.rb').freeze
@@ -25,14 +25,6 @@ RSpec.configure do |config|
   end
   config.disable_monkey_patching!
 
-  config.before(:suite) do
-    DatabaseCleaner.strategy = :truncation
-  end
-
-  config.around do |example|
-    DatabaseCleaner.cleaning { example.run }
-  end
-
   config.before do
     # Need to manually reload spec models for mutant to work as expected
     if ENV['MUTANT']

data/spec/support/database_cleaner.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  DatabaseCleaner.strategy = :deletion
+  config.around do |example|
+    DatabaseCleaner.cleaning do
+      example.run
+    end
+  end
+
+  config.before(:all) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:all) do
+    DatabaseCleaner.clean
+  end
+end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-embedded-errors
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Mark Bates
 - Kristijan Novoselić
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-29 00:00:00.000000000 Z
+date: 2022-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid
@@ -17,20 +17,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '7.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 8.0.0
+        version: 9.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '7.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 8.0.0
+        version: 9.0.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -88,6 +88,7 @@ files:
 - gemfiles/mongoid_5.gemfile
 - gemfiles/mongoid_6.gemfile
 - gemfiles/mongoid_7.gemfile
+- gemfiles/mongoid_8.gemfile
 - lib/mongoid-embedded-errors.rb
 - lib/mongoid/embedded_errors.rb
 - lib/mongoid/embedded_errors/embedded_in.rb
@@ -95,6 +96,7 @@ files:
 - mongoid-embedded-errors.gemspec
 - spec/lib/mongoid/embedded_errors_spec.rb
 - spec/spec_helper.rb
+- spec/support/database_cleaner.rb
 - spec/support/models/annotation.rb
 - spec/support/models/article.rb
 - spec/support/models/page.rb
@@ -104,7 +106,7 @@ homepage: https://github.com/glooko/mongoid-embedded-errors
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -119,13 +121,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: Easily bubble up errors from embedded documents in Mongoid.
 test_files:
 - spec/lib/mongoid/embedded_errors_spec.rb
 - spec/spec_helper.rb
+- spec/support/database_cleaner.rb
 - spec/support/models/annotation.rb
 - spec/support/models/article.rb
 - spec/support/models/page.rb