mongoid-embedded-errors 2.1.1 → 3.0.1

data/spec/lib/mongoid/embedded_errors_spec.rb

@@ -1,33 +1,84 @@
+# frozen_string_literal: true
+
 RSpec.describe Mongoid::EmbeddedErrors do
   describe '#errors_with_embedded_errors' do
     subject(:article) { Article.new name: 'Test', summary: '-', pages: pages }
+
     before { |spec| article.validate unless spec.metadata[:do_not_validate] }
 
+    context 'when module is already included in a class', :do_not_validate do
+      let(:dummy_class) do
+        Class.new do
+          include Mongoid::Document
+          include Mongoid::EmbeddedErrors
+        end
+      end
+
+      it 'does not create errors_without_embedded_errors alias again' do
+        a = dummy_class.instance_method(:errors_without_embedded_errors)
+        dummy_class.include described_class
+
+        expect(
+          a
+        ).to eq(dummy_class.instance_method(:errors_without_embedded_errors))
+      end
+    end
+
     context 'when article does not have any pages associated' do
       let(:pages) { [] }
 
       it { is_expected.not_to be_valid }
+
       it "returns `can't be blank` error for pages" do
         expect(article.errors[:pages]).to include "can't be blank"
       end
     end
+
     context 'when article has one or more invalid pages' do
       let(:pages) { [Page.new] }
 
       it { is_expected.not_to be_valid }
+
       it 'does not have any errors under `:pages` key' do
         expect(article.errors[:pages]).to be_empty
       end
+
       it 'returns all errors for `pages[0]` object' do
         expect(article.errors[:'pages[0].title']).to include "can't be blank"
       end
     end
-    context 'when all pages in article are valid' do
-      let(:pages) { [Page.new(title: 'First page')] }
 
-      it { is_expected.to be_valid }
+    context 'when validated multiple times' do
+      let(:pages) { [Page.new] }
+
+      it 'does not have duplicated errors for the same object' do
+        article.valid?
+        expect(article.errors[:'pages[0].title']).to eq(["can't be blank"])
+      end
+    end
+
+    context 'when embeds_many relation is invalid' do
+      let(:pages) { [Page.new(title: 'Test page', sections: sections)] }
+      let(:sections) { [Section.new] }
+
+      it 'returns all errors for `sections[0]` object' do
+        expect(article.errors[:'pages[0].sections[0].header']).to include "can't be blank"
+      end
     end
-    context 'when embedded document has not been validated', :do_not_validate do
+
+    context 'when embeds_one relation is invalid' do
+      subject(:article) { Article.new name: 'Test', summary: '-', pages: pages, annotation: annotation }
+
+      let(:pages) { [Page.new(title: 'Test page')] }
+      let(:annotation) { Annotation.new }
+
+      it 'returns all errors for `annotation` object' do
+        expect(article.errors[:'annotation.text']).to include "can't be blank"
+      end
+    end
+
+    context 'when embedded document has not been validated',
+            :do_not_validate do
       let(:pages) { [Page.new] }
 
       it 'does not trigger validations' do

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'mongoid-embedded-errors'
 require 'database_cleaner'
@@ -27,11 +29,11 @@ RSpec.configure do |config|
     DatabaseCleaner.strategy = :truncation
   end
 
-  config.around(:each) do |example|
+  config.around do |example|
     DatabaseCleaner.cleaning { example.run }
   end
 
-  config.before(:each) do
+  config.before do
     # Need to manually reload spec models for mutant to work as expected
     if ENV['MUTANT']
       Dir[SPEC_MODELS_PATH].each do |filename|

data/spec/support/models/annotation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Annotation
   include Mongoid::Document
 

data/spec/support/models/article.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Article
   include Mongoid::Document
   include Mongoid::Timestamps

data/spec/support/models/page.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Page
   include Mongoid::Document
   include Mongoid::Timestamps

data/spec/support/models/section.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Section
   include Mongoid::Document
   include Mongoid::Timestamps

data/spec/support/mongoid.yml

@@ -1,5 +1,5 @@
 test:
-  # mongoid 3 and 4
+  # mongoid 4
   sessions:
     default:
       database: mongoid_embedded_errors_test

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-embedded-errors
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 3.0.1
 platform: ruby
 authors:
 - Mark Bates
 - Kristijan Novoselić
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2020-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid
@@ -17,24 +17,57 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
-description: Easily bubble up errors from embedded documents in Mongoid.
+        version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 8.0.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.92'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.92'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.43'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.43'
+description: Embedded documents in Mongoid can be really useful. However, when one
+  of those embedded documents is invalid, Mongoid does not say which validation has
+  failed. Instead of just saying that an embedded document is invalid, this gem modifies
+  Mongoid behavior so it explicitly provides validation errors on a per-field basis
+  for embedded documents, the same way it does for parent documents.
 email:
 - mark@markbates.com
 - kristijan@glooko.com
-executables:
-- _guard-core
-- appraisal
-- guard
-- rake
-- rspec
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
@@ -42,26 +75,19 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".semaphore/semaphore.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/_guard-core
-- bin/appraisal
-- bin/guard
-- bin/rake
-- bin/rspec
-- gemfiles/mongoid_3.gemfile
-- gemfiles/mongoid_3.gemfile.lock
+- gemfiles/.bundle/config
 - gemfiles/mongoid_4.gemfile
-- gemfiles/mongoid_4.gemfile.lock
 - gemfiles/mongoid_5.gemfile
-- gemfiles/mongoid_5.gemfile.lock
 - gemfiles/mongoid_6.gemfile
-- gemfiles/mongoid_6.gemfile.lock
+- gemfiles/mongoid_7.gemfile
 - lib/mongoid-embedded-errors.rb
 - lib/mongoid/embedded_errors.rb
 - lib/mongoid/embedded_errors/embedded_in.rb
@@ -74,10 +100,11 @@ files:
 - spec/support/models/page.rb
 - spec/support/models/section.rb
 - spec/support/mongoid.yml
-homepage: ''
-licenses: []
+homepage: https://github.com/glooko/mongoid-embedded-errors
+licenses:
+- MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -92,9 +119,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Easily bubble up errors from embedded documents in Mongoid.
 test_files:

data/Gemfile.lock

@@ -1,168 +0,0 @@
-PATH
-  remote: .
-  specs:
-    mongoid-embedded-errors (2.0.1)
-      mongoid (>= 3.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    abstract_type (0.0.7)
-    activemodel (4.2.6)
-      activesupport (= 4.2.6)
-      builder (~> 3.1)
-    activesupport (4.2.6)
-      i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
-      minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
-      tzinfo (~> 1.1)
-    adamantium (0.2.0)
-      ice_nine (~> 0.11.0)
-      memoizable (~> 0.4.0)
-    anima (0.3.0)
-      abstract_type (~> 0.0.7)
-      adamantium (~> 0.2)
-      equalizer (~> 0.0.11)
-    appraisal (2.1.0)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    ast (2.3.0)
-    bson (3.2.6)
-    builder (3.2.2)
-    coderay (1.1.1)
-    concord (0.1.5)
-      adamantium (~> 0.2.0)
-      equalizer (~> 0.0.9)
-    connection_pool (2.2.0)
-    database_cleaner (1.5.3)
-    diff-lcs (1.2.5)
-    equalizer (0.0.11)
-    ffi (1.9.14)
-    formatador (0.2.5)
-    guard (2.14.0)
-      formatador (>= 0.2.4)
-      listen (>= 2.7, < 4.0)
-      lumberjack (~> 1.0)
-      nenv (~> 0.1)
-      notiffany (~> 0.0)
-      pry (>= 0.9.12)
-      shellany (~> 0.0)
-      thor (>= 0.18.1)
-    guard-compat (1.2.1)
-    guard-rspec (4.7.3)
-      guard (~> 2.1)
-      guard-compat (~> 1.1)
-      rspec (>= 2.99.0, < 4.0)
-    i18n (0.7.0)
-    ice_nine (0.11.2)
-    json (1.8.3)
-    listen (3.1.5)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
-      ruby_dep (~> 1.2)
-    lumberjack (1.0.10)
-    memoizable (0.4.2)
-      thread_safe (~> 0.3, >= 0.3.1)
-    method_source (0.8.2)
-    minitest (5.9.0)
-    mongoid (4.0.2)
-      activemodel (~> 4.0)
-      moped (~> 2.0.0)
-      origin (~> 2.1)
-      tzinfo (>= 0.3.37)
-    moped (2.0.7)
-      bson (~> 3.0)
-      connection_pool (~> 2.0)
-      optionable (~> 0.2.0)
-    morpher (0.2.6)
-      abstract_type (~> 0.0.7)
-      adamantium (~> 0.2.0)
-      anima (~> 0.3.0)
-      ast (~> 2.2)
-      concord (~> 0.1.5)
-      equalizer (~> 0.0.9)
-      ice_nine (~> 0.11.0)
-      procto (~> 0.0.2)
-    mutant (0.8.11)
-      abstract_type (~> 0.0.7)
-      adamantium (~> 0.2.0)
-      anima (~> 0.3.0)
-      ast (~> 2.2)
-      concord (~> 0.1.5)
-      diff-lcs (~> 1.2)
-      equalizer (~> 0.0.9)
-      ice_nine (~> 0.11.1)
-      memoizable (~> 0.4.2)
-      morpher (~> 0.2.6)
-      parallel (~> 1.3)
-      parser (~> 2.3.0, >= 2.3.0.2)
-      procto (~> 0.0.2)
-      regexp_parser (~> 0.3.6)
-      unparser (~> 0.2.5)
-    mutant-rspec (0.8.11)
-      mutant (~> 0.8.11)
-      rspec-core (>= 3.4.0, < 3.6.0)
-    nenv (0.3.0)
-    notiffany (0.1.1)
-      nenv (~> 0.1)
-      shellany (~> 0.0)
-    optionable (0.2.0)
-    origin (2.2.0)
-    parallel (1.9.0)
-    parser (2.3.1.4)
-      ast (~> 2.2)
-    procto (0.0.3)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    rake (11.3.0)
-    rb-fsevent (0.9.7)
-    rb-inotify (0.9.7)
-      ffi (>= 0.5.0)
-    regexp_parser (0.3.6)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.3)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    ruby_dep (1.4.0)
-    shellany (0.0.1)
-    slop (3.6.0)
-    thor (0.19.1)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-    unparser (0.2.5)
-      abstract_type (~> 0.0.7)
-      adamantium (~> 0.2.0)
-      concord (~> 0.1.5)
-      diff-lcs (~> 1.2.5)
-      equalizer (~> 0.0.9)
-      parser (~> 2.3.0)
-      procto (~> 0.0.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  appraisal
-  database_cleaner
-  guard-rspec
-  mongoid-embedded-errors!
-  mutant-rspec
-  rake
-  rspec
-
-BUNDLED WITH
-   1.13.1