mongoid-embedded-errors 2.0.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 96ef455929fe07047621a0d5a2e33c576ee05926
-  data.tar.gz: dff154361af3fac2c963cd4ba7652902b8190441
+SHA256:
+  metadata.gz: 5a086d5eabe3e2746bbf05833787ee55f8e4b838f666e3aea1c5780e860aa58c
+  data.tar.gz: 1f8a09d1d856795631b53f6cbfe1bf832f385a350ff9e8a4e6f7cc0f4c0815c5
 SHA512:
-  metadata.gz: b70add5efeb3f66dd603edd5104537cbead19775fe643afa265b7fc1aef6ff2f308dcba412f0aafb5ae67256bdf86318917bb5a2632f910b254f4f4cd39054a0
-  data.tar.gz: fd0881ccee8b5243333a6f8e3219c5002d9c2772267db2f438f66c7975c495896edaa66f7da8c2491ba5f67a6fe7c77c0bf16c8fc05ebc47e14336e76f3d450c
+  metadata.gz: 9a6735fbef90d1143c2e724cdc2d33d669e6c829425e7ca4e1f548e2b7b11db5f817d1579cf1a6ba308c1758e628e70afc53865a3b35e84cbe2b3efee42d83cf
+  data.tar.gz: 7828bf072974db784c32622002c80650f0debb0858c10f4749906e77cb1ce5daa7658f483614b51b683e66db6f62c5334b4b322282eea247ff481e1ee3976422

data/.codeclimate.yml

@@ -0,0 +1,20 @@
+---
+version: "2"
+
+plugins:
+  rubocop:
+    enabled: true
+  bundler-audit:
+    enabled: true
+  fixme:
+    enabled: true
+  duplication:
+    enabled: true
+  reek:
+    enabled: true
+  git-legal:
+    enabled: true
+
+    config:
+      languages:
+      - ruby

data/.gitignore

@@ -17,3 +17,5 @@ profile
 .rake_tasks~
 *.log.lck
 solr/
+bin/
+*.lock

data/.rspec

@@ -0,0 +1,3 @@
+--color
+--require spec_helper
+--format documentation

data/.rubocop.yml

@@ -0,0 +1,83 @@
+# Use RuboCop RSpec
+require: rubocop-rspec
+
+# Common configuration.
+AllCops:
+  # Cop names are not displayed in offense messages by default. Change behavior
+  # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
+  # option.
+  DisplayCopNames: true
+  Exclude:
+    - Guardfile
+    - gemfiles/**/*
+    - bin/*
+    - vendor/bundle/**/*
+    - tmp/**/*
+  NewCops: enable
+
+Naming/FileName:
+  Exclude:
+    - Appraisals
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+  EnforcedStyleForEmptyBraces: no_space
+  SupportedStyles:
+    - space
+    - no_space
+
+Metrics/MethodLength:
+  CountComments: false  # count full line comments?
+  Max: 40
+
+Metrics/AbcSize:
+  Max: 40
+
+Layout/LineLength:
+  Max: 120
+
+Metrics/BlockLength:
+  Max: 50
+
+Style/Documentation:
+  Description: 'Document classes and non-namespace modules.'
+  Enabled: false
+
+Style/AutoResourceCleanup:
+  Description: 'Suggests the usage of an auto resource cleanup version of a method (if available).'
+  Enabled: true
+
+Style/CollectionMethods:
+  Description: 'Preferred collection methods.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size'
+  Enabled: true
+
+Style/MethodCalledOnDoEndBlock:
+  Description: 'Avoid chaining a method call on a do...end block.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#single-line-blocks'
+  Enabled: true
+
+Layout/ExtraSpacing:
+  Description: 'Do not use unnecessary spacing.'
+  Enabled: true
+
+Style/ClassAndModuleChildren:
+  # Checks the style of children definitions at classes and modules.
+  #
+  # Basically there are two different styles:
+  #
+  # `nested` - have each child on a separate line
+  #   class Foo
+  #     class Bar
+  #     end
+  #   end
+  #
+  # `compact` - combine definitions as much as possible
+  #   class Foo::Bar
+  #   end
+  #
+  # The compact style is only forced, for classes / modules with one child.
+  EnforcedStyle: compact
+  SupportedStyles:
+    - nested
+    - compact

data/.semaphore/semaphore.yml

@@ -0,0 +1,46 @@
+version: v1.0
+name: mongoid-embedded-errors
+agent:
+  machine:
+    type: e1-standard-2
+    os_image: ubuntu1804
+
+blocks:
+  - name: Code Climate
+    task:
+      jobs:
+      - name: Code Climate
+        commands: 
+          - checkout 
+          - cache restore gems-$SEMAPHORE_GIT_BRANCH-$(checksum Gemfile.lock),gems-$SEMAPHORE_GIT_BRANCH,gems-master
+          - bundle install --path vendor/bundle
+          - cache store gems-$SEMAPHORE_GIT_BRANCH-$(checksum Gemfile.lock) vendor/bundle
+          - docker run   --interactive --tty --rm   --env CODECLIMATE_CODE="$PWD"  --volume "$PWD":/code   --volume /tmp/cc:/tmp/cc   --volume /var/run/docker.sock:/var/run/docker.sock   codeclimate/codeclimate analyze
+
+  - name: Unit tests
+    task:
+      jobs:
+      - name: Appraisal
+        commands:
+          - checkout 
+          - cache restore gems-$SEMAPHORE_GIT_BRANCH-$(checksum Gemfile.lock),gems-$SEMAPHORE_GIT_BRANCH,gems-master
+          - bundle install --path vendor/bundle
+          - cache store gems-$SEMAPHORE_GIT_BRANCH-$(checksum Gemfile.lock) vendor/bundle
+          - cache restore appraisal-$SEMAPHORE_GIT_BRANCH-$(checksum gemfiles/*.gemfile.lock),appraisal-$SEMAPHORE_GIT_BRANCH,appraisal-master
+          - bundle exec appraisal
+          - cache store appraisal-$SEMAPHORE_GIT_BRANCH-$(checksum gemfiles/*.gemfile.lock) vendor/bundle
+          - sem-service start mongodb
+          - bundle exec appraisal rake test
+
+  - name: Mutant
+    task:
+      jobs:
+      - name: Mutant
+        commands:
+          - checkout 
+          - cache restore gems-$SEMAPHORE_GIT_BRANCH-$(checksum Gemfile.lock),gems-$SEMAPHORE_GIT_BRANCH,gems-master
+          - bundle install --path vendor/bundle
+          - cache store gems-$SEMAPHORE_GIT_BRANCH-$(checksum Gemfile.lock) vendor/bundle
+          - sem-service start mongodb
+          - MUTANT=true bundle exec mutant --since "$SEMAPHORE_GIT_SHA~1" --include lib --require mongoid --use rspec "Mongoid::EmbeddedErrors*"
+

data/Appraisals

@@ -0,0 +1,7 @@
+appraise 'mongoid-7' do
+  gem 'mongoid', '~> 7.0'
+end
+
+appraise 'mongoid-8' do
+  gem 'mongoid', '~> 8.0'
+end

data/CHANGELOG.md

@@ -0,0 +1,33 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+- TODO
+
+## [v4.0.0] - 2022-08-31
+- Fix rails 6 active model error deprecations (#22)
+- Added Mongoid 8 support
+- Dropped support for Mongoid 4, 5 and 6
+
+## [v3.0.1] - 2020-09-29
+### Added
+- Started 🔎 tracking changes in a changelog!
+- Mongoid 7 support
+- Ruby 2.4 support by using `send` instead of `public_send` [#18]
+
+### Removed
+- Mongoid 3 support
+
+### Fixed
+- Updated style to fix Rubocop issues (as per included .rubocop.yml configuration file)
+- Removed .lock files as these are not supposed to be included with gem source code
+
+## [v3.0.0] - 2020-09-29 [YANKED]
+- Yanked due to wrong dependencies in gemspec.
+
+[Unreleased]: https://github.com/glooko/mongoid-embedded-errors/compare/v4.0.0...HEAD
+[v4.0.0]: https://github.com/glooko/mongoid-embedded-errors/compare/v3.0.1...v4.0.0
+[v3.0.1]: https://github.com/glooko/mongoid-embedded-errors/compare/v3.0.0...v3.0.1
+[v3.0.0]: https://github.com/glooko/mongoid-embedded-errors/compare/f1ce0d8ed140de86c894b2fad7ad197504fefd5a...v3.0.0

data/Gemfile

@@ -1,7 +1,16 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in mongoid_delorean.gemspec
+# Specify your gem's dependencies in mongoid-embedded-errors.gemspec
 gemspec
 
-gem "rspec"
-gem 'database_cleaner'
+group :development do
+  gem 'rake'
+end
+
+group :test do
+  gem 'appraisal'
+  gem 'database_cleaner-mongoid', '~> 2.0', '>= 2.0.1'
+  gem 'guard-rspec'
+  gem 'mutant-rspec'
+  gem 'rspec'
+end

data/Guardfile

@@ -0,0 +1,42 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/README.md

@@ -1,6 +1,7 @@
 # Mongoid::EmbeddedErrors
+[![Code Climate](https://codeclimate.com/github/glooko/mongoid-embedded-errors/badges/gpa.svg)](https://codeclimate.com/github/glooko/mongoid-embedded-errors)
 
-Easily bubble up errors from embedded documents in Mongoid.
+Easily bubble up errors from embedded documents in Mongoid and newer.
 
 ## Installation
 
@@ -61,7 +62,7 @@ If we were to create an invalid `Article` with an invalid `Page` and tried to va
 article = Article.new(pages: [Page.new])
 article.valid? # => false
 
-article.error.messages
+article.errors.messages
 # => {:name=>["can't be blank"], :summary=>["can't be blank"], :pages=>["is invalid"]}
 ```
 
@@ -83,7 +84,7 @@ end
 article = Article.new(pages: [Page.new(sections: [Section.new])])
 article.valid? # => false
 
-article.error.messages
+article.errors.messages
 {
   :name => ["can't be blank"],
   :summary => ["can't be blank"],
@@ -102,8 +103,6 @@ Now, isn't that much nicer? Yeah, I think so to.
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
-## Contributers
+## Contributors
 
-* Mark Bates
-* Evgeniy Denisov
-* Nick Plante
+[See here](https://github.com/glooko/mongoid-embedded-errors/graphs/contributors)

data/Rakefile

@@ -1,11 +1,15 @@
-require 'bundler'  
+# frozen_string_literal: true
+
+require 'rubygems'
+require 'bundler/setup'
+
 Bundler::GemHelper.install_tasks
 
-desc "Run tests"
-task :default => [:test]
+desc 'Run tests'
+task default: [:test]
 
-task :spec => [:test]
+desc 'Run tests'
+task spec: [:test]
 
-task :test do
-  system "bundle exec rspec"
-end
+desc 'Run tests'
+task(:test) { system 'bundle exec rspec' }

data/gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

data/gemfiles/mongoid_4.gemfile

@@ -0,0 +1,16 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "mongoid", "~> 4.0"
+
+group :development do
+  gem "appraisal"
+  gem "database_cleaner"
+  gem "guard-rspec"
+  gem "mutant-rspec"
+  gem "rake"
+  gem "rspec"
+end
+
+gemspec path: "../"

data/gemfiles/mongoid_5.gemfile

@@ -0,0 +1,16 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "mongoid", "~> 5.0"
+
+group :development do
+  gem "appraisal"
+  gem "database_cleaner"
+  gem "guard-rspec"
+  gem "mutant-rspec"
+  gem "rake"
+  gem "rspec"
+end
+
+gemspec path: "../"

data/gemfiles/mongoid_6.gemfile

@@ -0,0 +1,16 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "mongoid", "~> 6.0"
+
+group :development do
+  gem "appraisal"
+  gem "database_cleaner"
+  gem "guard-rspec"
+  gem "mutant-rspec"
+  gem "rake"
+  gem "rspec"
+end
+
+gemspec path: "../"

data/gemfiles/mongoid_7.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "mongoid", "~> 7.0"
+
+group :development do
+  gem "rake"
+end
+
+group :test do
+  gem "appraisal"
+  gem "database_cleaner-mongoid", "~> 2.0", ">= 2.0.1"
+  gem "guard-rspec"
+  gem "mutant-rspec"
+  gem "rspec"
+end
+
+gemspec path: "../"

data/gemfiles/mongoid_8.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "mongoid", "~> 8.0"
+
+group :development do
+  gem "rake"
+end
+
+group :test do
+  gem "appraisal"
+  gem "database_cleaner-mongoid", "~> 2.0", ">= 2.0.1"
+  gem "guard-rspec"
+  gem "mutant-rspec"
+  gem "rspec"
+end
+
+gemspec path: "../"

data/lib/mongoid/embedded_errors/embedded_in.rb

@@ -0,0 +1,18 @@
+if Gem::Version.new(Mongoid::VERSION) >= Gem::Version.new('7.0.0')
+  require 'mongoid/association/embedded/embedded_in'
+  ASSOCIATION = Mongoid::Association::Macros::ClassMethods
+  EMBEDS_MANY = Mongoid::Association::Embedded::EmbedsMany
+else
+  require 'mongoid/relations/embedded/in'
+  ASSOCIATION = Mongoid::Relations::Macros::ClassMethods
+  EMBEDS_MANY = Mongoid::Relations::Embedded::Many
+end
+
+module ASSOCIATION
+  alias embedded_in_without_embedded_errors embedded_in
+  def embedded_in(*args)
+    relation = embedded_in_without_embedded_errors(*args)
+    send(:include, Mongoid::EmbeddedErrors)
+    relation
+  end
+end

data/lib/mongoid/embedded_errors/version.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+module Mongoid; end
+module Mongoid::EmbeddedErrors
+  VERSION = '4.0.0'
+end

data/lib/mongoid/embedded_errors.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'mongoid'
+require 'mongoid/embedded_errors/version'
+require 'mongoid/embedded_errors/embedded_in'
+
+module Mongoid::EmbeddedErrors
+  def self.included(klass)
+    return if klass.instance_methods.include?(:errors_without_embedded_errors)
+
+    klass.send :alias_method, :errors_without_embedded_errors, :errors
+    klass.send :alias_method, :errors, :errors_with_embedded_errors
+  end
+
+  def errors_with_embedded_errors
+    errors_without_embedded_errors.tap do |errs|
+      embedded_relations.each do |name, metadata|
+        # name is something like pages or sections
+        # if there is an 'is invalid' message for the relation then let's work it:
+        next unless Array(public_send(name)).any? { |doc| doc.errors.any? }
+
+        # first delete the generic 'is invalid' error for the relation
+        errs.delete name.to_sym, :invalid
+        errs.delete name.to_sym if errs[name].empty?
+
+        # next, loop through each of the relations (pages, sections, etc...)
+        [public_send(name)].flatten.reject(&:nil?).each_with_index do |rel, i|
+          next unless rel.errors.any?
+
+          # get each of their individual message and add them to the parent's errors:
+          rel.errors.each do |error|
+            attribute = error.attribute
+            message = error.message
+            relation = if Gem::Version.new(Mongoid::VERSION) >= Gem::Version.new('7.0.0')
+                         metadata.class
+                       else
+                         metadata.relation
+                       end
+            key = if relation.equal? EMBEDS_MANY
+                    "#{name}[#{i}].#{attribute}"
+                  else
+                    "#{name}.#{attribute}"
+                  end.to_sym
+            errs.delete(key)
+            errs.add key, message if message.present?
+          end
+        end
+      end
+    end
+  end
+end

data/lib/mongoid-embedded-errors.rb

@@ -1,41 +1,3 @@
-require 'mongoid'
-require "mongoid-embedded-errors/version"
-require "mongoid-embedded-errors/embedded_in"
-
-module Mongoid
-  module EmbeddedErrors
-
-    def self.included(klass)
-      # make sure that the alias only happens once:
-      unless klass.instance_methods.include?(:errors_without_embedded_errors)
-        klass.alias_method_chain(:errors, :embedded_errors)
-      end
-    end
-
-    def errors_with_embedded_errors
-      errs = errors_without_embedded_errors
-      self.embedded_relations.each do |name, metadata|
-        # name is something like pages or sections
-        # if there is an 'is invalid' message for the relation then let's work it:
-        if errs[name]
-          # first delete the unless 'is invalid' error for the relation
-          errs.delete(name.to_sym)
-          # next, loop through each of the relations (pages, sections, etc...)
-          [self.send(name)].flatten.reject(&:nil?).each_with_index do |rel, i|
-            # get each of their individual message and add them to the parent's errors:
-            if rel.errors.any?
-              rel.errors.messages.each do |k, v|
-                key = (rel.metadata.relation == Mongoid::Relations::Embedded::Many ? "#{name}[#{i}].#{k}" : "#{name}.#{k}").to_sym
-                errs.delete(key)
-                errs[key] = v
-                errs[key].flatten!
-              end
-            end
-          end
-        end
-      end
-      return errs
-    end
-
-  end
-end
+# rubocop:disable Naming/FileName
+require 'mongoid/embedded_errors'
+# rubocop:enable Naming/FileName

data/mongoid-embedded-errors.gemspec

@@ -1,21 +1,32 @@
-# -*- encoding: utf-8 -*-
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'mongoid-embedded-errors/version'
+require 'mongoid/embedded_errors/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = "mongoid-embedded-errors"
-  gem.version       = Mongoid::EmbeddedErrors::VERSION
-  gem.authors       = ["Mark Bates"]
-  gem.email         = ["mark@markbates.com"]
-  gem.description   = %q{Easily bubble up errors from embedded documents in Mongoid.}
-  gem.summary       = %q{Easily bubble up errors from embedded documents in Mongoid.}
-  gem.homepage      = ""
-
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.name          = 'mongoid-embedded-errors'
+  gem.version       = Mongoid::EmbeddedErrors::VERSION.dup
+  gem.authors       = ['Mark Bates', 'Kristijan Novoselić']
+  gem.email         = ['mark@markbates.com', 'kristijan@glooko.com']
+  gem.description   = 'Embedded documents in Mongoid can be really useful. '\
+                      'However, when one of those embedded documents is '\
+                      'invalid, Mongoid does not say which validation has '\
+                      'failed. Instead of just saying that an embedded '\
+                      'document is invalid, this gem modifies Mongoid '\
+                      'behavior so it explicitly provides validation errors '\
+                      'on a per-field basis for embedded documents, the '\
+                      'same way it does for parent documents.'
+  gem.summary       = 'Easily bubble up errors from embedded '\
+                      'documents in Mongoid.'
+  gem.homepage      = 'https://github.com/glooko/mongoid-embedded-errors'
+  gem.licenses      = ['MIT']
+  gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.require_paths = ['lib']
 
-  gem.add_dependency("mongoid", ">=3.0.0")
+  gem.add_dependency             'mongoid', '>=7.0', '<9.0.0'
+  gem.add_development_dependency 'rubocop', '~> 0.92'
+  gem.add_development_dependency 'rubocop-rspec', '~> 1.43'
 end

data/spec/lib/mongoid/embedded_errors_spec.rb

@@ -0,0 +1,89 @@
+# frozen_string_literal: true
+
+RSpec.describe Mongoid::EmbeddedErrors do
+  describe '#errors_with_embedded_errors' do
+    subject(:article) { Article.new name: 'Test', summary: '-', pages: pages }
+
+    before { |spec| article.validate unless spec.metadata[:do_not_validate] }
+
+    context 'when module is already included in a class', :do_not_validate do
+      let(:dummy_class) do
+        Class.new do
+          include Mongoid::Document
+          include Mongoid::EmbeddedErrors
+        end
+      end
+
+      it 'does not create errors_without_embedded_errors alias again' do
+        a = dummy_class.instance_method(:errors_without_embedded_errors)
+        dummy_class.include described_class
+
+        expect(
+          a
+        ).to eq(dummy_class.instance_method(:errors_without_embedded_errors))
+      end
+    end
+
+    context 'when article does not have any pages associated' do
+      let(:pages) { [] }
+
+      it { is_expected.not_to be_valid }
+
+      it "returns `can't be blank` error for pages" do
+        expect(article.errors[:pages]).to include "can't be blank"
+      end
+    end
+
+    context 'when article has one or more invalid pages' do
+      let(:pages) { [Page.new] }
+
+      it { is_expected.not_to be_valid }
+
+      it 'does not have any errors under `:pages` key' do
+        expect(article.errors[:pages]).to be_empty
+      end
+
+      it 'returns all errors for `pages[0]` object' do
+        expect(article.errors[:'pages[0].title']).to include "can't be blank"
+      end
+    end
+
+    context 'when validated multiple times' do
+      let(:pages) { [Page.new] }
+
+      it 'does not have duplicated errors for the same object' do
+        article.valid?
+        expect(article.errors[:'pages[0].title']).to eq(["can't be blank"])
+      end
+    end
+
+    context 'when embeds_many relation is invalid' do
+      let(:pages) { [Page.new(title: 'Test page', sections: sections)] }
+      let(:sections) { [Section.new] }
+
+      it 'returns all errors for `sections[0]` object' do
+        expect(article.errors[:'pages[0].sections[0].header']).to include "can't be blank"
+      end
+    end
+
+    context 'when embeds_one relation is invalid' do
+      subject(:article) { Article.new name: 'Test', summary: '-', pages: pages, annotation: annotation }
+
+      let(:pages) { [Page.new(title: 'Test page')] }
+      let(:annotation) { Annotation.new }
+
+      it 'returns all errors for `annotation` object' do
+        expect(article.errors[:'annotation.text']).to include "can't be blank"
+      end
+    end
+
+    context 'when embedded document has not been validated',
+            :do_not_validate do
+      let(:pages) { [Page.new] }
+
+      it 'does not trigger validations' do
+        expect(article.errors).to be_empty
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,18 +1,37 @@
-require 'bundler/setup'
-
-require 'mongoid-embedded-errors' # and any other gems you need
+# frozen_string_literal: true
 
-require 'database_cleaner'
+require 'bundler/setup'
+require 'mongoid-embedded-errors'
+require 'database_cleaner-mongoid'
 
-Mongoid.load!(File.join(File.dirname(__FILE__), "config.yml"), :test)
-require File.join(File.dirname(__FILE__), "support", "models")
+current_path = File.dirname(__FILE__)
+SPEC_MODELS_PATH = File.join(current_path, 'support/**/*.rb').freeze
+Dir[SPEC_MODELS_PATH].each { |f| require f }
 
-DatabaseCleaner[:mongoid].strategy = :truncation
+Mongoid.load! File.join(current_path, 'support/mongoid.yml'), :test
 
 RSpec.configure do |config|
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+  config.filter_run_excluding :skip
 
-  config.before(:each) do
-    DatabaseCleaner.clean
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+    expectations.syntax = :expect
   end
 
-end
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+  config.disable_monkey_patching!
+
+  config.before do
+    # Need to manually reload spec models for mutant to work as expected
+    if ENV['MUTANT']
+      Dir[SPEC_MODELS_PATH].each do |filename|
+        Object.send(:remove_const, File.basename(filename, '.rb').capitalize)
+        load filename
+      end
+    end
+  end
+end

data/spec/support/database_cleaner.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  DatabaseCleaner.strategy = :deletion
+  config.around do |example|
+    DatabaseCleaner.cleaning do
+      example.run
+    end
+  end
+
+  config.before(:all) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:all) do
+    DatabaseCleaner.clean
+  end
+end

data/spec/support/models/annotation.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class Annotation
+  include Mongoid::Document
+
+  embedded_in :article, inverse_of: :annotation
+
+  field :text, type: String
+
+  validates :text, presence: true
+end

data/spec/support/models/article.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class Article
+  include Mongoid::Document
+  include Mongoid::Timestamps
+  include Mongoid::EmbeddedErrors
+
+  embeds_many :pages
+  embeds_one :annotation
+
+  field :name, type: String
+  field :summary, type: String
+
+  validates :name, presence: true
+  validates :summary, presence: true
+  validates :pages, presence: true
+end

data/spec/support/models/page.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class Page
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  embedded_in :article, inverse_of: :pages
+  embeds_many :sections
+
+  field :title, type: String
+
+  validates :title, presence: true
+end

data/spec/support/models/section.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class Section
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  embedded_in :page, inverse_of: :sections
+
+  field :header, type: String
+  field :body, type: String
+
+  validates :header, presence: true
+end

data/spec/support/mongoid.yml

@@ -0,0 +1,13 @@
+test:
+  # mongoid 4
+  sessions:
+    default:
+      database: mongoid_embedded_errors_test
+      hosts:
+        - localhost:27017
+  # mongoid 5 and newer
+  clients:
+    default:
+      database: mongoid_embedded_errors_test
+      hosts:
+        - localhost:27017

metadata

@@ -1,52 +1,110 @@
 --- !ruby/object:Gem::Specification
 name: mongoid-embedded-errors
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Mark Bates
+- Kristijan Novoselić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-18 00:00:00.000000000 Z
+date: 2022-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 9.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 9.0.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.92'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.92'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.43'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
-description: Easily bubble up errors from embedded documents in Mongoid.
+        version: '1.43'
+description: Embedded documents in Mongoid can be really useful. However, when one
+  of those embedded documents is invalid, Mongoid does not say which validation has
+  failed. Instead of just saying that an embedded document is invalid, this gem modifies
+  Mongoid behavior so it explicitly provides validation errors on a per-field basis
+  for embedded documents, the same way it does for parent documents.
 email:
 - mark@markbates.com
+- kristijan@glooko.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".codeclimate.yml"
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".semaphore/semaphore.yml"
+- Appraisals
+- CHANGELOG.md
 - Gemfile
-- Gemfile.lock
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- gemfiles/.bundle/config
+- gemfiles/mongoid_4.gemfile
+- gemfiles/mongoid_5.gemfile
+- gemfiles/mongoid_6.gemfile
+- gemfiles/mongoid_7.gemfile
+- gemfiles/mongoid_8.gemfile
 - lib/mongoid-embedded-errors.rb
-- lib/mongoid-embedded-errors/embedded_in.rb
-- lib/mongoid-embedded-errors/version.rb
+- lib/mongoid/embedded_errors.rb
+- lib/mongoid/embedded_errors/embedded_in.rb
+- lib/mongoid/embedded_errors/version.rb
 - mongoid-embedded-errors.gemspec
-- spec/config.yml
-- spec/embedded_errors_spec.rb
+- spec/lib/mongoid/embedded_errors_spec.rb
 - spec/spec_helper.rb
-- spec/support/models.rb
-homepage: ''
-licenses: []
+- spec/support/database_cleaner.rb
+- spec/support/models/annotation.rb
+- spec/support/models/article.rb
+- spec/support/models/page.rb
+- spec/support/models/section.rb
+- spec/support/mongoid.yml
+homepage: https://github.com/glooko/mongoid-embedded-errors
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -54,23 +112,25 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Easily bubble up errors from embedded documents in Mongoid.
 test_files:
-- spec/config.yml
-- spec/embedded_errors_spec.rb
+- spec/lib/mongoid/embedded_errors_spec.rb
 - spec/spec_helper.rb
-- spec/support/models.rb
-has_rdoc: 
+- spec/support/database_cleaner.rb
+- spec/support/models/annotation.rb
+- spec/support/models/article.rb
+- spec/support/models/page.rb
+- spec/support/models/section.rb
+- spec/support/mongoid.yml

data/Gemfile.lock

@@ -1,44 +0,0 @@
-PATH
-  remote: .
-  specs:
-    mongoid-embedded-errors (2.0.1)
-      mongoid (>= 3.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activemodel (3.2.13)
-      activesupport (= 3.2.13)
-      builder (~> 3.0.0)
-    activesupport (3.2.13)
-      i18n (= 0.6.1)
-      multi_json (~> 1.0)
-    builder (3.0.4)
-    database_cleaner (0.9.1)
-    diff-lcs (1.1.3)
-    i18n (0.6.1)
-    mongoid (3.1.2)
-      activemodel (~> 3.2)
-      moped (~> 1.4.2)
-      origin (~> 1.0)
-      tzinfo (~> 0.3.22)
-    moped (1.4.5)
-    multi_json (1.7.7)
-    origin (1.1.0)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.3)
-    tzinfo (0.3.37)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  database_cleaner
-  mongoid-embedded-errors!
-  rspec

data/lib/mongoid-embedded-errors/embedded_in.rb

@@ -1,16 +0,0 @@
-require "mongoid/relations/embedded/in"
-
-module Mongoid
-  module Relations
-    module Macros
-      module ClassMethods
-        alias :embedded_in_without_embedded_errors :embedded_in
-        def embedded_in(*args)
-          relation = embedded_in_without_embedded_errors(*args)
-          self.send(:include, Mongoid::EmbeddedErrors)
-          return relation
-        end
-      end
-    end
-  end
-end

data/lib/mongoid-embedded-errors/version.rb

@@ -1,5 +0,0 @@
-module Mongoid
-  module EmbeddedErrors
-    VERSION = "2.0.1"
-  end
-end

data/spec/config.yml

@@ -1,6 +0,0 @@
-test:
-  sessions:
-    default:
-      database: mongoid_embedded_errors_test
-      hosts:
-        - localhost:27017

data/spec/embedded_errors_spec.rb

@@ -1,41 +0,0 @@
-require 'spec_helper'
-
-describe Mongoid::EmbeddedErrors do
-
-  let(:article) { Article.new }
-  let(:invalid_page) { Page.new }
-  let(:invalid_section) { Section.new }
-  let(:valid_section) { Section.new(header: "My Header") }
-  let(:invalid_annotation){ Annotation.new }
-
-  describe "errors" do
-
-    it "bubbles up errors from embedded documents" do
-      invalid_page.sections << valid_section
-      invalid_page.sections << invalid_section
-      article.pages << invalid_page
-      article.annotation = invalid_annotation
-      article.should_not be_valid
-      article.errors.messages.should eql({
-        name: ["can't be blank"],
-        summary: ["can't be blank"],
-        :"pages[0].title" => ["can't be blank"],
-        :"pages[0].sections[1].header" => ["can't be blank"],
-        :"annotation.text" => ["can't be blank"]
-      })
-    end
-
-    it "save works as before" do
-      article.save.should be_false
-      article.should_not be_persisted
-      article.errors.messages.should eql(name: ["can't be blank"], summary: ["can't be blank"])
-    end
-
-    it "handles errors on the main object" do
-      article.should_not be_valid
-      article.errors.messages.should eql(name: ["can't be blank"], summary: ["can't be blank"])
-    end
-
-  end
-
-end

data/spec/support/models.rb

@@ -1,49 +0,0 @@
-class Article
-  include Mongoid::Document
-  include Mongoid::Timestamps
-  include Mongoid::EmbeddedErrors
-
-  field :name, type: String
-  field :summary, type: String
-
-  validates :name, presence: true
-  validates :summary, presence: true
-
-  embeds_many :pages
-  embeds_one :annotation
-end
-
-class Page
-  include Mongoid::Document
-  include Mongoid::Timestamps
-
-  field :title, type: String
-
-  validates :title, presence: true
-
-  embedded_in :article, inverse_of: :pages
-  embeds_many :sections
-end
-
-class Section
-  include Mongoid::Document
-  include Mongoid::Timestamps
-
-  field :header, type: String
-  field :body, type: String
-
-  validates :header, presence: true
-
-  embedded_in :page, inverse_of: :sections
-end
-
-class Annotation
-  include Mongoid::Document
-
-  embedded_in :article, inverse_of: :annotation
-
-  field :text, type: String
-
-  validates :text, presence: true
-
-end