mongodoc 0.2.1 → 0.2.2

data/spec/associations/document_proxy_spec.rb

@@ -0,0 +1,42 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..',  'spec_helper'))
+
+describe "MongoDoc::Associations::DocumentProxy" do
+  class Parent
+    include MongoDoc::Document
+  end
+
+  class Child
+    include MongoDoc::Document
+  end
+
+  let(:parent) { Parent.new }
+  let(:name) {'association'}
+
+  subject do
+    MongoDoc::Associations::DocumentProxy.new(:assoc_name => name, :root => parent, :parent => parent, :assoc_class => Child)
+  end
+
+  it "has the association name" do
+    subject.assoc_name.should == name
+  end
+
+  it "has the parent" do
+    subject._parent.should == parent
+  end
+
+  it "has the root" do
+    subject._root.should == parent
+  end
+
+  it "has the association class" do
+    subject.assoc_class.should == Child
+  end
+
+  it "inserts the association name the _path_to_root" do
+    subject._path_to_root(Child.new, :name1 => 'value1', :name2 => 'value2').should == {"#{name}.name1" => 'value1', "#{name}.name2" => "value2"}
+  end
+
+  it "#build builds a new object" do
+    Child.should === subject.build({})
+  end
+end

data/spec/associations/hash_proxy_spec.rb

@@ -0,0 +1,163 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '/spec_helper'))
+
+describe MongoDoc::Associations::HashProxy do
+  class HashProxyTest
+    include MongoDoc::Document
+
+    key :name
+  end
+
+  let(:root) { stub('root', :register_save_observer => nil) }
+  let(:proxy) { MongoDoc::Associations::HashProxy.new(:assoc_name => 'has_many_name', :assoc_class => HashProxyTest, :root => root, :parent => root) }
+  let(:item) { HashProxyTest.new }
+  let(:other_item) {[1,2]}
+
+  context "#[]=" do
+    it "adds the item to the hash" do
+      proxy['new'] = item
+      proxy['new'].should == item
+    end
+
+    context "key names must be a string or symbol constrained by BSON element name" do
+      ['$invalid', 'in.valid', :_id, 'query', 1, Object.new].each do |name|
+        it "#{name} is invalid" do
+          expect do
+            proxy[name] = other_item
+          end.to raise_error(MongoDoc::InvalidEmbeddedHashKey)
+        end
+      end
+
+      [:key, 'key'].each do |name|
+        it "#{name} is a valid name" do
+          expect do
+            proxy[name] = other_item
+          end.to_not raise_error(MongoDoc::InvalidEmbeddedHashKey)
+        end
+      end
+    end
+
+    context "when the item is not a MongoDoc::Document" do
+
+      it "does not register a save observer" do
+        root.should_not_receive(:register_save_observer)
+        proxy['new'] = other_item
+      end
+
+      it "does not set the root" do
+        other_item.should_not_receive(:_root=)
+        proxy['new'] = other_item
+      end
+    end
+
+    context "when the item is a MongoDoc::Document" do
+      it "registers a save observer" do
+        root.should_receive(:register_save_observer)
+        proxy['new'] = item
+      end
+
+      it "sets the root" do
+        proxy['new'] = item
+        item._root.should == root
+      end
+    end
+  end
+
+  context "#merge!" do
+    context "when the key value is not a MongoDoc::Document" do
+
+      it "does not register a save observer" do
+        root.should_not_receive(:register_save_observer)
+        proxy.merge!(:new => other_item)
+      end
+
+      it "does not set the root" do
+        other_item.should_not_receive(:_root=)
+        proxy.merge!(:new => other_item)
+      end
+    end
+
+    context "when the key value is a MongoDoc::Document" do
+      it "registers a save observer" do
+        root.should_receive(:register_save_observer)
+        proxy.merge!(:new => item)
+      end
+
+      it "sets the root" do
+        proxy.merge!(:new => item)
+        item._root.should == root
+      end
+    end
+
+    context "with a block" do
+      it "calls into the block" do
+        proxy.merge!(:new => other_item) {|k, v1, v2| @result = v2}
+        @result.should == other_item
+      end
+
+      context "when the key value is not a MongoDoc::Document" do
+
+        it "does not register a save observer" do
+          root.should_not_receive(:register_save_observer)
+          proxy.merge!(:new => other_item) {|k, v1, v2| v2}
+        end
+
+        it "does not set the root" do
+          other_item.should_not_receive(:_root=)
+          proxy.merge!(:new => other_item) {|k, v1, v2| v2}
+        end
+      end
+
+      context "when the key value is a MongoDoc::Document" do
+        it "registers a save observer" do
+          root.should_receive(:register_save_observer)
+          proxy.merge!(:new => item) {|k, v1, v2| v2}
+        end
+
+        it "sets the root" do
+          proxy.merge!(:new => item) {|k, v1, v2| v2}
+          item._root.should == root
+        end
+      end
+    end
+  end
+
+  context "#replace" do
+    it "clears any existing data" do
+      proxy.should_receive(:clear)
+      proxy.replace(:new => other_item)
+    end
+
+    context "when the key value is not a MongoDoc::Document" do
+
+      it "does not register a save observer" do
+        root.should_not_receive(:register_save_observer)
+        proxy.replace(:new => other_item)
+      end
+
+      it "does not set the root" do
+        other_item.should_not_receive(:_root=)
+        proxy.replace(:new => other_item)
+      end
+    end
+
+    context "when the key value is a MongoDoc::Document" do
+      it "registers a save observer" do
+        root.should_receive(:register_save_observer)
+        proxy.replace(:new => item)
+      end
+
+      it "sets the root" do
+        proxy.replace(:new => item)
+        item._root.should == root
+      end
+    end
+
+  end
+
+  context "#build" do
+    it "builds an object of the collection class from the hash attrs" do
+      name = 'built'
+      proxy.build(:key, {:name => name}).name.should == name
+    end
+  end
+end

data/spec/attributes_spec.rb

@@ -66,7 +66,7 @@ describe "MongoDoc::Attributes" do
     class TestDoc
       include MongoDoc::Document
 
-      has_one :subdoc
+      has_one :sub_doc
     end
 
     class SubDoc
@@ -75,39 +75,33 @@ describe "MongoDoc::Attributes" do
       key :data
     end
 
-    it "sets the subdocuments parent to the parent proxy" do
-      subdoc = SubDoc.new
-      doc = TestDoc.new(:subdoc => subdoc)
-      MongoDoc::ParentProxy.should === subdoc._parent
-      subdoc._parent._parent.should == doc
+    let(:subdoc) { SubDoc.new }
+    let(:doc) { TestDoc.new(:sub_doc => subdoc) }
+
+    it "uses a proxy" do
+      MongoDoc::Associations::DocumentProxy.should === doc.sub_doc
     end
 
-    it "set the subdocuments root" do
-      subdoc = SubDoc.new
-      middoc = TestDoc.new
-      doc = TestDoc.new(:subdoc => middoc)
-      middoc.subdoc = subdoc
-      subdoc._root.should == doc
+    it "sets the subdocuments parent to the proxy" do
+      doc.sub_doc.should == subdoc._parent
     end
 
-    it "sets the subdocuments root no matter how when it is inserted" do
-      subdoc = SubDoc.new
-      middoc = TestDoc.new(:subdoc => subdoc)
-      doc = TestDoc.new(:subdoc => middoc)
-      subdoc._root.should == doc
+    it "set the subdocuments root" do
+      doc.should == subdoc._root
     end
 
-    class HasOneValidationTest
-      include MongoDoc::Document
+    context "validations" do
+      class HasOneValidationTest
+        include MongoDoc::Document
 
-      key :data
-      validates_presence_of :data
-    end
+        key :data
+        validates_presence_of :data
+      end
 
-    it "cascades validations down" do
-      invalid = HasOneValidationTest.new
-      doc = TestDoc.new(:subdoc => invalid)
-      doc.should have(1).error_on(:subdoc)
+      it "cascades validations down" do
+        invalid = HasOneValidationTest.new
+        TestDoc.new(:sub_doc => invalid).should have(1).error_on(:sub_doc)
+      end
     end
   end
 
@@ -144,50 +138,122 @@ describe "MongoDoc::Attributes" do
       has_many :sub_has_many_docs
     end
 
+    let(:subdoc) { SubHasManyDoc.new }
+    let(:doc) { TestHasManyDoc.new(:sub_docs => [subdoc]) }
+
     it "uses a proxy" do
-      MongoDoc::Proxy.should === TestHasManyDoc.new.sub_docs
+      MongoDoc::Associations::CollectionProxy.should === TestHasManyDoc.new.sub_docs
     end
 
     it "sets the subdocuments parent to the proxy" do
-      subdoc = SubHasManyDoc.new
-      doc = TestHasManyDoc.new(:sub_docs => [subdoc])
-      subdoc._parent.should == doc.sub_docs
+      doc.sub_docs.should == subdoc._parent
     end
 
     it "set the subdocuments root to the root" do
-      subdoc = SubHasManyDoc.new
-      doc = TestHasManyDoc.new(:sub_docs => [subdoc])
-      subdoc._root.should == doc
+      doc.should == subdoc._root
     end
 
     it "uses the association name to find the children's class name" do
-      subdoc = SubHasManyDoc.new
-      doc = TestImplicitHasManyDoc.new(:sub_has_many_docs => [subdoc])
+      TestImplicitHasManyDoc.new.sub_has_many_docs.assoc_class.should == SubHasManyDoc
     end
 
-    class HasManyValidationChild
+    context "validations" do
+      class HasManyValidationChild
+        include MongoDoc::Document
+
+        key :data
+        validates_presence_of :data
+      end
+
+      class HasManyValidationTest
+        include MongoDoc::Document
+
+        has_many :subdocs, :class_name => 'HasManyValidationChild'
+      end
+
+      let(:invalid_child) { HasHashValidationChild.new }
+      let(:doc) { HasHashValidationTest.new(:subdocs => {:key => invalid_child}) }
+
+      it "cascades validations and marks it in the parent" do
+        doc.should have(1).error_on(:subdocs)
+      end
+
+      it "cascades validations and marks it in the child" do
+        invalid_child.should have(1).error_on(:data)
+      end
+
+      it "ignores non-document children" do
+        HasManyValidationTest.new(:subdocs => ['not a doc']).should be_valid
+      end
+    end
+  end
+
+  context ".has_hash" do
+    class SubHasHashDoc
       include MongoDoc::Document
 
       key :data
-      validates_presence_of :data
     end
 
-    class HasManyValidationTest
+    class TestHasHashDoc
       include MongoDoc::Document
 
-      has_many :subdocs, :class_name => 'HasManyValidationChild'
+      has_hash :sub_docs, :class_name => 'SubHasHashDoc'
     end
 
-    it "cascades validations and marks it in the parent" do
-      invalid = HasManyValidationChild.new
-      doc = HasManyValidationTest.new(:subdocs => [invalid])
-      doc.should have(1).error_on(:subdocs)
+    class TestImplicitHasHashDoc
+      include MongoDoc::Document
+
+      has_hash :sub_has_hash_docs
+    end
+
+    let(:subdoc) { SubHasHashDoc.new }
+    let(:doc) { TestHasHashDoc.new(:sub_docs => {:key => subdoc}) }
+
+    it "uses a proxy" do
+      MongoDoc::Associations::HashProxy.should === TestHasHashDoc.new.sub_docs
+    end
+
+    it "sets the subdocuments parent to the proxy" do
+      doc.sub_docs.should == subdoc._parent
+    end
+
+    it "set the subdocuments root to the root" do
+      doc.should == subdoc._root
+    end
+
+    it "uses the association name to find the children's class name" do
+      TestImplicitHasHashDoc.new.sub_has_hash_docs.assoc_class.should == SubHasHashDoc
     end
 
-    it "cascades validations and marks it in the child" do
-      invalid = HasManyValidationChild.new
-      doc = HasManyValidationTest.new(:subdocs => [invalid])
-      invalid.should have(1).error_on(:data)
+    context "validations" do
+      class HasHashValidationChild
+        include MongoDoc::Document
+
+        key :data
+        validates_presence_of :data
+      end
+
+      class HasHashValidationTest
+        include MongoDoc::Document
+
+        has_hash :subdocs, :class_name => 'HasHashValidationChild'
+      end
+
+      let(:invalid_child) { HasHashValidationChild.new }
+      let(:doc) { HasHashValidationTest.new(:subdocs => {:key => invalid_child}) }
+
+      it "cascades validations and marks it in the parent" do
+        doc.should have(1).error_on(:subdocs)
+      end
+
+      it "cascades validations and marks it in the child" do
+        invalid_child.should have(1).error_on(:data)
+      end
+
+      it "ignores non-document children" do
+        HasHashValidationTest.new(:subdocs => {:key => 'data'}).should be_valid
+      end
     end
   end
 end

data/spec/bson_spec.rb

@@ -21,7 +21,7 @@ describe "BSON for Mongo (BSON)" do
       MongoDoc::BSON.should_receive(:array_create).with(array, options)
       MongoDoc::BSON.decode(array, options)
     end
-    
+
     it "returns the json value as is if the parameter is not a hash or array" do
       ["", 1, 1.5, true, false, nil].each do |type_value|
         MongoDoc::BSON.decode(type_value).should == type_value
@@ -37,7 +37,7 @@ describe "BSON for Mongo (BSON)" do
       MongoDoc::BSON.should_receive(:decode).with(first, options)
       MongoDoc::BSON.array_create(array, options)
     end
-    
+
     it "just returns the array if the :raw_json option is used" do
       hash = {'key' => 'value', MongoDoc::BSON::CLASS_KEY => 'Date'}
       array = [hash]
@@ -45,32 +45,32 @@ describe "BSON for Mongo (BSON)" do
       MongoDoc::BSON.array_create(array, :raw_json => true).should == array
     end
   end
-  
+
   describe "#bson_create" do
     it "leaves a simple hash intact" do
       hash = {}
       MongoDoc::BSON.bson_create(hash).should == hash
     end
-    
+
     it "a class hash extracts the class, and calls class.bson_create" do
       base_hash = {'key' => 'value'}
       bson_hash = base_hash.merge(MongoDoc::BSON::CLASS_KEY => 'Date')
       Date.should_receive(:bson_create).with(base_hash, {})
       MongoDoc::BSON.bson_create(bson_hash)
     end
-    
+
     it "ignores a class hash when the :raw_json option is used" do
       hash = {'key' => 'value', MongoDoc::BSON::CLASS_KEY => 'Date'}
       MongoDoc::BSON.bson_create(hash, :raw_json => true).should == hash
     end
   end
-  
+
   describe "Hash" do
     it "#to_bson returns the hash" do
       hash = {'key' => 1}
       hash.to_bson.should == hash
     end
-    
+
     it "#to_bson returns the hash with symbol keys as strings" do
       {:key => 1}.to_bson.should == {"key" => 1}
     end
@@ -79,45 +79,45 @@ describe "BSON for Mongo (BSON)" do
       hash = {'key' => 1}
       MongoDoc::BSON.decode(hash.to_bson).should == hash
     end
-    
+
     it "decodes the values of the hash" do
       hash = {'key' => {'subkey' => Date.today}}
       MongoDoc::BSON.decode(hash.to_bson).should == hash
     end
   end
-  
+
   describe "Array" do
     it "#to_bson returns the array" do
       array = ['string', 1]
       array.to_bson.should == array
     end
-    
+
     it "#to_bson iterates over its elements" do
       array = []
       array.should_receive(:map)
       array.to_bson
     end
-    
+
     it "decodes to an array" do
       array = ['string', 1]
       MongoDoc::BSON.decode(array.to_bson).should == array
     end
   end
-  
+
   describe "Extensions to core classes" do
     it "#to_bson for objects that are BSON native return themselves" do
       [true, false, nil, 1.0, 1, /regexp/, 'string', :symbol, Time.now].each do |native|
         native.to_bson.should == native
       end
     end
-    
+
     it "objects that are BSON native decode to themselves" do
       [true, false, nil, 1.0, 1, /regexp/, 'string', :symbol, Time.now].each do |native|
         hash = {'native' => native}
         MongoDoc::BSON.decode(hash.to_bson).should == hash
       end
     end
-    
+
     it "Date#to_bson returns a date hash" do
       date = Date.today
       date.to_bson.should == {MongoDoc::BSON::CLASS_KEY => "Date", "dt" => date.strftime, "sg"  => date.respond_to?(:start) ? date.start : date.sg}
@@ -127,40 +127,40 @@ describe "BSON for Mongo (BSON)" do
       date = Date.today
       MongoDoc::BSON.decode(date.to_bson).should == date
     end
-    
+
     it "DateTime#to_bson returns a datetime hash" do
       datetime = DateTime.now
       datetime.to_bson.should == {MongoDoc::BSON::CLASS_KEY => "DateTime", "dt" => datetime.strftime, "sg"  => datetime.respond_to?(:start) ? datetime.start : datetime.sg}
     end
-    
+
     it "roundtrips DateTime" do
       datetime = DateTime.now
       MongoDoc::BSON.decode(datetime.to_bson).to_s.should == datetime.to_s
     end
   end
-  
+
   describe "Mongo Classes" do
-    [Mongo::ObjectID.new, Mongo::DBRef.new('ns', 1), Mongo::Code.new('code'), Mongo::Binary.new, Mongo::RegexpOfHolding.new('a', 'i', 'g')].each do |obj|
+    [Mongo::ObjectID.new, Mongo::DBRef.new('ns', 1), Mongo::Code.new('code'), Mongo::Binary.new].each do |obj|
       it "#to_bson for #{obj.class.name} returns self" do
         obj.to_bson.should == obj
       end
-      
+
       it "objects of type #{obj.class.name} decode to themselves" do
         hash = {"mongo" => obj}
         MongoDoc::BSON.decode(hash.to_bson)["mongo"].should == obj
       end
     end
   end
-  
+
   describe "Extensions to Object" do
     class Simple
       attr_accessor :value
     end
-    
+
     class Complex
       attr_accessor :array_of_simple
     end
-    
+
     before do
       @value1 = 'value1'
       @simple1 = Simple.new
@@ -175,7 +175,7 @@ describe "BSON for Mongo (BSON)" do
     it "renders a json representation of a simple object" do
       @simple1.to_bson.should be_bson_eql({MongoDoc::BSON::CLASS_KEY => Simple.name, "value" => @value1})
     end
-    
+
     it "renders a json representation of an object with embedded objects" do
       @complex.to_bson.should be_bson_eql({MongoDoc::BSON::CLASS_KEY => Complex.name, "array_of_simple" => [@simple1.to_bson, @simple2.to_bson]})
     end
@@ -192,5 +192,5 @@ describe "BSON for Mongo (BSON)" do
       obj = MongoDoc::BSON.decode(@complex.to_bson)
       obj.array_of_simple.each {|o| o.should be_kind_of(Simple)}
     end
-  end  
+  end
 end