mongo_mapper 0.15.0 → 0.15.1

data/spec/functional/document_spec.rb

@@ -257,9 +257,6 @@ describe "Document" do
       @instance.bar.should_not be_nil
     end
 
-    it "should reset nil one association" do
-    end
-
     it "should reinstantiate embedded associations" do
       @instance.reload
       @instance.bars.first.name.should == '1'

data/spec/functional/identity_map_spec.rb

@@ -461,7 +461,7 @@ describe "IdentityMap" do
 
         blog = Blog.create(:title => 'Jill', :parent => root)
         assert_in_map(blog)
-        root.should equal(blog.parent.target)
+        root.should equal(blog.parent)
       end
 
       it "should work correctly with one proxy" do
@@ -470,7 +470,7 @@ describe "IdentityMap" do
 
         root = Item.create(:title => 'Root', :blog => blog)
         assert_in_map(root)
-        blog.should equal(root.blog.target)
+        blog.should equal(root.blog)
       end
 
       it "should work correctly with one proxy create" do

data/spec/functional/keys_spec.rb

@@ -34,28 +34,46 @@ describe "Keys" do
     instance.foo.should == 'baz'
   end
 
-  context "when persisting an typecasted array" do
-    TypecastedKeyModel = Doc do
-      key :people, Array, :typecast => "Person"
-    end
-
+  context "when persisting typecasts" do
     Person = Struct.new(:name) do
       def self.to_mongo(value)
         value.name
       end
 
       def self.from_mongo(value)
-        Person.new value
+        new(value)
       end
     end
 
-    it "should not mutate the model's state" do
-      person = Person.new "Bob"
-      doc = TypecastedKeyModel.new(:people => [person])
+    context "when persisting a typecast Array" do
+      typecast_key_model = Doc do
+        key :people, Array, :typecast => "Person"
+      end
+
+      it "should not mutate the model's state" do
+        person = Person.new "Bob"
+        doc = typecast_key_model.new(:people => [person])
 
-      doc.save
+        doc.save!
+
+        doc.people.should == [person]
+      end
+    end
 
-      doc.people.should == [person]
+    context "when persisting a typecast Set" do
+      typecast_key_model = Doc do
+        key :people, Set, :typecast => "Person"
+      end
+
+      it "should not mutate the model's state" do
+        person = Person.new "Bob"
+
+        doc = typecast_key_model.new(:people => Set.new([person]))
+
+        doc.save!
+
+        doc.people.should == Set.new([person])
+      end
     end
   end
 

data/spec/functional/modifiers_spec.rb

@@ -471,6 +471,13 @@ module Modifiers
             assert_page_counts page, 1, 2, 3
           end
 
+          it "should be able to increment with just the field name" do
+            page = page_class.create
+            page.increment :day_count
+
+            assert_page_counts page, 1, 0, 0
+          end
+
           it "should be able to decrement with modifier hashes" do
             page = page_class.create(:day_count => 1, :week_count => 2, :month_count => 3)
             page.decrement(:day_count => 1, :week_count => 2, :month_count => 3)
@@ -478,6 +485,13 @@ module Modifiers
             assert_page_counts page, 0, 0, 0
           end
 
+          it "should be able to decrement with just the field name" do
+            page = page_class.create
+            page.decrement :day_count
+
+            assert_page_counts page, -1, 0, 0
+          end
+
           it "should always decrement when decrement is called whether number is positive or negative" do
             page = page_class.create(:day_count => 1, :week_count => 2, :month_count => 3)
             page.decrement(:day_count => -1, :week_count => 2, :month_count => -3)

data/spec/functional/querying_spec.rb

@@ -219,6 +219,16 @@ describe "Querying" do
       end
     end
 
+    context "(with array of single id)" do
+      it "should return an array" do
+        document.find([@doc1._id]).should == [@doc1]
+      end
+
+      it "should return an array for find!" do
+        document.find!([@doc1._id]).should == [@doc1]
+      end
+    end
+
     it "should be able to find using condition auto-detection" do
       document.first(:first_name => 'John').should == @doc1
       document.all(:last_name => 'Nunemaker', :order => 'age desc').should == [@doc1, @doc3]
@@ -255,6 +265,18 @@ describe "Querying" do
         document.find_each(:last_name => 'Nunemaker', :order => 'age desc') {|doc| yield_documents << doc }
         yield_documents.should == [@doc1, @doc3]
       end
+
+      it "should return an enumerator when no block is given" do
+        yield_documents = []
+        enum = document.find_each(:order => "first_name")
+        enum.with_index {|doc, idx| yield_documents << [doc, idx] }
+        yield_documents.should == [[@doc1, 0], [@doc3, 1], [@doc2, 2]]
+
+        yield_documents = []
+        enum = document.find_each(:last_name => 'Nunemaker', :order => 'age desc')
+        enum.with_index {|doc, idx| yield_documents << [doc, idx] }
+        yield_documents.should == [[@doc1, 0], [@doc3, 1]]
+      end
     end
   end # finding documents
 

data/spec/functional/strong_parameters_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe "Strong parameters" do
+  context 'A document with strong parameters protection' do
+    if ::ActiveModel.const_defined?(:ForbiddenAttributesProtection)
+      require "action_controller/metal/strong_parameters"
+
+      before do
+        @doc_class = Doc do
+          plugin MongoMapper::Plugins::StrongParameters
+
+          key :name, String
+          key :admin, Boolean, :default => false
+        end
+
+        @doc = @doc_class.create(:name => 'Steve Sloan')
+      end
+
+      let(:params) {
+        {name: "Permitted", admin: true}
+      }
+
+      let(:strong_params) {
+        ActionController::Parameters.new params
+      }
+
+      it "allows assignment of attribute hashes" do
+        @doc.attributes = params
+        @doc.name.should =="Permitted"
+      end
+
+      it "doesn't allow mass assignment of ActionController::Parameters" do
+        lambda {
+          @doc.attributes = strong_params
+        }.should raise_error(ActiveModel::ForbiddenAttributesError)
+      end
+
+      it "does not allow mass assignment of non-permitted attributes" do
+        @doc.attributes = strong_params.permit(:name)
+        @doc.admin.should == false
+      end
+
+      it "allows mass assignment of permitted attributes" do
+        @doc.attributes = strong_params.permit(:name)
+        @doc.name.should == "Permitted"
+      end
+    end
+  end
+end

data/spec/unit/associations/proxy_spec.rb

@@ -77,10 +77,6 @@ describe "Proxy" do
     @proxy.proxy_owner.should == @owner
   end
 
-  it "should alias proxy target to target" do
-    @proxy.proxy_target.should == @target
-  end
-
   context "send" do
     it "should work if proxy responds to method" do
       @proxy.send(:reset)

data/spec/unit/keys_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 
-
 describe "Key" do
   context ".new with no id and _id of type integer" do
     it "should not error" do
@@ -152,4 +151,14 @@ describe "Key" do
       }.should_not change { counter }
     end
   end
+
+  context "with attributes key" do
+    it "should raise an error" do
+      lambda do
+        klass = Doc do
+          key :attributes, Hash
+        end
+      end.should raise_error("`attributes` is a reserved key name")
+    end
+  end
 end # KeyTest

data/spec/unit/validations_spec.rb

@@ -157,19 +157,19 @@ describe "Validations" do
       end # numericality of
 
       context "validating presence of" do
-           it "should work with validates_presence_of macro" do
-             @document.key :name, String
-             @document.validates_presence_of :name
-             doc = @document.new
-             doc.should have_error_on(:name)
-           end
-
-           it "should work with :required shortcut on key definition" do
-             @document.key :name, String, :required => true
-             doc = @document.new
-             doc.should have_error_on(:name)
-           end
-         end
+        it "should work with validates_presence_of macro" do
+          @document.key :name, String
+          @document.validates_presence_of :name
+          doc = @document.new
+          doc.should have_error_on(:name)
+        end
+
+        it "should work with :required shortcut on key definition" do
+          @document.key :name, String, :required => true
+          doc = @document.new
+          doc.should have_error_on(:name)
+        end
+      end
 
       context "validating exclusion of" do
         it "should throw error if enumerator not provided" do
@@ -436,19 +436,19 @@ describe "Validations" do
       end # numericality of
 
       context "validating presence of" do
-         it "should work with validates_presence_of macro" do
+        it "should work with validates_presence_of macro" do
            @embedded_doc.key :name, String
            @embedded_doc.validates_presence_of :name
            doc = @embedded_doc.new
            doc.should have_error_on(:name)
-         end
+        end
 
-         it "should work with :required shortcut on key definition" do
+        it "should work with :required shortcut on key definition" do
            @embedded_doc.key :name, String, :required => true
            doc = @embedded_doc.new
            doc.should have_error_on(:name)
-         end
-       end
+        end
+      end
 
       context "validating exclusion of" do
         it "should throw error if enumerator not provided" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongo_mapper
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - John Nunemaker
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-15 00:00:00.000000000 Z
+date: 2020-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongo
@@ -142,6 +142,7 @@ files:
 - lib/mongo_mapper/plugins/associations/collection.rb
 - lib/mongo_mapper/plugins/associations/embedded_collection.rb
 - lib/mongo_mapper/plugins/associations/in_array_proxy.rb
+- lib/mongo_mapper/plugins/associations/in_foreign_array_proxy.rb
 - lib/mongo_mapper/plugins/associations/many_association.rb
 - lib/mongo_mapper/plugins/associations/many_documents_as_proxy.rb
 - lib/mongo_mapper/plugins/associations/many_documents_proxy.rb
@@ -188,6 +189,7 @@ files:
 - lib/mongo_mapper/plugins/scopes.rb
 - lib/mongo_mapper/plugins/serialization.rb
 - lib/mongo_mapper/plugins/stats.rb
+- lib/mongo_mapper/plugins/strong_parameters.rb
 - lib/mongo_mapper/plugins/timestamps.rb
 - lib/mongo_mapper/plugins/touch.rb
 - lib/mongo_mapper/plugins/userstamps.rb
@@ -206,6 +208,7 @@ files:
 - spec/functional/associations/belongs_to_polymorphic_proxy_spec.rb
 - spec/functional/associations/belongs_to_proxy_spec.rb
 - spec/functional/associations/in_array_proxy_spec.rb
+- spec/functional/associations/in_foreign_array_proxy_spec.rb
 - spec/functional/associations/many_documents_as_proxy_spec.rb
 - spec/functional/associations/many_documents_proxy_spec.rb
 - spec/functional/associations/many_embedded_polymorphic_proxy_spec.rb
@@ -242,6 +245,7 @@ files:
 - spec/functional/scopes_spec.rb
 - spec/functional/static_keys_spec.rb
 - spec/functional/stats_spec.rb
+- spec/functional/strong_parameters_spec.rb
 - spec/functional/timestamps_spec.rb
 - spec/functional/touch_spec.rb
 - spec/functional/userstamps_spec.rb