mongo_mapper 0.14.0 → 0.15.4

data/spec/functional/accessible_spec.rb

@@ -91,6 +91,12 @@ describe "Accessible" do
       @doc.admin.should be_falsey
     end
 
+    it "should ignore inaccessible attribute on #assign_attributes" do
+      @doc.assign_attributes({:name => 'Ren Hoek', :admin => true})
+      @doc.name.should == 'Ren Hoek'
+      @doc.admin.should be_falsey
+    end
+
     it "should be indifferent to whether the accessible keys are strings or symbols" do
       @doc.update_attributes!("name" => 'Stimpson J. Cat', "admin" => true)
       @doc.name.should == 'Stimpson J. Cat'
@@ -119,7 +125,7 @@ describe "Accessible" do
         key :name, String
         key :site_id, ObjectId
       end
-      GrandParent.collection.remove
+      GrandParent.collection.drop
 
       class ::Child < ::GrandParent
         attr_accessible :position

data/spec/functional/associations/belongs_to_polymorphic_proxy_spec.rb

@@ -3,8 +3,8 @@ require 'spec_helper'
 
 describe "BelongsToPolymorphicProxy" do
   before do
-    Status.collection.remove
-    Project.collection.remove
+    Status.collection.drop
+    Project.collection.drop
   end
 
   it "should default to nil" do

data/spec/functional/associations/belongs_to_proxy_spec.rb

@@ -51,7 +51,7 @@ describe "BelongsToProxy" do
   it "should not reload the association when replacing" do
     post = @post_class.new(:name => 'mongomapper')
     comment = @comment_class.new(:name => 'Foo!', :post => post)
-    comment.post.proxy_target.object_id.should == post.object_id
+    comment.post.object_id.should == post.object_id
   end
 
   it "should properly assign the associated object when assigning the association with create" do
@@ -121,13 +121,13 @@ describe "BelongsToProxy" do
       class ::Property
         include MongoMapper::Document
       end
-      Property.collection.remove
+      Property.collection.drop
 
       class ::Thing
         include MongoMapper::Document
         key :name, String
       end
-      Thing.collection.remove
+      Thing.collection.drop
     end
 
     after do
@@ -211,7 +211,7 @@ describe "BelongsToProxy" do
       end
 
       it "should raise exception if invalid" do
-        expect { comment.create_post! }.to raise_error(MongoMapper::DocumentNotValid)
+        lambda { comment.create_post! }.should raise_error(MongoMapper::DocumentNotValid)
       end
 
       it "should work if valid" do
@@ -252,4 +252,54 @@ describe "BelongsToProxy" do
       post.reload.title.should == 'Hello, world!'
     end
   end
-end
+
+  context "regression with reassignment" do
+    it "should not infinite regress (shouldn't raise SystemStackError) when assigned to twice (when the proxy isn't around)" do
+      post = @post_class.create!
+      comment = @comment_class.create!(post: post)
+
+      comment = @comment_class.find(comment.id)
+
+      post = comment.post
+
+      comment.post = post
+
+      lambda do
+        comment.post = post
+      end.should_not raise_error
+    end
+  end
+
+  context "foreign_key=" do
+    it "should reset parent when foreign key is changed" do
+      post = @post_class.create!
+      comment = @comment_class.create!(post: post)
+      another_post = @post_class.create!
+
+      comment.post.should == post
+
+      comment.post_id = another_post.id
+
+      comment.post.should == another_post
+
+      comment.post_id = nil
+
+      comment.post.should == nil
+    end
+
+    it "should reset parent when foreign key is changed from nil" do
+      post = @post_class.create!
+      comment = @comment_class.create!(post: nil)
+
+      comment.post.should == nil
+
+      comment.post_id = post.id
+
+      comment.post.should == post
+
+      comment.post_id = nil
+
+      comment.post.should == nil
+    end
+  end
+end

data/spec/functional/associations/in_array_proxy_spec.rb

@@ -14,8 +14,8 @@ describe "InArrayProxy" do
         key :list_ids, Array
         many :lists, :in => :list_ids
       end
-      User.collection.remove
-      List.collection.remove
+      User.collection.drop
+      List.collection.drop
     end
 
     after do
@@ -112,9 +112,9 @@ describe "InArrayProxy" do
       end
 
       it "should raise exception if invalid" do
-        expect {
+        lambda {
           @user.lists.create!
-        }.to raise_error(MongoMapper::DocumentNotValid)
+        }.should raise_error(MongoMapper::DocumentNotValid)
       end
 
       it "should reset cache" do
@@ -144,7 +144,7 @@ describe "InArrayProxy" do
 
         it "should not hit the database if ids key is empty" do
           @user.list_ids = []
-          expect(@user.lists).to receive(:query).never
+          @user.lists.should_receive(:query).never
           @user.lists.all.should == []
         end
       end
@@ -160,7 +160,7 @@ describe "InArrayProxy" do
 
         it "should not hit the database if ids key is empty" do
           @user.list_ids = []
-          expect(@user.lists).to receive(:query).never
+          @user.lists.should_receive(:query).never
           @user.lists.first.should be_nil
         end
       end
@@ -176,7 +176,7 @@ describe "InArrayProxy" do
 
         it "should not hit the database if ids key is empty" do
           @user.list_ids = []
-          expect(@user.lists).to receive(:query).never
+          @user.lists.should_receive(:query).never
           @user.lists.last.should be_nil
         end
       end
@@ -195,9 +195,9 @@ describe "InArrayProxy" do
         end
 
         it "should raise error when using ! and not found" do
-          expect {
+          lambda {
             @user.lists.find!(@list3.id)
-          }.to raise_error(MongoMapper::DocumentNotFound)
+          }.should raise_error(MongoMapper::DocumentNotFound)
         end
       end
 
@@ -230,7 +230,7 @@ describe "InArrayProxy" do
 
         it "should not hit the database if ids key is empty" do
           @user.list_ids = []
-          expect(@user.lists).to receive(:query).never
+          @user.lists.should_receive(:query).never
           @user.lists.paginate(:page => 1).should == []
         end
       end
@@ -249,9 +249,9 @@ describe "InArrayProxy" do
         end
 
         it "should raise error when using ! and not found" do
-          expect {
+          lambda {
             @user.lists.find_by_name!('Foo 3')
-          }.to raise_error(MongoMapper::DocumentNotFound)
+          }.should raise_error(MongoMapper::DocumentNotFound)
         end
 
         context "find_or_create_by" do
@@ -293,7 +293,7 @@ describe "InArrayProxy" do
 
       it "should not hit the database if ids key is empty" do
         @user.list_ids = []
-        expect(@user.lists).to receive(:query).never
+        @user.lists.should_receive(:query).never
         @user.lists.count(:name => 'Foo 1').should == 0
       end
     end
@@ -346,4 +346,139 @@ describe "InArrayProxy" do
       end
     end
   end
-end
+
+  describe "ordering" do
+    before do
+      @user_class = Doc("User") do
+        key :list_ids, Array
+      end
+
+      @list_class = Doc("List") do
+        key :name, String, :required => true
+      end
+    end
+
+    def create_list_items
+      @user = @user_class.create!
+      @list1 = @list_class.create!(:name => "one")
+      @list2 = @list_class.create!(:name => "two")
+      @list3 = @list_class.create!(:name => "three")
+
+      @user.lists << [@list3, @list2, @list1]
+      @user.save!
+
+      @user.reload
+    end
+
+    shared_examples_for "ordering is on" do
+      it "should have the items ordered according to order of the ids" do
+        @user.lists.should == [@list3, @list2, @list1]
+      end
+
+      it "should have the right item for #first" do
+        @user.lists.first.should == @list3
+      end
+
+      it "should have the right item for #last" do
+        @user.lists.last.should == @list1
+      end
+
+      it "does not work for pagination (but probably should)" do
+        @user.lists.paginate(:per_page => 100).should == [@list1, @list2, @list3]
+      end
+
+      it "should work with find" do
+        @user.lists.find(@list2.id, @list1.id).should == [@list2, @list1]
+        @user.lists.find(@list1.id, @list2.id).should == [@list2, @list1]
+        @user.lists.find(@list1.id).should == @list1
+      end
+
+      it "should work with find!" do
+        @user.lists.find!(@list2.id, @list1.id).should == [@list2, @list1]
+        @user.lists.find!(@list1.id, @list2.id).should == [@list2, @list1]
+      end
+
+      it "should only load one object with first (and no params given)" do
+        @list_class.should_receive(:allocate).once.and_return @list3
+        @user.lists.first
+      end
+
+      it "should only load one object with first (and params given)" do
+        @list_class.should_receive(:allocate).once.and_return @list3
+        @user.lists.first(:name => /^t/)
+      end
+
+      it "should only load one object with last (and no params given)" do
+        @list_class.should_receive(:allocate).once.and_return @list1
+        @user.lists.last
+      end
+
+      it "should only load one object with last (and params given)" do
+        @list_class.should_receive(:allocate).once.and_return @list3
+        @user.lists.last(:name => /^t/)
+      end
+
+      it "should return nil if first with a query matches no objects" do
+        @user.lists.first(:name => "non-existent").should be_nil
+      end
+
+      it "should return nil if last with a query matches no objects" do
+        @user.lists.last(:name => "non-existent").should be_nil
+      end
+
+      it "should work with extra query params to first and last" do
+        @user.lists.first(:name => /^t/).should == @list3
+        @user.lists.first(:name => /^o/).should == @list1
+
+        @user.lists.last(:name => /^t/).should == @list2
+        @user.lists.last(:name => /^o/).should == @list1
+      end
+    end
+
+    shared_examples_for "ordering is off" do
+      it "should include all items" do
+        @user.lists.length == 3
+        @user.lists.should include(@list1)
+        @user.lists.should include(@list2)
+        @user.lists.should include(@list3)
+      end
+
+      it "should return the items in the natural order" do
+        @user.lists.should == [@list1, @list2, @list3]
+      end
+
+      it "should work with find" do
+        @user.lists.find(@list2.id, @list1.id).should == [@list1, @list2]
+        @user.lists.find(@list1.id, @list2.id).should == [@list1, @list2]
+        @user.lists.find(@list1.id).should == @list1
+      end
+    end
+
+    describe "without a param" do
+      before do
+        @user_class.many :lists, :in => :list_ids, :class => @list_class
+        create_list_items
+      end
+
+      it_behaves_like "ordering is off"
+    end
+
+    describe "with ordering off" do
+      before do
+        @user_class.many :lists, :in => :list_ids, :class => @list_class, :ordered => false
+        create_list_items
+      end
+
+      it_behaves_like "ordering is off"
+    end
+
+    describe "with ordering on" do
+      before do
+        @user_class.many :lists, :in => :list_ids, :class => @list_class, :ordered => true
+        create_list_items
+      end
+
+      it_behaves_like "ordering is on"
+    end
+  end
+end

data/spec/functional/associations/in_foreign_array_proxy_spec.rb

@@ -0,0 +1,321 @@
+require 'spec_helper'
+
+describe "InForeignArrayProxyTest" do
+  context "description" do
+    before do
+      class ::List
+        include MongoMapper::Document
+        key :name, String, :required => true
+        key :user_ids, Array
+        many :users, :in => :user_ids
+      end
+
+      class ::User
+        include MongoMapper::Document
+        key :name, String, :required => true
+        many :lists, :from => :user_ids, :as => :user
+      end
+      User.collection.drop
+      List.collection.drop
+    end
+
+    after do
+      Object.send :remove_const, 'List' if defined?(::List)
+      Object.send :remove_const, 'User' if defined?(::User)
+    end
+
+    it "should default reader to empty array" do
+      User.new.lists.should == []
+    end
+
+    it "should allow adding to association like it was an array" do
+      user = User.new(:name => 'John')
+      user.lists <<     List.new(:name => 'Foo1!')
+      user.lists.push   List.new(:name => 'Foo2!')
+      user.lists.concat List.new(:name => 'Foo3!')
+      user.lists.size.should == 3
+    end
+
+    it "should ignore adding duplicate ids" do
+      user = User.create(:name => 'John')
+      list = List.create(:name => 'Foo')
+      user.lists << list
+      user.lists << list
+      user.lists << list
+
+      list.reload.user_ids.should == [user.id]
+      user.lists.count.should == 1
+    end
+
+    it "should be able to replace the association" do
+      user = User.new(:name => 'John')
+      list = List.new(:name => 'Foo')
+      user.lists = [list]
+      user.save.should == true
+
+      user.reload
+      list.reload
+      list.user_ids.should == [user.id]
+      user.lists.size.should == 1
+      user.lists[0].name.should == 'Foo'
+    end
+
+    context "create" do
+      before do
+        @user = User.create(:name => 'John')
+        @list = @user.lists.create(:name => 'Foo!')
+      end
+
+      it "should add id to key" do
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should persist id addition to key in database" do
+        @list.reload
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should add doc to association" do
+        @user.lists.should include(@list)
+      end
+
+      it "should save doc" do
+        @list.should_not be_new
+      end
+
+      it "should reset cache" do
+        @user.lists.size.should == 1
+        @user.lists.create(:name => 'Moo!')
+        @user.lists.size.should == 2
+      end
+    end
+
+    context "create!" do
+      before do
+        @user = User.create(:name => 'John')
+        @list = @user.lists.create!(:name => 'Foo!')
+      end
+
+      it "should add id to key" do
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should persist id addition to key in database" do
+        @list.reload
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should add doc to association" do
+        @user.lists.should include(@list)
+      end
+
+      it "should save doc" do
+        @list.should_not be_new
+      end
+
+      it "should raise exception if invalid" do
+        lambda do
+          @user.lists.create!
+        end.should raise_error(MongoMapper::DocumentNotValid)
+      end
+
+      it "should reset cache" do
+        @user.lists.size.should == 1
+        @user.lists.create!(:name => 'Moo!')
+        @user.lists.size.should == 2
+      end
+    end
+
+    context "Finding scoped to association" do
+      before do
+        @user = User.create(:name => 'John')
+        @user2 = User.create(:name => 'Brandon')
+        @list1 = @user.lists.create!(:name => 'Foo 1', :position => 1)
+        @list2 = @user.lists.create!(:name => 'Foo 2', :position => 2)
+        @list3 = @user2.lists.create!(:name => 'Foo 3', :position => 1)
+      end
+
+      context "all" do
+        it "should work" do
+          @user.lists.all(:order => :position.asc).should == [@list1, @list2]
+        end
+
+        it "should work with conditions" do
+          @user.lists.all(:name => 'Foo 1').should == [@list1]
+        end
+      end
+
+      context "first" do
+        it "should work" do
+          @user.lists.first(:order => 'position').should == @list1
+        end
+
+        it "should work with conditions" do
+          @user.lists.first(:position => 2).should == @list2
+        end
+      end
+
+      context "last" do
+        it "should work" do
+          @user.lists.last(:order => 'position').should == @list2
+        end
+
+        it "should work with conditions" do
+          @user.lists.last(:position => 2, :order => 'position').should == @list2
+        end
+      end
+
+      context "with one id" do
+        it "should work for id in association" do
+          @user.lists.find(@list1.id).should == @list1
+        end
+
+        it "should work with string ids" do
+          @user.lists.find(@list1.id.to_s).should == @list1
+        end
+
+        it "should not work for id not in association" do
+          @user.lists.find(@list3.id).should be_nil
+        end
+
+        it "should raise error when using ! and not found" do
+          lambda do
+            @user.lists.find!(@list3.id)
+          end.should raise_error(MongoMapper::DocumentNotFound)
+        end
+      end
+
+      context "with multiple ids" do
+        it "should work for ids in association" do
+          @user.lists.find(@list1.id, @list2.id).should == [@list1, @list2]
+        end
+
+        it "should not work for ids not in association" do
+          @user.lists.find(@list1.id, @list2.id, @list3.id).should == [@list1, @list2]
+        end
+      end
+
+      context "with #paginate" do
+        before do
+          @lists = @user.lists.paginate(:per_page => 1, :page => 1, :order => 'position')
+        end
+
+        it "should return total pages" do
+          @lists.total_pages.should == 2
+        end
+
+        it "should return total entries" do
+          @lists.total_entries.should == 2
+        end
+
+        it "should return the subject" do
+          @lists.collect(&:name).should == ['Foo 1']
+        end
+      end
+
+      context "dynamic finders" do
+        it "should work with single key" do
+          @user.lists.find_by_name('Foo 1').should == @list1
+          @user.lists.find_by_name!('Foo 1').should == @list1
+          @user.lists.find_by_name('Foo 3').should be_nil
+        end
+
+        it "should work with multiple keys" do
+          @user.lists.find_by_name_and_position('Foo 1', 1).should == @list1
+          @user.lists.find_by_name_and_position!('Foo 1', 1).should == @list1
+          @user.lists.find_by_name_and_position('Foo 3', 1).should be_nil
+        end
+
+        it "should raise error when using ! and not found" do
+          lambda do
+            @user.lists.find_by_name!('Foo 3')
+          end.should raise_error(MongoMapper::DocumentNotFound)
+        end
+
+        context "find_or_create_by" do
+          it "should not create document if found" do
+            lambda {
+              list = @user.lists.find_or_create_by_name('Foo 1')
+              list.should == @list1
+            }.should_not change { List.count }
+          end
+
+          it "should create document if not found" do
+            lambda {
+              list = @user.lists.find_or_create_by_name('Home')
+              @user.lists.should include(list)
+            }.should change { List.count }
+          end
+        end
+      end
+    end
+
+    context "count" do
+      before do
+        @user = User.create(:name => 'John')
+        @user2 = User.create(:name => 'Brandon')
+        @list1 = @user.lists.create!(:name => 'Foo 1')
+        @list2 = @user.lists.create!(:name => 'Foo 2')
+        @list3 = @user2.lists.create!(:name => 'Foo 3')
+      end
+
+      it "should return number of ids" do
+        @user.lists.count.should == 2
+        @user2.lists.count.should == 1
+      end
+
+      it "should return correct count when given criteria" do
+        @user.lists.count(:name => 'Foo 1').should == 1
+        @user2.lists.count(:name => 'Foo 1').should == 0
+      end
+    end
+
+    context "Removing documents" do
+      before do
+        @user = User.create(:name => 'John')
+        @user2 = User.create(:name => 'Brandon')
+        @list1 = @user.lists.create!(:name => 'Foo 1', :position => 1)
+        @list2 = @user.lists.create!(:name => 'Foo 2', :position => 2)
+        @list3 = @user2.lists.create!(:name => 'Foo 3', :position => 1)
+      end
+
+      context "destroy_all" do
+        it "should work" do
+          @user.lists.count.should == 2
+          @user.lists.destroy_all
+          @user.lists.count.should == 0
+        end
+
+        it "should work with conditions" do
+          @user.lists.count.should == 2
+          @user.lists.destroy_all(:name => 'Foo 1')
+          @user.lists.count.should == 1
+        end
+      end
+
+      context "delete_all" do
+        it "should work" do
+          @user.lists.count.should == 2
+          @user.lists.delete_all
+          @user.lists.count.should == 0
+        end
+
+        it "should work with conditions" do
+          @user.lists.count.should == 2
+          @user.lists.delete_all(:name => 'Foo 1')
+          @user.lists.count.should == 1
+        end
+      end
+
+      it "should work with nullify" do
+        @user.lists.count.should == 2
+
+        lambda {
+          @user.lists.nullify
+        }.should_not change { List.count }
+
+        @user.lists.count.should == 0
+      end
+    end
+  end
+end