mongo_mapper 0.13.1 → 0.15.2

data/spec/functional/caching_spec.rb

@@ -23,11 +23,9 @@ describe "Caching" do
     end
 
     it "should work with suffix" do
-      @doc.cache_key(:foo).
-        should == 'Post/new/foo'
+      @doc.cache_key(:foo).should == 'Post/new/foo'
 
-      @doc.cache_key(:foo, :bar).
-        should == 'Post/new/foo/bar'
+      @doc.cache_key(:foo, :bar).should == 'Post/new/foo/bar'
     end
   end
 
@@ -35,7 +33,7 @@ describe "Caching" do
     before do
       @object_id = BSON::ObjectId.new
       @doc = @klass.new
-      @doc.stub(:persisted).and_return(true)
+      @doc.stub(:persisted?).and_return(true)
       @doc.stub(:id).and_return(@object_id)
     end
 
@@ -50,11 +48,9 @@ describe "Caching" do
       end
 
       it "should work with suffix" do
-        @doc.cache_key(:foo).
-          should == "Post/#{@object_id}-20100620081007/foo"
+        @doc.cache_key(:foo).should == "Post/#{@object_id}-20100620081007/foo"
 
-        @doc.cache_key(:foo, :bar).
-          should == "Post/#{@object_id}-20100620081007/foo/bar"
+        @doc.cache_key(:foo, :bar).should == "Post/#{@object_id}-20100620081007/foo/bar"
       end
     end
 
@@ -64,12 +60,9 @@ describe "Caching" do
       end
 
       it "should work with suffix" do
-        @doc.cache_key(:foo).
-          should == "Post/#{@object_id}/foo"
-
-        @doc.cache_key(:foo, :bar, :baz).
-          should == "Post/#{@object_id}/foo/bar/baz"
+        @doc.cache_key(:foo).should == "Post/#{@object_id}/foo"
+        @doc.cache_key(:foo, :bar, :baz).should == "Post/#{@object_id}/foo/bar/baz"
       end
     end
   end
-end
+end

data/spec/functional/callbacks_spec.rb

@@ -148,11 +148,11 @@ describe "Callbacks" do
       @root_class.define_callbacks :after_publish
       @root_class.after_save { |d| d.run_callbacks(:after_publish) }
 
-      expect {
+      lambda {
         child = @child_class.new(:name => 'Child')
         root  = @root_class.create(:name => 'Parent', :children => [child])
         child.history.should_not include(:after_publish)
-      }.to_not raise_error
+      }.should_not raise_error
     end
   end
 
@@ -240,4 +240,91 @@ describe "Callbacks" do
       doc.message.should == 'Ho!'
     end
   end
+
+  describe "after_find" do
+    before do
+      @found_objects = []
+      found_objects = @found_objects # use a local for closure
+
+      @doc_class = Doc("User") do
+        after_find :set_found_object
+
+        define_method :set_found_object do
+          found_objects << self
+        end
+      end
+    end
+
+    it "should run after finding an object with find!" do
+      @doc = @doc_class.create!
+
+      @doc_class.find!(@doc.id)
+      @found_objects.should == [@doc]
+    end
+
+    it "should not have run if nothing was queried" do
+      @found_objects.should == []
+    end
+
+    it "should run for multiple objects" do
+      @doc1 = @doc_class.create!
+      @doc2 = @doc_class.create!
+
+      @doc_class.all
+      @found_objects.should == [@doc1, @doc2]
+    end
+
+    it "should run after finding an object through the query proxy" do
+      @doc = @doc_class.create!
+      @doc_class.where(:_id => @doc.id).first
+      @found_objects.should == [@doc]
+    end
+
+    it "should still return the object" do
+      @doc = @doc_class.create!
+      @doc_class.where(:_id => @doc.id).first.should == @doc
+    end
+
+    it "should not bail if the method return false" do
+      @doc_class = Doc("User") do
+        after_find :set_found_object
+
+        define_method :set_found_object do
+          false
+        end
+      end
+
+      @doc = @doc_class.create!
+      @doc_class.where(:_id => @doc.id).first.should == @doc
+    end
+  end
+
+  describe "after_initialize" do
+    before do
+      @objects = []
+      objects = @objects
+
+      @doc_class = Doc("User") do
+        after_initialize :set_initialized_object
+
+        define_method :set_initialized_object do
+          objects << self
+        end
+      end
+    end
+
+    it "should be triggered for objects created with new" do
+      @objects.should == []
+      obj = @doc_class.new
+      @objects.should == [obj]
+    end
+
+    it "should be triggered for objects found in the db" do
+      @doc = @doc_class.create!
+      @objects.clear # don't re-assign as we want the operation to be in place
+
+      @doc_class.all
+      @objects.should == [@doc]
+    end
+  end
 end

data/spec/functional/counter_cache_spec.rb

@@ -15,6 +15,7 @@ module CounterCacheFixtureModels
 
     key :comments_count, Integer, :default => 0
     key :some_custom_comments_count, Integer, :default => 0
+    key :commentable_count, Integer, :default => 0
 
     has_many :comments,
              :class_name => "CounterCacheFixtureModels::Comment"
@@ -22,6 +23,20 @@ module CounterCacheFixtureModels
     belongs_to :user,
                :counter_cache => true,
                :class_name => "CounterCacheFixtureModels::User"
+
+    many :polymorphic_comments,
+         :as => :commentable,
+         :class_name => "CounterCacheFixtureModels::Comment"
+  end
+
+  class Article
+    include MongoMapper::Document
+
+    key :commentable_count, Integer, :default => 0
+
+    many :polymorphic_comments,
+         :as => :commentable,
+         :class_name => "CounterCacheFixtureModels::Comment"
   end
 
   class Comment
@@ -30,6 +45,10 @@ module CounterCacheFixtureModels
     belongs_to :post,
                :counter_cache => true,
                :class_name => "CounterCacheFixtureModels::Post"
+
+    belongs_to :commentable,
+               :polymorphic => true,
+               :counter_cache => :commentable_count
   end
 
   class CustomComment
@@ -143,4 +162,74 @@ describe MongoMapper::Plugins::CounterCache do
       end
     }.should raise_error(MongoMapper::Plugins::CounterCache::InvalidCounterCacheError, "Missing `key :invalid_field, Integer, :default => 0' on model CounterCacheFixtureModels::Post")
   end
+
+  describe "with polymorphic associations" do
+    before do
+      @article = CounterCacheFixtureModels::Article.new
+      @comment = CounterCacheFixtureModels::Comment.new
+      @comment.commentable = @article
+    end
+
+    it "should update the counter cache on save" do
+      lambda {
+        @comment.save!
+        @article.reload
+      }.should change(@article, :commentable_count).by(1)
+    end
+
+    it "should increment with a second object" do
+      @comment.save!
+
+      lambda {
+        second_comment = CounterCacheFixtureModels::Comment.new
+        second_comment.commentable = @article
+        second_comment.save!
+        @article.reload
+      }.should change(@article, :commentable_count).by(1)
+    end
+
+    it "should decrement the counter cache on destroy" do
+      @comment.save!
+
+      lambda {
+        @comment.destroy
+        @article.reload
+      }.should change(@article, :commentable_count).by(-1)
+    end
+
+    it "should increment with a different type of object" do
+      @comment.save!
+
+      lambda {
+        second_comment = CounterCacheFixtureModels::Comment.new
+        second_comment.commentable = @article
+        second_comment.save!
+
+        @article.reload
+      }.should change(@article, :commentable_count).by(1)
+    end
+
+    describe "without a counter cache field" do
+      before do
+        @comment = CounterCacheFixtureModels::Comment.new
+        @klass = Class.new do
+          include MongoMapper::Document
+
+          many :polymorphic_comments,
+               :as => :commentable,
+               :class_name => "CounterCacheFixtureModels::Comment"
+        end
+
+        @obj = @klass.new
+      end
+
+      it "should raise at save (runtime) if there is no counter cache field" do
+        @comment.commentable = @obj
+
+        lambda {
+          @comment.save!
+        }.should raise_error(MongoMapper::Plugins::CounterCache::InvalidCounterCacheError)
+      end
+    end
+  end
 end

data/spec/functional/dirty_spec.rb

@@ -9,40 +9,47 @@ describe "Dirty" do
   end
 
   context "marking changes" do
+    it "should have the changed? methods" do
+      obj = @document.new
+      obj.should respond_to(:changed?)
+      obj.should respond_to(:phrase_changed?)
+      obj.should respond_to(:paragraph_changed?)
+    end
+
     it "should not happen if there are none" do
       doc = @document.new
-      doc.phrase_changed?.should be_false
+      doc.phrase_changed?.should be_falsey
       doc.phrase_change.should be_nil
     end
 
     it "should happen when change happens" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.phrase_was.should be_nil
       doc.phrase_change.should == [nil, 'Golly Gee Willikers Batman']
     end
 
     it "should happen when initializing" do
       doc = @document.new(:phrase => 'Foo')
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
     end
 
     it "should clear changes on save" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.save
-      doc.phrase_changed?.should_not be_true
+      doc.phrase_changed?.should_not be_truthy
       doc.phrase_change.should be_nil
     end
 
     it "should clear changes on save!" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.save!
-      doc.phrase_changed?.should_not be_true
+      doc.phrase_changed?.should_not be_truthy
       doc.phrase_change.should be_nil
     end
 
@@ -51,33 +58,33 @@ describe "Dirty" do
       @document.any_instance.should_receive(:attribute_will_change!).never
       @document.any_instance.should_receive(:attribute_changed?).never
       doc = @document.find(doc.id)
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
 
     it "should not happen when reloading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc = @document.find(doc.id)
 
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.phrase = 'Fart'
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
       doc.reload
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
 
     it "should happen if changed after loading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc.reload
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.phrase = 'Bar'
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
     end
 
     it "should happen with aliased keys" do
       doc = @document.create(:paragraph => 'Wibbly')
       doc.paragraph = "Wobbly"
-      doc.changed?.should be_true
-      doc.paragraph_changed?.should be_true
+      doc.changed?.should be_truthy
+      doc.paragraph_changed?.should be_truthy
     end
   end
 
@@ -88,7 +95,7 @@ describe "Dirty" do
       [nil, ''].each do |value|
         doc = @document.new
         doc.age = value
-        doc.age_changed?.should be_false
+        doc.age_changed?.should be_falsey
         doc.age_change.should be_nil
       end
     end
@@ -101,7 +108,7 @@ describe "Dirty" do
       [nil, ''].each do |value|
         doc = @document.new
         doc.amount = value
-        doc.amount_changed?.should be_false
+        doc.amount_changed?.should be_falsey
         doc.amount_change.should be_nil
       end
     end
@@ -111,27 +118,27 @@ describe "Dirty" do
     it "should be true if key changed" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
     end
 
     it "should be false if no keys changed" do
-      @document.new.changed?.should be_false
+      @document.new.changed?.should be_falsey
     end
 
     it "should not raise when key name is 'value'" do
       @document.key :value, Integer
 
       doc = @document.new
-      doc.value_changed?.should be_false
+      doc.value_changed?.should be_falsey
     end
 
     it "should be false if the same ObjectId was assigned in String format" do
       @document.key :doc_id, ObjectId
 
       doc = @document.create!(:doc_id => BSON::ObjectId.new)
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.doc_id = doc.doc_id.to_s
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
   end
 
@@ -164,14 +171,14 @@ describe "Dirty" do
       doc = @document.create(:phrase => 'Foo')
 
       doc.phrase << 'bar'
-      doc.phrase_changed?.should be_false
+      doc.phrase_changed?.should be_falsey
 
       doc.phrase_will_change!
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.phrase_change.should == ['Foobar', 'Foobar']
 
       doc.phrase << '!'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.phrase_change.should == ['Foobar', 'Foobar!']
     end
   end
@@ -190,7 +197,7 @@ describe "Dirty" do
 
       milestone = milestone_class.create(:name => 'Launch')
       milestone.project = project_class.create(:name => 'Harmony')
-      milestone.changed?.should be_true
+      milestone.changed?.should be_truthy
       milestone.changed.should == %w(project_id)
     end
   end
@@ -204,11 +211,11 @@ describe "Dirty" do
       validated_doc = validated_class.new
       validated_doc.name = "I'm a changin"
       validated_doc.save
-      validated_doc.changed?.should be_true
+      validated_doc.changed?.should be_truthy
 
       validated_doc.required = 1
       validated_doc.save
-      validated_doc.changed?.should be_false
+      validated_doc.changed?.should be_falsey
     end
   end
 
@@ -220,20 +227,26 @@ describe "Dirty" do
       doc.a = "d"
       doc.a_change.should == ["b","d"]
     end
-    it "should reset changes when set back to the original value" do
-      doc = @document.create(:a=>"b")
-      doc.a = "c"
-      doc.a = "b"
-      doc.changed?.should be_false
-    end
+
+    # TODO: ? Is this consistent with how ActiveRecord now works with changes?
+    # it "should reset changes when set back to the original value" do
+    #   doc = @document.create(:a=>"b")
+    #   doc.a = "c"
+    #   doc.a = "b"
+    #   doc.changed?.should be_falsey
+    # end
   end
 
   context "reset_attribute!" do
     it "should reset the attribute back to the previous value" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
-      doc.reset_a!
-      doc.changed?.should be_false
+      if doc.respond_to?(:restore_a!)
+        doc.restore_a!
+      else
+        doc.reset_a!
+      end
+      doc.changed?.should be_falsey
       doc.a.should == "b"
     end
     it "should reset the attribute back to the original value after several changes" do
@@ -241,8 +254,12 @@ describe "Dirty" do
       doc.a = "c"
       doc.a = "d"
       doc.a = "e"
-      doc.reset_a!
-      doc.changed?.should be_false
+      if doc.respond_to?(:restore_a!)
+        doc.restore_a!
+      else
+        doc.reset_a!
+      end
+      doc.changed?.should be_falsey
       doc.a.should == "b"
     end
   end
@@ -263,6 +280,27 @@ describe "Dirty" do
     end
   end
 
+  context "Document having Array key with typecast option" do
+    before do
+      @author_id = BSON::ObjectId.new
+      @doc = Doc('Book') { key :author_ids, Array, typecast: "ObjectId" }
+      @doc.plugin MongoMapper::Plugins::Dirty
+      @book = @doc.create!(author_ids: [@author_id])
+    end
+
+    context "changed" do
+      it "should be empty if assigned the same array" do
+        @book.author_ids = [@author_id]
+        @book.changed.should be_empty
+      end
+
+      it "should be empty if assigned the same but before-typecasted array" do
+        @book.author_ids = [@author_id.to_s]
+        @book.changed.should be_empty
+      end
+    end
+  end
+
   context "Embedded documents" do
     before do
       @edoc = EDoc('Duck') { key :name, String }
@@ -275,21 +313,21 @@ describe "Dirty" do
 
     it "should track changes" do
       @duck.name = "hi"
-      @duck.changed?.should be_true
+      @duck.changed?.should be_truthy
     end
 
     it "should clear changes when saved" do
       @duck.name = "hi"
-      @duck.changed?.should be_true
+      @duck.changed?.should be_truthy
       @duck.save!
-      @duck.changed?.should_not be_true
+      @duck.changed?.should_not be_truthy
     end
 
     it "should clear changes when the parent is saved" do
       @duck.name = "hi"
-      @duck.changed?.should be_true
+      @duck.changed?.should be_truthy
       @doc.save!
-      @duck.changed?.should_not be_true
+      @duck.changed?.should_not be_truthy
     end
 
     context "with nested embedded documents" do
@@ -302,14 +340,14 @@ describe "Dirty" do
 
       it "should track changes" do
         @dong.name = "hi"
-        @dong.changed?.should be_true
+        @dong.changed?.should be_truthy
       end
 
       it "should clear changes when the root saves" do
         @dong.name = "hi"
-        @dong.changed?.should be_true
+        @dong.changed?.should be_truthy
         @doc.save!
-        @dong.changed?.should be_false
+        @dong.changed?.should be_falsey
       end
     end
   end