mongo_mapper 0.12.0 → 0.13.0.beta1

data/spec/functional/associations_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+require 'support/models'
+
+module AssociationsSpec
+  describe "Associations" do
+    it "should allow changing class names" do
+      class AwesomeUser
+        include MongoMapper::Document
+
+        many :posts, :class_name => 'AssociationsSpec::AwesomePost', :foreign_key => :creator_id
+      end
+      AwesomeUser.collection.remove
+
+      class AwesomeTag
+        include MongoMapper::EmbeddedDocument
+
+        key :name, String
+        key :post_id, ObjectId
+
+        belongs_to :post, :class_name => 'AssociationsSpec::AwesomeUser'
+      end
+
+      class AwesomePost
+        include MongoMapper::Document
+
+        key :creator_id, ObjectId
+
+        belongs_to :creator, :class_name => 'AssociationsSpec::AwesomeUser'
+        many :tags, :class_name => 'AssociationsSpec::AwesomeTag', :foreign_key => :post_id
+      end
+
+      AwesomeUser.collection.remove
+      AwesomePost.collection.remove
+
+      user = AwesomeUser.create
+      tag1 = AwesomeTag.new(:name => 'awesome')
+      tag2 = AwesomeTag.new(:name => 'grand')
+      post1 = AwesomePost.create(:creator => user, :tags => [tag1])
+      post2 = AwesomePost.create(:creator => user, :tags => [tag2])
+
+      user.reload
+      user.posts.should == [post1, post2]
+
+      post1 = post1.reload
+      post1.tags.should == [tag1]
+    end
+  end
+end

data/{test/functional/test_binary.rb → spec/functional/binary_spec.rb}

@@ -1,7 +1,7 @@
-require 'test_helper'
+require 'spec_helper'
 
-class BinaryTest < Test::Unit::TestCase
-  should "serialize and deserialize correctly" do
+describe "Binary" do
+  it "should serialize and deserialize correctly" do
     klass = Doc do
       key :contents, Binary
     end
@@ -14,14 +14,14 @@ class BinaryTest < Test::Unit::TestCase
   end
 
   context "Saving a document with a blank binary value" do
-    setup do
+    before do
       @document = Doc do
         key :file, Binary
       end
     end
 
-    should "not fail" do
-      assert_nothing_raised { @document.new(:file => nil).save }
+    it "not fail" do
+      expect { @document.new(:file => nil).save }.to_not raise_error
     end
   end
 end

data/spec/functional/caching_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe "Caching" do
+  before do
+    @klass = Class.new do
+      extend MongoMapper::Plugins
+      plugin MongoMapper::Plugins::Caching
+    end
+    @klass.stub(:name).and_return('Post')
+    @klass.any_instance.stub(:persisted?).and_return(true)
+    @klass.any_instance.stub(:[]).and_return(nil)
+    @klass.any_instance.stub(:[]=).and_return(nil)
+  end
+
+  context "new" do
+    before do
+      @doc = @klass.new
+      @doc.stub(:persisted?).and_return(false)
+    end
+
+    it "should be class/new" do
+      @doc.cache_key.should == 'Post/new'
+    end
+
+    it "should work with suffix" do
+      @doc.cache_key(:foo).
+        should == 'Post/new/foo'
+
+      @doc.cache_key(:foo, :bar).
+        should == 'Post/new/foo/bar'
+    end
+  end
+
+  context "not new" do
+    before do
+      @object_id = BSON::ObjectId.new
+      @doc = @klass.new
+      @doc.stub(:persisted).and_return(true)
+      @doc.stub(:id).and_return(@object_id)
+    end
+
+    context "with updated_at" do
+      before do
+        time = Time.utc(2010, 6, 20, 8, 10, 7)
+        @doc.stub(:[]).with(:updated_at).and_return(time)
+      end
+
+      it "should be class/id-timestamp" do
+        @doc.cache_key.should == "Post/#{@object_id}-20100620081007"
+      end
+
+      it "should work with suffix" do
+        @doc.cache_key(:foo).
+          should == "Post/#{@object_id}-20100620081007/foo"
+
+        @doc.cache_key(:foo, :bar).
+          should == "Post/#{@object_id}-20100620081007/foo/bar"
+      end
+    end
+
+    context "without updated_at" do
+      it "should be class/id" do
+        @doc.cache_key.should == "Post/#{@object_id}"
+      end
+
+      it "should work with suffix" do
+        @doc.cache_key(:foo).
+          should == "Post/#{@object_id}/foo"
+
+        @doc.cache_key(:foo, :bar, :baz).
+          should == "Post/#{@object_id}/foo/bar/baz"
+      end
+    end
+  end
+end

data/{test/functional/test_callbacks.rb → spec/functional/callbacks_spec.rb}

@@ -1,4 +1,4 @@
-require 'test_helper'
+require 'spec_helper'
 
 module CallbacksSupport
   def self.included base
@@ -26,7 +26,7 @@ module CallbacksSupport
   end
 end
 
-class CallbacksTest < Test::Unit::TestCase
+describe "Callbacks" do
   CreateCallbackOrder = [
     :before_validation,
     :after_validation,
@@ -46,16 +46,16 @@ class CallbacksTest < Test::Unit::TestCase
   ]
 
   context "Defining and running callbacks on documents" do
-    setup do
+    before do
       @document = Doc { include CallbacksSupport }
     end
 
-    should "get the order right for creating documents" do
+    it "should get the order right for creating documents" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.history.should == CreateCallbackOrder
     end
 
-    should "get the order right for updating documents" do
+    it "should get the order right for updating documents" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.clear_history
       doc.name = 'John'
@@ -63,20 +63,20 @@ class CallbacksTest < Test::Unit::TestCase
       doc.history.should == UpdateCallbackOrder
     end
 
-    should "work for before and after validation" do
+    it "should work for before and after validation" do
       doc = @document.new(:name => 'John Nunemaker')
       doc.valid?
       doc.history.should include(:before_validation)
       doc.history.should include(:after_validation)
     end
 
-    should "work for before and after create" do
+    it "should work for before and after create" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.history.should include(:before_create)
       doc.history.should include(:after_create)
     end
 
-    should "work for before and after update" do
+    it "should work for before and after update" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.name = 'John Doe'
       doc.save
@@ -84,7 +84,7 @@ class CallbacksTest < Test::Unit::TestCase
       doc.history.should include(:after_update)
     end
 
-    should "work for before and after save" do
+    it "should work for before and after save" do
       doc = @document.new
       doc.name = 'John Doe'
       doc.save
@@ -92,7 +92,7 @@ class CallbacksTest < Test::Unit::TestCase
       doc.history.should include(:after_save)
     end
 
-    should "work for before and after destroy" do
+    it "should work for before and after destroy" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.destroy
       doc.history.should include(:before_destroy)
@@ -101,16 +101,16 @@ class CallbacksTest < Test::Unit::TestCase
   end
 
   context "Defining and running callbacks on many embedded documents" do
-    setup do
+    before do
       @root_class        = Doc  { include CallbacksSupport }
       @child_class       = EDoc { include CallbacksSupport }
       @grand_child_class = EDoc { include CallbacksSupport }
 
-      @root_class.many :children, :class => @child_class
+      @root_class.many  :children, :class => @child_class
       @child_class.many :children, :class => @grand_child_class
     end
 
-    should "get the order right based on root document creation" do
+    it "should get the order right based on root document creation" do
       grand = @grand_child_class.new(:name => 'Grand Child')
       child = @child_class.new(:name => 'Child', :children => [grand])
       root  = @root_class.create(:name => 'Parent', :children => [child])
@@ -119,7 +119,7 @@ class CallbacksTest < Test::Unit::TestCase
       root.children.first.children.first.history.should == CreateCallbackOrder
     end
 
-    should "get the order right based on root document updating" do
+    it "should get the order right based on root document updating" do
       grand = @grand_child_class.new(:name => 'Grand Child')
       child = @child_class.new(:name => 'Child', :children => [grand])
       root  = @root_class.create(:name => 'Parent', :children => [child])
@@ -130,7 +130,7 @@ class CallbacksTest < Test::Unit::TestCase
       root.children.first.children.first.history.should == UpdateCallbackOrder
     end
 
-    should "work for before and after destroy" do
+    it "should work for before and after destroy" do
       grand = @grand_child_class.new(:name => 'Grand Child')
       child = @child_class.new(:name => 'Child', :children => [grand])
       root  = @root_class.create(:name => 'Parent', :children => [child])
@@ -144,42 +144,100 @@ class CallbacksTest < Test::Unit::TestCase
       grand.history.should include(:after_destroy)
     end
 
-    should "not attempt to run callback defined on root that is not defined on embedded association" do
+    it "should not attempt to run callback defined on root that is not defined on embedded association" do
       @root_class.define_callbacks :after_publish
       @root_class.after_save { |d| d.run_callbacks(:after_publish) }
 
-      assert_nothing_raised do
+      expect {
         child = @child_class.new(:name => 'Child')
         root  = @root_class.create(:name => 'Parent', :children => [child])
         child.history.should_not include(:after_publish)
-      end
+      }.to_not raise_error
+    end
+  end
+
+  context "By default" do
+    it "should not run callbacks when no callbacks were explicitly defined" do
+      EDoc { key :name, String }.embedded_callbacks_off?.should == true
+    end
+
+    it "should run callbacks when a callback was explicitly defined" do
+      EDoc {
+        key :name, String
+        before_save :no_op
+        def noop; end
+      }.embedded_callbacks_on?.should == true
+    end
+  end
+
+  context "Turning embedded callbacks off" do
+    before do
+      @root_class        = Doc  { include CallbacksSupport; embedded_callbacks_off }
+      @child_class       = EDoc { include CallbacksSupport; embedded_callbacks_off }
+      @grand_child_class = EDoc { include CallbacksSupport; embedded_callbacks_off }
+
+      @root_class.many  :children, :class => @child_class
+      @child_class.many :children, :class => @grand_child_class
+    end
+
+    it "should not run create callbacks" do
+      grand = @grand_child_class.new(:name => 'Grand Child')
+      child = @child_class.new(:name => 'Child', :children => [grand])
+      root  = @root_class.create(:name => 'Parent', :children => [child])
+
+      root.children.first.history.should == []
+      root.children.first.children.first.history.should == []
+    end
+
+    it "should not run update callbacks" do
+      grand = @grand_child_class.new(:name => 'Grand Child')
+      child = @child_class.new(:name => 'Child', :children => [grand])
+      root  = @root_class.create(:name => 'Parent', :children => [child])
+      root.clear_history
+      root.update_attributes(:name => 'Updated Parent')
+
+      root.children.first.history.should == []
+      root.children.first.children.first.history.should == []
+    end
+
+    it "should not run destroy callbacks" do
+      grand = @grand_child_class.new(:name => 'Grand Child')
+      child = @child_class.new(:name => 'Child', :children => [grand])
+      root  = @root_class.create(:name => 'Parent', :children => [child])
+      root.destroy
+      child = root.children.first
+      child.history.should == []
+
+      grand = root.children.first.children.first
+      grand.history.should == []
     end
   end
 
   context "Running validation callbacks with conditional execution" do
-    setup do
-      @document = Doc do
+    let(:document) do
+      Doc do
         include CallbacksSupport
         key :message, String
 
-        before_validation :set_message, :on => 'create'
+        before_validation :set_message, :on => :create
+
         def set_message
           self['message'] = 'Hi!'
         end
       end
     end
 
-    should 'run callback on create' do
-      doc = @document.create
+    it 'should run callback on create' do
+      doc = document.create
       doc.history.should include(:before_validation)
       doc.message.should == 'Hi!'
     end
 
-    should 'skip callback on update' do
-      doc = @document.create
+    it 'should skip callback on update' do
+      doc = document.create
       doc.message = 'Ho!'
       doc.save
       doc.message.should == 'Ho!'
     end
   end
-end
+end

data/{test/functional/test_dirty.rb → spec/functional/dirty_spec.rb}

@@ -1,18 +1,21 @@
-require 'test_helper'
-
-class DirtyTest < Test::Unit::TestCase
-  def setup
-    @document = Doc { key :phrase, String }
+require 'spec_helper'
+
+describe "Dirty" do
+  before do
+    @document = Doc {
+      key :phrase, String
+      key :paragraph, String, :alias => :para
+    }
   end
 
   context "marking changes" do
-    should "not happen if there are none" do
+    it "should not happen if there are none" do
       doc = @document.new
       doc.phrase_changed?.should be_false
       doc.phrase_change.should be_nil
     end
 
-    should "happen when change happens" do
+    it "should happen when change happens" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
       doc.phrase_changed?.should be_true
@@ -20,12 +23,12 @@ class DirtyTest < Test::Unit::TestCase
       doc.phrase_change.should == [nil, 'Golly Gee Willikers Batman']
     end
 
-    should "happen when initializing" do
+    it "should happen when initializing" do
       doc = @document.new(:phrase => 'Foo')
       doc.changed?.should be_true
     end
 
-    should "clear changes on save" do
+    it "should clear changes on save" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
       doc.phrase_changed?.should be_true
@@ -34,7 +37,7 @@ class DirtyTest < Test::Unit::TestCase
       doc.phrase_change.should be_nil
     end
 
-    should "clear changes on save!" do
+    it "should clear changes on save!" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
       doc.phrase_changed?.should be_true
@@ -43,7 +46,15 @@ class DirtyTest < Test::Unit::TestCase
       doc.phrase_change.should be_nil
     end
 
-    should "not happen when loading from database" do
+    it "should not happen when loading from database" do
+      doc = @document.create(:phrase => 'Foo')
+      @document.any_instance.should_receive(:attribute_will_change!).never
+      @document.any_instance.should_receive(:attribute_changed?).never
+      doc = @document.find(doc.id)
+      doc.changed?.should be_false
+    end
+
+    it "should not happen when reloading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc = @document.find(doc.id)
 
@@ -54,17 +65,24 @@ class DirtyTest < Test::Unit::TestCase
       doc.changed?.should be_false
     end
 
-    should "happen if changed after loading from database" do
+    it "should happen if changed after loading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc.reload
       doc.changed?.should be_false
       doc.phrase = 'Bar'
       doc.changed?.should be_true
     end
+
+    it "should happen with aliased keys" do
+      doc = @document.create(:paragraph => 'Wibbly')
+      doc.paragraph = "Wobbly"
+      doc.changed?.should be_true
+      doc.paragraph_changed?.should be_true
+    end
   end
 
   context "blank new value and type integer" do
-    should "not mark changes" do
+    it "should not mark changes" do
       @document.key :age, Integer
 
       [nil, ''].each do |value|
@@ -77,7 +95,7 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "blank new value and type float" do
-    should "not mark changes" do
+    it "should not mark changes" do
       @document.key :amount, Float
 
       [nil, ''].each do |value|
@@ -90,24 +108,24 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "changed?" do
-    should "be true if key changed" do
+    it "should be true if key changed" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
       doc.changed?.should be_true
     end
 
-    should "be false if no keys changed" do
+    it "should be false if no keys changed" do
       @document.new.changed?.should be_false
     end
 
-    should "not raise when key name is 'value'" do
+    it "should not raise when key name is 'value'" do
       @document.key :value, Integer
 
       doc = @document.new
       doc.value_changed?.should be_false
     end
 
-    should "be false if the same ObjectId was assigned in String format" do
+    it "should be false if the same ObjectId was assigned in String format" do
       @document.key :doc_id, ObjectId
 
       doc = @document.create!(:doc_id => BSON::ObjectId.new)
@@ -118,11 +136,11 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "changes" do
-    should "be empty hash if no changes" do
+    it "should be empty hash if no changes" do
       @document.new.changes.should == {}
     end
 
-    should "be hash of keys with values of changes if there are changes" do
+    it "should be hash of keys with values of changes if there are changes" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
       doc.changes['phrase'].should == [nil, 'A penny saved is a penny earned.']
@@ -130,11 +148,11 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "changed" do
-    should "be empty array if no changes" do
+    it "should be empty array if no changes" do
       @document.new.changed.should == []
     end
 
-    should "be array of keys that have changed if there are changes" do
+    it "should be array of keys that have changed if there are changes" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
       doc.changed.should == ['phrase']
@@ -142,7 +160,7 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "will_change!" do
-    should "mark changes" do
+    it "should mark changes" do
       doc = @document.create(:phrase => 'Foo')
 
       doc.phrase << 'bar'
@@ -159,7 +177,7 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "changing a foreign key through association" do
-    should "mark changes" do
+    it "should mark changes" do
       project_class = Doc do
         key :name, String
       end
@@ -178,7 +196,7 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "save with an invalid document" do
-    should "not clear changes" do
+    it "should not clear changes" do
       validated_class = Doc do
         key :name, String
         key :required, String, :required=>true
@@ -195,14 +213,14 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "changing an already changed attribute" do
-    should "preserve the original value" do
+    it "should preserve the original value" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       doc.a_change.should == ["b","c"]
       doc.a = "d"
       doc.a_change.should == ["b","d"]
     end
-    should "reset changes when set back to the original value" do
+    it "should reset changes when set back to the original value" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       doc.a = "b"
@@ -211,14 +229,14 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "reset_attribute!" do
-    should "reset the attribute back to the previous value" do
+    it "should reset the attribute back to the previous value" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       doc.reset_a!
       doc.changed?.should be_false
       doc.a.should == "b"
     end
-    should "reset the attribute back to the original value after several changes" do
+    it "should reset the attribute back to the original value after several changes" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       doc.a = "d"
@@ -230,22 +248,23 @@ class DirtyTest < Test::Unit::TestCase
   end
 
   context "previous_changes" do
-    should "reflect previously committed change" do
+    it "should reflect previously committed change" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       changes = doc.changes
       doc.save!
       doc.previous_changes.should == changes
+      doc.previous_changes["a"].should == ["b", "c"]
     end
 
-    should "not include attributes loaded from db" do
+    it "should not include attributes loaded from db" do
       doc = @document.create(:a => "b")
       @document.find(doc.id).previous_changes.should be_blank
     end
   end
 
   context "Embedded documents" do
-    setup do
+    before do
       @edoc = EDoc('Duck') { key :name, String }
       @edoc.plugin MongoMapper::Plugins::Dirty
       @document = Doc('Long') { key :name, String }
@@ -254,19 +273,19 @@ class DirtyTest < Test::Unit::TestCase
       @duck = @doc.ducks.build
     end
 
-    should "track changes" do
+    it "should track changes" do
       @duck.name = "hi"
       @duck.changed?.should be_true
     end
 
-    should "clear changes when saved" do
+    it "should clear changes when saved" do
       @duck.name = "hi"
       @duck.changed?.should be_true
       @duck.save!
       @duck.changed?.should_not be_true
     end
 
-    should "clear changes when the parent is saved" do
+    it "should clear changes when the parent is saved" do
       @duck.name = "hi"
       @duck.changed?.should be_true
       @doc.save!
@@ -274,28 +293,24 @@ class DirtyTest < Test::Unit::TestCase
     end
 
     context "with nested embedded documents" do
-      setup do
+      before do
         @inner_edoc = EDoc('Dong') {key :name, String}
         @inner_edoc.plugin MongoMapper::Plugins::Dirty
         @edoc.many :dongs, :class=>@inner_edoc
         @dong = @duck.dongs.build
       end
 
-      should "track changes" do
+      it "should track changes" do
         @dong.name = "hi"
         @dong.changed?.should be_true
       end
 
-      should "clear changes when the root saves" do
+      it "should clear changes when the root saves" do
         @dong.name = "hi"
         @dong.changed?.should be_true
         @doc.save!
         @dong.changed?.should be_false
       end
-
     end
-
   end
-
-
 end