mongo_mapper-unstable 2010.3.8 → 2010.06.23

data/test/functional/test_callbacks.rb

@@ -1,60 +1,68 @@
 require 'test_helper'
 
+module CallbacksSupport
+  def self.included base
+    base.key :name, String
+
+    [ :before_validation_on_create, :before_validation_on_update,
+      :before_validation, :after_validation,
+      :before_create,     :after_create,
+      :before_update,     :after_update,
+      :before_save,       :after_save,
+      :before_destroy,    :after_destroy].each do |callback|
+      callback_method = "#{callback}_callback"
+      base.send(callback, callback_method)
+      define_method(callback_method) do
+        history << callback.to_sym
+      end
+    end
+  end
+
+  def history
+    @history ||= []
+  end
+
+  def clear_history
+    embedded_associations.each { |a| self.send(a.name).each(&:clear_history) }
+    @history = nil
+  end
+end
+
 class CallbacksTest < Test::Unit::TestCase
-  context "Defining and running callbacks" do
+  CreateCallbackOrder = [:before_validation, :before_validation_on_create, :after_validation, :before_save, :before_create, :after_create, :after_save]
+  UpdateCallbackOrder = [:before_validation, :before_validation_on_update, :after_validation, :before_save, :before_update, :after_update, :after_save]
+
+  context "Defining and running callbacks on documents" do
     setup do
-      @document = Doc do
-        key :name, String
-        
-        [ :before_validation_on_create, :before_validation_on_update,
-          :before_validation, :after_validation,
-          :before_create,     :after_create, 
-          :before_update,     :after_update,
-          :before_save,       :after_save,
-          :before_destroy,    :after_destroy].each do |callback|
-          callback_method = "#{callback}_callback"
-          send(callback, callback_method)
-          define_method(callback_method) do
-            history << callback.to_sym
-          end
-        end
-        
-        def history
-          @history ||= []
-        end
-        
-        def clear_history
-          @history = nil
-        end
-      end
+      @document = Doc { include CallbacksSupport }
     end
-    
+
     should "get the order right for creating documents" do
       doc = @document.create(:name => 'John Nunemaker')
-      doc.history.should == [:before_validation, :before_validation_on_create, :after_validation, :before_save, :before_create, :after_create, :after_save]
+      doc.history.should == CreateCallbackOrder
     end
-    
+
     should "get the order right for updating documents" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.clear_history
       doc.name = 'John'
       doc.save
-      doc.history.should == [:before_validation, :before_validation_on_update, :after_validation, :before_save, :before_update, :after_update, :after_save]
+      doc.history.should == UpdateCallbackOrder
     end
-    
+
     should "work for before and after validation" do
       doc = @document.new(:name => 'John Nunemaker')
       doc.valid?
       doc.history.should include(:before_validation)
       doc.history.should include(:after_validation)
     end
-    
+
     should "work for before and after create" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.history.should include(:before_create)
       doc.history.should include(:after_create)
     end
-    
+
     should "work for before and after update" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.name = 'John Doe'
@@ -62,7 +70,7 @@ class CallbacksTest < Test::Unit::TestCase
       doc.history.should include(:before_update)
       doc.history.should include(:after_update)
     end
-    
+
     should "work for before and after save" do
       doc = @document.new
       doc.name = 'John Doe'
@@ -70,7 +78,7 @@ class CallbacksTest < Test::Unit::TestCase
       doc.history.should include(:before_save)
       doc.history.should include(:after_save)
     end
-    
+
     should "work for before and after destroy" do
       doc = @document.create(:name => 'John Nunemaker')
       doc.destroy
@@ -78,4 +86,66 @@ class CallbacksTest < Test::Unit::TestCase
       doc.history.should include(:after_destroy)
     end
   end
+
+  context "Defining and running callbacks on many embedded documents" do
+    setup do
+      @root_class        = Doc  { include CallbacksSupport }
+      @child_class       = EDoc { include CallbacksSupport }
+      @grand_child_class = EDoc { include CallbacksSupport }
+
+      @root_class.many :children, :class => @child_class
+      @child_class.many :children, :class => @grand_child_class
+    end
+
+    should "get the order right based on root document creation" do
+      grand = @grand_child_class.new(:name => 'Grand Child')
+      child = @child_class.new(:name => 'Child', :children => [grand])
+      root  = @root_class.create(:name => 'Parent', :children => [child])
+
+      child = root.children.first
+      child.history.should == CreateCallbackOrder
+
+      grand = root.children.first.children.first
+      grand.history.should == CreateCallbackOrder
+    end
+
+    should "get the order right based on root document updating" do
+      grand = @grand_child_class.new(:name => 'Grand Child')
+      child = @child_class.new(:name => 'Child', :children => [grand])
+      root  = @root_class.create(:name => 'Parent', :children => [child])
+      root.clear_history
+      root.update_attributes(:name => 'Updated Parent')
+
+      child = root.children.first
+      child.history.should == UpdateCallbackOrder
+
+      grand = root.children.first.children.first
+      grand.history.should == UpdateCallbackOrder
+    end
+
+    should "work for before and after destroy" do
+      grand = @grand_child_class.new(:name => 'Grand Child')
+      child = @child_class.new(:name => 'Child', :children => [grand])
+      root  = @root_class.create(:name => 'Parent', :children => [child])
+      root.destroy
+      child = root.children.first
+      child.history.should include(:before_destroy)
+      child.history.should include(:after_destroy)
+
+      grand = root.children.first.children.first
+      grand.history.should include(:before_destroy)
+      grand.history.should include(:after_destroy)
+    end
+
+    should "not attempt to run callback defined on root that is not defined on embedded association" do
+      @root_class.define_callbacks :after_publish
+      @root_class.after_save { |d| d.run_callbacks(:after_publish) }
+
+      assert_nothing_raised do
+        child = @child_class.new(:name => 'Child')
+        root  = @root_class.create(:name => 'Parent', :children => [child])
+        child.history.should_not include(:after_publish)
+      end
+    end
+  end
 end

data/test/functional/test_dirty.rb

@@ -46,7 +46,7 @@ class DirtyTest < Test::Unit::TestCase
     should "not happen when loading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc = @document.find(doc.id)
-      
+
       doc.changed?.should be_false
       doc.phrase = 'Fart'
       doc.changed?.should be_true
@@ -75,7 +75,7 @@ class DirtyTest < Test::Unit::TestCase
       end
     end
   end
-  
+
   context "blank new value and type float" do
     should "not mark changes" do
       @document.key :amount, Float
@@ -87,73 +87,73 @@ class DirtyTest < Test::Unit::TestCase
         doc.amount_change.should be_nil
       end
     end
-  end  
-  
+  end
+
   context "changed?" do
     should "be true if key changed" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
       doc.changed?.should be_true
     end
-    
+
     should "be false if no keys changed" do
       @document.new.changed?.should be_false
     end
   end
-  
+
   context "changes" do
     should "be empty hash if no changes" do
       @document.new.changes.should == {}
     end
-    
+
     should "be hash of keys with values of changes if there are changes" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
       doc.changes['phrase'].should == [nil, 'A penny saved is a penny earned.']
     end
   end
-  
+
   context "changed" do
     should "be empty array if no changes" do
       @document.new.changed.should == []
     end
-    
+
     should "be array of keys that have changed if there are changes" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
       doc.changed.should == ['phrase']
     end
   end
-  
+
   context "will_change!" do
     should "mark changes" do
       doc = @document.create(:phrase => 'Foo')
-      
+
       doc.phrase << 'bar'
       doc.phrase_changed?.should be_false
-      
+
       doc.phrase_will_change!
       doc.phrase_changed?.should be_true
       doc.phrase_change.should == ['Foobar', 'Foobar']
-      
+
       doc.phrase << '!'
       doc.phrase_changed?.should be_true
       doc.phrase_change.should == ['Foobar', 'Foobar!']
     end
   end
-  
+
   context "changing a foreign key through association" do
     should "mark changes" do
       project_class = Doc do
         key :name, String
       end
-      
+
       milestone_class = Doc do
         key :project_id, ObjectId
         key :name, String
       end
       milestone_class.belongs_to :project, :class => project_class
-      
+
       milestone = milestone_class.create(:name => 'Launch')
       milestone.project = project_class.create(:name => 'Harmony')
       milestone.changed?.should be_true