mongo 2.8.0 → 2.9.0.rc0

data/spec/integration/retryable_writes_spec.rb

@@ -25,9 +25,9 @@ describe 'Retryable writes integration tests' do
 
   let(:primary_connection) do
     client.database.command(ping: 1)
-    expect(primary_server.pool.send(:queue).pool_size).to eq(1)
-    expect(primary_server.pool.send(:queue).queue_size).to eq(1)
-    primary_server.pool.send(:queue).queue.first
+    expect(primary_server.pool.size).to eq(1)
+    expect(primary_server.pool.available_count).to eq(1)
+    primary_server.pool.instance_variable_get('@available_connections').last
   end
 
   shared_examples_for 'an operation that is retried' do
@@ -284,7 +284,7 @@ describe 'Retryable writes integration tests' do
     end
 
     let!(:collection) do
-      client[TEST_COLL, write: SpecConfig.instance.write_concern]
+      client[TEST_COLL]
     end
 
     before do
@@ -341,7 +341,7 @@ describe 'Retryable writes integration tests' do
       context 'when the collection has write concern acknowledged' do
 
         let!(:collection) do
-          client[TEST_COLL, write: SpecConfig.instance.write_concern]
+          client[TEST_COLL, write: {w: :majority}]
         end
 
         it_behaves_like 'operation that is retried when server supports retryable writes'
@@ -355,15 +355,6 @@ describe 'Retryable writes integration tests' do
 
         it_behaves_like 'an operation that is not retried'
       end
-
-      context 'when the collection has write concern not set' do
-
-        let!(:collection) do
-          client[TEST_COLL]
-        end
-
-        it_behaves_like 'operation that is retried when server supports retryable writes'
-      end
     end
 
     context 'when the client has retry_writes set to false' do
@@ -375,42 +366,7 @@ describe 'Retryable writes integration tests' do
       context 'when the collection has write concern acknowledged' do
 
         let!(:collection) do
-          client[TEST_COLL, write: SpecConfig.instance.write_concern]
-        end
-
-        it_behaves_like 'an operation that is not retried'
-      end
-
-      context 'when the collection has write concern unacknowledged' do
-
-        let!(:collection) do
-          client[TEST_COLL, write: { w: 0 }]
-        end
-
-        it_behaves_like 'an operation that is not retried'
-      end
-
-      context 'when the collection has write concern not set' do
-
-        let!(:collection) do
-          client[TEST_COLL]
-        end
-
-        it_behaves_like 'an operation that is not retried'
-      end
-    end
-
-    context 'when the client has retry_writes not set' do
-      require_no_retry_writes
-
-      let!(:client) do
-        authorized_client
-      end
-
-      context 'when the collection has write concern acknowledged' do
-
-        let!(:collection) do
-          client[TEST_COLL, write: SpecConfig.instance.write_concern]
+          client[TEST_COLL, write: {w: :majority}]
         end
 
         it_behaves_like 'an operation that is not retried'

data/spec/integration/sdam_error_handling_spec.rb

@@ -6,7 +6,7 @@ describe 'SDAM error handling' do
   end
 
   describe 'when there is an error during an operation' do
-    let(:client) { authorized_client }
+    let(:client) { authorized_client_without_any_retries }
 
     before do
       wait_for_all_servers(client.cluster)
@@ -58,6 +58,47 @@ describe 'SDAM error handling' do
       end
     end
 
+    shared_examples_for 'clears connection pool' do
+      it 'clears connection pool' do
+        generation = server.pool.generation
+        operation
+        new_generation = server.pool.generation
+        expect(new_generation).to eq(generation + 1)
+      end
+    end
+
+    shared_examples_for 'does not clear connection pool' do
+      it 'does not clear connection pool' do
+        generation = server.pool.generation
+        operation
+        new_generation = server.pool.generation
+        expect(new_generation).to eq(generation)
+      end
+    end
+
+    shared_examples_for 'not master or node recovering' do
+      it_behaves_like 'marks server unknown'
+      it_behaves_like 'requests server scan'
+
+      context 'server 4.2 or higher' do
+        min_server_fcv '4.2'
+
+        it_behaves_like 'does not clear connection pool'
+      end
+
+      context 'server 4.0 or lower' do
+        max_server_version '4.0'
+
+        it_behaves_like 'clears connection pool'
+      end
+    end
+
+    shared_examples_for 'node shutting down' do
+      it_behaves_like 'marks server unknown'
+      it_behaves_like 'requests server scan'
+      it_behaves_like 'clears connection pool'
+    end
+
     context 'not master error' do
       let(:exception_message) do
         /not master/
@@ -67,21 +108,31 @@ describe 'SDAM error handling' do
         make_not_master_reply
       end
 
-      it_behaves_like 'marks server unknown'
-      it_behaves_like 'requests server scan'
+      it_behaves_like 'not master or node recovering'
     end
 
-    context 'node is recovering error' do
+    context 'node recovering error' do
       let(:exception_message) do
-        /shutdown in progress/
+        /DueToStepDown/
       end
 
       let(:reply) do
         make_node_recovering_reply
       end
 
-      it_behaves_like 'marks server unknown'
-      it_behaves_like 'requests server scan'
+      it_behaves_like 'not master or node recovering'
+    end
+
+    context 'node shutting down error' do
+      let(:exception_message) do
+        /shutdown in progress/
+      end
+
+      let(:reply) do
+        make_node_shutting_down_reply
+      end
+
+      it_behaves_like 'node shutting down'
     end
 
     context 'network error' do
@@ -100,6 +151,7 @@ describe 'SDAM error handling' do
 
         it_behaves_like 'marks server unknown'
         it_behaves_like 'does not request server scan'
+        it_behaves_like 'clears connection pool'
       end
 
       context 'network timeout error' do
@@ -109,6 +161,7 @@ describe 'SDAM error handling' do
 
         it_behaves_like 'does not mark server unknown'
         it_behaves_like 'does not request server scan'
+        it_behaves_like 'does not clear connection pool'
       end
     end
   end

data/spec/integration/ssl_uri_options_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe 'SSL connections with URI options' do
+  # SpecConfig currently creates clients exclusively through non-URI options. Because we don't
+  # currently have a way to create what the URI would look like for a given client, it's simpler
+  # just to test the that TLS works when configured from a URI on a standalone server without auth
+  # required, since that allows us to build the URI more easily.
+  require_no_auth
+  require_topology :single
+  require_ssl
+
+  let(:hosts) do
+    SpecConfig.instance.addresses.join(',')
+  end
+
+  let(:uri) do
+    "mongodb://#{hosts}/?tls=true&tlsInsecure=true&tlsCertificateKeyFile=#{SpecConfig.instance.client_cert_key_pem}"
+  end
+
+  it 'successfully connects and runs an operation' do
+    client = Mongo::Client.new(uri)
+    expect { client[:foo].count_documents({}) }.not_to raise_error
+  end
+end

data/spec/integration/step_down_spec.rb

@@ -0,0 +1,197 @@
+require 'spec_helper'
+
+describe 'Step down behavior' do
+  require_topology :replica_set
+
+=begin Uncommenting this will reduce the runtime of the test, but the spec currently does not allow us to do it
+  before(:all) do
+    # These before/after blocks are run even if the tests themselves are
+    # skipped due to server version not being appropriate
+    if ClusterConfig.instance.fcv_ish >= '4.2' && ClusterConfig.instance.topology == :replica_set
+      ClusterTools.instance.set_election_timeout(1)
+      ClusterTools.instance.set_election_handoff(false)
+    end
+  end
+
+  after(:all) do
+    if ClusterConfig.instance.fcv_ish >= '4.2' && ClusterConfig.instance.topology == :replica_set
+      ClusterTools.instance.set_election_timeout(10)
+      ClusterTools.instance.set_election_handoff(true)
+      ClusterTools.instance.reset_priorities
+    end
+  end
+=end
+
+  let(:event_subscriber) { EventSubscriber.new }
+
+  let(:test_client) do
+    authorized_client_without_any_retries.with(server_selection_timeout: 20).tap do |client|
+      client.subscribe(Mongo::Monitoring::CONNECTION_POOL, event_subscriber)
+    end
+  end
+
+  let(:collection) { test_client['step-down'].with(write: write_concern) }
+
+  let(:admin_support_client) do
+    ClientRegistry.instance.global_client('root_authorized').use('admin')
+  end
+
+  describe 'getMore iteration' do
+    min_server_fcv '4.2'
+
+    let(:subscribed_client) do
+      test_client.tap do |client|
+        client.subscribe(Mongo::Monitoring::COMMAND, EventSubscriber)
+        client.subscribe(Mongo::Monitoring::CONNECTION_POOL, EventSubscriber)
+      end
+    end
+
+    let(:collection) { subscribed_client['step-down'] }
+
+    before do
+      collection.insert_many([{test: 1}] * 100)
+    end
+
+    let(:view) { collection.find({test: 1}, batch_size: 10) }
+    let(:enum) { view.to_enum }
+
+    it 'continues through step down' do
+
+      subscribed_client.cluster.next_primary.pool.clear
+      event_subscriber.clear_events!
+
+      # get the first item
+      item = enum.next
+      expect(item['test']).to eq(1)
+
+      connection_created_events = EventSubscriber.published_events.select do |event|
+        event.is_a?(Mongo::Monitoring::Event::Cmap::ConnectionCreated)
+      end
+      expect(connection_created_events).not_to be_empty
+
+      current_primary = subscribed_client.cluster.next_primary
+      ClusterTools.instance.force_step_down
+
+      EventSubscriber.clear_events!
+
+      # exhaust the batch
+      9.times do
+        enum.next
+      end
+
+      # this should issue a getMore
+      item = enum.next
+      expect(item['test']).to eq(1)
+
+      get_more_events = EventSubscriber.started_events.select do |event|
+        event.command['getMore']
+      end
+
+      expect(get_more_events.length).to eq(1)
+
+      # getMore should have been sent on the same connection as find
+      connection_created_events = EventSubscriber.published_events.select do |event|
+        event.is_a?(Mongo::Monitoring::Event::Cmap::ConnectionCreated)
+      end
+      expect(connection_created_events).to be_empty
+    end
+
+    after do
+      # The tests normally operate with a low server selection timeout,
+      # but since this test caused a cluster election we may need to wait
+      # longer for the cluster to reestablish itself.
+      # To keep all other tests' timeouts low, wait for primary to be
+      # elected at the end of this test
+      test_client.cluster.servers.each do |server|
+        server.unknown!
+      end
+      test_client.cluster.next_primary
+
+      # Since we are changing which server is primary, close all clients
+      # to prevent subsequent tests setting fail points on servers which
+      # are not primary
+      ClientRegistry.instance.close_all_clients
+    end
+  end
+
+  describe 'writes on connections' do
+    min_server_fcv '4.0'
+
+    let(:server) do
+      client = test_client.with(app_name: rand)
+      client['test'].insert_one(test: 1)
+      client.cluster.next_primary
+    end
+
+    let(:fail_point) do
+      { configureFailPoint: 'failCommand', data: {
+        # There is currently no way to turn write retries on not master
+        # errors off - therefore set the number of fails to 2
+        failCommands: ['insert'], errorCode: fail_point_code, }, mode: {times: 2} }
+    end
+
+    before do
+      collection.find
+      admin_support_client.command(fail_point)
+    end
+
+    after do
+      admin_support_client.command(configureFailPoint: 'failCommand', mode: 'off')
+    end
+
+    describe 'not master - 4.2' do
+      min_server_fcv '4.2'
+
+      let(:write_concern) { {:w => 1} }
+
+      # not master
+      let(:fail_point_code) { 10107 }
+
+      it 'keeps connection open' do
+        event_subscriber.clear_events!
+
+        expect do
+          collection.insert_one(test: 1)
+        end.to raise_error(Mongo::Error::OperationFailure, /10107/)
+
+        expect(event_subscriber.select_published_events(Mongo::Monitoring::Event::Cmap::PoolCleared).count).to eq(0)
+      end
+    end
+
+    describe 'not master - 4.0' do
+      max_server_version '4.0'
+
+      let(:write_concern) { {:w => 1} }
+
+      # not master
+      let(:fail_point_code) { 10107 }
+
+      it 'closes the connection' do
+        event_subscriber.clear_events!
+
+        expect do
+          collection.insert_one(test: 1)
+        end.to raise_error(Mongo::Error::OperationFailure, /10107/)
+
+        expect(event_subscriber.select_published_events(Mongo::Monitoring::Event::Cmap::PoolCleared).count).to eq(1)
+      end
+    end
+
+    describe 'node shutting down' do
+      let(:write_concern) { {:w => 1} }
+
+      # interrupted at shutdown
+      let(:fail_point_code) { 11600 }
+
+      it 'closes the connection' do
+        event_subscriber.clear_events!
+
+        expect do
+          collection.insert_one(test: 1)
+        end.to raise_error(Mongo::Error::OperationFailure, /11600/)
+
+        expect(event_subscriber.select_published_events(Mongo::Monitoring::Event::Cmap::PoolCleared).count).to eq(1)
+      end
+    end
+  end
+end

data/spec/lite_spec_helper.rb

@@ -7,6 +7,7 @@ SERVER_SELECTION_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/server_select
 MAX_STALENESS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/max_staleness/**/*.yml")
 CRUD_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/crud/**/*.yml")
 RETRYABLE_WRITES_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/retryable_writes/**/*.yml")
+RETRYABLE_READS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/retryable_reads/**/*.yml").sort
 COMMAND_MONITORING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/command_monitoring/**/*.yml")
 CONNECTION_STRING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/connection_string/*.yml")
 URI_OPTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/uri_options/*.yml")
@@ -15,6 +16,7 @@ GRIDFS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/gridfs/*.yml")
 TRANSACTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions/*.yml")
 TRANSACTIONS_API_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions_api/*.yml")
 CHANGE_STREAMS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/change_streams/*.yml")
+CMAP_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/cmap/*.yml")
 
 if ENV['DRIVERS_TOOLS']
   CLIENT_CERT_PEM = ENV['DRIVER_TOOLS_CLIENT_CERT_PEM']
@@ -68,6 +70,7 @@ require 'support/server_selection'
 require 'support/sdam_monitoring'
 require 'support/crud'
 require 'support/command_monitoring'
+require 'support/cmap'
 require 'support/connection_string'
 require 'support/gridfs'
 require 'support/transactions'
@@ -77,6 +80,7 @@ require 'support/client_registry'
 require 'support/client_registry_macros'
 require 'support/json_ext_formatter'
 require 'support/sdam_formatter_integration'
+require 'support/utils'
 
 if SpecConfig.instance.mri?
   require 'timeout_interrupt'