mongo 2.7.2 → 2.8.0.rc0

data/spec/mongo/socket/tcp_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Mongo::Socket::TCP do
+  require_no_ssl
+
+  let(:address) { default_address }
+
+  let!(:resolver) do
+    address.send(:create_resolver, {})
+  end
+
+  let(:socket) do
+    resolver.socket(5, {})
+  end
+
+  describe '#address' do
+    it 'returns the address and tls indicator' do
+      addr = socket.send(:socket).remote_address
+      expect(socket.send(:address)).to eq("#{addr.ip_address}:#{addr.ip_port} (no TLS)")
+    end
+  end
+end

data/spec/mongo/socket/unix_spec.rb

@@ -2,15 +2,19 @@ require 'spec_helper'
 
 describe Mongo::Socket::Unix do
 
+  let(:path) { "/tmp/mongodb-#{SpecConfig.instance.any_port}.sock" }
+
   let(:socket) do
-    described_class.new("/tmp/mongodb-#{SpecConfig.instance.any_port}.sock", 5)
+    described_class.new(path, 5)
   end
 
-  describe '#connect!' do
-
-    before do
-      socket.connect!
+  describe '#address' do
+    it 'returns the path' do
+      expect(socket.send(:address)).to eq(path)
     end
+  end
+
+  describe '#connect!' do
 
     after do
       socket.close
@@ -25,10 +29,6 @@ describe Mongo::Socket::Unix do
 
     context 'when the socket is connected' do
 
-      before do
-        socket.connect!
-      end
-
       after do
         socket.close
       end

data/spec/mongo/socket_spec.rb

@@ -6,7 +6,19 @@ describe Mongo::Socket do
     described_class.new(Socket::PF_INET)
   end
 
+  describe '#address' do
+    it 'raises NotImplementedError' do
+      expect do
+        socket.send(:address)
+      end.to raise_error(NotImplementedError)
+    end
+  end
+
   describe '#handle_errors' do
+    before do
+      expect(socket).to receive(:address).and_return('fake-address')
+    end
+
     it 'maps timeout exception' do
       expect do
         socket.send(:handle_errors) do
@@ -20,7 +32,7 @@ describe Mongo::Socket do
         socket.send(:handle_errors) do
           raise SystemCallError.new('Test error', Errno::ENFILE::Errno)
         end
-      end.to raise_error(Mongo::Error::SocketError, 'Errno::ENFILE: Too many open files in system - Test error')
+      end.to raise_error(Mongo::Error::SocketError, 'Errno::ENFILE: Too many open files in system - Test error (for fake-address)')
     end
 
     it 'maps IOError and preserves message' do
@@ -28,7 +40,7 @@ describe Mongo::Socket do
         socket.send(:handle_errors) do
           raise IOError.new('Test error')
         end
-      end.to raise_error(Mongo::Error::SocketError, 'IOError: Test error')
+      end.to raise_error(Mongo::Error::SocketError, 'IOError: Test error (for fake-address)')
     end
 
     it 'maps SSLError and preserves message' do
@@ -36,7 +48,7 @@ describe Mongo::Socket do
         socket.send(:handle_errors) do
           raise OpenSSL::SSL::SSLError.new('Test error')
         end
-      end.to raise_error(Mongo::Error::SocketError, 'OpenSSL::SSL::SSLError: Test error (MongoDB may not be configured with SSL support)')
+      end.to raise_error(Mongo::Error::SocketError, 'OpenSSL::SSL::SSLError: Test error (for fake-address) (MongoDB may not be configured with SSL support)')
     end
   end
 end

data/spec/spec_tests/server_selection_spec.rb

@@ -46,6 +46,7 @@ describe 'Server Selection' do
           allow(c).to receive(:unknown?).and_return(topology.unknown?)
           allow(c).to receive(:app_metadata).and_return(app_metadata)
           allow(c).to receive(:options).and_return({})
+          allow(c).to receive(:server_selection_semaphore).and_return(nil)
         end
       end
 
@@ -101,6 +102,7 @@ describe 'Server Selection' do
       end
 
       context 'No matching server available', if: !spec.server_available? do
+        skip_if_linting
 
         it 'Raises exception' do
           expect do

data/spec/support/client_registry.rb

@@ -95,13 +95,19 @@ class ClientRegistry
       )
     # Provides an authorized mongo client that retries writes.
     when 'authorized_with_retry_writes'
-      global_client('authorized').with(retry_writes: true).tap do |client|
+      global_client('authorized').with(
+        retry_writes: true,
+        server_selection_timeout: 4.97,
+      ).tap do |client|
         client.subscribe(Mongo::Monitoring::COMMAND, EventSubscriber)
       end
     # Provides an authorized mongo client that does not retry writes,
     # overriding global test suite option to retry writes if necessary.
     when 'authorized_without_retry_writes'
-      global_client('authorized').with(retry_writes: false).tap do |client|
+      global_client('authorized').with(
+        retry_writes: false,
+        server_selection_timeout: 4.99,
+      ).tap do |client|
         client.subscribe(Mongo::Monitoring::COMMAND, EventSubscriber)
       end
     # Provides an unauthorized mongo client on the admin database, for use in

data/spec/support/common_shortcuts.rb

@@ -37,7 +37,7 @@ module CommonShortcuts
       # the case, this test will fail due to exceeding the general
       # test timeout eventually.
       while cluster.servers_list.any? { |server| server.unknown? }
-        warn "Waiting for unknown servers in #{cluster.servers}"
+        warn "Waiting for unknown servers in #{cluster.summary}"
         sleep 0.25
       end
     end
@@ -74,5 +74,24 @@ module CommonShortcuts
         allow(s).to receive(:description).and_return(description)
       end
     end
+
+    def make_protocol_reply(payload)
+      Mongo::Protocol::Reply.new.tap do |reply|
+        reply.instance_variable_set('@flags', [])
+        reply.instance_variable_set('@documents', [payload])
+      end
+    end
+
+    def make_not_master_reply
+      make_protocol_reply(
+        'ok' => 0, 'code' => 10107, 'errmsg' => 'not master'
+      )
+    end
+
+    def make_node_recovering_reply
+      make_protocol_reply(
+        'ok' => 0, 'code' => 91, 'errmsg' => 'shutdown in progress'
+      )
+    end
   end
 end

data/spec/support/constraints.rb

@@ -80,6 +80,14 @@ module Constraints
     end
   end
 
+  def require_no_ssl
+    before do
+      if SpecConfig.instance.ssl?
+        skip "SSL enabled"
+      end
+    end
+  end
+
   def require_local_tls
     before do
       unless SpecConfig.instance.ssl? && !SpecConfig.instance.ci?
@@ -130,7 +138,7 @@ module Constraints
 
   def require_auth
     before do
-      unless ENV['AUTH'] == 'auth' || ClusterConfig.instance.auth_enabled?
+      unless ENV['AUTH'] == 'auth' || SpecConfig.instance.user || ClusterConfig.instance.auth_enabled?
         skip "Auth required"
       end
     end
@@ -138,7 +146,7 @@ module Constraints
 
   def require_no_auth
     before do
-      if ENV['AUTH'] == 'auth' || ClusterConfig.instance.auth_enabled?
+      if ENV['AUTH'] == 'auth' || SpecConfig.instance.user || ClusterConfig.instance.auth_enabled?
         skip "Auth not allowed"
       end
     end

data/spec/support/lite_constraints.rb

@@ -28,6 +28,14 @@ module LiteConstraints
     end
   end
 
+  def require_linting
+    before do
+      unless Mongo::Lint.enabled?
+        skip "Linting is not enabled"
+      end
+    end
+  end
+
   # Some tests will fail if linting is enabled:
   # 1. Tests that pass invalid options to client, etc. which the linter
   #    rejects.

data/spec/support/spec_config.rb

@@ -148,6 +148,14 @@ class SpecConfig
 
   # Option hashes
 
+  def auth_options
+    {
+      user: user,
+      password: password,
+      auth_source: auth_source,
+    }
+  end
+
   def ssl_options
     if ssl?
       {
@@ -190,7 +198,7 @@ class SpecConfig
       # means the test suite hangs for about 4 seconds before
       # failing.
       # Server selection timeout of 1 is insufficient for evergreen.
-      server_selection_timeout: 2,
+      server_selection_timeout: ssl? ? 4.01 : 2.01,
       wait_queue_timeout: 2,
       connect_timeout: 3,
       max_idle_time: 5

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongo
 version: !ruby/object:Gem::Version
-  version: 2.7.2
+  version: 2.8.0.rc0
 platform: ruby
 authors:
 - Tyler Brock
@@ -31,7 +31,7 @@ cert_chain:
   bMYVwXXhV8czdzgkQB/ZPWHSbEWXnmkze1mzvqWBCPOVXYrcnL9cnEl/RoxtS1hr
   Db6Ac6mCUSYfYHBWpWqxjc45n70i5Xi1
   -----END CERTIFICATE-----
-date: 2019-03-21 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson
@@ -172,6 +172,7 @@ files:
 - lib/mongo/error/max_message_size.rb
 - lib/mongo/error/mismatched_domain.rb
 - lib/mongo/error/missing_file_chunk.rb
+- lib/mongo/error/missing_password.rb
 - lib/mongo/error/missing_resume_token.rb
 - lib/mongo/error/multi_index_drop.rb
 - lib/mongo/error/need_primary_server.rb
@@ -179,6 +180,7 @@ files:
 - lib/mongo/error/no_srv_records.rb
 - lib/mongo/error/operation_failure.rb
 - lib/mongo/error/parser.rb
+- lib/mongo/error/sdam_error_detection.rb
 - lib/mongo/error/session_ended.rb
 - lib/mongo/error/socket_error.rb
 - lib/mongo/error/socket_timeout_error.rb
@@ -379,6 +381,7 @@ files:
 - lib/mongo/server/app_metadata.rb
 - lib/mongo/server/connectable.rb
 - lib/mongo/server/connection.rb
+- lib/mongo/server/connection_base.rb
 - lib/mongo/server/connection_pool.rb
 - lib/mongo/server/connection_pool/queue.rb
 - lib/mongo/server/context.rb
@@ -387,6 +390,7 @@ files:
 - lib/mongo/server/monitor.rb
 - lib/mongo/server/monitor/app_metadata.rb
 - lib/mongo/server/monitor/connection.rb
+- lib/mongo/server/pending_connection.rb
 - lib/mongo/server/round_trip_time_averager.rb
 - lib/mongo/server_selector.rb
 - lib/mongo/server_selector/nearest.rb
@@ -413,6 +417,7 @@ files:
 - spec/README.md
 - spec/atlas/atlas_connectivity_spec.rb
 - spec/enterprise_auth/kerberos_spec.rb
+- spec/integration/auth_spec.rb
 - spec/integration/bulk_insert_spec.rb
 - spec/integration/change_stream_examples_spec.rb
 - spec/integration/change_stream_spec.rb
@@ -428,6 +433,7 @@ files:
 - spec/integration/operation_failure_code_spec.rb
 - spec/integration/reconnect_spec.rb
 - spec/integration/retryable_writes_spec.rb
+- spec/integration/sdam_error_handling_spec.rb
 - spec/integration/sdam_events_spec.rb
 - spec/integration/server_description_spec.rb
 - spec/integration/server_selector_spec.rb
@@ -583,6 +589,7 @@ files:
 - spec/mongo/session_spec.rb
 - spec/mongo/session_transaction_spec.rb
 - spec/mongo/socket/ssl_spec.rb
+- spec/mongo/socket/tcp_spec.rb
 - spec/mongo/socket/unix_spec.rb
 - spec/mongo/socket_spec.rb
 - spec/mongo/uri/srv_protocol_spec.rb
@@ -964,9 +971,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.1
 signing_key: 
@@ -1032,11 +1039,13 @@ test_files:
 - spec/integration/reconnect_spec.rb
 - spec/integration/client_connectivity_spec.rb
 - spec/integration/bulk_insert_spec.rb
+- spec/integration/auth_spec.rb
 - spec/integration/command_spec.rb
 - spec/integration/change_stream_spec.rb
 - spec/integration/time_zone_querying_spec.rb
 - spec/integration/heartbeat_events_spec.rb
 - spec/integration/docs_examples_spec.rb
+- spec/integration/sdam_error_handling_spec.rb
 - spec/mongo/cursor_spec.rb
 - spec/mongo/collection_spec.rb
 - spec/mongo/server/round_trip_time_averager_spec.rb
@@ -1093,6 +1102,7 @@ test_files:
 - spec/mongo/monitoring/event/secure_spec.rb
 - spec/mongo/monitoring/event/topology_opening_spec.rb
 - spec/mongo/socket/unix_spec.rb
+- spec/mongo/socket/tcp_spec.rb
 - spec/mongo/socket/ssl_spec.rb
 - spec/mongo/server_selector_spec.rb
 - spec/mongo/address/ipv6_spec.rb