mongo 2.4.0.rc1 → 2.4.0

data/spec/mongo/cluster/topology/sharded_spec.rb

@@ -7,11 +7,11 @@ describe Mongo::Cluster::Topology::Sharded do
   end
 
   let(:topology) do
-    described_class.new({})
+    described_class.new({}, monitoring)
   end
 
   let(:monitoring) do
-    Mongo::Monitoring.new
+    Mongo::Monitoring.new(monitoring: false)
   end
 
   let(:listeners) do
@@ -20,6 +20,7 @@ describe Mongo::Cluster::Topology::Sharded do
 
   let(:cluster) do
     double('cluster').tap do |cl|
+      allow(cl).to receive(:topology).and_return(topology)
       allow(cl).to receive(:app_metadata).and_return(app_metadata)
     end
   end
@@ -86,6 +87,20 @@ describe Mongo::Cluster::Topology::Sharded do
     end
   end
 
+  describe '#has_readable_servers?' do
+
+    it 'returns true' do
+      expect(topology).to have_readable_server(nil, nil)
+    end
+  end
+
+  describe '#has_writable_servers?' do
+
+    it 'returns true' do
+      expect(topology).to have_writable_server(nil)
+    end
+  end
+
   describe '#add_hosts?' do
 
     it 'returns false' do

data/spec/mongo/cluster/topology/single_spec.rb

@@ -6,12 +6,12 @@ describe Mongo::Cluster::Topology::Single do
     Mongo::Address.new('127.0.0.1:27017')
   end
 
-  let(:topology) do
-    described_class.new({})
+  let(:monitoring) do
+    Mongo::Monitoring.new(monitoring: false)
   end
 
-  let(:monitoring) do
-    Mongo::Monitoring.new
+  let(:topology) do
+    described_class.new({}, monitoring)
   end
 
   let(:listeners) do
@@ -21,6 +21,7 @@ describe Mongo::Cluster::Topology::Single do
   let(:cluster) do
     double('cluster').tap do |cl|
       allow(cl).to receive(:app_metadata).and_return(app_metadata)
+      allow(cl).to receive(:topology).and_return(topology)
     end
   end
 
@@ -91,6 +92,20 @@ describe Mongo::Cluster::Topology::Single do
     end
   end
 
+  describe '#has_readable_servers?' do
+
+    it 'returns true' do
+      expect(topology).to have_readable_server(nil, nil)
+    end
+  end
+
+  describe '#has_writable_servers?' do
+
+    it 'returns true' do
+      expect(topology).to have_writable_server(nil)
+    end
+  end
+
   describe '#add_hosts?' do
 
     it 'returns false' do

data/spec/mongo/cluster/topology/unknown_spec.rb

@@ -2,8 +2,12 @@ require 'spec_helper'
 
 describe Mongo::Cluster::Topology::Unknown do
 
+  let(:monitoring) do
+    Mongo::Monitoring.new(monitoring: false)
+  end
+
   let(:topology) do
-    described_class.new({})
+    described_class.new({}, monitoring)
   end
 
   describe '.servers' do
@@ -45,6 +49,20 @@ describe Mongo::Cluster::Topology::Unknown do
     end
   end
 
+  describe '#has_readable_servers?' do
+
+    it 'returns false' do
+      expect(topology).to_not have_readable_server(nil, nil)
+    end
+  end
+
+  describe '#has_writable_servers?' do
+
+    it 'returns false' do
+      expect(topology).to_not have_writable_server(nil)
+    end
+  end
+
   describe '#add_hosts?' do
 
     context 'when the description is from an unknown server' do

data/spec/mongo/cluster/topology_spec.rb

@@ -2,12 +2,16 @@ require 'spec_helper'
 
 describe Mongo::Cluster::Topology do
 
+  let(:monitoring) do
+    Mongo::Monitoring.new(monitoring: false)
+  end
+
   describe '.initial' do
 
     context 'when provided a replica set option' do
 
       let(:topology) do
-        described_class.initial([ 'a' ], connect: :replica_set)
+        described_class.initial([ 'a' ], monitoring, connect: :replica_set)
       end
 
       it 'returns a replica set topology' do
@@ -18,7 +22,7 @@ describe Mongo::Cluster::Topology do
     context 'when provided a single option' do
 
       let(:topology) do
-        described_class.initial([ 'a' ], connect: :direct)
+        described_class.initial([ 'a' ], monitoring, connect: :direct)
       end
 
       it 'returns a single topology' do
@@ -33,7 +37,7 @@ describe Mongo::Cluster::Topology do
     context 'when provided a sharded option' do
 
       let(:topology) do
-        described_class.initial([ 'a' ], connect: :sharded)
+        described_class.initial([ 'a' ], monitoring, connect: :sharded)
       end
 
       it 'returns a sharded topology' do
@@ -46,7 +50,7 @@ describe Mongo::Cluster::Topology do
       context 'when a set name is in the options' do
 
         let(:topology) do
-          described_class.initial([], replica_set: 'testing')
+          described_class.initial([], monitoring, replica_set: 'testing')
         end
 
         it 'returns a replica set topology' do
@@ -57,7 +61,7 @@ describe Mongo::Cluster::Topology do
       context 'when no set name is in the options' do
 
         let(:topology) do
-          described_class.initial([], {})
+          described_class.initial([], monitoring, {})
         end
 
         it 'returns an unknown topology' do
@@ -68,7 +72,7 @@ describe Mongo::Cluster::Topology do
       context 'when provided a single mongos', if: single_mongos? do
 
         let(:topology) do
-          described_class.initial(ADDRESSES, TEST_OPTIONS)
+          described_class.initial(ADDRESSES, monitoring, TEST_OPTIONS)
         end
 
         it 'returns a sharded topology' do
@@ -79,7 +83,7 @@ describe Mongo::Cluster::Topology do
       context 'when provided a single replica set member', if: single_rs_member? do
 
         let(:topology) do
-          described_class.initial(ADDRESSES, TEST_OPTIONS)
+          described_class.initial(ADDRESSES, monitoring, TEST_OPTIONS)
         end
 
         it 'returns a single topology' do

data/spec/mongo/cluster_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Mongo::Cluster do
 
   let(:monitoring) do
-    Mongo::Monitoring.new
+    Mongo::Monitoring.new(monitoring: false)
   end
 
   let(:cluster) do
@@ -59,6 +59,24 @@ describe Mongo::Cluster do
     end
   end
 
+  describe '#has_readable_server?' do
+
+    let(:selector) do
+      Mongo::ServerSelector.get(mode: :primary)
+    end
+
+    it 'delegates to the topology' do
+      expect(cluster.has_readable_server?).to eq(cluster.topology.has_readable_server?(cluster))
+    end
+  end
+
+  describe '#has_writable_server?' do
+
+    it 'delegates to the topology' do
+      expect(cluster.has_writable_server?).to eq(cluster.topology.has_writable_server?(cluster))
+    end
+  end
+
   describe '#inspect' do
 
     let(:preference) do
@@ -156,7 +174,7 @@ describe Mongo::Cluster do
       context 'when topology is Single' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::Single.new({})
+          Mongo::Cluster::Topology::Single.new({}, monitoring)
         end
 
         it 'returns an empty array' do
@@ -167,7 +185,7 @@ describe Mongo::Cluster do
       context 'when topology is ReplicaSet' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::ReplicaSet.new({})
+          Mongo::Cluster::Topology::ReplicaSet.new({}, monitoring)
         end
 
         it 'returns an empty array' do
@@ -178,7 +196,7 @@ describe Mongo::Cluster do
       context 'when topology is Sharded' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::Sharded.new({})
+          Mongo::Cluster::Topology::Sharded.new({}, monitoring)
         end
 
         it 'returns an empty array' do
@@ -189,7 +207,7 @@ describe Mongo::Cluster do
       context 'when topology is Unknown' do
 
         let(:topology) do
-          Mongo::Cluster::Topology::Unknown.new({})
+          Mongo::Cluster::Topology::Unknown.new({}, monitoring)
         end
 
         it 'returns an empty array' do
@@ -268,7 +286,7 @@ describe Mongo::Cluster do
     end
 
     let(:monitoring) do
-      Mongo::Monitoring.new
+      Mongo::Monitoring.new(monitoring: false)
     end
 
     let(:server_a) do
@@ -361,7 +379,7 @@ describe Mongo::Cluster do
     end
 
     let(:monitoring) do
-      Mongo::Monitoring.new
+      Mongo::Monitoring.new(monitoring: false)
     end
 
     let(:server) do

data/spec/mongo/max_staleness_spec.rb

@@ -11,7 +11,11 @@ describe 'Max Staleness Spec' do
     context(spec.description) do
 
       let(:topology) do
-        spec.type.new({})
+        spec.type.new({}, monitoring, [])
+      end
+
+      let(:monitoring) do
+        Mongo::Monitoring.new(monitoring: false)
       end
 
       let(:monitoring) do
@@ -26,10 +30,10 @@ describe 'Max Staleness Spec' do
         if spec.heartbeat_frequency
           TEST_OPTIONS.merge(heartbeat_frequency: spec.heartbeat_frequency)
         else
-          copy = TEST_OPTIONS.dup
-          copy.delete(:heartbeat_frequency)
-          copy
-        end.merge!(server_selection_timeout: 0.2)
+          TEST_OPTIONS.dup.tap do |opts|
+            opts.delete(:heartbeat_frequency)
+          end
+        end.merge!(server_selection_timeout: 0.2, connect_timeout: 0.1)
       end
 
       let(:cluster) do
@@ -38,7 +42,8 @@ describe 'Max Staleness Spec' do
           allow(c).to receive(:single?).and_return(topology.single?)
           allow(c).to receive(:sharded?).and_return(topology.sharded?)
           allow(c).to receive(:replica_set?).and_return(topology.replica_set?)
-          allow(c).to receive(:options).and_return(options.merge(server_selection_timeout: 0.2))
+          allow(c).to receive(:unknown?).and_return(topology.unknown?)
+          allow(c).to receive(:options).and_return(options)
           allow(c).to receive(:scan!).and_return(true)
           allow(c).to receive(:app_metadata).and_return(app_metadata)
         end
@@ -47,17 +52,17 @@ describe 'Max Staleness Spec' do
       let(:candidate_servers) do
         spec.candidate_servers.collect do |server|
           features = double('features').tap do |feat|
-            allow(feat).to receive(:max_staleness_enabled?).and_return(server['maxWireVersion'] >= 5)
+            allow(feat).to receive(:max_staleness_enabled?).and_return(server['maxWireVersion'] && server['maxWireVersion'] >= 5)
           end
           address = Mongo::Address.new(server['address'])
           Mongo::Server.new(address, cluster, monitoring, listeners, options).tap do |s|
-            allow(s).to receive(:average_round_trip_time).and_return(server['avg_rtt_ms'])
+            allow(s).to receive(:average_round_trip_time).and_return(server['avg_rtt_ms'] / 1000.0) if server['avg_rtt_ms']
             allow(s).to receive(:tags).and_return(server['tags'])
             allow(s).to receive(:secondary?).and_return(server['type'] == 'RSSecondary')
             allow(s).to receive(:primary?).and_return(server['type'] == 'RSPrimary')
             allow(s).to receive(:connectable?).and_return(true)
-            allow(s).to receive(:last_write_date).and_return(server['lastWrite']['lastWriteDate']['$numberLong'].to_i * 1000)
-            allow(s).to receive(:last_scan).and_return(server['lastUpdateTime'] * 1000)
+            allow(s).to receive(:last_write_date).and_return(server['lastWrite']['lastWriteDate']['$numberLong'].to_i) if server['lastWrite']
+            allow(s).to receive(:last_scan).and_return(server['lastUpdateTime'])
             allow(s).to receive(:features).and_return(features)
           end
         end
@@ -65,7 +70,7 @@ describe 'Max Staleness Spec' do
 
       let(:in_latency_window) do
         spec.in_latency_window.collect do |server|
-          Mongo::Server.new(Mongo::Address.new(server['address']), cluster, monitoring, listeners)
+          Mongo::Server.new(Mongo::Address.new(server['address']), cluster, monitoring, listeners, options)
         end
       end
 
@@ -84,23 +89,36 @@ describe 'Max Staleness Spec' do
         allow(cluster).to receive(:servers).and_return(candidate_servers)
       end
 
-      context 'Valid read preference and matching server available', unless: spec.invalid_max_staleness? do
+      context 'when the max staleness is invalid' do
 
-        it 'Finds all suitable servers in the latency window', if: spec.replica_set? do
-          expect(server_selector.send(:select, cluster.servers)).to match_array(in_latency_window)
-        end
+        it 'Raises an InvalidServerPreference exception', if: spec.invalid_max_staleness? do
 
-        it 'Finds the most suitable server in the latency window' do
-          expect(in_latency_window).to include(server_selector.select_server(cluster))
+          expect do
+            server_selector.select_server(cluster)
+          end.to raise_exception(Mongo::Error::InvalidServerPreference)
         end
       end
 
-      context 'when the max staleness cannot be applied', if: spec.invalid_max_staleness? do
+      context 'when the max staleness is valid' do
 
-        it 'Raises exception' do
-          expect do
-            server_selector.select_server(cluster)
-          end.to raise_exception(Mongo::Error::InvalidServerPreference)
+        context 'when there are available servers' do
+
+          it 'Finds all suitable servers in the latency window', if: (spec.replica_set? && !spec.invalid_max_staleness? && spec.server_available?) do
+            expect(server_selector.send(:select, cluster.servers)).to match_array(in_latency_window)
+          end
+
+          it 'Finds the most suitable server in the latency window', if: (!spec.invalid_max_staleness? && spec.server_available?) do
+            expect(in_latency_window).to include(server_selector.select_server(cluster))
+          end
+        end
+
+        context 'when there are no available servers', if: (!spec.invalid_max_staleness? && !spec.server_available?) do
+
+          it 'Raises a NoServerAvailable Exception' do
+            expect do
+              server_selector.select_server(cluster)
+            end.to raise_exception(Mongo::Error::NoServerAvailable)
+          end
         end
       end
     end

data/spec/mongo/monitoring_spec.rb

@@ -45,7 +45,7 @@ describe Mongo::Monitoring do
       end
 
       it 'includes the global subscribers' do
-        expect(monitoring.subscribers.size).to eq(1)
+        expect(monitoring.subscribers.size).to eq(6)
       end
     end
 
@@ -58,7 +58,7 @@ describe Mongo::Monitoring do
         end
 
         it 'includes the global subscribers' do
-          expect(monitoring.subscribers.size).to eq(1)
+          expect(monitoring.subscribers.size).to eq(6)
         end
       end
 

data/spec/mongo/sdam_monitoring_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe 'SDAM Monitoring' do
+  include Mongo::SDAM
+
+  SDAM_MONITORING_TESTS.each do |file|
+
+    spec = Mongo::SDAM::Spec.new(file)
+
+    context(spec.description) do
+
+      before(:all) do
+        @client = Mongo::Client.new([], heartbeat_frequency: 100, connect_timeout: 0.1)
+        @subscriber = Mongo::SDAMMonitoring::TestSubscriber.new
+        @client.subscribe(Mongo::Monitoring::SERVER_OPENING, @subscriber)
+        @client.subscribe(Mongo::Monitoring::SERVER_CLOSED, @subscriber)
+        @client.subscribe(Mongo::Monitoring::SERVER_DESCRIPTION_CHANGED, @subscriber)
+        @client.subscribe(Mongo::Monitoring::TOPOLOGY_OPENING, @subscriber)
+        @client.subscribe(Mongo::Monitoring::TOPOLOGY_CHANGED, @subscriber)
+        @client.send(:create_from_uri, spec.uri_string)
+      end
+
+      after(:all) do
+        @client.close
+      end
+
+      spec.phases.each_with_index do |phase, index|
+
+        context("Phase: #{index + 1}") do
+
+          before(:all) do
+            phase.responses.each do |response|
+              # For each response in the phase, we need to change that server's description.
+              server = find_server(@client, response.address)
+              server ||= Mongo::Server.new(
+                           Mongo::Address.new(response.address),
+                           @client.cluster,
+                           @client.instance_variable_get(:@monitoring),
+                           @client.cluster.send(:event_listeners),
+                           @client.cluster.options
+                         )
+              monitor = server.instance_variable_get(:@monitor)
+              description = monitor.inspector.run(server.description, response.ismaster, 0.5)
+              monitor.instance_variable_set(:@description, description)
+            end
+          end
+
+          phase.outcome.events.each do |expectation|
+
+            it "expects a #{expectation.name} to be fired" do
+              fired_event = @subscriber.first_event(expectation.name)
+              expect(fired_event).not_to be_nil
+              expect(fired_event).to match_sdam_monitoring_event(expectation)
+            end
+          end
+        end
+      end
+    end
+  end
+end