mongo 2.3.1 → 2.4.0.rc0

data/spec/mongo/max_staleness_spec.rb

@@ -0,0 +1,108 @@
+require 'spec_helper'
+
+describe 'Max Staleness Spec' do
+
+  include Mongo::ServerSelection::Read
+
+  MAX_STALENESS_TESTS.each do |file|
+
+    spec = Mongo::ServerSelection::Read::Spec.new(file)
+
+    context(spec.description) do
+
+      let(:topology) do
+        spec.type.new({})
+      end
+
+      let(:monitoring) do
+        Mongo::Monitoring.new
+      end
+
+      let(:listeners) do
+        Mongo::Event::Listeners.new
+      end
+
+      let(:options) do
+        if spec.heartbeat_frequency
+          TEST_OPTIONS.merge(heartbeat_frequency: spec.heartbeat_frequency)
+        else
+          copy = TEST_OPTIONS.dup
+          copy.delete(:heartbeat_frequency)
+          copy
+        end.merge!(server_selection_timeout: 0.2)
+      end
+
+      let(:cluster) do
+        double('cluster').tap do |c|
+          allow(c).to receive(:topology).and_return(topology)
+          allow(c).to receive(:single?).and_return(topology.single?)
+          allow(c).to receive(:sharded?).and_return(topology.sharded?)
+          allow(c).to receive(:replica_set?).and_return(topology.replica_set?)
+          allow(c).to receive(:options).and_return(options.merge(server_selection_timeout: 0.2))
+          allow(c).to receive(:scan!).and_return(true)
+          allow(c).to receive(:app_metadata).and_return(app_metadata)
+        end
+      end
+
+      let(:candidate_servers) do
+        spec.candidate_servers.collect do |server|
+          features = double('features').tap do |feat|
+            allow(feat).to receive(:max_staleness_enabled?).and_return(server['maxWireVersion'] >= 5)
+          end
+          address = Mongo::Address.new(server['address'])
+          Mongo::Server.new(address, cluster, monitoring, listeners, options).tap do |s|
+            allow(s).to receive(:average_round_trip_time).and_return(server['avg_rtt_ms'])
+            allow(s).to receive(:tags).and_return(server['tags'])
+            allow(s).to receive(:secondary?).and_return(server['type'] == 'RSSecondary')
+            allow(s).to receive(:primary?).and_return(server['type'] == 'RSPrimary')
+            allow(s).to receive(:connectable?).and_return(true)
+            allow(s).to receive(:last_write_date).and_return(server['lastWrite']['lastWriteDate']['$numberLong'].to_i * 1000)
+            allow(s).to receive(:last_scan).and_return(server['lastUpdateTime'] * 1000)
+            allow(s).to receive(:features).and_return(features)
+          end
+        end
+      end
+
+      let(:in_latency_window) do
+        spec.in_latency_window.collect do |server|
+          Mongo::Server.new(Mongo::Address.new(server['address']), cluster, monitoring, listeners)
+        end
+      end
+
+      let(:server_selector_definition) do
+        { mode: spec.read_preference['mode'] }.tap do |definition|
+          definition[:tag_sets] = spec.read_preference['tag_sets']
+          definition[:max_staleness] = spec.max_staleness if spec.max_staleness
+        end
+      end
+
+      let(:server_selector) do
+        Mongo::ServerSelector.get(server_selector_definition)
+      end
+
+      before do
+        allow(cluster).to receive(:servers).and_return(candidate_servers)
+      end
+
+      context 'Valid read preference and matching server available', unless: spec.invalid_max_staleness? do
+
+        it 'Finds all suitable servers in the latency window', if: spec.replica_set? do
+          expect(server_selector.send(:select, cluster.servers)).to match_array(in_latency_window)
+        end
+
+        it 'Finds the most suitable server in the latency window' do
+          expect(in_latency_window).to include(server_selector.select_server(cluster))
+        end
+      end
+
+      context 'when the max staleness cannot be applied', if: spec.invalid_max_staleness? do
+
+        it 'Raises exception' do
+          expect do
+            server_selector.select_server(cluster)
+          end.to raise_exception(Mongo::Error::InvalidServerPreference)
+        end
+      end
+    end
+  end
+end

data/spec/mongo/operation/read_preference_spec.rb

@@ -55,7 +55,7 @@ describe Mongo::Operation::ReadPreference do
     end
 
     it 'returns a special selector' do
-      expect(operation.send(:update_selector, server)).to eq(expected)
+      expect(operation.send(:update_selector_for_read_pref, operation.send(:selector), server)).to eq(expected)
     end
 
     context 'when the selector already has $query in it' do
@@ -70,7 +70,7 @@ describe Mongo::Operation::ReadPreference do
       end
 
       it 'returns an unaltered special selector' do
-        expect(operation.send(:update_selector, server)).to eq(expected)
+        expect(operation.send(:update_selector_for_read_pref, operation.send(:selector), server)).to eq(expected)
       end
     end
   end
@@ -82,7 +82,7 @@ describe Mongo::Operation::ReadPreference do
     end
 
     it 'returns a selector' do
-      expect(operation.send(:update_selector, server)).to eq(selector)
+      expect(operation.send(:update_selector_for_read_pref, operation.send(:selector), server)).to eq(selector)
     end
   end
 
@@ -168,7 +168,7 @@ describe Mongo::Operation::ReadPreference do
       end
 
       it 'does not set the slave_ok flag' do
-        expect(operation.send(:update_options, server)).to eq(expected)
+        expect(operation.send(:update_options_for_slave_ok, operation.send(:options), server)).to eq(expected)
       end
     end
 
@@ -183,7 +183,7 @@ describe Mongo::Operation::ReadPreference do
       end
 
       it 'sets the slave_ok flag' do
-        expect(operation.send(:update_options, server)).to eq(expected)
+        expect(operation.send(:update_options_for_slave_ok, operation.send(:options), server)).to eq(expected)
       end
     end
   end
@@ -205,7 +205,7 @@ describe Mongo::Operation::ReadPreference do
       end
 
       it 'does not set the slave_ok flag' do
-        expect(operation.send(:update_options, server)).to eq(expected)
+        expect(operation.send(:update_options_for_slave_ok, operation.send(:options), server)).to eq(expected)
       end
     end
 
@@ -222,7 +222,7 @@ describe Mongo::Operation::ReadPreference do
         end
 
         it 'sets the slave_ok flag' do
-          expect(operation.send(:update_options, server)).to eq(expected)
+          expect(operation.send(:update_options_for_slave_ok, operation.send(:options), server)).to eq(expected)
         end
       end
 
@@ -237,7 +237,7 @@ describe Mongo::Operation::ReadPreference do
         end
 
         it 'does not set the slave_ok flag' do
-          expect(operation.send(:update_options, server)).to eq(expected)
+          expect(operation.send(:update_options_for_slave_ok, operation.send(:options), server)).to eq(expected)
         end
       end
     end

data/spec/mongo/operation/write/command/delete_spec.rb

@@ -100,7 +100,7 @@ describe Mongo::Operation::Write::Command::Delete do
                                                            '$cmd',
                                                            expected_selector,
                                                            { limit: -1 } )
-      op.send(:message)
+      op.send(:message, double('server'))
     end
   end
 end

data/spec/mongo/operation/write/command/insert_spec.rb

@@ -99,7 +99,7 @@ describe Mongo::Operation::Write::Command::Insert do
                                                            '$cmd',
                                                             expected_selector,
                                                             { limit: -1, validating_keys: true })
-      op.send(:message)
+      op.send(:message, double('server'))
     end
   end
 end

data/spec/mongo/operation/write/command/update_spec.rb

@@ -104,7 +104,7 @@ describe Mongo::Operation::Write::Command::Update do
 
     it 'creates the correct Command message' do
       expect(Mongo::Protocol::Query).to receive(:new).with(TEST_DB, '$cmd', expected_selector, { limit: -1 })
-      op.send(:message)
+      op.send(:message, double('server'))
     end
   end
 end

data/spec/mongo/server/connection_pool_spec.rb

@@ -19,7 +19,9 @@ describe Mongo::Server::ConnectionPool do
   end
 
   let(:cluster) do
-    double('cluster')
+    double('cluster').tap do |cl|
+      allow(cl).to receive(:app_metadata).and_return(app_metadata)
+    end
   end
 
   describe '#checkin' do

data/spec/mongo/server/connection_spec.rb

@@ -14,8 +14,14 @@ describe Mongo::Server::Connection do
     Mongo::Event::Listeners.new
   end
 
+  let(:app_metadata) do
+    Mongo::Cluster::AppMetadata.new(authorized_client.cluster)
+  end
+
   let(:cluster) do
-    double('cluster')
+    double('cluster').tap do |cl|
+      allow(cl).to receive(:app_metadata).and_return(app_metadata)
+    end
   end
 
   let(:server) do
@@ -59,7 +65,7 @@ describe Mongo::Server::Connection do
     context 'when no socket exists' do
 
       let(:connection) do
-        described_class.new(server)
+        described_class.new(server, server.options)
       end
 
       let!(:result) do
@@ -86,7 +92,7 @@ describe Mongo::Server::Connection do
     context 'when a socket exists' do
 
       let(:connection) do
-        described_class.new(server)
+        described_class.new(server, server.options)
       end
 
       before do
@@ -163,7 +169,7 @@ describe Mongo::Server::Connection do
     context 'when a socket is not connected' do
 
       let(:connection) do
-        described_class.new(server)
+        described_class.new(server, server.options)
       end
 
       it 'does not raise an error' do
@@ -174,7 +180,7 @@ describe Mongo::Server::Connection do
     context 'when a socket is connected' do
 
       let(:connection) do
-        described_class.new(server)
+        described_class.new(server, server.options)
       end
 
       before do
@@ -431,7 +437,7 @@ describe Mongo::Server::Connection do
     context 'when host and port are provided' do
 
       let(:connection) do
-        described_class.new(server)
+        described_class.new(server, server.options)
       end
 
       it 'sets the address' do
@@ -535,7 +541,7 @@ describe Mongo::Server::Connection do
   describe '#auth_mechanism' do
 
     let(:connection) do
-      described_class.new(server)
+      described_class.new(server, server.options)
     end
 
     let(:reply) do
@@ -564,6 +570,7 @@ describe Mongo::Server::Connection do
           socket = connection.instance_variable_get(:@socket)
           max_message_size = connection.send(:max_message_size)
           allow(Mongo::Protocol::Reply).to receive(:deserialize).with(socket, max_message_size).and_return(reply)
+          connection.send(:handshake!)
           expect(connection.send(:default_mechanism)).to eq(:scram)
         end
       end
@@ -574,6 +581,7 @@ describe Mongo::Server::Connection do
           socket = connection.instance_variable_get(:@socket)
           max_message_size = connection.send(:max_message_size)
           allow(Mongo::Protocol::Reply).to receive(:deserialize).with(socket, max_message_size).and_return(reply)
+          connection.send(:handshake!)
           expect(connection.send(:default_mechanism)).to eq(:scram)
         end
       end
@@ -595,6 +603,7 @@ describe Mongo::Server::Connection do
           socket = connection.instance_variable_get(:@socket)
           max_message_size = connection.send(:max_message_size)
           allow(Mongo::Protocol::Reply).to receive(:deserialize).with(socket, max_message_size).and_return(reply)
+          connection.send(:handshake!)
           expect(connection.send(:default_mechanism)).to eq(:scram)
         end
       end
@@ -605,6 +614,7 @@ describe Mongo::Server::Connection do
           socket = connection.instance_variable_get(:@socket)
           max_message_size = connection.send(:max_message_size)
           allow(Mongo::Protocol::Reply).to receive(:deserialize).with(socket, max_message_size).and_return(reply)
+          connection.send(:handshake!)
           expect(connection.send(:default_mechanism)).to eq(:mongodb_cr)
         end
       end

data/spec/mongo/server/description/features_spec.rb

@@ -56,6 +56,56 @@ describe Mongo::Server::Description::Features do
     end
   end
 
+  describe '#collation_enabled?' do
+
+    context 'when the wire range includes 5' do
+
+      let(:features) do
+        described_class.new(0..5)
+      end
+
+      it 'returns true' do
+        expect(features).to be_collation_enabled
+      end
+    end
+
+    context 'when the wire range does not include 5' do
+
+      let(:features) do
+        described_class.new(0..2)
+      end
+
+      it 'returns false' do
+        expect(features).to_not be_collation_enabled
+      end
+    end
+  end
+
+  describe '#max_staleness_enabled?' do
+
+    context 'when the wire range includes 5' do
+
+      let(:features) do
+        described_class.new(0..5)
+      end
+
+      it 'returns true' do
+        expect(features).to be_max_staleness_enabled
+      end
+    end
+
+    context 'when the wire range does not include 5' do
+
+      let(:features) do
+        described_class.new(0..2)
+      end
+
+      it 'returns false' do
+        expect(features).to_not be_max_staleness_enabled
+      end
+    end
+  end
+
   describe '#find_command_enabled?' do
 
     context 'when the wire range includes 4' do

data/spec/mongo/server/description_spec.rb

@@ -35,6 +35,12 @@ describe Mongo::Server::Description do
     Mongo::Monitoring.new
   end
 
+  let(:cluster) do
+    double('cluster').tap do |cl|
+      allow(cl).to receive(:app_metadata).and_return(app_metadata)
+    end
+  end
+
   describe '#arbiter?' do
 
     context 'when the server is an arbiter' do
@@ -587,7 +593,7 @@ describe Mongo::Server::Description do
     end
 
     let(:server) do
-      Mongo::Server.new(address, double('cluster'), monitoring, listeners)
+      Mongo::Server.new(address, cluster, monitoring, listeners)
     end
 
     let(:description) do
@@ -608,7 +614,7 @@ describe Mongo::Server::Description do
       end
 
       let(:server) do
-        Mongo::Server.new(other_address, double('cluster'), monitoring, listeners)
+        Mongo::Server.new(other_address, cluster, monitoring, listeners)
       end
 
       it 'returns false' do
@@ -674,7 +680,7 @@ describe Mongo::Server::Description do
     end
 
     let(:server) do
-      Mongo::Server.new(server_address, double('cluster'), monitoring, listeners)
+      Mongo::Server.new(server_address, cluster, monitoring, listeners)
     end
 
     context 'when the server is included in the description hosts list' do

data/spec/mongo/server_selection_spec.rb

@@ -28,13 +28,14 @@ describe 'Server Selection' do
           allow(c).to receive(:single?).and_return(topology.single?)
           allow(c).to receive(:sharded?).and_return(topology.sharded?)
           allow(c).to receive(:replica_set?).and_return(topology.replica_set?)
+          allow(c).to receive(:app_metadata).and_return(app_metadata)
         end
       end
 
       let(:candidate_servers) do
         spec.candidate_servers.collect do |server|
           address = Mongo::Address.new(server['address'])
-          Mongo::Server.new(address, double('cluster'), monitoring, listeners, TEST_OPTIONS).tap do |s|
+          Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS).tap do |s|
             allow(s).to receive(:average_round_trip_time).and_return(server['avg_rtt_ms'])
             allow(s).to receive(:tags).and_return(server['tags'])
             allow(s).to receive(:secondary?).and_return(server['type'] == 'RSSecondary')
@@ -47,7 +48,7 @@ describe 'Server Selection' do
       let(:in_latency_window) do
         spec.in_latency_window.collect do |server|
           address = Mongo::Address.new(server['address'])
-          Mongo::Server.new(address, double('cluster'), monitoring, listeners, TEST_OPTIONS).tap do |s|
+          Mongo::Server.new(address, cluster, monitoring, listeners, TEST_OPTIONS).tap do |s|
             allow(s).to receive(:average_round_trip_time).and_return(server['avg_rtt_ms'])
             allow(s).to receive(:tags).and_return(server['tags'])
             allow(s).to receive(:connectable?).and_return(true)
@@ -64,12 +65,13 @@ describe 'Server Selection' do
         allow(cluster).to receive(:servers).and_return(candidate_servers)
         allow(cluster).to receive(:options).and_return(server_selection_timeout: 0.2)
         allow(cluster).to receive(:scan!).and_return(true)
+        allow(cluster).to receive(:app_metadata).and_return(app_metadata)
       end
 
       context 'Valid read preference and matching server available', if: spec.server_available? do
 
         it 'Finds all suitable servers in the latency window', if: spec.replica_set? do
-          expect(server_selector.send(:select, cluster.servers)).to eq(in_latency_window)
+          expect(server_selector.send(:select, cluster.servers)).to match_array(in_latency_window)
         end
 
         it 'Finds the most suitable server in the latency window' do