mongo 2.22.0 → 2.24.0

data/lib/mongo/cluster/topology/load_balanced.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2021 MongoDB Inc.
 #
@@ -18,12 +17,10 @@
 module Mongo
   class Cluster
     module Topology
-
       # Defines behavior for when a cluster is in load-balanced topology.
       class LoadBalanced < Base
-
         # The display name for the topology.
-        NAME = 'LoadBalanced'.freeze
+        NAME = 'LoadBalanced'
 
         # Get the display name.
         #
@@ -48,7 +45,9 @@ module Mongo
         #   selector.
         #
         # @return [ true ] A standalone always has a readable server.
-        def has_readable_server?(cluster, server_selector = nil); true; end
+        def has_readable_server?(_cluster, _server_selector = nil)
+          true
+        end
 
         # Determine if the topology would select a writable server for the
         # provided candidates.
@@ -56,45 +55,56 @@ module Mongo
         # @param [ Cluster ] cluster The cluster.
         #
         # @return [ true ] A standalone always has a writable server.
-        def has_writable_server?(cluster); true; end
+        def has_writable_server?(_cluster)
+          true
+        end
 
         # Returns whether this topology is one of the replica set ones.
         #
         # @return [ false ] Always false.
-        def replica_set?; false; end
+        def replica_set?
+          false
+        end
 
         # Select appropriate servers for this topology.
         #
         # @param [ Array<Server> ] servers The known servers.
         #
         # @return [ Array<Server> ] All of the known servers.
-        def servers(servers, name = nil)
+        def servers(servers, _name = nil)
           servers
         end
 
         # Returns whether this topology is sharded.
         #
         # @return [ false ] Always false.
-        def sharded?; false; end
+        def sharded?
+          false
+        end
 
         # Returns whether this topology is Single.
         #
-        # @return [ true ] Always false.
-        def single?; false; end
+        # @return [ false ] Always false.
+        def single?
+          false
+        end
 
         # Returns whether this topology is Unknown.
         #
         # @return [ false ] Always false.
-        def unknown?; false; end
+        def unknown?
+          false
+        end
 
         private
 
         def validate_options(options, cluster)
           if cluster.servers_list.length > 1
-            raise ArgumentError, "Cannot instantiate a load-balanced topology with more than one server in the cluster: #{cluster.servers_list.map(&:address).map(&:seed).join(', ')}"
+            raise ArgumentError,
+                  "Cannot instantiate a load-balanced topology with more than one server in the cluster: #{cluster.servers_list.map(&:address).map(&:seed).join(', ')}"
           end
 
-          super(options, cluster)
+          super
         end
       end
     end

data/lib/mongo/cluster/topology/no_replica_set_options.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -24,12 +23,10 @@ module Mongo
         def validate_options(options, cluster)
           # These options can be set to nil for convenience, but not to
           # any value including an empty string.
-          [:replica_set_name, :max_election_id, :max_set_version].each do |option|
-            if options[option]
-              raise ArgumentError, "Topology #{self.class.name} cannot have the :#{option} option set"
-            end
+          %i[replica_set_name max_election_id max_set_version].each do |option|
+            raise ArgumentError, "Topology #{self.class.name} cannot have the :#{option} option set" if options[option]
           end
-          super(options, cluster)
+          super
         end
       end
     end

data/lib/mongo/cluster/topology/replica_set_no_primary.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -18,19 +17,17 @@
 module Mongo
   class Cluster
     module Topology
-
       # Defines behavior when a cluster is in replica set topology,
       # and there is no primary or the primary has not yet been discovered
       # by the driver.
       #
       # @since 2.0.0
       class ReplicaSetNoPrimary < Base
-
         # The display name for the topology.
         #
         # @since 2.0.0
         # @deprecated
-        NAME = 'Replica Set'.freeze
+        NAME = 'Replica Set'
 
         # Get the display name.
         #
@@ -50,16 +47,10 @@ module Mongo
         # @since 2.7.0
         def summary
           details = server_descriptions.keys.join(',')
-          if details != ''
-            details << ','
-          end
+          details << ',' if details != ''
           details << "name=#{replica_set_name}"
-          if max_set_version
-            details << ",v=#{max_set_version}"
-          end
-          if max_election_id
-            details << ",e=#{max_election_id && max_election_id.to_s.sub(/^0+/, '')}"
-          end
+          details << ",v=#{max_set_version}" if max_set_version
+          details << ",e=#{max_election_id && max_election_id.to_s.sub(/^0+/, '')}" if max_election_id
           "#{display_name}[#{details}]"
         end
 
@@ -104,7 +95,9 @@ module Mongo
         # @return [ true ] Always true.
         #
         # @since 2.0.0
-        def replica_set?; true; end
+        def replica_set?
+          true
+        end
 
         # Select appropriate servers for this topology.
         #
@@ -118,8 +111,8 @@ module Mongo
         # @since 2.0.0
         def servers(servers)
           servers.select do |server|
-            (replica_set_name.nil? || server.replica_set_name == replica_set_name) &&
-              server.primary? || server.secondary?
+            ((replica_set_name.nil? || server.replica_set_name == replica_set_name) &&
+              server.primary?) || server.secondary?
           end
         end
 
@@ -131,7 +124,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def sharded?; false; end
+        def sharded?
+          false
+        end
 
         # A replica set topology is not single.
         #
@@ -141,7 +136,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def single?; false; end
+        def single?
+          false
+        end
 
         # A replica set topology is not unknown.
         #
@@ -151,20 +148,20 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def unknown?; false; end
+        def unknown?
+          false
+        end
 
         private
 
         def validate_options(options, cluster)
-          if options[:replica_set_name] == ''
-            options = options.merge(replica_set_name: nil)
-          end
+          options = options.merge(replica_set_name: nil) if options[:replica_set_name] == ''
 
           unless options[:replica_set_name]
             raise ArgumentError, 'Cannot instantiate a replica set topology without a replica set name'
           end
 
-          super(options, cluster)
+          super
         end
       end
     end

data/lib/mongo/cluster/topology/replica_set_with_primary.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   class Cluster
     module Topology
-
       # Defines behavior when a cluster is in replica set topology,
       # and is a no primary which has been discovered by the driver.
       #

data/lib/mongo/cluster/topology/sharded.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   class Cluster
     module Topology
-
       # Defines behavior for when a cluster is in sharded topology.
       #
       # @since 2.0.0
@@ -28,7 +26,7 @@ module Mongo
         # The display name for the topology.
         #
         # @since 2.0.0
-        NAME = 'Sharded'.freeze
+        NAME = 'Sharded'
 
         # Get the display name.
         #
@@ -64,7 +62,9 @@ module Mongo
         # @return [ true ] A Sharded cluster always has a readable server.
         #
         # @since 2.4.0
-        def has_readable_server?(cluster, server_selector = nil); true; end
+        def has_readable_server?(_cluster, _server_selector = nil)
+          true
+        end
 
         # Determine if the topology would select a writable server for the
         # provided candidates.
@@ -77,7 +77,9 @@ module Mongo
         # @return [ true ] A Sharded cluster always has a writable server.
         #
         # @since 2.4.0
-        def has_writable_server?(cluster); true; end
+        def has_writable_server?(_cluster)
+          true
+        end
 
         # A sharded topology is not a replica set.
         #
@@ -87,7 +89,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def replica_set?; false; end
+        def replica_set?
+          false
+        end
 
         # Select appropriate servers for this topology.
         #
@@ -111,7 +115,9 @@ module Mongo
         # @return [ true ] Always true.
         #
         # @since 2.0.0
-        def sharded?; true; end
+        def sharded?
+          true
+        end
 
         # A sharded topology is not single.
         #
@@ -121,7 +127,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def single?; false; end
+        def single?
+          false
+        end
 
         # A sharded topology is not unknown.
         #
@@ -131,7 +139,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def unknown?; false; end
+        def unknown?
+          false
+        end
       end
     end
   end

data/lib/mongo/cluster/topology/single.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -18,16 +17,14 @@
 module Mongo
   class Cluster
     module Topology
-
       # Defines behavior for when a cluster is in single topology.
       #
       # @since 2.0.0
       class Single < Base
-
         # The display name for the topology.
         #
         # @since 2.0.0
-        NAME = 'Single'.freeze
+        NAME = 'Single'
 
         # Get the display name.
         #
@@ -63,7 +60,9 @@ module Mongo
         # @return [ true ] A standalone always has a readable server.
         #
         # @since 2.4.0
-        def has_readable_server?(cluster, server_selector = nil); true; end
+        def has_readable_server?(_cluster, _server_selector = nil)
+          true
+        end
 
         # Determine if the topology would select a writable server for the
         # provided candidates.
@@ -76,7 +75,9 @@ module Mongo
         # @return [ true ] A standalone always has a writable server.
         #
         # @since 2.4.0
-        def has_writable_server?(cluster); true; end
+        def has_writable_server?(_cluster)
+          true
+        end
 
         # A single topology is not a replica set.
         #
@@ -86,7 +87,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def replica_set?; false; end
+        def replica_set?
+          false
+        end
 
         # Select appropriate servers for this topology.
         #
@@ -98,7 +101,7 @@ module Mongo
         # @return [ Array<Server> ] The single servers.
         #
         # @since 2.0.0
-        def servers(servers, name = nil)
+        def servers(servers, _name = nil)
           servers.reject { |server| server.unknown? }
         end
 
@@ -110,7 +113,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def sharded?; false; end
+        def sharded?
+          false
+        end
 
         # A single topology is single.
         #
@@ -120,9 +125,11 @@ module Mongo
         # @return [ true ] Always true.
         #
         # @since 2.0.0
-        def single?; true; end
+        def single?
+          true
+        end
 
-        # An single topology is not unknown.
+        # A single topology is not unknown.
         #
         # @example Is the topology unknown?
         #   Single.unknown?
@@ -130,16 +137,19 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def unknown?; false; end
+        def unknown?
+          false
+        end
 
         private
 
         def validate_options(options, cluster)
           if cluster.servers_list.length > 1
-            raise ArgumentError, "Cannot instantiate a single topology with more than one server in the cluster: #{cluster.servers_list.map(&:address).map(&:seed).join(', ')}"
+            raise ArgumentError,
+                  "Cannot instantiate a single topology with more than one server in the cluster: #{cluster.servers_list.map(&:address).map(&:seed).join(', ')}"
           end
 
-          super(options, cluster)
+          super
         end
       end
     end

data/lib/mongo/cluster/topology/unknown.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   class Cluster
     module Topology
-
       # Defines behavior for when a cluster is in an unknown state.
       #
       # @since 2.0.0
@@ -28,7 +26,7 @@ module Mongo
         # The display name for the topology.
         #
         # @since 2.0.0
-        NAME = 'Unknown'.freeze
+        NAME = 'Unknown'
 
         # Get the display name.
         #
@@ -64,7 +62,9 @@ module Mongo
         # @return [ false ] An Unknown topology will never have a readable server.
         #
         # @since 2.4.0
-        def has_readable_server?(cluster, server_selector = nil); false; end
+        def has_readable_server?(_cluster, _server_selector = nil)
+          false
+        end
 
         # Determine if the topology would select a writable server for the
         # provided candidates.
@@ -77,7 +77,9 @@ module Mongo
         # @return [ false ] An Unknown topology will never have a writable server.
         #
         # @since 2.4.0
-        def has_writable_server?(cluster); false; end
+        def has_writable_server?(_cluster)
+          false
+        end
 
         # An unknown topology is not a replica set.
         #
@@ -87,7 +89,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def replica_set?; false; end
+        def replica_set?
+          false
+        end
 
         # Select appropriate servers for this topology.
         #
@@ -100,7 +104,7 @@ module Mongo
         #   unknown.
         #
         # @since 2.0.0
-        def servers(servers)
+        def servers(_servers)
           []
         end
 
@@ -112,7 +116,9 @@ module Mongo
         # @return [ false ] Always false.
         #
         # @since 2.0.0
-        def sharded?; false; end
+        def sharded?
+          false
+        end
 
         # An unknown topology is not single.
         #
@@ -122,7 +128,9 @@ module Mongo
         # @return [ true ] Always false.
         #
         # @since 2.0.0
-        def single?; false; end
+        def single?
+          false
+        end
 
         # An unknown topology is unknown.
         #
@@ -132,7 +140,9 @@ module Mongo
         # @return [ true ] Always true.
         #
         # @since 2.0.0
-        def unknown?; true; end
+        def unknown?
+          true
+        end
       end
     end
   end

data/lib/mongo/cluster/topology.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -90,30 +89,35 @@ module Mongo
       def initial(cluster, monitoring, options)
         connect = options[:connect]&.to_sym
         cls = if options[:direct_connection]
-          if connect && connect != :direct
-            raise ArgumentError, "Conflicting topology options: direct_connection=true and connect=#{connect}"
-          end
-          if options[:load_balanced]
-            raise ArgumentError, "Conflicting topology options: direct_connection=true and load_balanced=true"
-          end
-          Single
-        elsif options[:direct_connection] == false && connect && connect == :direct
-          raise ArgumentError, "Conflicting topology options: direct_connection=false and connect=#{connect}"
-        elsif connect && connect != :load_balanced
-          if options[:load_balanced]
-            raise ArgumentError, "Conflicting topology options: connect=#{options[:connect].inspect} and load_balanced=true"
-          end
-          OPTIONS.fetch(options[:connect].to_sym)
-        elsif options.key?(:replica_set) || options.key?(:replica_set_name)
-          if options[:load_balanced]
-            raise ArgumentError, "Conflicting topology options: replica_set/replica_set_name and load_balanced=true"
-          end
-          ReplicaSetNoPrimary
-        elsif options[:load_balanced] || connect == :load_balanced
-          LoadBalanced
-        else
-          Unknown
-        end
+                if connect && connect != :direct
+                  raise ArgumentError, "Conflicting topology options: direct_connection=true and connect=#{connect}"
+                end
+                if options[:load_balanced]
+                  raise ArgumentError, 'Conflicting topology options: direct_connection=true and load_balanced=true'
+                end
+
+                Single
+              elsif options[:direct_connection] == false && connect && connect == :direct
+                raise ArgumentError, "Conflicting topology options: direct_connection=false and connect=#{connect}"
+              elsif connect && connect != :load_balanced
+                if options[:load_balanced]
+                  raise ArgumentError,
+                        "Conflicting topology options: connect=#{options[:connect].inspect} and load_balanced=true"
+                end
+
+                OPTIONS.fetch(options[:connect].to_sym)
+              elsif options.key?(:replica_set) || options.key?(:replica_set_name)
+                if options[:load_balanced]
+                  raise ArgumentError,
+                        'Conflicting topology options: replica_set/replica_set_name and load_balanced=true'
+                end
+
+                ReplicaSetNoPrimary
+              elsif options[:load_balanced] || connect == :load_balanced
+                LoadBalanced
+              else
+                Unknown
+              end
         # Options here are client/cluster/server options.
         # In particular the replica set name key is different for
         # topology.