mongo 2.20.2 → 2.21.0

data/spec/integration/reconnect_spec.rb

@@ -111,10 +111,6 @@ describe 'Client after reconnect' do
       # thread.kill should've similarly failed, but it doesn't.
       fails_on_jruby
 
-      # odd failures related to async on ruby <= 3.1, I suspect something
-      # with how fibers worked in those versions.
-      minimum_mri_version '3.2.0'
-
       it 'recreates SRV monitor' do
         wait_for_discovery
 
@@ -155,10 +151,6 @@ describe 'Client after reconnect' do
       # NotImplementedError: recvmsg_nonblock is not implemented
       fails_on_jruby
 
-      # odd failures related to async on ruby <= 3.1, I suspect something
-      # with how fibers worked in those versions.
-      minimum_mri_version '3.2.0'
-
       let(:uri) do
         "mongodb+srv://test-fake.test.build.10gen.cc/"
       end
@@ -189,6 +181,8 @@ describe 'Client after reconnect' do
       end
 
       around do |example|
+        require 'support/dns'
+
         rules = [
           ['_mongodb._tcp.test-fake.test.build.10gen.cc', :srv,
             [0, 0, 2799, 'localhost.test.build.10gen.cc'],

data/spec/integration/retryable_errors_spec.rb

@@ -83,7 +83,7 @@ describe 'Failing retryable operations' do
 
         begin
           collection.find(a: 1).to_a
-        rescue Mongo::Error::OperationFailure => exception
+        rescue Mongo::Error::OperationFailure::Family => exception
         else
           fail('Expected operation to fail')
         end
@@ -128,7 +128,7 @@ describe 'Failing retryable operations' do
 
         begin
           collection.insert_one(a: 1)
-        rescue Mongo::Error::OperationFailure => exception
+        rescue Mongo::Error::OperationFailure::Family => exception
         else
           fail('Expected operation to fail')
         end

data/spec/integration/sdam_error_handling_spec.rb

@@ -420,7 +420,8 @@ describe 'SDAM error handling' do
         expect_server_state_change
       end
 
-      it_behaves_like 'marks server unknown and clears connection pool'
+      # https://jira.mongodb.org/browse/RUBY-2523
+      # it_behaves_like 'marks server unknown and clears connection pool'
 
       after do
         admin_client.command(configureFailPoint: 'failCommand', mode: 'off')

data/spec/integration/search_indexes_prose_spec.rb

@@ -87,6 +87,10 @@ describe 'Mongo::Collection#search_indexes prose tests' do
   let(:definition) { { 'mappings' => { 'dynamic' => false } } }
   let(:create_index) { helper.collection.search_indexes.create_one(definition, name: name) }
 
+  after do
+    client.close
+  end
+
   # Case 1: Driver can successfully create and list search indexes
   context 'when creating and listing search indexes' do
     let(:index) { helper.wait_for(name).first }

data/spec/integration/server_spec.rb

@@ -6,6 +6,7 @@ require 'spec_helper'
 describe 'Server' do
   let(:client) { authorized_client }
 
+  let(:context) { Mongo::Operation::Context.new(client: client) }
   let(:server) { client.cluster.next_primary }
 
   let(:collection) { client['collection'] }
@@ -15,7 +16,7 @@ describe 'Server' do
     context 'it performs read operations and receives the correct result type' do
       context 'normal server' do
         it 'can be used for reads' do
-          result = view.send(:send_initial_query, server)
+          result = view.send(:send_initial_query, server, context)
           expect(result).to be_a(Mongo::Operation::Find::Result)
         end
       end
@@ -35,7 +36,7 @@ describe 'Server' do
 
         it 'can be used for reads' do
           # See also RUBY-3102.
-          result = view.send(:send_initial_query, server)
+          result = view.send(:send_initial_query, server, context)
           expect(result).to be_a(Mongo::Operation::Find::Result)
         end
       end
@@ -57,7 +58,7 @@ describe 'Server' do
         it 'is unusable' do
           # See also RUBY-3102.
           lambda do
-            view.send(:send_initial_query, server)
+            view.send(:send_initial_query, server, context)
           end.should raise_error(Mongo::Error::ServerNotUsable)
         end
       end

data/spec/integration/srv_monitoring_spec.rb

@@ -76,8 +76,9 @@ describe 'SRV Monitoring' do
     # NotImplementedError: recvmsg_nonblock is not implemented
     fails_on_jruby
 
-    # mock dns implementation doesn't play nice with 2.7, etc.
-    minimum_mri_version '3.0.0'
+    before(:all) do
+      require 'support/dns'
+    end
 
     around do |example|
       # Speed up the tests by listening on the fake ports we are using.

data/spec/integration/srv_spec.rb

@@ -12,6 +12,10 @@ describe 'SRV lookup' do
     # NotImplementedError: recvmsg_nonblock is not implemented
     fails_on_jruby
 
+    before(:all) do
+      require 'support/dns'
+    end
+
     let(:uri) do
       "mongodb+srv://test-fake.test.build.10gen.cc/?tls=#{SpecConfig.instance.ssl?}&tlsInsecure=true"
     end

data/spec/integration/transactions_api_examples_spec.rb

@@ -58,5 +58,7 @@ describe 'Transactions API examples' do
 
     # End Transactions withTxn API Example 1
 
+    # Do not leak clients.
+    client.close
   end
 end

data/spec/kerberos/kerberos_spec.rb

@@ -20,6 +20,10 @@ describe 'kerberos authentication' do
     end
   end
 
+  after do
+    client&.close
+  end
+
   let(:user) do
    "#{require_env_value('SASL_USER')}%40#{realm}"
   end

data/spec/lite_spec_helper.rb

@@ -22,7 +22,9 @@ CMAP_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/cmap/*.yml").sort.select
   !defined?(JRUBY_VERSION) || !f.include?('pool-checkout-minPoolSize-connection-maxConnecting.yml')
 end
 AUTH_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/auth/*.yml").sort
-CLIENT_SIDE_ENCRYPTION_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/client_side_encryption/*.yml").sort
+CLIENT_SIDE_ENCRYPTION_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/client_side_encryption/*.yml").sort.delete_if do |spec|
+  ![ 1, '1', 'yes', 'true' ].include?(ENV['CSOT_SPEC_TESTS']) && spec =~ /.*timeoutMS.yml$/
+end
 
 # Disable output buffering: https://www.rubyguides.com/2019/02/ruby-io/
 STDOUT.sync = true

data/spec/mongo/auth/user/view_spec.rb

@@ -526,7 +526,7 @@ describe Mongo::Auth::User::View do
       it "raises and reports the write concern error correctly" do
         begin
           view.send(method, input)
-        rescue Mongo::Error::OperationFailure => e
+        rescue Mongo::Error::OperationFailure::Family => e
           expect(e.write_concern_error?).to be true
           expect(e.write_concern_error_document).to eq(
             "code" => 64,

data/spec/mongo/caching_cursor_spec.rb

@@ -23,7 +23,7 @@ describe Mongo::CachingCursor do
   end
 
   let(:reply) do
-    view.send(:send_initial_query, server)
+    view.send(:send_initial_query, server, Mongo::Operation::Context.new(client: authorized_client))
   end
 
   let(:cursor) do

data/spec/mongo/client_encryption_spec.rb

@@ -303,6 +303,7 @@ describe Mongo::ClientEncryption do
         end
 
         it 'raises a KmsError' do
+          skip 'https://jira.mongodb.org/browse/RUBY-3375'
           expect do
             data_key_id
           end.to raise_error(Mongo::Error::KmsError, /Error while connecting to socket/)

data/spec/mongo/client_spec.rb

@@ -561,6 +561,75 @@ describe Mongo::Client do
         expect(command['comment']).to eq('comment')
       end
     end
+
+    context 'with timeout_ms' do
+      # To make it easier with failCommand
+      require_topology :single
+      min_server_version '4.4'
+
+      before do
+        root_authorized_client.use('admin').command({
+          configureFailPoint: "failCommand",
+          mode: "alwaysOn",
+          data: {
+              failCommands: ["listDatabases"],
+              blockConnection: true,
+              blockTimeMS: 100
+            }
+        })
+      end
+
+      after do
+        root_authorized_client.use('admin').command({
+          configureFailPoint: "failCommand",
+          mode: "off"
+        })
+      end
+
+      context 'when timeout_ms is set on command level' do
+        context 'when there is not enough time' do
+          it 'raises' do
+            expect do
+              monitored_client.database_names({}, timeout_ms: 50)
+            end.to raise_error(Mongo::Error::TimeoutError)
+          end
+        end
+
+        context 'when there is enough time' do
+          it 'does not raise' do
+            expect do
+              monitored_client.database_names({}, timeout_ms: 200)
+            end.not_to raise_error
+          end
+        end
+      end
+
+      context 'when timeout_ms is set on client level' do
+        context 'when there is not enough time' do
+          let(:client) do
+            root_authorized_client.with(timeout_ms: 50)
+          end
+
+          it 'raises' do
+            expect do
+              client.database_names({})
+            end.to raise_error(Mongo::Error::TimeoutError)
+          end
+        end
+
+        context 'when there is enough time' do
+          let(:client) do
+            root_authorized_client.with(timeout_ms: 200)
+          end
+
+          it 'does not raise' do
+            expect do
+              monitored_client.database_names({})
+            end.not_to raise_error
+          end
+        end
+      end
+    end
   end
 
   describe '#list_databases' do
@@ -572,8 +641,6 @@ describe Mongo::Client do
     end
 
     context 'when filter criteria is present' do
-      min_server_fcv '3.6'
-
       include_context 'ensure test db exists'
 
       let(:result) do
@@ -591,8 +658,6 @@ describe Mongo::Client do
     end
 
     context 'when name_only is true' do
-      min_server_fcv '3.6'
-
       let(:command) do
         Utils.get_command_event(root_authorized_client, 'listDatabases') do |client|
           client.list_databases({}, true)
@@ -667,6 +732,75 @@ describe Mongo::Client do
         expect(command['comment']).to eq('comment')
       end
     end
+
+    context 'with timeout_ms' do
+      # To make it easier with failCommand
+      require_topology :single
+      min_server_version '4.4'
+
+      before do
+        root_authorized_client.use('admin').command({
+          configureFailPoint: "failCommand",
+          mode: "alwaysOn",
+          data: {
+              failCommands: ["listDatabases"],
+              blockConnection: true,
+              blockTimeMS: 100
+            }
+        })
+      end
+
+      after do
+        root_authorized_client.use('admin').command({
+          configureFailPoint: "failCommand",
+          mode: "off"
+        })
+      end
+
+      context 'when timeout_ms is set on command level' do
+        context 'when there is not enough time' do
+          it 'raises' do
+            expect do
+              monitored_client.list_databases({}, false, timeout_ms: 50)
+            end.to raise_error(Mongo::Error::TimeoutError)
+          end
+        end
+
+        context 'when there is enough time' do
+          it 'does not raise' do
+            expect do
+              monitored_client.list_databases({}, false, timeout_ms: 200)
+            end.not_to raise_error
+          end
+        end
+      end
+
+      context 'when timeout_ms is set on client level' do
+        context 'when there is not enough time' do
+          let(:client) do
+            root_authorized_client.with(timeout_ms: 50)
+          end
+
+          it 'raises' do
+            expect do
+              client.list_databases({})
+            end.to raise_error(Mongo::Error::TimeoutError)
+          end
+        end
+
+        context 'when there is enough time' do
+          let(:client) do
+            root_authorized_client.with(timeout_ms: 200)
+          end
+
+          it 'does not raise' do
+            expect do
+              monitored_client.list_databases({})
+            end.not_to raise_error
+          end
+        end
+      end
+    end
   end
 
   describe '#list_mongo_databases' do
@@ -1156,6 +1290,26 @@ describe Mongo::Client do
         }.to raise_exception(Mongo::Error::InvalidSession)
       end
     end
+
+    context 'when CSOT is set on the client' do
+      require_topology :replica_set
+
+      let(:timeout_ms) { 10 }
+
+      let(:timeout_sec) { timeout_ms / 1_000.0 }
+
+      let(:client) do
+        authorized_client.with(timeout_ms: timeout_ms)
+      end
+
+      it 'uses CSOT timeout set on the client' do
+        expect_any_instance_of(Mongo::ServerSelector::PrimaryPreferred).to(
+          receive(:select_server).with(anything, {timeout: timeout_sec}).and_call_original
+        )
+
+        client.start_session
+      end
+    end
   end
 
   describe '#summary' do

data/spec/mongo/collection/view/aggregation_spec.rb

@@ -156,8 +156,6 @@ describe Mongo::Collection::View::Aggregation do
     end
 
     context 'when the initial response has no results but an active cursor' do
-      min_server_fcv '3.2'
-
       let(:documents) do
         [
             { city: 'a'*6000000 },
@@ -166,7 +164,7 @@ describe Mongo::Collection::View::Aggregation do
       end
 
       let(:options) do
-        { :use_cursor => true }
+        {}
       end
 
       let(:pipeline) do
@@ -486,48 +484,25 @@ describe Mongo::Collection::View::Aggregation do
       end
     end
 
-    context 'when use_cursor is set' do
-
-      context 'when use_cursor is true' do
-
-        context 'when batch_size is set' do
-
-          let(:options) do
-            { :use_cursor => true,
-              :batch_size => 10
-            }
-          end
-
-          it 'sets a batch size document in the spec' do
-            expect(aggregation_spec[:selector][:cursor][:batchSize]).to eq(options[:batch_size])
-          end
-        end
-
-        context 'when batch_size is not set' do
-
-          let(:options) do
-            { :use_cursor => true }
-          end
+    context 'when batch_size is set' do
 
-          it 'sets an empty document in the spec' do
-            expect(aggregation_spec[:selector][:cursor]).to eq({})
-          end
-        end
+      let(:options) do
+        { :batch_size => 10 }
+      end
 
+      it 'sets a batch size document in the spec' do
+        expect(aggregation_spec[:selector][:cursor][:batchSize]).to eq(options[:batch_size])
       end
+    end
 
-      context 'when use_cursor is false' do
+    context 'when batch_size is not set' do
 
-        let(:options) do
-          { :use_cursor => false }
-        end
-
-        context 'when batch_size is set' do
+      let(:options) do
+        {}
+      end
 
-          it 'does not set the cursor option in the spec' do
-            expect(aggregation_spec[:selector][:cursor]).to be_nil
-          end
-        end
+      it 'sets an empty document in the spec' do
+        expect(aggregation_spec[:selector][:cursor]).to eq({})
       end
     end
   end

data/spec/mongo/collection/view/change_stream_spec.rb

@@ -507,7 +507,7 @@ describe Mongo::Collection::View::ChangeStream do
       end
 
       it 'includes the max_await_time value in the formatted string' do
-        expect(change_stream.inspect).to include({ max_await_time_ms: 10 }.to_s)
+        expect(change_stream.inspect).to include({ 'max_await_time_ms' => 10 }.to_s)
       end
     end
 
@@ -518,7 +518,7 @@ describe Mongo::Collection::View::ChangeStream do
       end
 
       it 'includes the batch_size value in the formatted string' do
-        expect(change_stream.inspect).to include({ batch_size: 5 }.to_s)
+        expect(change_stream.inspect).to include({ 'batch_size' => 5 }.to_s)
       end
     end
 
@@ -529,7 +529,7 @@ describe Mongo::Collection::View::ChangeStream do
       end
 
       it 'includes the collation value in the formatted string' do
-        expect(change_stream.inspect).to include({ 'collation' => { locale: 'en_US', strength: 2 } }.to_s)
+        expect(change_stream.inspect).to include({ 'collation' => { 'locale' => 'en_US', 'strength' => 2 } }.to_s)
       end
     end
 

data/spec/mongo/collection_spec.rb

@@ -828,13 +828,12 @@ describe Mongo::Collection do
 
         let(:enum) { change_stream.to_enum }
 
+        let(:get_more) { subscriber.started_events.detect { |e| e.command['getMore'] }.command }
+
         it 'sets the option correctly' do
-          expect(change_stream.instance_variable_get(:@cursor)).to receive(:get_more_operation).once.and_wrap_original do |m, *args, &block|
-            m.call(*args).tap do |op|
-              expect(op.max_time_ms).to eq(3000)
-            end
-          end
-          enum.next
+          enum.try_next
+          expect(get_more).not_to be_nil
+          expect(get_more['maxTimeMS']).to be == 3000
         end
 
         it "waits the appropriate amount of time" do

data/spec/mongo/crypt/auto_encrypter_spec.rb

@@ -58,6 +58,8 @@ describe Mongo::Crypt::AutoEncrypter do
     )
   end
 
+  let(:operation_context) { Mongo::Operation::Context.new }
+
   shared_context 'with jsonSchema validator' do
     before do
       users_collection = client.use(db_name)[collection_name]
@@ -81,14 +83,14 @@ describe Mongo::Crypt::AutoEncrypter do
   shared_examples 'a functioning auto encrypter' do
     describe '#encrypt' do
       it 'replaces the ssn field with a BSON::Binary' do
-        result = auto_encrypter.encrypt(db_name, command)
+        result = auto_encrypter.encrypt(db_name, command, operation_context)
         expect(result).to eq(encrypted_command)
       end
     end
 
     describe '#decrypt' do
       it 'returns the unencrypted document' do
-        result = auto_encrypter.decrypt(encrypted_command)
+        result = auto_encrypter.decrypt(encrypted_command, operation_context)
         expect(result).to eq(command)
       end
     end
@@ -329,14 +331,14 @@ describe Mongo::Crypt::AutoEncrypter do
 
       describe '#encrypt' do
         it 'does not perform encryption' do
-          result = auto_encrypter.encrypt(db_name, command)
+          result = auto_encrypter.encrypt(db_name, command, operation_context)
           expect(result).to eq(command)
         end
       end
 
       describe '#decrypt' do
         it 'still performs decryption' do
-          result = auto_encrypter.decrypt(encrypted_command)
+          result = auto_encrypter.decrypt(encrypted_command, operation_context)
           expect(result).to eq(command)
         end
       end
@@ -347,14 +349,14 @@ describe Mongo::Crypt::AutoEncrypter do
 
       describe '#encrypt' do
         it 'does not perform encryption' do
-          result = auto_encrypter.encrypt(db_name, command)
+          result = auto_encrypter.encrypt(db_name, command, operation_context)
           expect(result).to eq(command)
         end
       end
 
       describe '#decrypt' do
         it 'still performs decryption' do
-          result = auto_encrypter.decrypt(encrypted_command)
+          result = auto_encrypter.decrypt(encrypted_command, operation_context)
           expect(result).to eq(command)
         end
       end
@@ -365,14 +367,14 @@ describe Mongo::Crypt::AutoEncrypter do
 
       describe '#encrypt' do
         it 'does not perform encryption' do
-          result = auto_encrypter.encrypt(db_name, command)
+          result = auto_encrypter.encrypt(db_name, command, operation_context)
           expect(result).to eq(command)
         end
       end
 
       describe '#decrypt' do
         it 'still performs decryption' do
-          result = auto_encrypter.decrypt(encrypted_command)
+          result = auto_encrypter.decrypt(encrypted_command, operation_context)
           expect(result).to eq(command)
         end
       end
@@ -383,14 +385,14 @@ describe Mongo::Crypt::AutoEncrypter do
 
       describe '#encrypt' do
         it 'does not perform encryption' do
-          result = auto_encrypter.encrypt(db_name, command)
+          result = auto_encrypter.encrypt(db_name, command, operation_context)
           expect(result).to eq(command)
         end
       end
 
       describe '#decrypt' do
         it 'still performs decryption' do
-          result = auto_encrypter.decrypt(encrypted_command)
+          result = auto_encrypter.decrypt(encrypted_command, operation_context)
           expect(result).to eq(command)
         end
       end
@@ -401,14 +403,14 @@ describe Mongo::Crypt::AutoEncrypter do
 
       describe '#encrypt' do
         it 'does not perform encryption' do
-          result = auto_encrypter.encrypt(db_name, command)
+          result = auto_encrypter.encrypt(db_name, command, operation_context)
           expect(result).to eq(command)
         end
       end
 
       describe '#decrypt' do
         it 'still performs decryption' do
-          result = auto_encrypter.decrypt(encrypted_command)
+          result = auto_encrypter.decrypt(encrypted_command, operation_context)
           expect(result).to eq(command)
         end
       end

data/spec/mongo/crypt/data_key_context_spec.rb

@@ -136,8 +136,10 @@ describe Mongo::Crypt::DataKeyContext do
         )
       end
 
+      let(:operation_context) { Mongo::Operation::Context.new }
+
       it 'creates a data key' do
-        expect(context.run_state_machine).to be_a_kind_of(Hash)
+        expect(context.run_state_machine(operation_context)).to be_a_kind_of(Hash)
       end
     end
   end

data/spec/mongo/crypt/explicit_encryption_context_spec.rb

@@ -139,7 +139,7 @@ describe Mongo::Crypt::ExplicitEncryptionContext do
               value,
               options.merge(query_type: "equality")
             )
-          end.to raise_error(ArgumentError, /query_type is allowed only for "Indexed" or "RangePreview" algorithm/)
+          end.to raise_error(ArgumentError, /query_type is allowed only for "Indexed" or "Range" algorithm/)
         end
       end
 
@@ -154,7 +154,7 @@ describe Mongo::Crypt::ExplicitEncryptionContext do
               value,
               options.merge(contention_factor: 10)
             )
-          end.to raise_error(ArgumentError, /contention_factor is allowed only for "Indexed" or "RangePreview" algorithm/)
+          end.to raise_error(ArgumentError, /contention_factor is allowed only for "Indexed" or "Range" algorithm/)
         end
       end
 

data/spec/mongo/crypt/handle_spec.rb

@@ -188,7 +188,7 @@ describe Mongo::Crypt::Handle do
         end
 
         it 'raises an exception' do
-          expect { handle }.to raise_error(Mongo::Error::CryptError, 'local key must be 96 bytes (libmongocrypt error code 1)')
+          expect { handle }.to raise_error(Mongo::Error::CryptError, /local key must be 96 bytes \(libmongocrypt error code 1\)/)
         end
       end