mongo 2.18.2 → 2.19.3

data/spec/integration/transactions_examples_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/integration/truncated_utf8_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/integration/versioned_api_examples_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -98,7 +98,7 @@ describe 'Versioned API examples' do
       # Start Versioned API Example 6
 
       # Mongo::Error::OperationFailure:
-      #   [323:APIStrictError]: Provided apiStrict:true, but the command count is not in API Version 1. Information on supported commands and migrations in API Version 1 can be found at https://dochub.mongodb.org/core/manual-versioned-api
+      #   [323:APIStrictError]: Provided apiStrict:true, but the command count is not in API Version 1. Information on supported commands and migrations in API Version 1 can be found at https://www.mongodb.com/docs/manual/reference/stable-api
 
       # End Versioned API Example 6
 

data/spec/integration/x509_auth_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/integration/zlib_compression_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/integration/zstd_compression_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/kerberos/kerberos_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/lite_spec_helper.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "shared", "lib"))
 
@@ -16,7 +16,11 @@ GRIDFS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/gridfs/*.yml").sort
 TRANSACTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions/*.yml").sort
 TRANSACTIONS_API_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions_api/*.yml").sort
 CHANGE_STREAMS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/change_streams/*.yml").sort
-CMAP_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/cmap/*.yml").sort
+CMAP_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/cmap/*.yml").sort.select do |f|
+  # Skip tests that are flaky on JRuby.
+  # https://jira.mongodb.org/browse/RUBY-3292
+  !defined?(JRUBY_VERSION) || !f.include?('pool-checkout-minPoolSize-connection-maxConnecting.yml')
+end
 AUTH_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/auth/*.yml").sort
 CLIENT_SIDE_ENCRYPTION_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/client_side_encryption/*.yml").sort
 
@@ -102,6 +106,31 @@ Mrss.patch_mongo_for_session_registry
 
 class ExampleTimeout < StandardError; end
 
+STANDARD_TIMEOUTS = {
+  stress: 210,
+  jruby: 90,
+  default: 45,
+}.freeze
+
+def timeout_type
+  if ENV['EXAMPLE_TIMEOUT'].to_i > 0
+    :custom
+  elsif %w(1 true yes).include?(ENV['STRESS']&.downcase)
+    :stress
+  elsif BSON::Environment.jruby?
+    :jruby
+  else
+    :default
+  end
+end
+
+def example_timeout_seconds
+  STANDARD_TIMEOUTS.fetch(
+    timeout_type,
+    (ENV['EXAMPLE_TIMEOUT'] || STANDARD_TIMEOUTS[:default]).to_i
+  )
+end
+
 RSpec.configure do |config|
   config.extend(CommonShortcuts::ClassMethods)
   config.include(CommonShortcuts::InstanceMethods)
@@ -110,6 +139,21 @@ RSpec.configure do |config|
   config.include(MongosMacros)
   config.extend(Mongo::Macros)
 
+  # Used for spec/solo/*
+  def require_solo
+    before(:all) do
+      unless %w(1 true yes).include?(ENV['SOLO'])
+        skip 'Set SOLO=1 in environment to run solo tests'
+      end
+    end
+  end
+
+  def require_atlas
+    before do
+      skip 'Set ATLAS_URI in environment to run atlas tests' if ENV['ATLAS_URI'].nil?
+    end
+  end
+
   if SpecConfig.instance.ci?
     SdamFormatterIntegration.subscribe
     config.add_formatter(JsonExtFormatter, File.join(File.dirname(__FILE__), '../tmp/rspec.json'))
@@ -128,16 +172,7 @@ RSpec.configure do |config|
     # Tests should take under 10 seconds ideally but it seems
     # we have some that run for more than 10 seconds in CI.
     config.around(:each) do |example|
-      timeout = if %w(1 true yes).include?(ENV['STRESS']&.downcase)
-        210
-      else
-        if BSON::Environment.jruby?
-          90
-        else
-          45
-        end
-      end
-      TimeoutInterrupt.timeout(timeout, ExampleTimeout) do
+      TimeoutInterrupt.timeout(example_timeout_seconds, ExampleTimeout) do
         example.run
       end
     end

data/spec/mongo/address/ipv4_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/address/ipv6_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/address/unix_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/address/validator_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/address_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -293,6 +293,12 @@ describe Mongo::Address do
             expect(socket.getsockopt(Socket::IPPROTO_TCP, Socket::TCP_KEEPIDLE).int).to be <= 120
           end
         end
+
+        if Socket.const_defined?(:TCP_USER_TIMEOUT)
+          it 'sets the socket TCP_KEEPIDLE option' do
+            expect(socket.getsockopt(Socket::IPPROTO_TCP, Socket::TCP_USER_TIMEOUT).int).to be <= 210
+          end
+        end
       end
     end
 
@@ -305,7 +311,7 @@ describe Mongo::Address do
         RSpec::Mocks.with_temporary_scope do
           resolved_address = double('address')
           # This test's expectation
-          expect(resolved_address).to receive(:socket).with(0, connect_timeout: 10)
+          expect(resolved_address).to receive(:socket).with(0, {connect_timeout: 10})
 
           expect(Mongo::Address::IPv4).to receive(:new).and_return(resolved_address)
 

data/spec/mongo/auth/aws/credential_cache_spec.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require 'lite_spec_helper'
+
+describe Mongo::Auth::Aws::CredentialsCache do
+  let(:subject) do
+    described_class.new
+  end
+
+  describe '#fetch' do
+    context 'when credentials are not cached' do
+      it 'yields to the block' do
+        expect { |b| subject.fetch(&b) }.to yield_control
+      end
+
+      it 'sets the credentials' do
+        credentials = double('credentials')
+        subject.fetch { credentials }
+        expect(subject.credentials).to eq(credentials)
+      end
+    end
+
+    context 'when credentials are cached' do
+      context 'when credentials are not expired' do
+        let(:credentials) do
+          double('credentials', expired?: false)
+        end
+
+        it 'does not yield to the block' do
+          subject.credentials = credentials
+          expect { |b| subject.fetch(&b) }.not_to yield_control
+        end
+      end
+    end
+
+    context 'when credentials are expired' do
+      let(:credentials) do
+        double('credentials', expired?: true)
+      end
+
+      it 'yields to the block' do
+        subject.credentials = credentials
+        expect { |b| subject.fetch(&b) }.to yield_control
+      end
+
+      it 'sets the credentials' do
+        subject.credentials = credentials
+        new_credentials = double('new credentials')
+        subject.fetch { new_credentials }
+        expect(subject.credentials).to eq(new_credentials)
+      end
+    end
+  end
+
+  describe '#clear' do
+    it 'clears the credentials' do
+      subject.credentials = double('credentials')
+      subject.clear
+      expect(subject.credentials).to be nil
+    end
+  end
+end

data/spec/mongo/auth/aws/credentials_retriever_spec.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require 'lite_spec_helper'
+
+describe Mongo::Auth::Aws::CredentialsRetriever do
+  describe '#credentials' do
+    context 'when credentials should be obtained from endpoints' do
+      let(:cache) do
+        Mongo::Auth::Aws::CredentialsCache.new
+      end
+
+      let(:subject) do
+        described_class.new(credentials_cache: cache).tap do |retriever|
+          allow(retriever).to receive(:credentials_from_environment).and_return(nil)
+        end
+      end
+
+      context 'when cached credentials are not expired' do
+        let(:credentials) do
+          double('credentials', expired?: false)
+        end
+
+        before(:each) do
+          cache.credentials = credentials
+        end
+
+        it 'returns the cached credentials' do
+          expect(subject.credentials).to eq(credentials)
+        end
+
+        it 'does not obtain credentials from endpoints' do
+          expect(subject).not_to receive(:obtain_credentials_from_endpoints)
+          described_class.new(credentials_cache: cache).credentials
+        end
+      end
+
+      shared_examples_for 'obtains credentials from endpoints' do
+        context 'when obtained credentials are not expired' do
+          let(:credentials) do
+            double('credentials', expired?: false)
+          end
+
+          before(:each) do
+            expect(subject)
+              .to receive(:obtain_credentials_from_endpoints)
+              .and_return(credentials)
+          end
+
+          it 'returns the obtained credentials' do
+            expect(subject.credentials).not_to be_expired
+          end
+
+          it 'caches the obtained credentials' do
+            subject.credentials
+            expect(cache.credentials).to eq(credentials)
+          end
+        end
+
+        context 'when cannot obtain credentials from endpoints' do
+          before(:each) do
+            expect(subject)
+              .to receive(:obtain_credentials_from_endpoints)
+              .and_return(nil)
+          end
+
+          it 'raises an error' do
+            expect { subject.credentials }.to raise_error(Mongo::Auth::Aws::CredentialsNotFound)
+          end
+        end
+      end
+
+      context 'when cached credentials expired' do
+        before(:each) do
+          cache.credentials = double('credentials', expired?: true)
+        end
+
+        it_behaves_like 'obtains credentials from endpoints'
+      end
+
+      context 'when no credentials cached' do
+        before(:each) do
+          cache.clear
+        end
+
+        it_behaves_like 'obtains credentials from endpoints'
+      end
+    end
+  end
+end

data/spec/mongo/auth/aws/credentials_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require 'lite_spec_helper'
+
+describe Mongo::Auth::Aws::Credentials do
+  describe '#expired?' do
+    context 'when expiration is nil' do
+      let(:credentials) do
+        described_class.new('access_key_id', 'secret_access_key', nil, nil)
+      end
+
+      it 'returns false' do
+        expect(credentials.expired?).to be false
+      end
+    end
+
+    context 'when expiration is not nil' do
+      before do
+        Timecop.freeze
+      end
+      after do
+        Timecop.return
+      end
+      context 'when the expiration is more than five minutes away' do
+        let(:credentials) do
+          described_class.new('access_key_id', 'secret_access_key', nil, Time.now.utc + 400)
+        end
+
+        it 'returns false' do
+          expect(credentials.expired?).to be false
+        end
+      end
+
+      context 'when the expiration is less than five minutes away' do
+        let(:credentials) do
+          described_class.new('access_key_id', 'secret_access_key', nil, Time.now.utc + 200)
+        end
+
+        it 'returns true' do
+          expect(credentials.expired?).to be true
+        end
+      end
+    end
+  end
+end

data/spec/mongo/auth/aws/request_region_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/auth/aws/request_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/auth/cr_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 require 'support/shared/auth_context'
@@ -19,6 +19,7 @@ describe Mongo::Auth::CR do
     end
 
     context 'when the user is not authorized' do
+      max_server_fcv "4.0"
 
       let(:user) do
         Mongo::Auth::User.new(
@@ -44,7 +45,6 @@ describe Mongo::Auth::CR do
 
       context 'when compression is used' do
         require_compression
-        min_server_fcv '3.6'
 
         it 'does not compress the message' do
           expect(Mongo::Protocol::Compressed).not_to receive(:new)
@@ -55,24 +55,4 @@ describe Mongo::Auth::CR do
       end
     end
   end
-
-  context 'when the user is authorized for the database' do
-    max_server_fcv '2.6'
-
-    before do
-      connection.connect!
-    end
-
-    let(:cr) do
-      described_class.new(root_user, connection)
-    end
-
-    let(:login) do
-      cr.login
-    end
-
-    it 'logs the user into the connection' do
-      expect(login['ok']).to eq(1)
-    end
-  end
 end

data/spec/mongo/auth/gssapi/conversation_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/auth/invalid_mechanism_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/auth/ldap/conversation_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/auth/ldap_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 require 'support/shared/auth_context'

data/spec/mongo/auth/scram/conversation_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require 'support/shared/scram_conversation'

data/spec/mongo/auth/scram256/conversation_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require 'support/shared/scram_conversation'

data/spec/mongo/auth/scram_negotiation_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/auth/scram_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 require 'support/shared/auth_context'

data/spec/mongo/auth/stringprep/profiles/sasl_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/auth/stringprep_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/auth/user/view_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -486,4 +486,99 @@ describe Mongo::Auth::User::View do
       end
     end
   end
+
+  context "when the result is a write concern error" do
+    require_topology :replica_set
+    min_server_version '4.0'
+
+    let(:user) do
+      Mongo::Auth::User.new({
+        user: 'user',
+        roles: [ Mongo::Auth::Roles::READ_WRITE ],
+        password: 'password'
+      })
+    end
+
+    before do
+      authorized_client.use('admin').database.command(
+        configureFailPoint: "failCommand",
+        mode: { times: 1 },
+        data: {
+          failCommands: [ failCommand ],
+          writeConcernError: {
+              code: 64,
+              codeName: "WriteConcernFailed",
+              errmsg: "waiting for replication timed out",
+              errInfo: { wtimeout: true }
+          }
+        }
+      )
+    end
+
+    shared_examples "raises the correct write concern error" do
+
+      it "raises a write concern error" do
+        expect do
+          view.send(method, input)
+        end.to raise_error(Mongo::Error::OperationFailure, /[64:WriteConcernFailed]/)
+      end
+
+      it "raises and reports the write concern error correctly" do
+        begin
+          view.send(method, input)
+        rescue Mongo::Error::OperationFailure => e
+          expect(e.write_concern_error?).to be true
+          expect(e.write_concern_error_document).to eq(
+            "code" => 64,
+            "codeName" => "WriteConcernFailed",
+            "errmsg" => "waiting for replication timed out",
+            "errInfo" => { "wtimeout" => true }
+          )
+        end
+      end
+    end
+
+    context "when creating a user" do
+
+      let(:failCommand) { "createUser" }
+      let(:method) { :create }
+      let(:input) { user }
+
+      after do
+        view.remove(user.name)
+      end
+
+      include_examples "raises the correct write concern error"
+    end
+
+    context "when updating a user" do
+
+      let(:failCommand) { "updateUser" }
+      let(:method) { :update }
+      let(:input) { user.name }
+
+      before do
+        view.create(user)
+      end
+
+      after do
+        view.remove(user.name)
+      end
+
+      include_examples "raises the correct write concern error"
+    end
+
+    context "when removing a user" do
+
+      let(:failCommand) { "dropUser" }
+      let(:method) { :remove }
+      let(:input) { user.name }
+
+      before do
+        view.create(user)
+      end
+
+      include_examples "raises the correct write concern error"
+    end
+  end
 end

data/spec/mongo/auth/user_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'