mongo 2.18.2 → 2.19.1

data/spec/spec_tests/data/cmap/pool-close-destroy-conns.yml

@@ -2,6 +2,7 @@ version: 1
 style: unit
 description: When a pool is closed, it MUST first destroy all available connections in that pool
 operations:
+  - name: ready
   - name: checkOut
   - name: checkOut
     label: conn
@@ -21,6 +22,7 @@ events:
     address: 42
 ignore:
   - ConnectionCreated
+  - ConnectionPoolReady
   - ConnectionReady
   - ConnectionPoolCreated
   - ConnectionCheckOutStarted

data/spec/spec_tests/data/cmap/pool-create-max-size.yml

@@ -4,6 +4,7 @@ description: must never exceed maxPoolSize total connections
 poolOptions:
   maxPoolSize: 3
 operations:
+  - name: ready
   - name: checkOut
     label: conn1
   - name: checkOut
@@ -69,3 +70,4 @@ events:
     address: 42
 ignore:
   - ConnectionReady
+  - ConnectionPoolReady

data/spec/spec_tests/data/cmap/pool-create-min-size-error.yml

@@ -0,0 +1,43 @@
+version: 1
+style: integration
+description: error during minPoolSize population clears pool
+runOn:
+  -
+    # required for appName in fail point
+    minServerVersion: "4.9.0"
+  # Remove the topology runOn requirement when cmap specs are adjusted for lbs
+  - topology: [ "single", "replicaset", "sharded" ]
+failPoint:
+  configureFailPoint: failCommand
+  # high amount to ensure not interfered with by monitor checks.
+  mode: { times: 50 }
+  data:
+    failCommands: ["isMaster","hello"]
+    closeConnection: true
+    appName: "poolCreateMinSizeErrorTest"
+poolOptions:
+  minPoolSize: 1
+  backgroundThreadIntervalMS: 50
+  appName: "poolCreateMinSizeErrorTest"
+operations:
+  - name: ready
+  - name: waitForEvent
+    event: ConnectionPoolCleared
+    count: 1
+  # ensure pool doesn't start making new connections
+  - name: wait
+    ms: 200
+events:
+  - type: ConnectionPoolReady
+    address: 42
+  - type: ConnectionCreated
+    address: 42
+  # The ruby driver clears the pool before closing the connection.
+  - type: ConnectionPoolCleared
+    address: 42
+  - type: ConnectionClosed
+    address: 42
+    connectionId: 42
+    reason: error
+ignore:
+  - ConnectionPoolCreated

data/spec/spec_tests/data/cmap/pool-create-min-size.yml

@@ -1,9 +1,16 @@
 version: 1
 style: unit
 description: must be able to start a pool with minPoolSize connections
+# Remove the topology runOn requirement when cmap specs are adjusted for lbs
+runOn:
+  - topology: [ "single", "replicaset", "sharded" ]
 poolOptions:
   minPoolSize: 3
 operations:
+  # ensure no connections are created until this pool is ready
+  - name: wait
+    ms: 200
+  - name: ready
   - name: waitForEvent
     event: ConnectionCreated
     count: 3
@@ -15,6 +22,8 @@ events:
   - type: ConnectionPoolCreated
     address: 42
     options: 42
+  - type: ConnectionPoolReady
+    address: 42
   - type: ConnectionCreated
     connectionId: 42
     address: 42

data/spec/spec_tests/data/cmap/pool-ready-ready.yml

@@ -0,0 +1,22 @@
+version: 1
+style: unit
+description: readying a ready pool emits no events
+# Remove the topology runOn requirement when cmap specs are adjusted for lbs
+runOn:
+  - topology: [ "single", "replicaset", "sharded" ]
+operations:
+  - name: ready
+  - name: ready
+  - name: ready
+  # the first ready after this clear should emit an event
+  - name: clear
+  - name: ready
+events:
+  - type: ConnectionPoolReady
+    address: 42
+  - type: ConnectionPoolCleared
+    address: 42
+  - type: ConnectionPoolReady
+    address: 42
+ignore:
+  - ConnectionPoolCreated

data/spec/spec_tests/data/cmap/pool-ready.yml

@@ -0,0 +1,30 @@
+version: 1
+style: unit
+description: pool starts as cleared and becomes ready
+operations:
+  - name: start
+    target: thread1
+  - name: checkOut
+    thread: thread1
+  - name: waitForEvent
+    event: ConnectionCheckOutFailed
+    count: 1
+  - name: ready
+  - name: checkOut
+events:
+  - type: ConnectionCheckOutStarted
+    address: 42
+  - type: ConnectionCheckOutFailed
+    reason: connectionError
+    address: 42
+  - type: ConnectionPoolReady
+    address: 42
+  - type: ConnectionCheckOutStarted
+    address: 42
+  - type: ConnectionCreated
+    address: 42
+  - type: ConnectionCheckedOut
+    address: 42
+ignore:
+  - ConnectionPoolCreated
+  - ConnectionReady

data/spec/spec_tests/data/cmap/wait-queue-fairness.yml

@@ -5,6 +5,7 @@ poolOptions:
   maxPoolSize: 1
   waitQueueTimeoutMS: 5000
 operations:
+  - name: ready
     # Check out sole connection in pool
   - name: checkOut
     label: conn0
@@ -121,4 +122,5 @@ ignore:
   - ConnectionCreated
   - ConnectionReady
   - ConnectionClosed
+  - ConnectionPoolReady
   - ConnectionPoolCreated

data/spec/spec_tests/data/cmap/wait-queue-timeout.yml

@@ -1,10 +1,14 @@
 version: 1
 style: unit
 description: must aggressively timeout threads enqueued longer than waitQueueTimeoutMS
+# Remove the topology runOn requirement when cmap specs are adjusted for lbs
+runOn:
+  - topology: [ "single", "replicaset", "sharded" ]
 poolOptions:
   maxPoolSize: 1
-  waitQueueTimeoutMS: 20
+  waitQueueTimeoutMS: 50
 operations:
+  - name: ready
   # Check out only possible connection
   - name: checkOut
     label: conn0
@@ -44,3 +48,4 @@ ignore:
   - ConnectionReady
   - ConnectionClosed
   - ConnectionPoolCreated
+  - ConnectionPoolReady

data/spec/spec_tests/data/collection_management/modifyCollection-errorResponse.yml

@@ -0,0 +1,59 @@
+description: "modifyCollection-errorResponse"
+
+schemaVersion: "1.12"
+
+createEntities:
+  - client:
+      id: &client0 client0
+      observeEvents: [ commandStartedEvent ]
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name collMod-tests
+  - collection:
+      id: &collection0 collection0
+      database: *database0
+      collectionName: &collection0Name test
+
+initialData: &initialData
+  - collectionName: *collection0Name
+    databaseName: *database0Name
+    documents:
+      - { _id: 1, x: 1 }
+      - { _id: 2, x: 1 }
+
+tests:
+  - description: "modifyCollection prepareUnique violations are accessible"
+    runOnRequirements:
+      - minServerVersion: "5.2" # SERVER-61158
+    operations:
+      - name: createIndex
+        object: *collection0
+        arguments:
+          keys: { x: 1 }
+      - name: modifyCollection
+        object: *database0
+        arguments:
+          collection: *collection0Name
+          index:
+            keyPattern: { x: 1 }
+            prepareUnique: true
+      - name: insertOne
+        object: *collection0
+        arguments:
+          document: { _id: 3, x: 1 }
+        expectError:
+          errorCode: 11000 # DuplicateKey
+      - name: modifyCollection
+        object: *database0
+        arguments:
+          collection: *collection0Name
+          index:
+            keyPattern: { x: 1 }
+            unique: true
+        expectError:
+          isClientError: false
+          errorCode: 359 # CannotConvertIndexToUnique
+          errorResponse:
+            violations:
+               - { ids: [ 1, 2 ] }

data/spec/spec_tests/data/collection_management/timeseries-collection.yml

@@ -127,3 +127,38 @@ tests:
                 filter: {}
                 sort: { time: 1 }
               databaseName: *database0Name
+
+  - description: "createCollection with bucketing options"
+    runOnRequirements:
+      - minServerVersion: "7.0"
+    operations:
+      - name: dropCollection
+        object: *database0
+        arguments:
+          collection: *collection0Name
+      - name: createCollection
+        object: *database0
+        arguments:
+          collection: *collection0Name
+          timeseries: &timeseries1
+            timeField: "time"
+            bucketMaxSpanSeconds: 3600
+            bucketRoundingSeconds: 3600
+      - name: assertCollectionExists
+        object: testRunner
+        arguments:
+          databaseName: *database0Name
+          collectionName: *collection0Name
+    expectEvents:
+      - client: *client0
+        events:
+          - commandStartedEvent:
+              command:
+                drop: *collection0Name
+              databaseName: *database0Name
+          - commandStartedEvent:
+              command:
+                create: *collection0Name
+                timeseries: *timeseries1
+              databaseName: *database0Name
+

data/spec/spec_tests/data/command_monitoring_unified/redacted-commands.yml

@@ -93,6 +93,8 @@ tests:
                 payload: { $$exists: false }
 
   - description: "getnonce"
+    runOnRequirements:
+    - maxServerVersion: 6.1.99 # getnonce removed as of 6.2 via SERVER-71007
     operations:
       - name: runCommand
         object: *database
@@ -159,6 +161,8 @@ tests:
                 roles: { $$exists: false }
 
   - description: "copydbgetnonce"
+    runOnRequirements:
+    - maxServerVersion: 3.6.99 # copydbgetnonce was removed as of 4.0 via SERVER-32276
     operations:
       - name: runCommand
         object: *database
@@ -176,6 +180,8 @@ tests:
               command: { copydbgetnonce: { $$exists: false } }
 
   - description: "copydbsaslstart"
+    runOnRequirements:
+    - maxServerVersion: 4.0.99 # copydbsaslstart was removed as of 4.2 via SERVER-36211
     operations:
       - name: runCommand
         object: *database
@@ -193,6 +199,8 @@ tests:
               command: { copydbsaslstart: { $$exists: false } }
 
   - description: "copydb"
+    runOnRequirements:
+    - maxServerVersion: 4.0.99 # copydb was removed as of 4.2 via SERVER-36257
     operations:
       - name: runCommand
         object: *database

data/spec/spec_tests/data/command_monitoring_unified/writeConcernError.yml

@@ -0,0 +1,80 @@
+description: "writeConcernError"
+schemaVersion: "1.13"
+runOnRequirements:
+  -
+    minServerVersion: 4.1.0
+    topologies:
+      - replicaset
+    serverless: "forbid"
+
+createEntities:
+  - client:
+      id: &client client
+      observeEvents:
+        - commandStartedEvent
+        - commandSucceededEvent
+        - commandFailedEvent
+  - database:
+      id: &database database
+      client: *client
+      databaseName: &databaseName command-monitoring-tests
+  - collection:
+      id: &collection collection
+      database: *database
+      collectionName: &collectionName test
+
+initialData:
+  - collectionName: *collectionName
+    databaseName: *databaseName
+    documents:
+      - { _id: 1, x: 11 }
+
+tests:
+  - description: "A retryable write with write concern errors publishes success event"
+    operations:
+      - name: failPoint
+        object: testRunner
+        arguments:
+          client: *client
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 1 }
+            data:
+              failCommands: [ insert ]
+              writeConcernError:
+                code: 91 # ShutdownInProgress
+                errorLabels: [RetryableWriteError]
+      - name: insertOne
+        object: *collection
+        arguments:
+          document: { _id: 2, x: 22 }
+    expectEvents:
+      - client: *client
+        events:
+          - commandStartedEvent:
+              command:
+                insert: *collectionName
+                documents:
+                  - { _id: 2, x: 22 }
+                ordered: true
+              commandName: insert
+              databaseName: *databaseName
+          - commandSucceededEvent:
+              reply:
+                ok: 1
+                n: 1
+                writeConcernError: { code: 91, errorLabels: [ "RetryableWriteError" ] }
+              commandName: insert
+          - commandStartedEvent:
+              command:
+                insert: *collectionName
+                documents:
+                  - { _id: 2, x: 22 }
+                ordered: true
+              commandName: insert
+              databaseName: *databaseName
+          - commandSucceededEvent:
+              reply:
+                ok: 1
+                n: 1
+              commandName: insert

data/spec/spec_tests/data/crud_unified/aggregate-merge-errorResponse.yml

@@ -0,0 +1,42 @@
+description: "aggregate-merge-errorResponse"
+
+schemaVersion: "1.12"
+
+createEntities:
+  - client:
+      id: &client0 client0
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name crud-tests
+  - collection:
+      id: &collection0 collection0
+      database: *database0
+      collectionName: &collection0Name test
+
+initialData: &initialData
+  - collectionName: *collection0Name
+    databaseName: *database0Name
+    documents:
+      - { _id: 1, x: 1 }
+      - { _id: 2, x: 1 }
+
+tests:
+  - description: "aggregate $merge DuplicateKey error is accessible"
+    runOnRequirements:
+      - minServerVersion: "5.1" # SERVER-59097
+        # Exclude sharded topologies since the aggregate command fails with
+        # IllegalOperation(20) instead of DuplicateKey(11000)
+        topologies: [ single, replicaset ]
+    operations:
+      - name: aggregate
+        object: *database0
+        arguments:
+          pipeline:
+            - { $documents: [ { _id: 2, x: 1 } ] }
+            - { $merge: { into: *collection0Name, whenMatched: "fail" } }
+        expectError:
+          errorCode: 11000 # DuplicateKey
+          errorResponse:
+            keyPattern: { _id: 1 }
+            keyValue: { _id: 2 }

data/spec/spec_tests/data/crud_unified/bulkWrite-errorResponse.yml

@@ -0,0 +1,50 @@
+description: "bulkWrite-errorResponse"
+
+schemaVersion: "1.12"
+
+createEntities:
+  - client:
+      id: &client0 client0
+      useMultipleMongoses: false
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name crud-tests
+  - collection:
+      id: &collection0 collection0
+      database: *database0
+      collectionName: &collection0Name test
+
+tests:
+  # This test intentionally executes only a single insert operation in the bulk
+  # write to make the error code and response assertions less ambiguous. That
+  # said, some drivers may still need to skip this test because the CRUD spec
+  # does not prescribe how drivers should formulate a BulkWriteException beyond
+  # collecting write and write concern errors.
+  - description: "bulkWrite operations support errorResponse assertions"
+    runOnRequirements:
+      - minServerVersion: "4.0.0"
+        topologies: [ single, replicaset ]
+      - minServerVersion: "4.2.0"
+        topologies: [ sharded ]
+    operations:
+      - name: failPoint
+        object: testRunner
+        arguments:
+          client: *client0
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 1 }
+            data:
+              failCommands: [ insert ]
+              errorCode: &errorCode 8 # UnknownError
+      - name: bulkWrite
+        object: *collection0
+        arguments:
+          requests:
+            - insertOne:
+                document: { _id: 1 }
+        expectError:
+          errorCode: *errorCode
+          errorResponse:
+            code: *errorCode

data/spec/spec_tests/data/crud_unified/deleteOne-errorResponse.yml

@@ -0,0 +1,46 @@
+description: "deleteOne-errorResponse"
+
+schemaVersion: "1.12"
+
+createEntities:
+  - client:
+      id: &client0 client0
+      useMultipleMongoses: false
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name crud-tests
+  - collection:
+      id: &collection0 collection0
+      database: *database0
+      collectionName: &collection0Name test
+
+tests:
+  # Some drivers may still need to skip this test because the CRUD spec does not
+  # prescribe how drivers should formulate a WriteException beyond collecting a
+  # write or write concern error.
+  - description: "delete operations support errorResponse assertions"
+    runOnRequirements:
+      - minServerVersion: "4.0.0"
+        topologies: [ single, replicaset ]
+      - minServerVersion: "4.2.0"
+        topologies: [ sharded ]
+    operations:
+      - name: failPoint
+        object: testRunner
+        arguments:
+          client: *client0
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 1 }
+            data:
+              failCommands: [ delete ]
+              errorCode: &errorCode 8 # UnknownError
+      - name: deleteOne
+        object: *collection0
+        arguments:
+          filter: { _id: 1 }
+        expectError:
+          errorCode: *errorCode
+          errorResponse:
+            code: *errorCode

data/spec/spec_tests/data/crud_unified/estimatedDocumentCount.yml

@@ -21,6 +21,10 @@ createEntities:
       id: &collection1 collection1
       database: *database0
       collectionName: &collection1Name coll1
+  - collection:
+      id: &collection0View collection0View
+      database: *database0
+      collectionName: &collection0ViewName coll0view
 
 initialData:
   - collectionName: *collection0Name
@@ -135,3 +139,43 @@ tests:
                 count: *collection0Name
               commandName: count
               databaseName: *database0Name
+
+  - description: "estimatedDocumentCount works correctly on views"
+    # viewOn option was added to the create command in 3.4
+    runOnRequirements:
+      - minServerVersion: "3.4.0"
+    operations:
+      - name: dropCollection
+        object: *database0
+        arguments:
+          collection: *collection0ViewName
+      - name: createCollection
+        object: *database0
+        arguments:
+          collection: *collection0ViewName
+          viewOn: *collection0Name
+          pipeline: &pipeline
+            - { $match: { _id: { $gt: 1 } } }
+      - name: estimatedDocumentCount
+        object: *collection0View
+        expectResult: 2
+    expectEvents:
+      - client: *client0
+        events:
+          - commandStartedEvent:
+              command:
+                drop: *collection0ViewName
+              commandName: drop
+              databaseName: *database0Name
+          - commandStartedEvent:
+              command:
+                create: *collection0ViewName
+                viewOn: *collection0Name
+                pipeline: *pipeline
+              commandName: create
+              databaseName: *database0Name
+          - commandStartedEvent:
+              command:
+                count: *collection0ViewName
+              commandName: count
+              databaseName: *database0Name

data/spec/spec_tests/data/crud_unified/findOneAndUpdate-errorResponse.yml

@@ -0,0 +1,69 @@
+description: "findOneAndUpdate-errorResponse"
+
+schemaVersion: "1.12"
+
+createEntities:
+  - client:
+      id: &client0 client0
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name crud-tests
+  - collection:
+      id: &collection0 collection0
+      database: *database0
+      collectionName: &collection0Name test
+
+initialData: &initialData
+  - collectionName: *collection0Name
+    databaseName: *database0Name
+    documents:
+      - { _id: 1, x: "foo" }
+
+tests:
+  - description: "findOneAndUpdate DuplicateKey error is accessible"
+    runOnRequirements:
+      - minServerVersion: "4.2" # SERVER-37124
+    operations:
+      - name: createIndex
+        object: *collection0
+        arguments:
+          keys: { x: 1 }
+          unique: true
+      - name: findOneAndUpdate
+        object: *collection0
+        arguments:
+          filter: { _id: 2 }
+          update: { $set: { x: "foo" } }
+          upsert: true
+        expectError:
+          errorCode: 11000 # DuplicateKey
+          errorResponse:
+            keyPattern: { x: 1 }
+            keyValue: { x: "foo" }
+
+  - description: "findOneAndUpdate document validation errInfo is accessible"
+    runOnRequirements:
+      - minServerVersion: "5.0"
+    operations:
+      - name: modifyCollection
+        object: *database0
+        arguments:
+          collection: *collection0Name
+          validator:
+            x: { $type: "string" }
+      - name: findOneAndUpdate
+        object: *collection0
+        arguments:
+          filter: { _id: 1 }
+          update: { $set: { x: 1 } }
+        expectError:
+          errorCode: 121 # DocumentValidationFailure
+          errorResponse:
+            # Avoid asserting the exact contents of errInfo as it may vary by
+            # server version. Likewise, this is why drivers do not model the
+            # document. The following is sufficient to test that validation
+            # details are accessible. See SERVER-20547 for more context.
+            errInfo:
+              failingDocumentId: 1
+              details: { $$type: "object" }