mongo 2.18.2 → 2.19.0

data/spec/mongo/uri/srv_protocol_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 
@@ -15,6 +15,12 @@ describe Mongo::URI::SRVProtocol do
     new_local_client_nmio(string)
   end
 
+  shared_examples "roundtrips string" do
+    it "returns the correct string for the uri" do
+      expect(uri.to_s).to eq(URI::DEFAULT_PARSER.unescape(string))
+    end
+  end
+
   describe 'invalid uris' do
 
     context 'when there is more than one hostname' do
@@ -273,6 +279,8 @@ describe Mongo::URI::SRVProtocol do
         it 'returns an array with the parsed server' do
           expect(uri.servers).to eq(['localhost.test.build.10gen.cc:27017'])
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'multiple servers' do
@@ -283,6 +291,8 @@ describe Mongo::URI::SRVProtocol do
             expect(uri.servers.length).to eq 2
             uri.servers.should =~ hosts
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'with srvMaxHosts' do
@@ -291,6 +301,8 @@ describe Mongo::URI::SRVProtocol do
             expect(uri.servers.length).to eq 1
             expect(hosts.include?(uri.servers.first)).to be true
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'with srvMaxHosts > total hosts' do
@@ -299,6 +311,8 @@ describe Mongo::URI::SRVProtocol do
             expect(uri.servers.length).to eq 2
             uri.servers.should =~ hosts
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'with srvMaxHosts == total hosts' do
@@ -307,6 +321,8 @@ describe Mongo::URI::SRVProtocol do
             expect(uri.servers.length).to eq 2
             uri.servers.should =~ hosts
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'with srvMaxHosts=0' do
@@ -315,6 +331,8 @@ describe Mongo::URI::SRVProtocol do
             expect(uri.servers.length).to eq 2
             uri.servers.should =~ hosts
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'when setting the srvServiceName' do
@@ -324,6 +342,8 @@ describe Mongo::URI::SRVProtocol do
           it 'returns an array with the parsed server' do
             uri.servers.should =~ hosts
           end
+
+          include_examples "roundtrips string"
         end
       end
     end
@@ -356,6 +376,8 @@ describe Mongo::URI::SRVProtocol do
       it 'sets ssl to true' do
         expect(options[:ssl]).to eq(true)
       end
+
+      include_examples "roundtrips string"
     end
 
     describe '#credentials' do
@@ -369,6 +391,10 @@ describe Mongo::URI::SRVProtocol do
         it 'returns the username' do
           expect(uri.credentials[:user]).to eq(user)
         end
+
+        it "drops the colon in to_s" do
+          expect(uri.to_s).to eq("mongodb+srv://tyler@test5.test.build.10gen.cc")
+        end
       end
 
       context 'username and password provided' do
@@ -382,6 +408,8 @@ describe Mongo::URI::SRVProtocol do
         it 'returns the password' do
           expect(uri.credentials[:password]).to eq(password)
         end
+
+        include_examples "roundtrips string"
       end
     end
 
@@ -394,6 +422,8 @@ describe Mongo::URI::SRVProtocol do
         it 'returns the database name' do
           expect(uri.database).to eq(db)
         end
+
+        include_examples "roundtrips string"
       end
     end
 
@@ -407,6 +437,8 @@ describe Mongo::URI::SRVProtocol do
         it 'returns an empty hash' do
           expect(uri.uri_options).to be_empty
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'write concern options provided' do
@@ -422,6 +454,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:write_concern]).to eq(concern)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'w=majority' do
@@ -435,6 +469,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:write_concern]).to eq(concern)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'journal' do
@@ -448,6 +484,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:write_concern]).to eq(concern)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'fsync' do
@@ -461,6 +499,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:write_concern]).to eq(concern)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'wtimeoutMS' do
@@ -475,6 +515,10 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:write_concern]).to eq(concern)
           end
+
+          it "roundtrips the string with camelCase" do
+            expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?w=2&wTimeoutMS=1234")
+          end
         end
       end
 
@@ -492,6 +536,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'primaryPreferred' do
@@ -505,6 +551,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'secondary' do
@@ -518,6 +566,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'secondaryPreferred' do
@@ -531,6 +581,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'nearest' do
@@ -544,6 +596,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
       end
 
@@ -565,6 +619,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'multiple read preference tag sets' do
@@ -583,6 +639,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:read]).to eq(read)
           end
+
+          include_examples "roundtrips string"
         end
       end
 
@@ -604,6 +662,10 @@ describe Mongo::URI::SRVProtocol do
           expect(client.options[:read]).to eq(read)
         end
 
+        it "rountrips the string with lowercase values" do
+          expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?readPreference=secondary&maxStalenessSeconds=120")
+        end
+
         context 'when the read preference and max staleness combination is invalid' do
 
           context 'when max staleness is combined with read preference mode primary' do
@@ -628,6 +690,10 @@ describe Mongo::URI::SRVProtocol do
             it 'does not raise an exception and is omitted' do
               expect(client.read_preference).to eq(BSON::Document.new(mode: :secondary))
             end
+
+            it "drops maxStalenessSeconds in to_s" do
+              expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?readPreference=secondary")
+            end
           end
         end
       end
@@ -643,6 +709,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the options on a client created with the uri' do
           expect(client.options[:replica_set]).to eq(rs_name)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'auth mechanism provided' do
@@ -668,6 +736,8 @@ describe Mongo::URI::SRVProtocol do
             client = new_local_client_nmio(string.downcase)
             expect(client.options[:auth_mech]).to eq(expected)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'mongodb-cr' do
@@ -686,6 +756,8 @@ describe Mongo::URI::SRVProtocol do
             client = new_local_client_nmio(string.downcase)
             expect(client.options[:auth_mech]).to eq(expected)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'gssapi' do
@@ -707,6 +779,10 @@ describe Mongo::URI::SRVProtocol do
             client = new_local_client_nmio(string.downcase)
             expect(client.options[:auth_mech]).to eq(expected)
           end
+
+          it "roundtrips the string" do
+            expect(uri.to_s).to eq("mongodb+srv://tyler:s3kr4t@test5.test.build.10gen.cc/?authSource=$external&authMechanism=GSSAPI")
+          end
         end
 
         context 'scram-sha-1' do
@@ -725,6 +801,8 @@ describe Mongo::URI::SRVProtocol do
             client = new_local_client_nmio(string.downcase)
             expect(client.options[:auth_mech]).to eq(expected)
           end
+
+          include_examples "roundtrips string"
         end
 
         context 'mongodb-x509' do
@@ -746,6 +824,10 @@ describe Mongo::URI::SRVProtocol do
             expect(client.options[:auth_mech]).to eq(expected)
           end
 
+          it "roundtrips the string" do
+            expect(uri.to_s).to eq("mongodb+srv://tyler@test5.test.build.10gen.cc/?authSource=$external&authMechanism=MONGODB-X509")
+          end
+
           context 'when a username is not provided' do
             let(:string) { "#{scheme}#{servers}/?#{options}" }
             it 'recognizes the mechanism with no username' do
@@ -753,6 +835,10 @@ describe Mongo::URI::SRVProtocol do
               expect(client.options[:auth_mech]).to eq(expected)
               expect(client.options[:user]).to be_nil
             end
+
+            it "roundtrips the string" do
+              expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?authSource=$external&authMechanism=MONGODB-X509")
+            end
           end
         end
       end
@@ -770,6 +856,8 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the options on a client created with the uri' do
             expect(client.options[:auth_source]).to eq(source)
           end
+
+          include_examples "roundtrips string"
         end
       end
 
@@ -807,6 +895,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           include_examples 'sets options in the expected manner'
+          include_examples "roundtrips string"
         end
 
         context 'canonicalize_host_name' do
@@ -829,6 +918,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           include_examples 'sets options in the expected manner'
+          include_examples "roundtrips string"
         end
 
         context 'service_realm' do
@@ -851,6 +941,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           include_examples 'sets options in the expected manner'
+          include_examples "roundtrips string"
         end
 
         context 'multiple properties' do
@@ -881,6 +972,7 @@ describe Mongo::URI::SRVProtocol do
           end
 
           include_examples 'sets options in the expected manner'
+          include_examples "roundtrips string"
         end
       end
 
@@ -890,6 +982,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the the connect timeout' do
           expect(uri.uri_options[:connect_timeout]).to eq(4.567)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'socketTimeoutMS' do
@@ -898,6 +992,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the socket timeout' do
           expect(uri.uri_options[:socket_timeout]).to eq(8.910)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing serverSelectionTimeoutMS' do
@@ -907,6 +1003,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the the connect timeout' do
           expect(uri.uri_options[:server_selection_timeout]).to eq(3.561)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing localThresholdMS' do
@@ -916,6 +1014,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the the connect timeout' do
           expect(uri.uri_options[:local_threshold]).to eq(3.561)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing maxPoolSize' do
@@ -926,6 +1026,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the max pool size option' do
           expect(uri.uri_options[:max_pool_size]).to eq(max_pool_size)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing minPoolSize' do
@@ -936,6 +1038,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the min pool size option' do
           expect(uri.uri_options[:min_pool_size]).to eq(min_pool_size)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing waitQueueTimeoutMS' do
@@ -946,6 +1050,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the wait queue timeout option' do
           expect(uri.uri_options[:wait_queue_timeout]).to eq(0.5)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing srvMaxHosts' do
@@ -955,6 +1061,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the srv max hosts option' do
           expect(uri.uri_options[:srv_max_hosts]).to eq(srv_max_hosts)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing srvMaxHosts as 0' do
@@ -964,6 +1072,8 @@ describe Mongo::URI::SRVProtocol do
         it 'doesn\'t set the srv max hosts option' do
           expect(uri.uri_options[:srv_max_hosts]).to eq(srv_max_hosts)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when providing invalid integer to srvMaxHosts' do
@@ -973,6 +1083,10 @@ describe Mongo::URI::SRVProtocol do
         it 'does not set the srv max hosts option' do
           expect(uri.uri_options).to_not have_key(:srv_max_hosts)
         end
+
+        it "drops srvMaxHosts in to_s" do
+          expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc")
+        end
       end
 
       context 'when providing invalid type to srvMaxHosts' do
@@ -982,6 +1096,10 @@ describe Mongo::URI::SRVProtocol do
         it 'does not set the srv max hosts option' do
           expect(uri.uri_options).to_not have_key(:srv_max_hosts)
         end
+
+        it "drops srvMaxHosts in to_s" do
+          expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc")
+        end
       end
 
       context 'when providing srvServiceName' do
@@ -991,6 +1109,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the srv service name option' do
           expect(uri.uri_options[:srv_service_name]).to eq(srv_service_name)
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'ssl' do
@@ -1002,6 +1122,10 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the ssl option to true' do
             expect(uri.uri_options[:ssl]).to be true
           end
+
+          it "uses tls in to_s" do
+            expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?tls=true")
+          end
         end
 
         context 'false' do
@@ -1010,6 +1134,10 @@ describe Mongo::URI::SRVProtocol do
           it 'sets the ssl option to false' do
             expect(uri.uri_options[:ssl]).to be false
           end
+
+          it "uses tls in to_s" do
+            expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?tls=false")
+          end
         end
       end
 
@@ -1019,6 +1147,10 @@ describe Mongo::URI::SRVProtocol do
         it 'do not overshadow top level options' do
           expect(uri.uri_options).not_to be_empty
         end
+
+        it "uses tls in to_s" do
+          expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?w=1&tls=true")
+        end
       end
 
       context 'when an invalid option is provided' do
@@ -1033,6 +1165,10 @@ describe Mongo::URI::SRVProtocol do
           expect(uri_options).to be_empty
         end
 
+        it "drops the invalid option in to_s" do
+          expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc")
+        end
+
         context 'when an invalid option is combined with valid options' do
 
           let(:options) { 'invalidOption=10&waitQueueTimeoutMS=500&ssl=true' }
@@ -1045,15 +1181,21 @@ describe Mongo::URI::SRVProtocol do
             expect(uri_options[:wait_queue_timeout]).to eq(0.5)
             expect(uri_options[:ssl]).to be true
           end
+
+          it "drops the invalid option in to_s" do
+            expect(uri.to_s).to eq("mongodb+srv://test5.test.build.10gen.cc/?waitQueueTimeoutMS=500&tls=true")
+          end
         end
       end
 
       context 'when an app name option is provided' do
-        let(:options) { "appname=srv_test" }
+        let(:options) { "appName=srv_test" }
 
         it 'sets the app name on the client' do
           expect(client.options[:app_name]).to eq('srv_test')
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when a supported compressors option is provided' do
@@ -1062,6 +1204,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the compressors as an array on the client' do
           expect(client.options[:compressors]).to eq(['zlib'])
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when a non-supported compressors option is provided' do
@@ -1071,6 +1215,8 @@ describe Mongo::URI::SRVProtocol do
           expect(Mongo::Logger.logger).to receive(:warn)
           expect(client.options[:compressors]).to be_nil
         end
+
+        include_examples "roundtrips string"
       end
 
       context 'when a zlibCompressionLevel option is provided' do
@@ -1079,6 +1225,8 @@ describe Mongo::URI::SRVProtocol do
         it 'sets the zlib compression level on the client' do
           expect(client.options[:zlib_compression_level]).to eq(6)
         end
+
+        include_examples "roundtrips string"
       end
     end
   end

data/spec/mongo/uri_option_parsing_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'