mongo 2.15.1 → 2.16.0.alpha1

data/spec/integration/retryable_writes/retryable_writes_36_and_older_spec.rb

@@ -20,7 +20,7 @@ describe 'Retryable writes integration tests' do
 
   # These tests override server selector, which fails if there are multiple
   # eligible servers as would be the case in a multi-shard sharded cluster
-  require_no_multi_shard
+  require_no_multi_mongos
 
   # Note: these tests are deprecated in favor of the tests in the file
   # spec/integration/retryable_writes/retryable_writes_40_and_newer_spec.rb

data/spec/integration/retryable_writes/retryable_writes_40_and_newer_spec.rb

@@ -10,7 +10,7 @@ require_relative './shared/does_not_support_retries'
 describe 'Retryable Writes' do
   require_fail_command
   require_wired_tiger
-  require_no_multi_shard
+  require_no_multi_mongos
   require_warning_clean
 
   let(:client) do

data/spec/integration/sdam_error_handling_spec.rb

@@ -4,6 +4,8 @@
 require 'spec_helper'
 
 describe 'SDAM error handling' do
+  require_topology :single, :replica_set, :sharded
+
   clean_slate
 
   after do
@@ -14,9 +16,9 @@ describe 'SDAM error handling' do
 
   # These tests operate on specific servers, and don't work in a multi
   # shard cluster where multiple servers are equally eligible
-  require_no_multi_shard
+  require_no_multi_mongos
 
-  let(:diagnostic_subscriber) { VerboseEventSubscriber.new }
+  let(:diagnostic_subscriber) { Mrss::VerboseEventSubscriber.new }
 
   let(:client) do
     new_local_client(SpecConfig.instance.addresses,
@@ -288,7 +290,7 @@ describe 'SDAM error handling' do
   describe 'when there is an error on monitoring connection' do
     clean_slate_for_all
 
-    let(:subscriber) { EventSubscriber.new }
+    let(:subscriber) { Mrss::EventSubscriber.new }
 
     let(:set_subscribers) do
       client.subscribe(Mongo::Monitoring::SERVER_DESCRIPTION_CHANGED, subscriber)

data/spec/integration/sdam_events_spec.rb

@@ -4,7 +4,7 @@
 require 'spec_helper'
 
 describe 'SDAM events' do
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   describe 'server closed event' do
     it 'is published when client is closed' do
@@ -50,13 +50,20 @@ describe 'SDAM events' do
     context 'pre-4.4 servers' do
       max_server_version '4.2'
 
+      let(:sdam_proc) do
+        Proc.new do |client|
+          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+        end
+      end
+
       let(:client) do
         new_local_client(SpecConfig.instance.addresses,
           # Heartbeat interval is bound by 500 ms
-          SpecConfig.instance.test_options.merge(heartbeat_frequency: 0.5),
-        ).tap do |client|
-          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
-        end
+          SpecConfig.instance.test_options.merge(
+            heartbeat_frequency: 0.5,
+            sdam_proc: sdam_proc
+          ),
+        )
       end
 
       it 'is published every heartbeat interval' do
@@ -78,13 +85,20 @@ describe 'SDAM events' do
     context '4.4+ servers' do
       min_server_fcv '4.4'
 
+      let(:sdam_proc) do
+        Proc.new do |client|
+          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+        end
+      end
+
       let(:client) do
         new_local_client(SpecConfig.instance.addresses,
           # Heartbeat interval is bound by 500 ms
-          SpecConfig.instance.test_options.merge(heartbeat_frequency: 0.5),
-        ).tap do |client|
-          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
-        end
+          SpecConfig.instance.test_options.merge(
+            heartbeat_frequency: 0.5,
+            sdam_proc: sdam_proc
+          ),
+        )
       end
 
       it 'is published up to twice every heartbeat interval' do
@@ -92,23 +106,25 @@ describe 'SDAM events' do
         sleep 3
         client.close
 
-        events = subscriber.select_started_events(Mongo::Monitoring::Event::ServerHeartbeatStarted)
+        started_events = subscriber.select_started_events(
+          Mongo::Monitoring::Event::ServerHeartbeatStarted
+        )
         # We could have up to 16 events and should have no fewer than 8 events.
         # Whenever an awaited hello succeeds while the regular monitor is
         # waiting, the regular monitor's next scan is pushed forward.
-        events.length.should >= 6
-        events.length.should <= 18
-        (started_awaited = events.select(&:awaited?)).should_not be_empty
-        (started_regular = events.reject(&:awaited?)).should_not be_empty
+        started_events.length.should >= 6
+        started_events.length.should <= 18
+        (started_awaited = started_events.select(&:awaited?)).should_not be_empty
+        (started_regular = started_events.reject(&:awaited?)).should_not be_empty
 
-        events = subscriber.select_completed_events(
+        completed_events = subscriber.select_completed_events(
           Mongo::Monitoring::Event::ServerHeartbeatSucceeded,
           Mongo::Monitoring::Event::ServerHeartbeatFailed,
         )
-        events.length.should >= 6
-        events.length.should <= 18
-        (succeeded_awaited = events.select(&:awaited?)).should_not be_empty
-        (succeeded_regular = events.reject(&:awaited?)).should_not be_empty
+        completed_events.length.should >= 6
+        completed_events.length.should <= 18
+        (succeeded_awaited = completed_events.select(&:awaited?)).should_not be_empty
+        (succeeded_regular = completed_events.reject(&:awaited?)).should_not be_empty
 
         # There may be in-flight hellos that don't complete, both
         # regular and awaited.

data/spec/integration/sdam_prose_spec.rb

@@ -11,7 +11,7 @@ describe 'SDAM prose tests' do
     min_server_fcv '4.4'
     require_topology :single
 
-    let(:subscriber) { EventSubscriber.new }
+    let(:subscriber) { Mrss::EventSubscriber.new }
 
     let(:client) do
       new_local_client(SpecConfig.instance.addresses,

data/spec/integration/server_monitor_spec.rb

@@ -4,6 +4,7 @@
 require 'spec_helper'
 
 describe 'Server::Monitor' do
+  require_topology :single, :replica_set, :sharded
 
   let(:client) do
     new_local_client([ClusterConfig.instance.primary_address_str],

data/spec/integration/server_selector_spec.rb

@@ -11,7 +11,7 @@ describe 'Server selector' do
   describe '#select_server' do
     # These tests operate on specific servers, and don't work in a multi
     # shard cluster where multiple servers are equally eligible
-    require_no_multi_shard
+    require_no_multi_mongos
 
     let(:result) { selector.select_server(cluster) }
 
@@ -52,6 +52,8 @@ describe 'Server selector' do
       end
 
       context 'there is no known primary' do
+        require_topology :single, :replica_set, :sharded
+
         before do
           primary_server = client.cluster.next_primary
           client.close
@@ -59,15 +61,30 @@ describe 'Server selector' do
           primary_server.unknown!
         end
 
-        it 'raises NoServerAvailable with a message explaining the situation' do
-          expect do
-            result
-          end.to raise_error(Mongo::Error::NoServerAvailable, /The cluster is disconnected \(client may have been closed\)/)
+        context 'non-lb' do
+          require_topology :single, :replica_set, :sharded
+
+          it 'raises NoServerAvailable with a message explaining the situation' do
+            expect do
+              result
+            end.to raise_error(Mongo::Error::NoServerAvailable, /The cluster is disconnected \(client may have been closed\)/)
+          end
+        end
+
+        context 'lb' do
+          require_topology :load_balanced
+
+          it 'returns the load balancer' do
+            expect(result).to be_a(Mongo::Server)
+            result.should be_load_balancer
+          end
         end
       end
     end
 
     context 'monitoring thread is dead' do
+      require_topology :single, :replica_set, :sharded
+
       before do
         client.cluster.servers.each do |server|
           server.monitor.instance_variable_get('@thread').kill

data/spec/integration/server_spec.rb

@@ -33,6 +33,8 @@ describe 'Server' do
       end
 
       context 'unknown server in disconnected cluster' do
+        require_topology :single, :replica_set, :sharded
+
         before do
           client.close
           server.unknown!

data/spec/integration/srv_monitoring_spec.rb

@@ -144,7 +144,7 @@ describe 'SRV Monitoring' do
 
     context 'sharded cluster' do
       require_topology :sharded
-      require_multi_shard
+      require_multi_mongos
 
       it 'updates topology via SRV records' do
 

data/spec/integration/step_down_spec.rb

@@ -32,7 +32,7 @@ describe 'Step down behavior' do
     end
   end
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:test_client) do
     authorized_client_without_any_retries.with(server_selection_timeout: 20).tap do |client|

data/spec/integration/transaction_pinning_spec.rb

@@ -0,0 +1,120 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe 'Transaction pinning' do
+  let(:client) { authorized_client.with(max_pool_size: 4) }
+  let(:collection_name) { 'tx_pinning' }
+  let(:collection) { client[collection_name] }
+
+  before do
+    authorized_client[collection_name].insert_many([{test: 1}] * 200)
+  end
+
+  let(:server) { client.cluster.next_primary }
+
+  clean_slate
+
+  context 'non-lb' do
+    require_topology :sharded
+    min_server_fcv '4.2'
+
+    # Start several transactions, then complete each of them.
+    # Force each transaction to be on its own connection.
+
+    before do
+      4.times do |i|
+        # Collections cannot be created inside transactions.
+        client["tx_pin_t#{i}"].drop
+        client["tx_pin_t#{i}"].create
+      end
+    end
+
+    it 'works' do
+      sessions = []
+      connections = []
+
+      4.times do |i|
+        session = client.start_session
+        session.start_transaction
+        client["tx_pin_t#{i}"].insert_one({test: 1}, session: session)
+        session.pinned_server.should be_a(Mongo::Server)
+        sessions << session
+        connections << server.pool.check_out
+      end
+
+      server.pool.size.should == 4
+
+      connections.each do |c|
+        server.pool.check_in(c)
+      end
+
+      sessions.each_with_index do |session, i|
+        client["tx_pin_t#{i}"].insert_one({test: 2}, session: session)
+        session.commit_transaction
+      end
+    end
+  end
+
+  context 'lb' do
+    require_topology :load_balanced
+    min_server_fcv '4.2'
+
+    # In load-balanced topology, we cannot create new connections to a
+    # particular service.
+
+    context 'when no connection is available' do
+
+      before do
+        client["tx_pin"].drop
+        client["tx_pin"].create
+      end
+
+      it 'raises ConnectionCheckOutTimeout' do
+        session = client.start_session
+        session.start_transaction
+        client["tx_pin"].insert_one({test: 1}, session: session)
+        session.pinned_server.should be nil
+        session.pinned_service_id.should_not be nil
+
+        server.pool.size.should == 1
+        server.pool.clear
+        server.pool.size.should == 0
+
+        lambda do
+          client["tx_pin"].insert_one({test: 2}, session: session)
+        end.should raise_error(Mongo::Error::ConnectionCheckOutTimeout)
+      end
+    end
+
+    context 'when connection is available' do
+
+      it 'uses the available connection' do
+        sessions = []
+        connections = []
+
+        4.times do |i|
+          session = client.start_session
+          session.start_transaction
+          client["tx_pin_t#{i}"].insert_one({test: 1}, session: session)
+          session.pinned_server.should be nil
+          session.pinned_service_id.should_not be nil
+          sessions << session
+          connections << server.pool.check_out
+        end
+
+        server.pool.size.should == 4
+
+        connections.each do |c|
+          server.pool.check_in(c)
+        end
+
+        sessions.each_with_index do |session, i|
+          client["tx_pin_t#{i}"].insert_one({test: 2}, session: session)
+          session.commit_transaction
+        end
+      end
+    end
+  end
+end

data/spec/integration/versioned_api_examples_spec.rb

@@ -66,4 +66,49 @@ describe 'Versioned API examples' do
     # Do not leak clients.
     client.close
   end
+
+  it "Versioned API Strict Migration Example" do
+    client = Mongo::Client.new(uri_string, server_api: {version: "1", strict: true})
+    client[:sales].drop
+
+    # Start Versioned API Example 5
+
+    client[:sales].insert_many([
+      { _id: 1, item: "abc", price: 10, quantity: 2,  date: DateTime.parse("2021-01-01T08:00:00Z") },
+      { _id: 2, item: "jkl", price: 20, quantity: 1,  date: DateTime.parse("2021-02-03T09:00:00Z") },
+      { _id: 3, item: "xyz", price: 5,  quantity: 5,  date: DateTime.parse("2021-02-03T09:05:00Z") },
+      { _id: 4, item: "abc", price: 10, quantity: 10, date: DateTime.parse("2021-02-15T08:00:00Z") },
+      { _id: 5, item: "xyz", price: 5,  quantity: 10, date: DateTime.parse("2021-02-15T09:05:00Z") },
+      { _id: 6, item: "xyz", price: 5,  quantity: 5,  date: DateTime.parse("2021-02-15T12:05:10Z") },
+      { _id: 7, item: "xyz", price: 5,  quantity: 10, date: DateTime.parse("2021-02-15T14:12:12Z") },
+      { _id: 8, item: "abc", price: 10, quantity: 5,  date: DateTime.parse("2021-03-16T20:20:13Z") }
+    ])
+
+    # End Versioned API Example 5
+
+    expect do
+      client.database.command(count: :sales)
+    end.to raise_error(Mongo::Error::OperationFailure)
+
+    # Start Versioned API Example 6
+
+    # Mongo::Error::OperationFailure:
+    #   [323:APIStrictError]: Provided apiStrict:true, but the command count is not in API Version 1. Information on supported commands and migrations in API Version 1 can be found at https://dochub.mongodb.org/core/manual-versioned-api
+
+    # End Versioned API Example 6
+
+    # Start Versioned API Example 7
+
+    client[:sales].count_documents
+
+    # End Versioned API Example 7
+
+    # Start Versioned API Example 8
+
+    # 8
+
+    # End Versioned API Example 8
+    # Do not leak clients.
+    client.close
+  end
 end

data/spec/integration/x509_auth_spec.rb

@@ -38,7 +38,7 @@ describe 'X.509 auth integration tests' do
       "C=US,ST=New York,L=New York City,O=MongoDB,OU=x509,CN=localhost".freeze
     end
 
-    let(:subscriber) { EventSubscriber.new }
+    let(:subscriber) { Mrss::EventSubscriber.new }
 
     shared_examples 'authenticates successfully' do
       it 'authenticates successfully' do

data/spec/lite_spec_helper.rb

@@ -16,7 +16,6 @@ RETRYABLE_READS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/retryable_read
 COMMAND_MONITORING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/command_monitoring/**/*.yml").sort
 CONNECTION_STRING_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/connection_string/*.yml").sort
 URI_OPTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/uri_options/*.yml").sort
-DNS_SEEDLIST_DISCOVERY_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/dns_seedlist_discovery/*.yml").sort
 GRIDFS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/gridfs/*.yml").sort
 TRANSACTIONS_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions/*.yml").sort
 TRANSACTIONS_API_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/transactions_api/*.yml").sort
@@ -78,7 +77,7 @@ end
 
 require 'mrss/lite_constraints'
 require 'support/matchers'
-require 'support/event_subscriber'
+require 'mrss/event_subscriber'
 require 'support/common_shortcuts'
 require 'support/client_registry'
 require 'support/client_registry_macros'

data/spec/mongo/address/unix_spec.rb

@@ -28,6 +28,7 @@ describe Mongo::Address::Unix do
   end
 
   describe '#socket' do
+    require_unix_socket
 
     let(:address) do
       "/tmp/mongodb-#{SpecConfig.instance.any_port}.sock"

data/spec/mongo/auth/cr_spec.rb

@@ -2,6 +2,7 @@
 # encoding: utf-8
 
 require 'spec_helper'
+require 'support/shared/auth_context'
 
 describe Mongo::Auth::CR do
 
@@ -9,9 +10,7 @@ describe Mongo::Auth::CR do
     authorized_client.cluster.next_primary
   end
 
-  let(:connection) do
-    Mongo::Server::Connection.new(server, SpecConfig.instance.test_options)
-  end
+  include_context 'auth unit tests'
 
   describe '#login' do
 

data/spec/mongo/auth/ldap_spec.rb

@@ -2,6 +2,7 @@
 # encoding: utf-8
 
 require 'spec_helper'
+require 'support/shared/auth_context'
 
 describe Mongo::Auth::LDAP do
 
@@ -9,9 +10,7 @@ describe Mongo::Auth::LDAP do
     authorized_client.cluster.next_primary
   end
 
-  let(:connection) do
-    Mongo::Server::Connection.new(server, SpecConfig.instance.test_options)
-  end
+  include_context 'auth unit tests'
 
   let(:user) do
     Mongo::Auth::User.new(

data/spec/mongo/auth/scram_spec.rb

@@ -2,6 +2,7 @@
 # encoding: utf-8
 
 require 'spec_helper'
+require 'support/shared/auth_context'
 
 describe Mongo::Auth::Scram do
   require_no_external_user
@@ -10,9 +11,7 @@ describe Mongo::Auth::Scram do
     authorized_client.cluster.next_primary
   end
 
-  let(:connection) do
-    Mongo::Server::Connection.new(server, SpecConfig.instance.monitoring_options)
-  end
+  include_context 'auth unit tests'
 
   let(:cache_mod) { Mongo::Auth::CredentialCache }
 

data/spec/mongo/auth/user/view_spec.rb

@@ -23,7 +23,7 @@ describe Mongo::Auth::User::View do
   shared_context 'testing write concern' do
 
     let(:subscriber) do
-      EventSubscriber.new
+      Mrss::EventSubscriber.new
     end
 
     let(:client) do

data/spec/mongo/auth/x509_spec.rb

@@ -2,6 +2,7 @@
 # encoding: utf-8
 
 require 'spec_helper'
+require 'support/shared/auth_context'
 
 describe Mongo::Auth::X509 do
 
@@ -9,9 +10,7 @@ describe Mongo::Auth::X509 do
     authorized_client.cluster.next_primary
   end
 
-  let(:connection) do
-    Mongo::Server::Connection.new(server, SpecConfig.instance.test_options)
-  end
+  include_context 'auth unit tests'
 
   let(:user) do
     Mongo::Auth::User.new(database: '$external')

data/spec/mongo/bulk_write_spec.rb

@@ -1424,7 +1424,7 @@ describe Mongo::BulkWrite do
 
               # In a multi-sharded cluster, the write seems to go to a
               # different shard from the read
-              require_no_multi_shard
+              require_no_multi_mongos
 
               let(:extra_options) do
                 { write_concern: { w: 0 } }
@@ -2103,10 +2103,10 @@ describe Mongo::BulkWrite do
 
             # In a multi-shard cluster, retries may go to a different server
             # than original command which these tests are not prepared to handle
-            require_no_multi_shard
+            require_no_multi_mongos
 
 
-            let(:subscriber) { EventSubscriber.new }
+            let(:subscriber) { Mrss::EventSubscriber.new }
 
             let(:client) do
               authorized_client_with_retry_writes.tap do |client|