mongo 2.15.0 → 2.18.1

data/spec/mongo/cluster_spec.rb

@@ -41,6 +41,34 @@ describe Mongo::Cluster do
       end
     end
 
+    context 'when topology is load-balanced' do
+      require_topology :load_balanced
+
+      it 'emits SDAM events' do
+        allow(monitoring).to receive(:succeeded)
+
+        register_cluster(
+          described_class.new(
+            SpecConfig.instance.addresses,
+            monitoring,
+            SpecConfig.instance.test_options
+            )
+          )
+
+          expect(monitoring).to have_received(:succeeded).with(
+            Mongo::Monitoring::TOPOLOGY_OPENING, any_args
+          )
+          expect(monitoring).to have_received(:succeeded).with(
+            Mongo::Monitoring::TOPOLOGY_CHANGED, any_args
+          ).twice
+          expect(monitoring).to have_received(:succeeded).with(
+            Mongo::Monitoring::SERVER_OPENING, any_args
+          )
+          expect(monitoring).to have_received(:succeeded).with(
+            Mongo::Monitoring::SERVER_DESCRIPTION_CHANGED, any_args
+          )
+      end
+    end
   end
 
   describe '#==' do
@@ -334,7 +362,7 @@ describe Mongo::Cluster do
       end
 
       let(:monitoring) { Mongo::Monitoring.new }
-      let(:subscriber) { EventSubscriber.new }
+      let(:subscriber) { Mrss::EventSubscriber.new }
 
       it 'publishes server closed event once' do
         monitoring.subscribe(Mongo::Monitoring::SERVER_CLOSED, subscriber)
@@ -425,7 +453,7 @@ describe Mongo::Cluster do
     end
 
     let(:primary_candidates) do
-      if cluster.single?
+      if cluster.single? || cluster.load_balanced?
         cluster.servers
       elsif cluster.sharded?
         cluster.servers
@@ -603,40 +631,6 @@ describe Mongo::Cluster do
       end
     end
 
-    context 'when client has not contacted any servers' do
-
-      let(:cluster) do
-        described_class.new(SpecConfig.instance.addresses, monitoring,
-          SpecConfig.instance.test_options.merge(
-            monitoring_io: false, server_selection_timeout: 0.183))
-      end
-
-      it_behaves_like 'does not support sessions'
-    end
-
-    context 'when client has contacted servers and then disconnected' do
-      min_server_fcv '3.6'
-      require_wired_tiger
-      require_topology :sharded, :replica_set
-
-      let(:cluster) do
-        described_class.new(SpecConfig.instance.addresses, monitoring,
-          SpecConfig.instance.test_options.merge(
-            server_selection_timeout: 0.183)
-        ).tap do |cluster|
-          register_cluster(cluster)
-        end
-      end
-
-      before do
-        cluster.next_primary
-        cluster.servers_list.map(&:disconnect!)
-        cluster.servers_list.map(&:unknown!)
-      end
-
-      it_behaves_like 'supports sessions'
-    end
-
     context 'in server < 3.6' do
       max_server_version '3.4'
 
@@ -761,6 +755,9 @@ describe Mongo::Cluster do
     let(:default_address) { SpecConfig.instance.addresses.first }
 
     context 'cluster has unknown servers' do
+      # Servers are never unknown in load-balanced topology.
+      require_topology :single, :replica_set, :sharded
+
       it 'includes unknown servers' do
         cluster.servers_list.each do |server|
           expect(server).to be_unknown

data/spec/mongo/collection/view/aggregation_spec.rb

@@ -29,8 +29,16 @@ describe Mongo::Collection::View::Aggregation do
     described_class.new(view, pipeline, options)
   end
 
+  let(:server) do
+    double('server')
+  end
+
+  let(:session) do
+    double('session')
+  end
+
   let(:aggregation_spec) do
-    aggregation.send(:aggregate_spec, double('session'))
+    aggregation.send(:aggregate_spec, session, nil)
   end
 
   before do
@@ -235,7 +243,7 @@ describe Mongo::Collection::View::Aggregation do
         { session: session }
       end
 
-      let(:subscriber) { EventSubscriber.new }
+      let(:subscriber) { Mrss::EventSubscriber.new }
 
       let(:client) do
         authorized_client.tap do |client|
@@ -351,15 +359,15 @@ describe Mongo::Collection::View::Aggregation do
 
   describe '#aggregate_spec' do
 
-    context 'when the collection has a read preference' do
+    context 'when a read preference is given' do
 
       let(:read_preference) do
-        {mode: :secondary}
+        BSON::Document.new({mode: :secondary})
       end
 
       it 'includes the read preference in the spec' do
-        allow(authorized_collection).to receive(:read_preference).and_return(read_preference)
-        expect(aggregation_spec[:read]).to eq(read_preference)
+        spec = aggregation.send(:aggregate_spec, session, read_preference)
+        expect(spec[:read]).to eq(read_preference)
       end
     end
 
@@ -570,109 +578,196 @@ describe Mongo::Collection::View::Aggregation do
   end
 
   context 'when $out is in the pipeline' do
-
-    let(:pipeline) do
-      [{
-           "$group" => {
-               "_id" => "$city",
-               "totalpop" => { "$sum" => "$pop" }
+    [['$out', 'string'], [:$out, 'symbol']].each do |op, type|
+      context "when #{op} is a #{type}" do
+        let(:pipeline) do
+          [{
+               "$group" => {
+                   "_id" => "$city",
+                   "totalpop" => { "$sum" => "$pop" }
+               }
+           },
+           {
+               op => 'output_collection'
            }
-       },
-       {
-           '$out' => 'output_collection'
-       }
-      ]
-    end
+          ]
+        end
 
-    before do
-      authorized_client['output_collection'].delete_many
-    end
+        before do
+          authorized_client['output_collection'].delete_many
+        end
+
+        let(:features) do
+          double()
+        end
+
+        let(:server) do
+          double().tap do |server|
+            allow(server).to receive(:features).and_return(features)
+          end
+        end
+
+        context 'when the view has a write concern' do
+
+          let(:collection) do
+            authorized_collection.with(write: INVALID_WRITE_CONCERN)
+          end
 
-    context 'when $out is a string' do
+          let(:view) do
+            Mongo::Collection::View.new(collection, selector, view_options)
+          end
+
+          context 'when the server supports write concern on the aggregate command' do
+            min_server_fcv '3.4'
+
+            it 'uses the write concern' do
+              expect {
+                aggregation.to_a
+              }.to raise_exception(Mongo::Error::OperationFailure)
+            end
+          end
+
+          context 'when the server does not support write concern on the aggregation command' do
+            max_server_version '3.2'
 
-      it 'does not allow the operation on a secondary' do
-        expect(aggregation.send(:secondary_ok?)).to be(false)
+            let(:documents) do
+              [
+                { city: "Berlin", pop: 18913, neighborhood: "Kreuzberg" },
+                { city: "Berlin", pop: 84143, neighborhood: "Mitte" },
+                { city: "New York", pop: 40270, neighborhood: "Brooklyn" }
+              ]
+            end
+
+            before do
+              authorized_collection.insert_many(documents)
+              aggregation.to_a
+            end
+
+            it 'does not apply the write concern' do
+              expect(authorized_client['output_collection'].find.count).to eq(2)
+            end
+          end
+        end
       end
     end
+  end
+
+  context "when there is a filter on the view" do
+
+    context "when broken_view_aggregate is turned off" do
+      config_override :broken_view_aggregate, false
 
-    context 'when $out is a symbol' do
+      let(:documents) do
+        [
+          { city: "Berlin", pop: 18913, neighborhood: "Kreuzberg" },
+          { city: "Berlin", pop: 84143, neighborhood: "Mitte" },
+          { city: "New York", pop: 40270, neighborhood: "Brooklyn" }
+        ]
+      end
 
       let(:pipeline) do
         [{
-             "$group" => {
-                 "_id" => "$city",
-                 "totalpop" => { "$sum" => "$pop" }
-             }
-         },
-         {
-             :$out => 'output_collection'
-         }
-        ]
+          "$project" => {
+            city: 1
+          }
+        }]
       end
 
-      it 'does not allow the operation on a secondary' do
-        expect(aggregation.send(:secondary_ok?)).to be(false)
+      let(:view) do
+        authorized_collection.find(city: "Berlin")
       end
-    end
 
+      before do
+        authorized_collection.delete_many
+        authorized_collection.insert_many(documents)
+      end
 
-    context 'when the server is not a valid for writing' do
+      it "uses the filter on the view" do
+        expect(aggregation.to_a.length).to eq(2)
+      end
 
-     it 'reroutes the operation to a primary' do
-       allow(aggregation).to receive(:valid_server?).and_return(false)
-       expect(Mongo::Logger.logger).to receive(:warn).and_call_original
-       aggregation.to_a
-     end
+      it "adds a match stage" do
+        expect(aggregation.pipeline.length).to eq(2)
+        expect(aggregation.pipeline.first).to eq({ :$match => { "city" => "Berlin" } })
+      end
     end
 
-    context 'when the server is a valid for writing' do
+    context "when broken_view_aggregate is turned on" do
+      config_override :broken_view_aggregate, true
 
-     it 'does not reroute the operation to a primary' do
-       expect(Mongo::Logger.logger).not_to receive(:warn)
-       aggregation.to_a
-     end
+      let(:documents) do
+        [
+          { city: "Berlin", pop: 18913, neighborhood: "Kreuzberg" },
+          { city: "Berlin", pop: 84143, neighborhood: "Mitte" },
+          { city: "New York", pop: 40270, neighborhood: "Brooklyn" }
+        ]
+      end
 
-     context 'when the view has a write concern' do
+      let(:pipeline) do
+        [{
+          "$project" => {
+            city: 1
+          }
+        }]
+      end
+
+      let(:view) do
+        authorized_collection.find(city: "Berlin")
+      end
 
-       let(:collection) do
-         authorized_collection.with(write: INVALID_WRITE_CONCERN)
-       end
+      before do
+        authorized_collection.delete_many
+        authorized_collection.insert_many(documents)
+      end
 
-       let(:view) do
-         Mongo::Collection::View.new(collection, selector, view_options)
-       end
+      it "ignores the view filter" do
+        expect(aggregation.to_a.length).to eq(3)
+      end
 
-       context 'when the server supports write concern on the aggregate command' do
-        min_server_fcv '3.4'
+      it "does not add a match stage" do
+        expect(aggregation.pipeline.length).to eq(1)
+        expect(aggregation.pipeline).to eq([ { "$project" => { city: 1 } } ])
+      end
+    end
+  end
 
-         it 'uses the write concern' do
-           expect {
-             aggregation.to_a
-           }.to raise_exception(Mongo::Error::OperationFailure)
-         end
-       end
+  context "when there is no filter on the view" do
 
-       context 'when the server does not support write concern on the aggregation command' do
-        max_server_version '3.2'
+    with_config_values :broken_view_aggregate, true, false do
 
-         let(:documents) do
-           [
-             { city: "Berlin", pop: 18913, neighborhood: "Kreuzberg" },
-             { city: "Berlin", pop: 84143, neighborhood: "Mitte" },
-             { city: "New York", pop: 40270, neighborhood: "Brooklyn" }
-           ]
-         end
-
-         before do
-           authorized_collection.insert_many(documents)
-           aggregation.to_a
-         end
-
-         it 'does not apply the write concern' do
-           expect(authorized_client['output_collection'].find.count).to eq(2)
-         end
-       end
-     end
+      let(:documents) do
+        [
+          { city: "Berlin", pop: 18913, neighborhood: "Kreuzberg" },
+          { city: "Berlin", pop: 84143, neighborhood: "Mitte" },
+          { city: "New York", pop: 40270, neighborhood: "Brooklyn" }
+        ]
+      end
+
+      let(:pipeline) do
+        [{
+          "$project" => {
+            city: 1
+          }
+        }]
+      end
+
+      let(:view) do
+        authorized_collection.find
+      end
+
+      before do
+        authorized_collection.delete_many
+        authorized_collection.insert_many(documents)
+      end
+
+      it "ignores the view filter" do
+        expect(aggregation.to_a.length).to eq(3)
+      end
+
+      it "does not add a match stage" do
+        expect(aggregation.pipeline.length).to eq(1)
+        expect(aggregation.pipeline).to eq([ { "$project" => { city: 1 } } ])
+      end
     end
   end
 end

data/spec/mongo/collection/view/builder/find_command_spec.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
 # encoding: utf-8
 
+# TODO convert, move or delete these tests as part of RUBY-2706.
+
+=begin
 require 'lite_spec_helper'
 
 describe Mongo::Collection::View::Builder::FindCommand do
@@ -522,3 +525,4 @@ describe Mongo::Collection::View::Builder::FindCommand do
     end
   end
 end
+=end

data/spec/mongo/collection/view/builder/op_query_spec.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
 # encoding: utf-8
 
+# TODO convert, move or delete these tests as part of RUBY-2706.
+
+=begin
 require 'spec_helper'
 
 describe Mongo::Collection::View::Builder::OpQuery do
@@ -155,3 +158,4 @@ describe Mongo::Collection::View::Builder::OpQuery do
     end
   end
 end
+=end

data/spec/mongo/collection/view/change_stream_spec.rb

@@ -56,7 +56,7 @@ describe Mongo::Collection::View::ChangeStream do
 
   let(:command_spec) do
     change_stream.send(:instance_variable_set, '@resuming', false)
-    change_stream.send(:aggregate_spec, double('session'))
+    change_stream.send(:aggregate_spec, double('session'), nil)
   end
 
   let(:cursor) do
@@ -178,7 +178,7 @@ describe Mongo::Collection::View::ChangeStream do
 
       it 'raises the error from the server' do
         expect(error).to be_a(Mongo::Error::OperationFailure)
-        expect(error.message).to include('$changeStream is only valid as the first stage in a pipeline')
+        expect(error.message).to include('is only valid as the first stage in a pipeline')
       end
     end
 

data/spec/mongo/collection/view/map_reduce_spec.rb

@@ -60,6 +60,14 @@ describe Mongo::Collection::View::MapReduce do
     described_class.new(view, map, reduce, options)
   end
 
+  describe '#initialize' do
+    it 'warns of deprecation' do
+      Mongo::Logger.logger.should receive(:warn).with('MONGODB | The map_reduce operation is deprecated, please use the aggregation pipeline instead')
+
+      map_reduce
+    end
+  end
+
   describe '#map_function' do
 
     it 'returns the map function' do
@@ -242,7 +250,7 @@ describe Mongo::Collection::View::MapReduce do
             Mongo::Collection::View.new(client[TEST_COLL], selector, view_options)
           end
 
-          let(:subscriber) { EventSubscriber.new }
+          let(:subscriber) { Mrss::EventSubscriber.new }
 
           let(:client) do
             authorized_client.tap do |client|
@@ -672,7 +680,12 @@ describe Mongo::Collection::View::MapReduce do
         end
 
         it 'does not reroute the operation to a primary' do
-          expect(Mongo::Logger.logger).not_to receive(:warn)
+          # We produce a deprecation warning, but there shouldn't be
+          # the reroute warning.
+          expect(Mongo::Logger.logger).to receive(:warn).once do |msg|
+            expect(msg).not_to include('Rerouting the MapReduce operation to the primary server')
+          end
+
           map_reduce.to_a
         end
       end
@@ -865,4 +878,20 @@ describe Mongo::Collection::View::MapReduce do
       end
     end
   end
+
+  describe '#map_reduce_spec' do
+    context 'when read preference is given' do
+      let(:view_options) do
+        { read: {mode: :secondary} }
+      end
+
+      context 'selector' do
+        # For compatibility with released versions of Mongoid, this method
+        # must return read preference under the :read key.
+        it 'contains read preference' do
+          map_reduce_spec[:selector][:read].should == {'mode' => :secondary}
+        end
+      end
+    end
+  end
 end