mongo 2.15.0.alpha → 2.16.0

data/spec/mongo/protocol/delete_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 

data/spec/mongo/protocol/get_more_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 

data/spec/mongo/protocol/insert_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 

data/spec/mongo/protocol/kill_cursors_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 

data/spec/mongo/protocol/msg_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 
@@ -100,7 +103,7 @@ describe Mongo::Protocol::Msg do
       context 'when the main_document are not equal' do
 
         let(:other_main_document) do
-          { '$db'=> SpecConfig.instance.test_db, ismaster: 1 }
+          { '$db'=> SpecConfig.instance.test_db, hello: 1 }
         end
 
         let(:other) do

data/spec/mongo/protocol/query_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 
@@ -27,7 +30,7 @@ describe Mongo::Protocol::Query do
     context 'when options are provided' do
 
       context 'when flags are provided' do
-        let(:options) { { :flags => [:slave_ok] } }
+        let(:options) { { :flags => [:secondary_ok] } }
 
         it 'sets the flags' do
           expect(message.flags).to eq(options[:flags])
@@ -166,7 +169,7 @@ describe Mongo::Protocol::Query do
         end
 
         context 'slave ok flag' do
-          let(:flags) { [:slave_ok] }
+          let(:flags) { [:secondary_ok] }
           it 'sets the third bit' do
             expect(field).to be_int32(4)
           end
@@ -208,7 +211,7 @@ describe Mongo::Protocol::Query do
         end
 
         context 'multiple flags' do
-          let(:flags) { [:await_data, :slave_ok] }
+          let(:flags) { [:await_data, :secondary_ok] }
           it 'sets the correct bits' do
             expect(field).to be_int32(36)
           end

data/spec/mongo/protocol/registry_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 
 describe Mongo::Protocol::Registry do

data/spec/mongo/protocol/reply_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 
 describe Mongo::Protocol::Reply do

data/spec/mongo/protocol/update_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/protocol'
 

data/spec/mongo/query_cache_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::QueryCache do
@@ -11,7 +14,7 @@ describe Mongo::QueryCache do
     authorized_collection.delete_many
   end
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:client) do
     authorized_client.tap do |client|
@@ -136,7 +139,11 @@ describe Mongo::QueryCache do
 
   describe '#get' do
     let(:view) { double("Mongo::Collection::View") }
-    let(:result) { double("Mongo::Operation::Result") }
+    let(:result) do
+      double("Mongo::Operation::Result").tap do |result|
+        allow(result).to receive(:is_a?).with(Mongo::Operation::Result).and_return(true)
+      end
+    end
     let(:server) { double("Mongo::Server") }
     let(:caching_cursor) { Mongo::CachingCursor.new(view, result, server) }
 

data/spec/mongo/retryable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 class RetryableTestConsumer

data/spec/mongo/semaphore_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 
 describe Mongo::Semaphore do

data/spec/mongo/server/app_metadata_spec.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
-require_relative './app_metadata_shared'
 
 describe Mongo::Server::AppMetadata do
 
@@ -11,6 +13,14 @@ describe Mongo::Server::AppMetadata do
     authorized_client.cluster
   end
 
+  describe 'MAX_DOCUMENT_SIZE' do
+    it 'should be 512 bytes' do
+      # This test is an additional check that MAX_DOCUMENT_SIZE
+      # has not been accidentially changed.
+      expect(described_class::MAX_DOCUMENT_SIZE).to eq(512)
+    end
+  end
+
   describe '#initialize' do
 
     context 'when the cluster has an app name option set' do
@@ -63,7 +73,9 @@ describe Mongo::Server::AppMetadata do
         end
 
         it 'truncates the document' do
-          expect(app_metadata.send(:ismaster_bytes)).to be_a(String)
+          expect(
+            app_metadata.validated_document.to_bson.to_s.size
+          ).to be < described_class::MAX_DOCUMENT_SIZE
         end
       end
 
@@ -74,7 +86,9 @@ describe Mongo::Server::AppMetadata do
         end
 
         it 'truncates the document' do
-          expect(app_metadata.send(:ismaster_bytes)).to be_a(String)
+          expect(
+            app_metadata.validated_document.to_bson.to_s.size
+          ).to be < described_class::MAX_DOCUMENT_SIZE
         end
       end
 
@@ -85,7 +99,9 @@ describe Mongo::Server::AppMetadata do
         end
 
         it 'truncates the document' do
-          expect(app_metadata.send(:ismaster_bytes)).to be_a(String)
+          expect(
+            app_metadata.validated_document.to_bson.to_s.size
+          ).to be < described_class::MAX_DOCUMENT_SIZE
         end
       end
 
@@ -95,8 +111,10 @@ describe Mongo::Server::AppMetadata do
           allow(app_metadata).to receive(:platform).and_return('x'*500)
         end
 
-        it 'truncates the document to be just an ismaster command' do
-          expect(app_metadata.send(:ismaster_bytes)).to be_a(String)
+        it 'truncates the document' do
+          expect(
+            app_metadata.validated_document.to_bson.to_s.size
+          ).to be < described_class::MAX_DOCUMENT_SIZE
         end
       end
 
@@ -107,21 +125,10 @@ describe Mongo::Server::AppMetadata do
           allow(app_metadata).to receive(:driver_doc).and_return('x'*500)
         end
 
-        it 'truncates the document to be just an ismaster command and the compressors' do
-          # Because we sometimes request that the server provide a list of valid auth mechanisms for
-          # the user, we need to conditionally add the length of that metadata to the expected
-          # length of the isMaster document.
-          sasl_supported_mechs_size = 0
-          sasl_supported_mechs = app_metadata.instance_variable_get(:@request_auth_mech)
-
-          if sasl_supported_mechs
-            sasl_supported_mechs_size += 1                               # length of BSON type byte
-            sasl_supported_mechs_size += 'saslSupportedMechs'.length + 1        # length of BSON key
-            sasl_supported_mechs_size += 4                               # length of BSON string length
-            sasl_supported_mechs_size += sasl_supported_mechs.length + 1 # length of BSON string
-          end
-
-          expect(app_metadata.ismaster_bytes.length).to eq(Mongo::Server::Monitor::Connection::ISMASTER_BYTES.length + sasl_supported_mechs_size + 26)
+        it 'truncates the document' do
+          expect(
+            app_metadata.validated_document.to_bson.to_s.size
+          ).to be < described_class::MAX_DOCUMENT_SIZE
         end
       end
     end
@@ -144,4 +151,20 @@ describe Mongo::Server::AppMetadata do
 
     it_behaves_like 'app metadata document'
   end
+
+  describe '#validated_document' do
+    it 'raises with too long app name' do
+      app_name = 'app'*500
+      expect {
+        described_class.new(app_name: app_name).validated_document
+      }.to raise_error(Mongo::Error::InvalidApplicationName)
+    end
+
+    it 'does not raise with correct app name' do
+      app_name = 'app'
+      expect {
+        described_class.new(app_name: app_name).validated_document
+      }.not_to raise_error
+    end
+  end
 end

data/spec/mongo/server/connection_auth_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 # these tests fail intermittently in evergreen
@@ -52,13 +55,7 @@ describe Mongo::Server::Connection, retry: 3 do
       described_class.new(server, server.options)
     end
 
-    let(:reply) do
-      double('reply').tap do |r|
-        allow(r).to receive(:documents).and_return([ ismaster ])
-      end
-    end
-
-    context 'when the ismaster response includes saslSupportedMechs' do
+    context 'when the hello response includes saslSupportedMechs' do
       min_server_fcv '4.0'
 
       let(:server_options) do
@@ -94,7 +91,7 @@ describe Mongo::Server::Connection, retry: 3 do
       end
     end
 
-    context 'when the ismaster response indicates the auth mechanism is :scram' do
+    context 'when the hello response indicates the auth mechanism is :scram' do
       require_no_external_user
 
       let(:features) do
@@ -116,7 +113,7 @@ describe Mongo::Server::Connection, retry: 3 do
       end
     end
 
-    context 'when the ismaster response indicates the auth mechanism is :mongodb_cr' do
+    context 'when the hello response indicates the auth mechanism is :mongodb_cr' do
       let(:features) do
         Mongo::Server::Description::Features.new(0..2)
       end

data/spec/mongo/server/connection_common_spec.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'lite_spec_helper'
+
+describe Mongo::Server::ConnectionCommon do
+  let(:subject) { described_class.new }
+
+  let(:metadata) do
+    Mongo::Server::AppMetadata.new({})
+  end
+
+  describe '#handshake_document' do
+    let(:document) do
+      subject.handshake_document(metadata)
+    end
+
+    context 'with api version' do
+      let(:metadata) do
+        Mongo::Server::AppMetadata.new({
+          server_api: { version: '1'  }
+        })
+      end
+
+      it 'returns hello document with API version' do
+        expect(document['hello']).to eq(1)
+      end
+    end
+
+    context 'without api version' do
+      it 'returns legacy hello document without API version' do
+        expect(document['isMaster']).to eq(1)
+      end
+    end
+
+    context 'when connecting to load balancer' do
+
+      let(:document) do
+        subject.handshake_document(metadata, load_balancer: true)
+      end
+
+      it 'includes loadBalanced: true' do
+        document['loadBalanced'].should be true
+      end
+    end
+  end
+
+  describe '#handshake_command' do
+    let(:document) do
+      subject.handshake_document(metadata)
+    end
+
+    context 'with api version' do
+      let(:metadata) do
+        Mongo::Server::AppMetadata.new({
+          server_api: { version: '1'  }
+        })
+      end
+
+      it 'returns OP_MSG command' do
+        expect(
+          subject.handshake_command(document)
+        ).to be_a(Mongo::Protocol::Msg)
+      end
+    end
+
+    context 'without api version' do
+      it 'returns OP_QUERY command' do
+        expect(
+          subject.handshake_command(document)
+        ).to be_a(Mongo::Protocol::Query)
+      end
+    end
+  end
+end

data/spec/mongo/server/connection_pool/populator_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Server::Populator do

data/spec/mongo/server/connection_pool_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Server::ConnectionPool do
@@ -314,6 +317,11 @@ describe Mongo::Server::ConnectionPool do
     end
 
     context 'connection of the same generation as pool' do
+      # These tests are also applicable to load balancers, but
+      # require different setup and assertions because load balancers
+      # do not have a single global generation.
+      require_topology :single, :replica_set, :sharded
+
       before do
         expect(pool.generation).to eq(connection.generation)
       end
@@ -346,6 +354,11 @@ describe Mongo::Server::ConnectionPool do
     end
 
     context 'connection of earlier generation than pool' do
+      # These tests are also applicable to load balancers, but
+      # require different setup and assertions because load balancers
+      # do not have a single global generation.
+      require_topology :single, :replica_set, :sharded
+
       let(:connection) do
         pool.check_out.tap do |connection|
           expect(connection).to receive(:generation).at_least(:once).and_return(0)
@@ -361,6 +374,11 @@ describe Mongo::Server::ConnectionPool do
     end
 
     context 'connection of later generation than pool' do
+      # These tests are also applicable to load balancers, but
+      # require different setup and assertions because load balancers
+      # do not have a single global generation.
+      require_topology :single, :replica_set, :sharded
+
       let(:connection) do
         pool.check_out.tap do |connection|
           expect(connection).to receive(:generation).at_least(:once).and_return(7)
@@ -446,6 +464,11 @@ describe Mongo::Server::ConnectionPool do
     end
 
     context 'when there is an available connection which is stale' do
+      # These tests are also applicable to load balancers, but
+      # require different setup and assertions because load balancers
+      # do not have a single global generation.
+      require_topology :single, :replica_set, :sharded
+
       let(:options) do
         { max_pool_size: 2, max_idle_time: 0.1 }
       end
@@ -486,13 +509,54 @@ describe Mongo::Server::ConnectionPool do
 
       context 'when the max size is reached' do
 
-        it 'raises a timeout error' do
-          expect(Mongo::Server::Connection).to receive(:new).once.and_call_original
-          expect {
-            pool.check_out
+        context 'without service_id' do
+          it 'raises a timeout error' do
+            expect(Mongo::Server::Connection).to receive(:new).once.and_call_original
             pool.check_out
-          }.to raise_error(::Timeout::Error)
-          expect(pool.size).to eq(1)
+            expect {
+              pool.check_out
+            }.to raise_error(::Timeout::Error)
+            expect(pool.size).to eq(1)
+          end
+        end
+
+        context 'with service_id' do
+          require_topology :load_balanced
+
+          let(:service_id) do
+            pool.with_connection do |connection|
+              connection.service_id.should_not be nil
+              connection.service_id
+            end
+          end
+
+          it 'raises a timeout error' do
+            expect(Mongo::Server::Connection).to receive(:new).once.and_call_original
+            service_id
+
+            pool.check_out(service_id: service_id)
+
+            expect {
+              pool.check_out(service_id: service_id)
+            }.to raise_error(Mongo::Error::ConnectionCheckOutTimeout)
+
+            expect(pool.size).to eq(1)
+          end
+
+          it 'waits for the timeout' do
+            expect(Mongo::Server::Connection).to receive(:new).once.and_call_original
+            service_id
+
+            pool.check_out(service_id: service_id)
+
+            start_time = Mongo::Utils.monotonic_time
+            expect {
+              pool.check_out(service_id: service_id)
+            }.to raise_error(Mongo::Error::ConnectionCheckOutTimeout)
+            elapsed_time = Mongo::Utils.monotonic_time - start_time
+
+            elapsed_time.should > 1
+          end
         end
       end
     end
@@ -538,7 +602,7 @@ describe Mongo::Server::ConnectionPool do
        it 'raises an error and emits ConnectionCheckOutFailedEvent' do
         pool
 
-        subscriber = EventSubscriber.new
+        subscriber = Mrss::EventSubscriber.new
         client.subscribe(Mongo::Monitoring::CONNECTION_POOL, subscriber)
 
         subscriber.clear_events!
@@ -576,6 +640,11 @@ describe Mongo::Server::ConnectionPool do
     end
 
     shared_examples_for 'disconnects and removes all connections in the pool and bumps generation' do
+      # These tests are also applicable to load balancers, but
+      # require different setup and assertions because load balancers
+      # do not have a single global generation.
+      require_topology :single, :replica_set, :sharded
+
       it 'disconnects and removes and bumps' do
         old_connections = []
         pool.instance_variable_get('@available_connections').each do |connection|