mongo 2.14.0 → 2.15.0.alpha

data/spec/integration/bulk_write_error_message_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe 'BulkWriteError message' do
+  let(:client) { authorized_client }
+  let(:collection_name) { 'bulk_write_error_message_spec' }
+  let(:collection) { client[collection_name] }
+
+  before do
+    collection.delete_many
+  end
+
+  context 'a bulk write with one error' do
+    it 'reports code name, code and message' do
+      begin
+        collection.insert_many([
+          {_id: 1},
+          {_id: 1},
+          {_id: 1},
+        ], ordered: true)
+        fail('Should have raised')
+      rescue Mongo::Error::BulkWriteError => e
+        e.message.should =~ %r,\A\[11000\]: (insertDocument :: caused by :: 11000 )?E11000 duplicate key error (collection|index):,
+      end
+    end
+  end
+
+  context 'a bulk write with multiple errors' do
+    it 'reports code name, code and message' do
+      begin
+        collection.insert_many([
+          {_id: 1},
+          {_id: 1},
+          {_id: 1},
+        ], ordered: false)
+        fail('Should have raised')
+      rescue Mongo::Error::BulkWriteError => e
+        e.message.should =~ %r,\AMultiple errors: \[11000\]: (insertDocument :: caused by :: 11000 )?E11000 duplicate key error (collection|index):.*\[11000\]: (insertDocument :: caused by :: 11000 )?E11000 duplicate key error (collection|index):,
+      end
+    end
+  end
+end

data/spec/integration/change_stream_spec.rb

@@ -98,7 +98,7 @@ describe 'Change stream integration', retry: 4 do
       it 'watch raises error' do
         expect do
           client['change-stream'].watch
-        end.to raise_error(Mongo::Error::OperationFailure, /Failing command due to 'failCommand' failpoint \(10107\)/)
+        end.to raise_error(Mongo::Error::OperationFailure, /10107\b.*Failing command due to 'failCommand' failpoint/)
       end
     end
 
@@ -283,7 +283,7 @@ describe 'Change stream integration', retry: 4 do
 
         expect do
           enum.next
-        end.to raise_error(Mongo::Error::OperationFailure, /Failing command due to 'failCommand' failpoint \(101\)/)
+        end.to raise_error(Mongo::Error::OperationFailure, /101\b.*Failing command due to 'failCommand' failpoint/)
       end
     end
   end
@@ -414,7 +414,7 @@ describe 'Change stream integration', retry: 4 do
 
           expect do
             enum.try_next
-          end.to raise_error(Mongo::Error::OperationFailure, /Failing command due to 'failCommand' failpoint \(10107\)/)
+          end.to raise_error(Mongo::Error::OperationFailure, /10107\b.*Failing command due to 'failCommand' failpoint/)
         end
       end
 
@@ -441,7 +441,7 @@ describe 'Change stream integration', retry: 4 do
 
           expect do
             enum.try_next
-          end.to raise_error(Mongo::Error::OperationFailure, /Failing command due to 'failCommand' failpoint \(10107\)/)
+          end.to raise_error(Mongo::Error::OperationFailure, /10107\b.*Failing command due to 'failCommand' failpoint/)
         end
       end
     end

data/spec/integration/command_monitoring_spec.rb

@@ -135,8 +135,8 @@ describe 'Command monitoring' do
 
       subscriber.clear_events!
       expect do
-        command.execute(server, client: nil)
-      end.to raise_error(Mongo::Error::OperationFailure, /Not enough data-bearing nodes \(100\)/)
+        command.execute(server, context: Mongo::Operation::Context.new(session: session))
+      end.to raise_error(Mongo::Error::OperationFailure, /100\b.*Not enough data-bearing nodes/)
 
       expect(subscriber.started_events.length).to eq(1)
       event = subscriber.started_events.first

data/spec/integration/connection_spec.rb

@@ -232,6 +232,8 @@ describe 'Connections' do
     end
 
     describe 'wire protocol version range update' do
+      require_no_required_api_version
+
       # 3.2 wire protocol is 4.
       # Wire protocol < 2 means only scram auth is available,
       # which is not supported by modern mongos.

data/spec/integration/docs_examples_spec.rb

@@ -4,7 +4,14 @@ describe 'aggregation examples in Ruby' do
   before(:all) do
     # In sharded clusters we need to ensure the database exists before running
     # the tests in this file.
-    ClientRegistry.instance.global_client('authorized')['_placeholder'].create
+    begin
+      ClientRegistry.instance.global_client('authorized')['_placeholder'].create
+    rescue Mongo::Error::OperationFailure => e
+      # Collection already exists
+      if e.code != 48
+        raise
+      end
+    end
   end
 
   let(:client) do

data/spec/integration/fork_reconnect_spec.rb

@@ -18,7 +18,10 @@ describe 'fork reconnect' do
 
   describe 'monitoring connection' do
     let(:monitor) do
-      Mongo::Server::Monitor.new(server, [], Mongo::Monitoring.new, server.options)
+      Mongo::Server::Monitor.new(server, [], Mongo::Monitoring.new, server.options.merge(
+        app_metadata: client.cluster.monitor_app_metadata,
+        push_monitor_app_metadata: client.cluster.push_monitor_app_metadata,
+      ))
     end
 
     it 'reconnects' do

data/spec/integration/ocsp_verifier_spec.rb

@@ -42,7 +42,7 @@ describe Mongo::Socket::OcspVerifier do
           lambda do
             verifier.verify
           end.should raise_error(Mongo::Error::ServerCertificateRevoked)
-        end.should take_shorter_than 3
+        end.should take_shorter_than 7
       end
     end
 
@@ -76,7 +76,7 @@ describe Mongo::Socket::OcspVerifier do
     end
 
     let(:verifier) do
-      described_class.new('foo', cert, ca_cert, cert_store, timeout: 3)
+      described_class.new('foo', cert, ca_cert, cert_store, timeout: 7)
     end
   end
 
@@ -101,7 +101,7 @@ describe Mongo::Socket::OcspVerifier do
           # the operation complete quickly.
           lambda do
             verifier.verify
-          end.should take_shorter_than 3
+          end.should take_shorter_than 7
         end
       end
 
@@ -124,7 +124,7 @@ describe Mongo::Socket::OcspVerifier do
             it 'does not wait for the timeout' do
               lambda do
                 verifier.verify
-              end.should take_shorter_than 3
+              end.should take_shorter_than 7
             end
           end
 
@@ -152,7 +152,7 @@ describe Mongo::Socket::OcspVerifier do
             it 'does not wait for the timeout' do
               lambda do
                 verifier.verify
-              end.should take_shorter_than 3
+              end.should take_shorter_than 7
             end
           end
         end
@@ -198,7 +198,7 @@ describe Mongo::Socket::OcspVerifier do
         it 'does not wait for the timeout' do
           lambda do
             verifier.verify
-          end.should take_shorter_than 3
+          end.should take_shorter_than 7
         end
       end
 
@@ -228,7 +228,7 @@ describe Mongo::Socket::OcspVerifier do
         it 'does not wait for the timeout' do
           lambda do
             verifier.verify
-          end.should take_shorter_than 3
+          end.should take_shorter_than 7
         end
       end
     end
@@ -278,6 +278,8 @@ describe Mongo::Socket::OcspVerifier do
         ensure
           server.shutdown
         end
+
+        ::Utils.wait_for_port_free(8100, 5)
       end
 
       [400, 404, 500, 503].each do |_code|
@@ -312,6 +314,9 @@ describe Mongo::Socket::OcspVerifier do
   context 'responder URI has no path' do
     require_external_connectivity
 
+    # https://github.com/jruby/jruby-openssl/issues/210
+    fails_on_jruby
+
     include_context 'basic verifier'
 
     let(:cert_path) { File.join(File.dirname(__FILE__), '../support/certificates/atlas-ocsp.crt') }
@@ -323,6 +328,7 @@ describe Mongo::Socket::OcspVerifier do
     end
 
     before do
+      verifier.ocsp_uris.length.should > 0
       URI.parse(verifier.ocsp_uris.first).path.should == ''
     end
 

data/spec/integration/operation_failure_code_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'OperationFailure code' do
-  let(:collection_name) { 'operation_error_code_spec' }
+  let(:collection_name) { 'operation_failure_code_spec' }
   let(:collection) { authorized_client[collection_name] }
 
   before do

data/spec/integration/operation_failure_message_spec.rb

@@ -0,0 +1,90 @@
+require 'spec_helper'
+
+describe 'OperationFailure message' do
+  let(:client) { authorized_client }
+  let(:collection_name) { 'operation_failure_message_spec' }
+  let(:collection) { client[collection_name] }
+
+  context 'crud error' do
+    before do
+      collection.delete_many
+    end
+
+    context 'a command error with code and code name' do
+      context 'on modern servers that provide code name' do
+        # Sharded clusters include the code name: SERVER-55582
+        require_topology :single, :replica_set
+
+        min_server_fcv '3.4'
+
+        it 'reports code, code name and message' do
+          begin
+            client.command(bogus_command: nil)
+            fail('Should have raised')
+          rescue Mongo::Error::OperationFailure => e
+            e.code_name.should == 'CommandNotFound'
+            e.message.should =~ %r,\A\[59:CommandNotFound\]: no such (?:command|cmd): '?bogus_command'?,
+          end
+        end
+      end
+
+      context 'on legacy servers where code name is not provided' do
+        max_server_version '3.2'
+
+        it 'reports code and message' do
+          begin
+            client.command(bogus_command: nil)
+            fail('Should have raised')
+          rescue Mongo::Error::OperationFailure => e
+            e.code_name.should be nil
+            e.message.should =~ %r,\A\[59\]: no such (?:command|cmd): '?bogus_command'?,
+          end
+        end
+      end
+    end
+
+    context 'a write error with code and no code name' do
+      # Sharded clusters include the code name: SERVER-55582
+      require_topology :single, :replica_set
+
+      it 'reports code name, code and message' do
+        begin
+          collection.insert_one(_id: 1)
+          collection.insert_one(_id: 1)
+          fail('Should have raised')
+        rescue Mongo::Error::OperationFailure => e
+          e.code_name.should be nil
+          e.message.should =~ %r,\A\[11000\]: (?:insertDocument :: caused by :: 11000 )?E11000 duplicate key error (?:collection|index):,
+        end
+      end
+    end
+  end
+
+  context 'authentication error' do
+    require_no_external_user
+
+    let(:client) do
+      authorized_client.with(user: 'bogus', password: 'bogus')
+    end
+
+    context 'on modern servers where code name is provided' do
+      min_server_fcv '3.4'
+
+      it 'includes code and code name in the message' do
+        lambda do
+          client.command(ping: 1)
+        end.should raise_error(Mongo::Auth::Unauthorized, /User bogus.*is not authorized.*\[18:AuthenticationFailed\]: Authentication failed/)
+      end
+    end
+
+    context 'on legacy servers where code name is not provided' do
+      max_server_version '3.2'
+
+      it 'includes code only in the message' do
+        lambda do
+          client.command(ping: 1)
+        end.should raise_error(Mongo::Auth::Unauthorized, /User bogus.*is not authorized.*\[18\]: (?:Authentication|auth) failed/)
+      end
+    end
+  end
+end

data/spec/integration/reconnect_spec.rb

@@ -65,7 +65,7 @@ describe 'Client after reconnect' do
     end
 
     let(:client) do
-      new_local_client(uri, SpecConfig.instance.ssl_options.merge(
+      new_local_client(uri, SpecConfig.instance.monitoring_options.merge(
         server_selection_timeout: 3.86, logger: logger))
     end
 

data/spec/integration/sdam_error_handling_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'SDAM error handling' do
-  clean_slate_for_all
+  clean_slate
 
   after do
     # Close all clients after every test to avoid leaking expectations into

data/spec/integration/sdam_events_spec.rb

@@ -67,10 +67,8 @@ describe 'SDAM events' do
         started_events.length.should <= 10
 
         succeeded_events = subscriber.select_succeeded_events(Mongo::Monitoring::Event::ServerHeartbeatSucceeded)
-        # Since we gracefully close the client, we expect each heartbeat
-        # to complete.
         started_events.length.should > 1
-        (succeeded_events.length-1..succeeded_events.length).should include(started_events.length)
+        (succeeded_events.length..succeeded_events.length+1).should include(started_events.length)
       end
     end
 
@@ -109,9 +107,9 @@ describe 'SDAM events' do
         # There may be in-flight ismasters that don't complete, both
         # regular and awaited.
         started_awaited.length.should > 1
-        (succeeded_awaited.length-1..succeeded_awaited.length).should include(started_awaited.length)
+        (succeeded_awaited.length..succeeded_awaited.length+1).should include(started_awaited.length)
         started_regular.length.should > 1
-        (succeeded_regular.length-1..succeeded_regular.length).should include(started_regular.length)
+        (succeeded_regular.length..succeeded_regular.length+1).should include(started_regular.length)
       end
     end
   end

data/spec/integration/snappy_compression_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe 'Snappy compression' do
+  require_snappy_compression
+
+  before do
+    authorized_client['test'].drop
+  end
+
+  context 'when client has snappy compressor option enabled' do
+    it 'compresses the message to the server' do
+      # Double check that the client has snappy compression enabled
+      expect(authorized_client.options[:compressors]).to include('snappy')
+
+      expect(Mongo::Protocol::Compressed).to receive(:new).twice.and_call_original
+      expect(Snappy).to receive(:deflate).twice.and_call_original
+      expect(Snappy).to receive(:inflate).twice.and_call_original
+
+      authorized_client['test'].insert_one(_id: 1, text: 'hello world')
+      document = authorized_client['test'].find(_id: 1).first
+
+      expect(document['text']).to eq('hello world')
+    end
+  end
+end

data/spec/integration/srv_monitoring_spec.rb

@@ -117,7 +117,7 @@ describe 'SRV Monitoring' do
 
     let(:client) do
       new_local_client(uri,
-        SpecConfig.instance.ssl_options.merge(
+        SpecConfig.instance.monitoring_options.merge(
           server_selection_timeout: 3.16,
           socket_timeout: 8.11,
           connect_timeout: 8.12,

data/spec/integration/transactions_examples_spec.rb

@@ -8,6 +8,12 @@ describe 'Transactions examples' do
     authorized_client.with(read_concern: {level: :majority}, write: {w: :majority})
   end
 
+  before do
+    if SpecConfig.instance.client_debug?
+      Mongo::Logger.logger.level = 0
+    end
+  end
+
   let(:hr) do
     client.use(:hr).database
   end

data/spec/integration/zlib_compression_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'Zlib compression' do
-  require_compression
+  require_zlib_compression
 
   before do
     authorized_client['test'].drop

data/spec/integration/zstd_compression_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe 'Zstd compression' do
+  min_server_version '4.2'
+  require_zstd_compression
+
+  before do
+    authorized_client['test'].drop
+  end
+
+  context 'when client has snappy compressor option enabled' do
+    it 'compresses the message to the server' do
+      # Double check that the client has zstd compression enabled
+      expect(authorized_client.options[:compressors]).to include('zstd')
+
+      expect(Mongo::Protocol::Compressed).to receive(:new).twice.and_call_original
+      expect(Zstd).to receive(:compress).twice.and_call_original
+      expect(Zstd).to receive(:decompress).twice.and_call_original
+
+      authorized_client['test'].insert_one(_id: 1, text: 'hello world')
+      document = authorized_client['test'].find(_id: 1).first
+
+      expect(document['text']).to eq('hello world')
+    end
+  end
+end