mongo 2.13.2 → 2.15.0

data/spec/mongo/auth/invalid_mechanism_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 
 describe Mongo::Auth::InvalidMechanism do

data/spec/mongo/auth/ldap/conversation_spec.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::LDAP::Conversation do
 
   let(:user) do
     Mongo::Auth::User.new(
-      database: Mongo::Database::ADMIN,
+      database: '$external',
       user: 'user',
       password: 'pencil'
     )

data/spec/mongo/auth/ldap_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::LDAP do
@@ -11,7 +14,11 @@ describe Mongo::Auth::LDAP do
   end
 
   let(:user) do
-    Mongo::Auth::User.new(database: SpecConfig.instance.test_db, user: 'driver', password: 'password')
+    Mongo::Auth::User.new(
+      database: '$external',
+      user: 'driver',
+      password: 'password',
+    )
   end
 
   describe '#login' do

data/spec/mongo/auth/scram/conversation_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/scram_conversation'
 

data/spec/mongo/auth/scram256/conversation_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 require 'support/shared/scram_conversation'
 

data/spec/mongo/auth/scram_negotiation_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 # max_pool_size is set to 1 to force a single connection being used for
@@ -329,7 +332,7 @@ describe 'SCRAM-SHA auth mechanism negotiation' do
     end
 
     let(:client) do
-      new_local_client(uri, SpecConfig.instance.ssl_options.merge(max_pool_size: 1))
+      new_local_client(uri, SpecConfig.instance.monitoring_options.merge(max_pool_size: 1))
     end
 
     context 'when the user exists' do

data/spec/mongo/auth/scram_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::Scram do
@@ -8,7 +11,7 @@ describe Mongo::Auth::Scram do
   end
 
   let(:connection) do
-    Mongo::Server::Connection.new(server, SpecConfig.instance.test_options)
+    Mongo::Server::Connection.new(server, SpecConfig.instance.monitoring_options)
   end
 
   let(:cache_mod) { Mongo::Auth::CredentialCache }

data/spec/mongo/auth/stringprep/profiles/sasl_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::StringPrep::Profiles::SASL do

data/spec/mongo/auth/stringprep_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::StringPrep do

data/spec/mongo/auth/user/view_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::User::View do

data/spec/mongo/auth/user_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::User do
@@ -55,7 +58,7 @@ describe Mongo::Auth::User do
       let(:options) { {auth_mech: 'scram'} }
 
       context 'not linting' do
-        skip_if_linting
+        require_no_linting
 
         it 'warns' do
           expect(Mongo::Logger.logger).to receive(:warn)

data/spec/mongo/auth/x509/conversation_spec.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::X509::Conversation do
 
   let(:user) do
     Mongo::Auth::User.new(
-      database: Mongo::Database::ADMIN,
+      database: '$external',
       user: 'user',
     )
   end
@@ -35,7 +38,7 @@ describe Mongo::Auth::X509::Conversation do
 
       let(:user) do
         Mongo::Auth::User.new(
-          database: Mongo::Database::ADMIN
+          database: '$external',
         )
       end
 
@@ -52,7 +55,7 @@ describe Mongo::Auth::X509::Conversation do
 
       let(:user) do
         Mongo::Auth::User.new(
-          database: Mongo::Database::ADMIN,
+          database: '$external',
           user: nil
         )
       end

data/spec/mongo/auth/x509_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth::X509 do

data/spec/mongo/auth_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Auth do

data/spec/mongo/bson_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Symbol do

data/spec/mongo/bulk_write/ordered_combiner_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::BulkWrite::OrderedCombiner do

data/spec/mongo/bulk_write/result_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'lite_spec_helper'
 
 describe Mongo::BulkWrite::Result do

data/spec/mongo/bulk_write/unordered_combiner_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::BulkWrite::UnorderedCombiner do

data/spec/mongo/bulk_write_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::BulkWrite do
@@ -1335,7 +1338,7 @@ describe Mongo::BulkWrite do
             context 'when the number of updates exceeds the max batch size' do
               # Test uses doubles for server descriptions, doubles are
               # incompatible with freezing which linting does for descriptions
-              skip_if_linting
+              require_no_linting
 
               let(:batch_size) do
                 11
@@ -2012,7 +2015,7 @@ describe Mongo::BulkWrite do
       context 'when the operations need to be split' do
         # Test uses doubles for server descriptions, doubles are
         # incompatible with freezing which linting does for descriptions
-        skip_if_linting
+        require_no_linting
 
         let(:batch_size) do
           11

data/spec/mongo/caching_cursor_spec.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Mongo::CachingCursor do
+
+  around do |spec|
+    Mongo::QueryCache.clear
+    Mongo::QueryCache.cache { spec.run }
+  end
+
+  let(:authorized_collection) do
+    authorized_client['caching_cursor']
+  end
+
+  before do
+    authorized_collection.drop
+  end
+
+  let(:server) do
+    view.send(:server_selector).select_server(authorized_client.cluster)
+  end
+
+  let(:reply) do
+    view.send(:send_initial_query, server)
+  end
+
+  let(:cursor) do
+    described_class.new(view, reply, server)
+  end
+
+  let(:view) do
+    Mongo::Collection::View.new(authorized_collection)
+  end
+
+  before do
+    authorized_collection.delete_many
+    3.times { |i| authorized_collection.insert_one(_id: i) }
+  end
+
+  describe '#cached_docs' do
+    context 'when no query has been performed' do
+      it 'returns nil' do
+        expect(cursor.cached_docs).to be_nil
+      end
+    end
+
+    context 'when a query has been performed' do
+      it 'returns the number of documents' do
+        cursor.to_a
+        expect(cursor.cached_docs.length).to eq(3)
+        expect(cursor.cached_docs).to eq([{ '_id' => 0 }, { '_id' => 1 }, { '_id' => 2 }])
+      end
+    end
+  end
+
+  describe '#try_next' do
+    it 'fetches the next document' do
+      expect(cursor.try_next).to eq('_id' => 0)
+      expect(cursor.try_next).to eq('_id' => 1)
+      expect(cursor.try_next).to eq('_id' => 2)
+    end
+  end
+
+  describe '#each' do
+    it 'iterates the cursor' do
+      result = cursor.each.to_a
+      expect(result.length).to eq(3)
+      expect(result).to eq([{ '_id' => 0 }, { '_id' => 1 }, { '_id' => 2 }])
+    end
+  end
+end

data/spec/mongo/client_construction_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Mongo::Client do
@@ -95,7 +98,7 @@ describe Mongo::Client do
           expect(time_taken).to be < 5
 
           # run a command to ensure the client is a working one
-          client.database.command(ismaster: 1)
+          client.database.command(ping: 1)
         end
       end
     end
@@ -463,7 +466,56 @@ describe Mongo::Client do
             SpecConfig.instance.all_test_options.merge(options))
         end
 
-        context 'when the compressor is supported' do
+        context 'when the compressor is not supported by the driver' do
+          require_warning_clean
+
+          let(:options) do
+            { compressors: ['snoopy'] }
+          end
+
+          it 'does not set the compressor and warns' do
+            expect(Mongo::Logger.logger).to receive(:warn).with(/Unsupported compressor/)
+            expect(client.options['compressors']).to be_nil
+          end
+
+          it 'sets the compression key of the handshake document to an empty array' do
+            expect(client.cluster.app_metadata.send(:document)[:compression]).to eq([])
+          end
+
+          context 'when one supported compressor and one unsupported compressor are provided' do
+            require_compression
+            min_server_fcv '3.6'
+
+            let(:options) do
+              { compressors: ['zlib', 'snoopy'] }
+            end
+
+            it 'does not set the unsupported compressor and warns' do
+              expect(Mongo::Logger.logger).to receive(:warn).at_least(:once)
+              expect(client.options['compressors']).to eq(['zlib'])
+            end
+
+            it 'sets the compression key of the handshake document to the list of supported compressors' do
+              expect(client.cluster.app_metadata.send(:document)[:compression]).to eq(['zlib'])
+            end
+          end
+        end
+
+        context 'when the compressor is not supported by the server' do
+          max_server_version '3.4'
+
+          let(:options) do
+            { compressors: ['zlib'] }
+          end
+
+          it 'does not set the compressor and warns' do
+            expect(Mongo::Logger.logger).to receive(:warn).at_least(:once)
+            expect(client.cluster.next_primary.monitor.compressor).to be_nil
+          end
+        end
+
+        context 'when zlib compression is requested' do
+          require_zlib_compression
 
           let(:options) do
             { compressors: ['zlib'] }
@@ -478,7 +530,6 @@ describe Mongo::Client do
           end
 
           context 'when server supports compression' do
-            require_compression
             min_server_fcv '3.6'
 
             it 'uses compression for messages' do
@@ -495,50 +546,55 @@ describe Mongo::Client do
           end
         end
 
-        context 'when the compressor is not supported by the driver' do
+        context 'when snappy compression is requested and supported by the server' do
+          min_server_version '3.6'
 
           let(:options) do
-            { compressors: ['snoopy'] }
-          end
-
-          it 'does not set the compressor and warns' do
-            expect(Mongo::Logger.logger).to receive(:warn)
-            expect(client.options['compressors']).to be_nil
+            { compressors: ['snappy'] }
           end
 
-          it 'sets the compression key of the handshake document to an empty array' do
-            expect(client.cluster.app_metadata.send(:document)[:compression]).to eq([])
-          end
-
-          context 'when one supported compressor and one unsupported compressor are provided' do
-            require_compression
-            min_server_fcv '3.6'
+          context 'when snappy gem is installed' do
+            require_snappy_compression
 
-            let(:options) do
-              { compressors: ['zlib', 'snoopy'] }
+            it 'creates the client' do
+              expect(client.options['compressors']).to eq(['snappy'])
             end
+          end
 
-            it 'does not set the unsupported compressor and warns' do
-              expect(Mongo::Logger.logger).to receive(:warn).at_least(:once)
-              expect(client.options['compressors']).to eq(['zlib'])
-            end
+          context 'when snappy gem is not installed' do
+            require_no_snappy_compression
 
-            it 'sets the compression key of the handshake document to the list of supported compressors' do
-              expect(client.cluster.app_metadata.send(:document)[:compression]).to eq(['zlib'])
+            it 'raises an exception' do
+              expect do
+                client
+              end.to raise_error(Mongo::Error::UnmetDependency, /Cannot enable snappy compression/)
             end
           end
         end
 
-        context 'when the compressor is not supported by the server' do
-          max_server_version '3.4'
+        context 'when zstd compression is requested and supported by the server' do
+          min_server_version '4.2'
 
           let(:options) do
-            { compressors: ['zlib'] }
+            { compressors: ['zstd'] }
           end
 
-          it 'does not set the compressor and warns' do
-            expect(Mongo::Logger.logger).to receive(:warn).at_least(:once)
-            expect(client.cluster.next_primary.monitor.compressor).to be_nil
+          context 'when zstd gem is installed' do
+            require_zstd_compression
+
+            it 'creates the client' do
+              expect(client.options['compressors']).to eq(['zstd'])
+            end
+          end
+
+          context 'when zstd gem is not installed' do
+            require_no_zstd_compression
+
+            it 'raises an exception' do
+              expect do
+                client
+              end.to raise_error(Mongo::Error::UnmetDependency, /Cannot enable zstd compression/)
+            end
           end
         end
       end
@@ -674,7 +730,7 @@ describe Mongo::Client do
       context 'when providing a custom logger' do
 
         let(:logger) do
-          Logger.new($stdout).tap do |l|
+          Logger.new(STDOUT).tap do |l|
             l.level = Logger::FATAL
           end
         end
@@ -844,13 +900,14 @@ describe Mongo::Client do
         end
 
         context 'mri' do
-          only_mri
+          require_mri
 
           let(:platform_string) do
             [
               "Ruby #{RUBY_VERSION}",
               RUBY_PLATFORM,
-              RbConfig::CONFIG['build']
+              RbConfig::CONFIG['build'],
+              'A',
             ].join(', ')
           end
 
@@ -868,7 +925,8 @@ describe Mongo::Client do
               "like Ruby #{RUBY_VERSION}",
               RUBY_PLATFORM,
               "JVM #{java.lang.System.get_property('java.version')}",
-              RbConfig::CONFIG['build']
+              RbConfig::CONFIG['build'],
+              'A',
             ].join(', ')
           end
 
@@ -1311,7 +1369,7 @@ describe Mongo::Client do
         end
 
         context 'when not linting' do
-          skip_if_linting
+          require_no_linting
 
           it 'rejects bogus read preference as symbol' do
             expect do
@@ -1343,6 +1401,46 @@ describe Mongo::Client do
         end
       end
 
+      context 'when setting read concern options' do
+        min_server_fcv '3.2'
+
+        context 'when read concern is valid' do
+          let(:options) do
+            { read_concern: { level: :local } }
+          end
+
+          it 'does not warn' do
+            expect(Mongo::Logger.logger).to_not receive(:warn)
+            new_local_client_nmio(SpecConfig.instance.addresses, options)
+          end
+        end
+
+        context 'when read concern has an invalid key' do
+          require_no_linting
+
+          let(:options) do
+            { read_concern: { hello: :local } }
+          end
+
+          it 'logs a warning' do
+            expect(Mongo::Logger.logger).to receive(:warn).with(/Read concern has invalid keys: hello/)
+            new_local_client_nmio(SpecConfig.instance.addresses, options)
+          end
+        end
+
+        context 'when read concern has a non-user-settable key' do
+          let(:options) do
+            { read_concern: { after_cluster_time: 100 } }
+          end
+
+          it 'raises an exception' do
+            expect do
+              new_local_client_nmio(SpecConfig.instance.addresses, options)
+            end.to raise_error(Mongo::Error::InvalidReadConcern, 'The after_cluster_time read_concern option cannot be specified by the user')
+          end
+        end
+      end
+
       context 'when an invalid option is provided' do
 
         let(:options) do
@@ -1494,6 +1592,109 @@ describe Mongo::Client do
           end
         end
       end
+
+      context ':auth_mech_properties option' do
+        context 'is nil' do
+          let(:options) do
+            {auth_mech_properties: nil}
+          end
+
+          it 'creates the client without the option' do
+            client.options.should_not have_key(:auth_mech_properties)
+          end
+        end
+      end
+
+      context ':server_api parameter' do
+        context 'is a hash with symbol keys' do
+          context 'using known keys' do
+            let(:options) do
+              {server_api: {
+                version: '1',
+                strict: true,
+                deprecation_errors: false,
+              }}
+            end
+
+            it 'is accepted' do
+              client.options[:server_api].should == {
+                'version' => '1',
+                'strict' => true,
+                'deprecation_errors' => false,
+              }
+            end
+          end
+
+          context 'using an unknown version' do
+            let(:options) do
+              {server_api: {
+                version: '42',
+              }}
+            end
+
+            it 'is rejected' do
+              lambda do
+                client
+              end.should raise_error(ArgumentError, 'Unknown server API version: 42')
+            end
+          end
+
+          context 'using an unknown option' do
+            let(:options) do
+              {server_api: {
+                vversion: '1',
+              }}
+            end
+
+            it 'is rejected' do
+              lambda do
+                client
+              end.should raise_error(ArgumentError, 'Unknown keys under :server_api: "vversion"')
+            end
+          end
+
+          context 'using a value which is not a hash' do
+            let(:options) do
+              {server_api: 42}
+            end
+
+            it 'is rejected' do
+              lambda do
+                client
+              end.should raise_error(ArgumentError, ':server_api value must be a hash: 42')
+            end
+          end
+        end
+
+        context 'when connected to a pre-OP_MSG server' do
+          max_server_version '3.4'
+
+          let(:options) do
+            {server_api: {version: 1}}
+          end
+
+          let(:client) do
+            new_local_client(SpecConfig.instance.addresses,
+              SpecConfig.instance.all_test_options.merge(options))
+          end
+
+          it 'constructs the client' do
+            client.should be_a(Mongo::Client)
+          end
+
+          it 'does not discover servers' do
+            client.cluster.servers_list.each do |s|
+              expect(s.status).to eq('UNKNOWN')
+            end
+          end
+
+          it 'fails operations' do
+            lambda do
+              client.command(ping: 1)
+            end.should raise_error(Mongo::Error::NoServerAvailable)
+          end
+        end
+      end
     end
 
     context 'when making a block client' do
@@ -2134,6 +2335,37 @@ describe Mongo::Client do
         new_client.cluster.topology.class.should_not be Mongo::Cluster::Topology::Unknown
       end
     end
+
+    context 'when :server_api is changed' do
+
+      let(:client) do
+        new_local_client_nmio(['127.0.0.1:27017'])
+      end
+
+      let(:new_client) do
+        client.with(server_api: {version: '1'})
+      end
+
+      it 'changes :server_api' do
+        new_client.options[:server_api].should == {'version' => '1'}
+      end
+    end
+
+    context 'when :server_api is cleared' do
+
+      let(:client) do
+        new_local_client_nmio(['127.0.0.1:27017'], server_api: {version: '1'})
+      end
+
+      let(:new_client) do
+        client.with(server_api: nil)
+      end
+
+      it 'clears :server_api' do
+        new_client.options[:server_api].should be nil
+      end
+    end
+
   end
 
   describe '#dup' do