mongo 2.13.2 → 2.14.0.rc1

data/spec/lite_spec_helper.rb

@@ -49,6 +49,7 @@ end
 autoload :Benchmark, 'benchmark'
 autoload :IceNine, 'ice_nine'
 autoload :Timecop, 'timecop'
+autoload :ChildProcess, 'childprocess'
 
 if BSON::Environment.jruby?
   require 'concurrent-ruby'
@@ -60,7 +61,7 @@ end
 require 'support/utils'
 require 'support/spec_config'
 
-Mongo::Logger.logger = Logger.new($stdout)
+Mongo::Logger.logger = Logger.new(STDOUT)
 unless SpecConfig.instance.client_debug?
   Mongo::Logger.logger.level = Logger::INFO
 end
@@ -76,6 +77,7 @@ require 'support/crypt'
 require 'support/json_ext_formatter'
 require 'support/sdam_formatter_integration'
 require 'support/background_thread_registry'
+require 'support/session_registry'
 
 if SpecConfig.instance.mri?
   require 'timeout_interrupt'
@@ -104,7 +106,7 @@ RSpec.configure do |config|
     end
   end
 
-  if SpecConfig.instance.ci? && !%w(1 true yes).include?(ENV['INTERACTIVE']&.downcase)
+  if SpecConfig.instance.ci?
     # Allow a max of 30 seconds per test.
     # Tests should take under 10 seconds ideally but it seems
     # we have some that run for more than 10 seconds in CI.

data/spec/mongo/address_spec.rb

@@ -234,7 +234,7 @@ describe Mongo::Address do
       end
 
       let(:address) do
-        Mongo::Address.new(custom_hostname)
+        Mongo::Address.new("#{custom_hostname}:#{SpecConfig.instance.any_port}")
       end
 
       before do

data/spec/mongo/caching_cursor_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe Mongo::CachingCursor do
+
+  around do |spec|
+    Mongo::QueryCache.clear
+    Mongo::QueryCache.cache { spec.run }
+  end
+
+  let(:authorized_collection) do
+    authorized_client['caching_cursor']
+  end
+
+  before do
+    authorized_collection.drop
+  end
+
+  let(:server) do
+    view.send(:server_selector).select_server(authorized_client.cluster)
+  end
+
+  let(:reply) do
+    view.send(:send_initial_query, server)
+  end
+
+  let(:cursor) do
+    described_class.new(view, reply, server)
+  end
+
+  let(:view) do
+    Mongo::Collection::View.new(authorized_collection)
+  end
+
+  before do
+    authorized_collection.delete_many
+    3.times { |i| authorized_collection.insert_one(_id: i) }
+  end
+
+  describe '#cached_docs' do
+    context 'when no query has been performed' do
+      it 'returns nil' do
+        expect(cursor.cached_docs).to be_nil
+      end
+    end
+
+    context 'when a query has been performed' do
+      it 'returns the number of documents' do
+        cursor.to_a
+        expect(cursor.cached_docs.length).to eq(3)
+        expect(cursor.cached_docs).to eq([{ '_id' => 0 }, { '_id' => 1 }, { '_id' => 2 }])
+      end
+    end
+  end
+
+  describe '#try_next' do
+    it 'fetches the next document' do
+      expect(cursor.try_next).to eq('_id' => 0)
+      expect(cursor.try_next).to eq('_id' => 1)
+      expect(cursor.try_next).to eq('_id' => 2)
+    end
+  end
+
+  describe '#each' do
+    it 'iterates the cursor' do
+      result = cursor.each.to_a
+      expect(result.length).to eq(3)
+      expect(result).to eq([{ '_id' => 0 }, { '_id' => 1 }, { '_id' => 2 }])
+    end
+  end
+end

data/spec/mongo/client_construction_spec.rb

@@ -496,6 +496,7 @@ describe Mongo::Client do
         end
 
         context 'when the compressor is not supported by the driver' do
+          require_warning_clean
 
           let(:options) do
             { compressors: ['snoopy'] }
@@ -674,7 +675,7 @@ describe Mongo::Client do
       context 'when providing a custom logger' do
 
         let(:logger) do
-          Logger.new($stdout).tap do |l|
+          Logger.new(STDOUT).tap do |l|
             l.level = Logger::FATAL
           end
         end
@@ -1343,6 +1344,46 @@ describe Mongo::Client do
         end
       end
 
+      context 'when setting read concern options' do
+        min_server_fcv '3.2'
+
+        context 'when read concern is valid' do
+          let(:options) do
+            { read_concern: { level: :local } }
+          end
+
+          it 'does not warn' do
+            expect(Mongo::Logger.logger).to_not receive(:warn)
+            new_local_client_nmio(SpecConfig.instance.addresses, options)
+          end
+        end
+
+        context 'when read concern has an invalid key' do
+          skip_if_linting
+
+          let(:options) do
+            { read_concern: { hello: :local } }
+          end
+
+          it 'logs a warning' do
+            expect(Mongo::Logger.logger).to receive(:warn).with(/Read concern has invalid keys: hello/)
+            new_local_client_nmio(SpecConfig.instance.addresses, options)
+          end
+        end
+
+        context 'when read concern has a non-user-settable key' do
+          let(:options) do
+            { read_concern: { after_cluster_time: 100 } }
+          end
+
+          it 'raises an exception' do
+            expect do
+              new_local_client_nmio(SpecConfig.instance.addresses, options)
+            end.to raise_error(Mongo::Error::InvalidReadConcern, 'The after_cluster_time read_concern option cannot be specified by the user')
+          end
+        end
+      end
+
       context 'when an invalid option is provided' do
 
         let(:options) do
@@ -1494,6 +1535,18 @@ describe Mongo::Client do
           end
         end
       end
+
+      context ':auth_mech_properties option' do
+        context 'is nil' do
+          let(:options) do
+            {auth_mech_properties: nil}
+          end
+
+          it 'creates the client without the option' do
+            client.options.should_not have_key(:auth_mech_properties)
+          end
+        end
+      end
     end
 
     context 'when making a block client' do

data/spec/mongo/client_encryption_spec.rb

@@ -268,7 +268,7 @@ describe Mongo::ClientEncryption do
         it_behaves_like 'it creates a data key'
       end
 
-      context 'with https' do
+      context 'with invalid endpoint' do
         let(:options) do
           {
             master_key: {
@@ -279,26 +279,20 @@ describe Mongo::ClientEncryption do
           }
         end
 
-        it_behaves_like 'it creates a data key'
-      end
-
-      context 'with invalid endpoint' do
-        let(:options) do
-          {
-            master_key: {
-              key: aws_arn,
-              region: aws_region,
-              endpoint: "invalid-nonsense-endpoint.com"
-            }
-          }
+        let(:expected_message) do
+          # RUBY-2129: This error message could be more specific and inform the user
+          # that there is a problem with their KMS endpoint
+          if BSON::Environment.jruby?
+            /getservbyname.* failed/
+          else
+            /SocketError/
+          end
         end
 
         it 'raises an exception' do
-          # RUBY-2129: This error message could be more specific and inform the user
-          # that there is a problem with their KMS endpoint
           expect do
             data_key_id
-          end.to raise_error(Mongo::Error::KmsError, /SocketError/)
+          end.to raise_error(Mongo::Error::KmsError, expected_message)
         end
       end
 

data/spec/mongo/client_spec.rb

@@ -894,4 +894,44 @@ describe Mongo::Client do
       end
     end
   end
+
+  describe '#summary' do
+
+    context 'monitoring omitted' do
+      let(:client) do
+        new_local_client_nmio(
+          ['127.0.0.1:27017'],
+          :read => { :mode => :primary },
+          :database => SpecConfig.instance.test_db
+        )
+      end
+
+      it 'indicates lack of monitoring' do
+        client.summary.should =~ /servers=.*UNKNOWN.*NO-MONITORING/
+      end
+    end
+
+    context 'monitoring present' do
+      let(:client) do
+        authorized_client
+      end
+
+      it 'does not indicate lack of monitoring' do
+        client.summary.should =~ /servers=.*(STANDALONE|PRIMARY|MONGOS)/
+        client.summary.should_not =~ /servers=.*(STANDALONE|PRIMARY|MONGOS).*NO-MONITORING/
+      end
+    end
+
+    context 'background threads killed' do
+      let(:client) do
+        authorized_client.tap do |client|
+          client.cluster.servers.map(&:disconnect!)
+        end
+      end
+
+      it 'does not indicate lack of monitoring' do
+        client.summary.should =~ /servers=.*(STANDALONE|PRIMARY|MONGOS).*NO-MONITORING/
+      end
+    end
+  end
 end

data/spec/mongo/cluster/topology/single_spec.rb

@@ -113,19 +113,28 @@ describe Mongo::Cluster::Topology::Single do
           monitoring, temp_cluster)
       end
 
+      let(:server_1) do
+        double('server').tap do |server|
+          allow(server).to receive(:address).and_return(Mongo::Address.new('one'))
+        end
+      end
+
+      let(:server_2) do
+        double('server').tap do |server|
+          allow(server).to receive(:address).and_return(Mongo::Address.new('two'))
+        end
+      end
+
       let(:temp_cluster) do
         double('temp cluster').tap do |cluster|
-          allow(cluster).to receive(:servers_list).and_return([
-            double('server'),
-            double('server'),
-          ])
+          allow(cluster).to receive(:servers_list).and_return([server_1, server_2])
         end
       end
 
       it 'fails' do
         expect do
           topology
-        end.to raise_error(ArgumentError, 'Cannot instantiate a single topology with more than one server in the cluster')
+        end.to raise_error(ArgumentError, /Cannot instantiate a single topology with more than one server in the cluster: one, two/)
       end
     end
   end

data/spec/mongo/cluster_spec.rb

@@ -178,6 +178,9 @@ describe Mongo::Cluster do
     before do
       expect(server).to receive(:monitor).at_least(:once).and_return(monitor)
       expect(monitor).to receive(:scan!)
+
+      # scan! complains that there isn't a monitor on the server, calls summary
+      allow(monitor).to receive(:running?)
     end
 
     it 'returns true' do

data/spec/mongo/collection/view/explainable_spec.rb

@@ -20,12 +20,95 @@ describe Mongo::Collection::View::Explainable do
 
   describe '#explain' do
 
-    let(:explain) do
-      view.explain
+    shared_examples 'executes the explain' do
+      context '3.0+ server' do
+        min_server_fcv '3.0'
+
+        context 'not sharded' do
+          require_topology :single, :replica_set
+
+          it 'executes the explain' do
+            explain[:queryPlanner][:namespace].should == authorized_collection.namespace
+          end
+        end
+
+        context 'sharded' do
+          require_topology :sharded
+
+          context 'pre-3.2 server' do
+            max_server_version '3.0'
+
+            it 'executes the explain' do
+              explain[:queryPlanner][:parsedQuery].should be_a(Hash)
+            end
+          end
+
+          context '3.2+ server' do
+            min_server_fcv '3.2'
+
+            it 'executes the explain' do
+              explain[:queryPlanner][:mongosPlannerVersion].should == 1
+            end
+          end
+        end
+      end
+
+      context '2.6 server' do
+        max_server_version '2.6'
+
+        it 'executes the explain' do
+          explain[:cursor].should == 'BasicCursor'
+        end
+      end
+    end
+
+    context 'without arguments' do
+      let(:explain) do
+        view.explain
+      end
+
+      include_examples 'executes the explain'
     end
 
-    it 'executes an explain' do
-      expect(explain[:cursor] == 'BasicCursor' || explain[:queryPlanner]).to be_truthy
+    context 'with verbosity argument' do
+      let(:explain) do
+        view.explain(verbosity: verbosity)
+      end
+
+      shared_examples 'triggers server error' do
+        # 3.0 does not produce the error.
+        min_server_fcv '3.2'
+
+        it 'triggers server error' do
+          lambda do
+            explain
+          end.should raise_error(Mongo::Error::OperationFailure, /verbosity string must be/)
+        end
+      end
+
+      context 'valid symbol value' do
+        let(:verbosity) { :query_planner }
+
+        include_examples 'executes the explain'
+      end
+
+      context 'valid string value' do
+        let(:verbosity) { 'executionStats' }
+
+        include_examples 'executes the explain'
+      end
+
+      context 'invalid symbol value' do
+        let(:verbosity) { :bogus }
+
+        include_examples 'triggers server error'
+      end
+
+      context 'invalid string value' do
+        let(:verbosity) { 'bogus' }
+
+        include_examples 'triggers server error'
+      end
     end
   end
 end

data/spec/mongo/collection/view/map_reduce_spec.rb

@@ -581,6 +581,7 @@ describe Mongo::Collection::View::MapReduce do
 
       context 'when the server is not valid for writing' do
         clean_slate
+        require_warning_clean
 
         before do
           stop_monitoring(authorized_client)
@@ -661,6 +662,7 @@ describe Mongo::Collection::View::MapReduce do
 
       context 'when the server is a valid for writing' do
         clean_slate
+        require_warning_clean
 
         before do
           stop_monitoring(authorized_client)

data/spec/mongo/collection_spec.rb

@@ -821,6 +821,38 @@ describe Mongo::Collection do
           end
         end
 
+        context 'when write concern passed in as an option' do
+          min_server_fcv '3.4'
+          require_topology :replica_set
+
+          before do
+            database['collection_spec'].drop
+          end
+
+          let(:events) do
+            subscriber.command_started_events('create')
+          end
+
+          let(:options) do
+            { write_concern: {w: 1} }
+          end
+
+          let!(:collection) do
+            authorized_collection.with(options)
+          end
+
+          let!(:command) do
+            Utils.get_command_event(authorized_client, 'create') do |client|
+              collection.create({ write_concern: {w: 2} })
+            end.command
+          end
+
+          it 'applies the write concern passed in as an option' do
+            expect(events.length).to eq(1)
+            expect(command[:writeConcern][:w]).to eq(2)
+          end
+        end
+
         context 'when the server does not support write concern on the create command' do
           max_server_version '3.2'
 
@@ -1059,6 +1091,34 @@ describe Mongo::Collection do
           end
         end
 
+        context 'when write concern passed in as an option' do
+          min_server_fcv '3.4'
+          require_set_write_concern
+
+          let(:events) do
+            subscriber.command_started_events('drop')
+          end
+
+          let(:options) do
+            { write_concern: {w: 1} }
+          end
+
+          let!(:collection) do
+            authorized_collection.with(options)
+          end
+
+          let!(:command) do
+            Utils.get_command_event(authorized_client, 'drop') do |client|
+              collection.drop({ write_concern: {w: 0} })
+            end.command
+          end
+
+          it 'applies the write concern passed in as an option' do
+            expect(events.length).to eq(1)
+            expect(command[:writeConcern][:w]).to eq(0)
+          end
+        end
+
         context 'when the server does not support write concern on the drop command' do
           max_server_version '3.2'