mongo 2.13.0 → 2.15.0.alpha

data/spec/mongo/index/view_spec.rb

@@ -305,7 +305,8 @@ describe Mongo::Index::View do
                     { key: { testing: -1 }, unique: true },
                     { commit_quorum: 'unsupported-value' }
                   )
-                end.to raise_error(Mongo::Error::OperationFailure, /Commit quorum cannot be satisfied with the current replica set configuration/)
+                # 4.4.4 changed the text of the error message
+                end.to raise_error(Mongo::Error::OperationFailure, /Commit quorum cannot be satisfied with the current replica set configuration|No write concern mode named 'unsupported-value' found in replica set configuration/)
               end
             end
           end
@@ -649,6 +650,8 @@ describe Mongo::Index::View do
     end
 
     context 'when using bucket option' do
+      # Option is removed in 4.9
+      max_server_version '4.7'
 
       let(:spec) do
         { 'any' => 1 }
@@ -755,6 +758,8 @@ describe Mongo::Index::View do
       end
 
       context 'when using bucket option' do
+        # Option is removed in 4.9
+        max_server_version '4.7'
 
         let(:spec) do
           { 'any' => 1 }
@@ -964,7 +969,8 @@ describe Mongo::Index::View do
           it 'raises an exception' do
             expect do
               view.create_one({ 'x' => 1 }, commit_quorum: 'unsupported-value')
-            end.to raise_error(Mongo::Error::OperationFailure, /Commit quorum cannot be satisfied with the current replica set configuration/)
+            # 4.4.4 changed the text of the error message
+            end.to raise_error(Mongo::Error::OperationFailure, /Commit quorum cannot be satisfied with the current replica set configuration|No write concern mode named 'unsupported-value' found in replica set configuration/)
           end
         end
       end

data/spec/mongo/logger_spec.rb

@@ -6,6 +6,16 @@ describe Mongo::Logger do
     described_class.logger
   end
 
+  around do |example|
+    saved_logger = Mongo::Logger.logger
+
+    begin
+      example.run
+    ensure
+      Mongo::Logger.logger = saved_logger
+    end
+  end
+
   describe '.logger' do
 
     context 'when no logger has been set' do
@@ -18,25 +28,21 @@ describe Mongo::Logger do
         Mongo::Logger.logger = nil
       end
 
-      after do
-        Mongo::Logger.logger = test_logger
-      end
-
       it 'returns the default logger' do
-        expect(logger.level).to eq(Logger::DEBUG)
+        expect(logger.level).to eq(Logger::INFO)
       end
     end
 
     context 'when a logger has been set' do
 
       let(:info) do
-        Logger.new($stdout).tap do |log|
+        Logger.new(STDOUT).tap do |log|
           log.level = Logger::INFO
         end
       end
 
       let(:debug) do
-        Logger.new($stdout).tap do |log|
+        Logger.new(STDOUT).tap do |log|
           log.level = Logger::DEBUG
         end
       end
@@ -45,10 +51,6 @@ describe Mongo::Logger do
         described_class.logger = debug
       end
 
-      after do
-        described_class.logger = info
-      end
-
       it 'returns the provided logger' do
         expect(logger.level).to eq(Logger::DEBUG)
       end

data/spec/mongo/monitoring/event/server_closed_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::ServerClosed do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/server_heartbeat_failed_spec.rb

@@ -20,7 +20,7 @@ describe Mongo::Monitoring::Event::ServerHeartbeatFailed do
   end
 
   let(:event) do
-    described_class.new(address, 1, Mongo::Error::SocketError.new('foo'))
+    described_class.new(address, 1, Mongo::Error::SocketError.new('foo'), started_event: nil)
   end
 
   describe '#summary' do

data/spec/mongo/monitoring/event/server_heartbeat_succeeded_spec.rb

@@ -20,7 +20,7 @@ describe Mongo::Monitoring::Event::ServerHeartbeatSucceeded do
   end
 
   let(:event) do
-    described_class.new(address, 1)
+    described_class.new(address, 1, started_event: nil)
   end
 
   describe '#summary' do

data/spec/mongo/monitoring/event/server_opening_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::ServerOpening do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/topology_changed_spec.rb

@@ -28,7 +28,7 @@ describe Mongo::Monitoring::Event::TopologyChanged do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(prev_topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/topology_closed_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::TopologyClosed do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/topology_opening_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::TopologyOpening do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/operation/aggregate_spec.rb

@@ -19,6 +19,7 @@ describe Mongo::Operation::Aggregate do
   end
   let(:op) { described_class.new(spec) }
 
+  let(:context) { Mongo::Operation::Context.new }
 
   describe '#initialize' do
 
@@ -64,7 +65,7 @@ describe Mongo::Operation::Aggregate do
 
       it 'raises an exception' do
         expect {
-          op.execute(authorized_primary, client: nil)
+          op.execute(authorized_primary, context: context)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end

data/spec/mongo/operation/collections_info_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe Mongo::Operation::CollectionsInfo do
+  require_no_required_api_version
 
   let(:spec) do
     { selector: { listCollections: 1 },
@@ -16,6 +17,8 @@ describe Mongo::Operation::CollectionsInfo do
     described_class.new(spec)
   end
 
+  let(:context) { Mongo::Operation::Context.new }
+
   describe '#execute' do
 
     before do
@@ -31,7 +34,7 @@ describe Mongo::Operation::CollectionsInfo do
     end
 
     let(:info) do
-      docs = op.execute(authorized_primary, client: nil).documents
+      docs = op.execute(authorized_primary, context: context).documents
       docs.collect { |info| info['name'].sub("#{SpecConfig.instance.test_db}.", '') }
     end
 

data/spec/mongo/operation/command_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe Mongo::Operation::Command do
+  require_no_required_api_version
 
   let(:selector) { { :ismaster => 1 } }
   let(:options) { { :limit => -1 } }
@@ -12,6 +13,8 @@ describe Mongo::Operation::Command do
   end
   let(:op) { described_class.new(spec) }
 
+  let(:context) { Mongo::Operation::Context.new }
+
   describe '#initialize' do
 
     it 'sets the spec' do
@@ -43,7 +46,7 @@ describe Mongo::Operation::Command do
     context 'when the command succeeds' do
 
       let(:response) do
-        op.execute(authorized_primary, client: nil)
+        op.execute(authorized_primary, context: context)
       end
 
       it 'returns the reponse' do
@@ -59,7 +62,7 @@ describe Mongo::Operation::Command do
 
       it 'raises an exception' do
         expect {
-          op.execute(authorized_primary, client: nil)
+          op.execute(authorized_primary, context: context)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end
@@ -72,7 +75,7 @@ describe Mongo::Operation::Command do
 
       it 'raises an error' do
         expect {
-          op.execute(authorized_primary, client: nil)
+          op.execute(authorized_primary, context: context)
         }.to raise_error(Mongo::Error::MaxBSONSize)
       end
     end

data/spec/mongo/operation/create_index_spec.rb

@@ -1,6 +1,9 @@
 require 'spec_helper'
 
 describe Mongo::Operation::CreateIndex do
+  require_no_required_api_version
+
+  let(:context) { Mongo::Operation::Context.new }
 
   before do
     authorized_collection.drop
@@ -20,7 +23,7 @@ describe Mongo::Operation::CreateIndex do
       end
 
       let(:response) do
-        operation.execute(authorized_primary, client: nil)
+        operation.execute(authorized_primary, context: context)
       end
 
       it 'returns ok' do
@@ -43,12 +46,12 @@ describe Mongo::Operation::CreateIndex do
       end
 
       before do
-        operation.execute(authorized_primary, client: nil)
+        operation.execute(authorized_primary, context: context)
       end
 
       it 'raises an exception' do
         expect {
-          second_operation.execute(authorized_primary, client: nil)
+          second_operation.execute(authorized_primary, context: context)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end

data/spec/mongo/operation/create_user_spec.rb

@@ -1,6 +1,9 @@
 require 'spec_helper'
 
 describe Mongo::Operation::CreateUser do
+  require_no_required_api_version
+
+  let(:context) { Mongo::Operation::Context.new }
 
   describe '#execute' do
 
@@ -26,7 +29,7 @@ describe Mongo::Operation::CreateUser do
     context 'when user creation was successful' do
 
       let!(:response) do
-        operation.execute(root_authorized_primary, client: nil)
+        operation.execute(root_authorized_primary, context: context)
       end
 
       it 'saves the user in the database' do
@@ -38,8 +41,8 @@ describe Mongo::Operation::CreateUser do
 
       it 'raises an exception' do
         expect {
-          operation.execute(root_authorized_primary, client: nil)
-          operation.execute(root_authorized_primary, client: nil)
+          operation.execute(root_authorized_primary, context: context)
+          operation.execute(root_authorized_primary, context: context)
         }.to raise_error(Mongo::Error::OperationFailure)
       end
     end

data/spec/mongo/operation/delete/bulk_spec.rb

@@ -1,6 +1,9 @@
 require 'spec_helper'
 
 describe Mongo::Operation::Delete do
+  require_no_required_api_version
+
+  let(:context) { Mongo::Operation::Context.new }
 
   let(:documents) do
     [ { 'q' => { foo: 1 }, 'limit' => 1 } ]
@@ -100,7 +103,7 @@ describe Mongo::Operation::Delete do
 
         it 'deletes the document from the database' do
           authorized_primary.with_connection do |connection|
-            op.bulk_execute(connection, client: nil)
+            op.bulk_execute(connection, context: context)
           end
           expect(authorized_collection.find.count).to eq(1)
         end
@@ -125,7 +128,7 @@ describe Mongo::Operation::Delete do
 
         it 'deletes the documents from the database' do
           authorized_primary.with_connection do |connection|
-            op.bulk_execute(connection, client: nil)
+            op.bulk_execute(connection, context: context)
           end
           expect(authorized_collection.find.count).to eq(0)
         end
@@ -162,7 +165,7 @@ describe Mongo::Operation::Delete do
 
           it 'aborts after first error' do
             authorized_primary.with_connection do |connection|
-              failing_delete.bulk_execute(connection, client: nil)
+              failing_delete.bulk_execute(connection, context: context)
             end
             expect(authorized_collection.find.count).to eq(2)
           end
@@ -176,7 +179,7 @@ describe Mongo::Operation::Delete do
 
           it 'aborts after first error' do
             authorized_primary.with_connection do |connection|
-              failing_delete.bulk_execute(connection, client: nil)
+              failing_delete.bulk_execute(connection, context: context)
             end
             expect(authorized_collection.find.count).to eq(2)
           end
@@ -214,7 +217,7 @@ describe Mongo::Operation::Delete do
 
           it 'does not abort after first error' do
             authorized_primary.with_connection do |connection|
-              failing_delete.bulk_execute(connection, client: nil)
+              failing_delete.bulk_execute(connection, context: context)
             end
             expect(authorized_collection.find.count).to eq(1)
           end
@@ -228,7 +231,7 @@ describe Mongo::Operation::Delete do
 
           it 'does not abort after first error' do
             authorized_primary.with_connection do |connection|
-              failing_delete.bulk_execute(connection, client: nil)
+              failing_delete.bulk_execute(connection, context: context)
             end
             expect(authorized_collection.find.count).to eq(1)
           end

data/spec/mongo/operation/delete/op_msg_spec.rb

@@ -72,7 +72,7 @@ describe Mongo::Operation::Delete::OpMsg do
 
   describe 'write concern' do
     # https://jira.mongodb.org/browse/RUBY-2224
-    skip_if_linting
+    require_no_linting
 
     context 'when write concern is not specified' do
 
@@ -99,7 +99,7 @@ describe Mongo::Operation::Delete::OpMsg do
 
   describe '#message' do
     # https://jira.mongodb.org/browse/RUBY-2224
-    skip_if_linting
+    require_no_linting
 
     context 'when the server supports OP_MSG' do
 
@@ -152,7 +152,7 @@ describe Mongo::Operation::Delete::OpMsg do
 
         context 'when an implicit session is created and the topology is then updated and the server does not support sessions' do
           # Mocks on features are incompatible with linting
-          skip_if_linting
+          require_no_linting
 
           let(:expected_global_args) do
             global_args.dup.tap do |args|

data/spec/mongo/operation/delete_spec.rb

@@ -1,6 +1,8 @@
 require 'spec_helper'
 
 describe Mongo::Operation::Delete do
+  require_no_required_api_version
+
   before do
     begin
       authorized_collection.delete_many
@@ -30,6 +32,8 @@ describe Mongo::Operation::Delete do
 
   let(:op) { described_class.new(spec) }
 
+  let(:context) { Mongo::Operation::Context.new }
+
   describe '#initialize' do
 
     context 'spec' do
@@ -103,7 +107,7 @@ describe Mongo::Operation::Delete do
         end
 
         let(:result) do
-          delete.execute(authorized_primary, client: nil)
+          delete.execute(authorized_primary, context: context)
         end
 
         it 'deletes the documents from the database' do
@@ -123,7 +127,7 @@ describe Mongo::Operation::Delete do
 
         it 'raises an exception' do
           expect {
-            delete.execute(authorized_primary, client: nil)
+            delete.execute(authorized_primary, context: context)
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -147,7 +151,7 @@ describe Mongo::Operation::Delete do
         end
 
         let(:result) do
-          delete.execute(authorized_primary, client: nil)
+          delete.execute(authorized_primary, context: context)
         end
 
         it 'deletes the documents from the database' do
@@ -166,13 +170,13 @@ describe Mongo::Operation::Delete do
         end
 
         let(:result) do
-          delete.execute(authorized_primary, client: nil)
+          delete.execute(authorized_primary, context: context)
         end
 
         it 'does not delete any documents' do
 
           expect {
-            op.execute(authorized_primary, client: nil)
+            op.execute(authorized_primary, context: context)
           }.to raise_error(Mongo::Error::OperationFailure)
 
           expect(authorized_collection.find.count).to eq(2)
@@ -187,7 +191,7 @@ describe Mongo::Operation::Delete do
 
         it 'raises an error' do
           expect {
-            op.execute(authorized_primary, client: nil)
+            op.execute(authorized_primary, context: context)
           }.to raise_error(Mongo::Error::MaxBSONSize)
         end
       end
@@ -211,7 +215,7 @@ describe Mongo::Operation::Delete do
       end
 
       let(:result) do
-        delete.execute(authorized_primary, client: nil)
+        delete.execute(authorized_primary, context: context)
       end
 
       before do