mongo 2.13.0.beta1 → 2.14.0

data/spec/mongo/distinguishing_semaphore_spec.rb

@@ -0,0 +1,63 @@
+require 'lite_spec_helper'
+
+describe Mongo::DistinguishingSemaphore do
+  let(:semaphore) do
+    described_class.new
+  end
+
+  it 'waits until signaled' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(3)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    semaphore.signal
+    consumer.join
+
+    (Time.now - start_time).should < 1
+
+    result.should be true
+  end
+
+  it 'waits until broadcast' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(3)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    semaphore.broadcast
+    consumer.join
+
+    (Time.now - start_time).should < 1
+
+    result.should be true
+  end
+
+  it 'times out' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(2)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    consumer.join
+
+    (Time.now - start_time).should > 1
+
+    result.should be false
+  end
+end

data/spec/mongo/error/no_server_available_spec.rb

@@ -16,7 +16,7 @@ describe Mongo::Error::NoServerAvailable do
     end
 
     it 'is correct' do
-      expect(error.message).to eq('No primary server is available in cluster: #<Cluster topology=Unknown[127.0.0.1:27017] servers=[#<Server address=127.0.0.1:27017 UNKNOWN>]> with timeout=30, LT=0.015')
+      expect(error.message).to eq('No primary server is available in cluster: #<Cluster topology=Unknown[127.0.0.1:27017] servers=[#<Server address=127.0.0.1:27017 UNKNOWN NO-MONITORING>]> with timeout=30, LT=0.015')
     end
 
     context 'when cluster is nil' do

data/spec/mongo/error/operation_failure_spec.rb

@@ -227,6 +227,46 @@ describe Mongo::Error::OperationFailure do
         end
       end
 
+      context 'when the error code is 43 (CursorNotFound)' do
+        let(:error) { Mongo::Error::OperationFailure.new(nil, result, code: 43, code_name: 'CursorNotFound') }
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
+        context 'wire protocol < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            # CursorNotFound exceptions are resumable even if they don't have
+            # a ResumableChangeStreamError label because the server is not aware
+            # of the cursor id, and thus cannot determine if it is a change stream.
+            expect(error.change_stream_resumable?).to be true
+          end
+        end
+
+        context 'wire protocol >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns true' do
+            # CursorNotFound exceptions are resumable even if they don't have
+            # a ResumableChangeStreamError label because the server is not aware
+            # of the cursor id, and thus cannot determine if it is a change stream.
+            expect(error.change_stream_resumable?).to be true
+          end
+        end
+      end
+
       context 'not a getMore response' do
         let(:result) do
           Mongo::Operation::Result.new(

data/spec/mongo/index/view_spec.rb

@@ -261,7 +261,7 @@ describe Mongo::Index::View do
         context 'when commit quorum options are specified' do
           require_topology :replica_set, :sharded
           context 'on server versions >= 4.4' do
-            min_server_fcv '4.3'
+            min_server_fcv '4.4'
 
             let(:subscriber) { EventSubscriber.new }
 
@@ -325,6 +325,81 @@ describe Mongo::Index::View do
           end
         end
 
+        context 'when hidden is specified' do
+          let(:index) { view.get('with_hidden_1') }
+
+          context 'on server versions <= 3.2' do
+            # DRIVERS-1220 Server versions 3.2 and older do not perform any option
+            # checking on index creation. The server will allow the user to create
+            # the index with the hidden option, but the server does not support this
+            # option and will not use it.
+            max_server_fcv '3.2'
+
+            let!(:result) do
+              view.create_many({ key: { with_hidden: 1 }, hidden: true })
+            end
+
+            it 'returns ok' do
+              expect(result).to be_successful
+            end
+
+            it 'creates an index' do
+              expect(index).to_not be_nil
+            end
+          end
+
+          context 'on server versions between 3.4 and 4.2' do
+            max_server_fcv '4.2'
+            min_server_fcv '3.4'
+
+            it 'raises an exception' do
+              expect do
+                view.create_many({ key: { with_hidden: 1 }, hidden: true })
+              end.to raise_error(/The field 'hidden' is not valid for an index specification/)
+            end
+          end
+
+          context 'on server versions >= 4.4' do
+            min_server_fcv '4.4'
+
+            context 'when hidden is true' do
+              let!(:result) do
+                view.create_many({ key: { with_hidden: 1 }, hidden: true })
+              end
+
+              it 'returns ok' do
+                expect(result).to be_successful
+              end
+
+              it 'creates an index' do
+                expect(index).to_not be_nil
+              end
+
+              it 'applies the hidden option to the index' do
+                expect(index['hidden']).to be true
+              end
+            end
+
+            context 'when hidden is false' do
+              let!(:result) do
+                view.create_many({ key: { with_hidden: 1 }, hidden: false })
+              end
+
+              it 'returns ok' do
+                expect(result).to be_successful
+              end
+
+              it 'creates an index' do
+                expect(index).to_not be_nil
+              end
+
+              it 'does not apply the hidden option to the index' do
+                expect(index['hidden']).to be_nil
+              end
+            end
+          end
+        end
+
         context 'when collation is specified' do
           min_server_fcv '3.4'
 
@@ -773,10 +848,81 @@ describe Mongo::Index::View do
       end
     end
 
+    context 'when providing hidden option' do
+      let(:index) { view.get('with_hidden_1') }
+
+      context 'on server versions <= 3.2' do
+        # DRIVERS-1220 Server versions 3.2 and older do not perform any option
+        # checking on index creation. The server will allow the user to create
+        # the index with the hidden option, but the server does not support this
+        # option and will not use it.
+        max_server_fcv '3.2'
+
+        let!(:result) do
+          view.create_one({ 'with_hidden' => 1 }, { hidden: true })
+        end
+
+        it 'returns ok' do
+          expect(result).to be_successful
+        end
+
+        it 'creates an index' do
+          expect(index).to_not be_nil
+        end
+      end
+
+      context 'on server versions between 3.4 and 4.2' do
+        max_server_fcv '4.2'
+        min_server_fcv '3.4'
+
+        it 'raises an exception' do
+          expect do
+            view.create_one({ 'with_hidden' => 1 }, { hidden: true })
+          end.to raise_error(/The field 'hidden' is not valid for an index specification/)
+        end
+      end
+
+      context 'on server versions >= 4.4' do
+        min_server_fcv '4.4'
+
+        context 'when hidden is true' do
+          let!(:result) { view.create_one({ 'with_hidden' => 1 }, { hidden: true }) }
+
+          it 'returns ok' do
+            expect(result).to be_successful
+          end
+
+          it 'creates an index' do
+            expect(index).to_not be_nil
+          end
+
+          it 'applies the hidden option to the index' do
+            expect(index['hidden']).to be true
+          end
+        end
+
+        context 'when hidden is false' do
+          let!(:result) { view.create_one({ 'with_hidden' => 1 }, { hidden: false }) }
+
+          it 'returns ok' do
+            expect(result).to be_successful
+          end
+
+          it 'creates an index' do
+            expect(index).to_not be_nil
+          end
+
+          it 'does not apply the hidden option to the index' do
+            expect(index['hidden']).to be_nil
+          end
+        end
+      end
+    end
+
     context 'when providing commit_quorum option' do
       require_topology :replica_set, :sharded
       context 'on server versions >= 4.4' do
-        min_server_fcv '4.3'
+        min_server_fcv '4.4'
 
         let(:subscriber) { EventSubscriber.new }
 

data/spec/mongo/logger_spec.rb

@@ -6,6 +6,16 @@ describe Mongo::Logger do
     described_class.logger
   end
 
+  around do |example|
+    saved_logger = Mongo::Logger.logger
+
+    begin
+      example.run
+    ensure
+      Mongo::Logger.logger = saved_logger
+    end
+  end
+
   describe '.logger' do
 
     context 'when no logger has been set' do
@@ -18,25 +28,21 @@ describe Mongo::Logger do
         Mongo::Logger.logger = nil
       end
 
-      after do
-        Mongo::Logger.logger = test_logger
-      end
-
       it 'returns the default logger' do
-        expect(logger.level).to eq(Logger::DEBUG)
+        expect(logger.level).to eq(Logger::INFO)
       end
     end
 
     context 'when a logger has been set' do
 
       let(:info) do
-        Logger.new($stdout).tap do |log|
+        Logger.new(STDOUT).tap do |log|
           log.level = Logger::INFO
         end
       end
 
       let(:debug) do
-        Logger.new($stdout).tap do |log|
+        Logger.new(STDOUT).tap do |log|
           log.level = Logger::DEBUG
         end
       end
@@ -45,10 +51,6 @@ describe Mongo::Logger do
         described_class.logger = debug
       end
 
-      after do
-        described_class.logger = info
-      end
-
       it 'returns the provided logger' do
         expect(logger.level).to eq(Logger::DEBUG)
       end

data/spec/mongo/monitoring/event/server_closed_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::ServerClosed do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/server_description_changed_spec.rb

@@ -27,12 +27,9 @@ describe Mongo::Monitoring::Event::ServerDescriptionChanged do
   end
 
   describe '#summary' do
-    skip_if_linting
 
     it 'renders correctly' do
-      expect(topology).to receive(:server_descriptions).and_return({
-        '127.0.0.1:27017' => Mongo::Server::Description.new(Mongo::Address.new('127.0.0.1:27017'))})
-      expect(event.summary).to eq("#<ServerDescriptionChanged address=127.0.0.1:27017 topology=Unknown[127.0.0.1:27017] prev=#{previous_desc.inspect} new=#{updated_desc.inspect}>")
+      expect(event.summary).to eq("#<ServerDescriptionChanged address=127.0.0.1:27017 prev=UNKNOWN new=UNKNOWN>")
     end
   end
 end

data/spec/mongo/monitoring/event/server_opening_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::ServerOpening do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/topology_changed_spec.rb

@@ -28,7 +28,7 @@ describe Mongo::Monitoring::Event::TopologyChanged do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(prev_topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/topology_closed_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::TopologyClosed do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/monitoring/event/topology_opening_spec.rb

@@ -24,7 +24,7 @@ describe Mongo::Monitoring::Event::TopologyOpening do
   end
 
   describe '#summary' do
-    skip_if_linting
+    require_no_linting
 
     it 'renders correctly' do
       expect(topology).to receive(:server_descriptions).and_return({

data/spec/mongo/operation/delete/op_msg_spec.rb

@@ -72,7 +72,7 @@ describe Mongo::Operation::Delete::OpMsg do
 
   describe 'write concern' do
     # https://jira.mongodb.org/browse/RUBY-2224
-    skip_if_linting
+    require_no_linting
 
     context 'when write concern is not specified' do
 
@@ -99,7 +99,7 @@ describe Mongo::Operation::Delete::OpMsg do
 
   describe '#message' do
     # https://jira.mongodb.org/browse/RUBY-2224
-    skip_if_linting
+    require_no_linting
 
     context 'when the server supports OP_MSG' do
 
@@ -152,7 +152,7 @@ describe Mongo::Operation::Delete::OpMsg do
 
         context 'when an implicit session is created and the topology is then updated and the server does not support sessions' do
           # Mocks on features are incompatible with linting
-          skip_if_linting
+          require_no_linting
 
           let(:expected_global_args) do
             global_args.dup.tap do |args|

data/spec/mongo/operation/insert/command_spec.rb

@@ -63,7 +63,7 @@ describe Mongo::Operation::Insert::Command do
 
   describe 'write concern' do
     # https://jira.mongodb.org/browse/RUBY-2224
-    skip_if_linting
+    require_no_linting
 
     context 'when write concern is not specified' do
 
@@ -90,7 +90,7 @@ describe Mongo::Operation::Insert::Command do
 
   describe '#message' do
     # https://jira.mongodb.org/browse/RUBY-2224
-    skip_if_linting
+    require_no_linting
 
     context 'when the server does not support OP_MSG' do
       max_server_version '3.4'