mongo 2.12.4 → 2.14.0.rc1

data/spec/mongo/distinguishing_semaphore_spec.rb

@@ -0,0 +1,63 @@
+require 'lite_spec_helper'
+
+describe Mongo::DistinguishingSemaphore do
+  let(:semaphore) do
+    described_class.new
+  end
+
+  it 'waits until signaled' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(3)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    semaphore.signal
+    consumer.join
+
+    (Time.now - start_time).should < 1
+
+    result.should be true
+  end
+
+  it 'waits until broadcast' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(3)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    semaphore.broadcast
+    consumer.join
+
+    (Time.now - start_time).should < 1
+
+    result.should be true
+  end
+
+  it 'times out' do
+    result = nil
+
+    consumer = Thread.new do
+      result = semaphore.wait(2)
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Time.now
+    consumer.join
+
+    (Time.now - start_time).should > 1
+
+    result.should be false
+  end
+end

data/spec/mongo/error/no_server_available_spec.rb

@@ -16,7 +16,7 @@ describe Mongo::Error::NoServerAvailable do
     end
 
     it 'is correct' do
-      expect(error.message).to eq('No primary server is available in cluster: #<Cluster topology=Unknown[127.0.0.1:27017] servers=[#<Server address=127.0.0.1:27017 UNKNOWN>]> with timeout=30, LT=0.015')
+      expect(error.message).to eq('No primary server is available in cluster: #<Cluster topology=Unknown[127.0.0.1:27017] servers=[#<Server address=127.0.0.1:27017 UNKNOWN NO-MONITORING>]> with timeout=30, LT=0.015')
     end
 
     context 'when cluster is nil' do

data/spec/mongo/error/operation_failure_heavy_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe Mongo::Error::OperationFailure do
+
+  describe '#write_concern_error' do
+    # Fail point will work on 4.0 mongod but requires 4.2 for mongos
+    min_server_fcv '4.2'
+    # Fail point must be set on the same server to which the query is sent
+    require_no_multi_shard
+
+    # https://github.com/mongodb/specifications/commit/7745234f93039a83ae42589a6c0cdbefcffa32fa
+    let(:fail_point_command) do
+     {
+       "configureFailPoint": "failCommand",
+       "data": {
+         "failCommands": ["insert"],
+         "writeConcernError": {
+           "code": 100,
+           "codeName": "UnsatisfiableWriteConcern",
+           "errmsg": "Not enough data-bearing nodes",
+           "errInfo": {
+             "writeConcern": {
+               "w": 2,
+               "wtimeout": 0,
+               "provenance": "clientSupplied"
+             }
+           }
+         }
+       },
+       "mode": { "times": 1 }
+     }
+    end
+
+    it 'exposes all server-provided fields' do
+      authorized_client.use('admin').command(fail_point_command)
+
+      begin
+        authorized_client['foo'].insert_one(test: 1)
+      rescue Mongo::Error::OperationFailure => exc
+      else
+        fail 'Expected an OperationFailure'
+      end
+
+      exc.write_concern_error_document.should == {
+        'code' => 100,
+        'codeName' => 'UnsatisfiableWriteConcern',
+        'errmsg' => 'Not enough data-bearing nodes',
+        'errInfo' => {
+          'writeConcern' => {
+            'w' => 2,
+            'wtimeout' => 0,
+            'provenance' => 'clientSupplied',
+          },
+        },
+      }
+    end
+  end
+end

data/spec/mongo/error/operation_failure_spec.rb

@@ -69,77 +69,113 @@ describe Mongo::Error::OperationFailure do
   end
 
   describe '#change_stream_resumable?' do
-    context 'when there is a network error' do
-      context 'getMore' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: socket exception',
-          Mongo::Operation::GetMore::Result.new(nil)) }
-
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to be true
+    context 'when there is a resumable code' do
+      context 'getMore response' do
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
         end
-      end
 
-      context 'not getMore' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: socket exception', nil) }
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          result,
+          :code => 91, :code_name => 'ShutdownInProgress') }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to be false
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            expect(error.change_stream_resumable?).to eql(true)
+          end
         end
-      end
-    end
-
-    context 'when there is a resumable message' do
-      context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: node is recovering',
-          Mongo::Operation::GetMore::Result.new(nil)) }
 
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to eql(true)
+        context 'wire protocol version >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns false' do
+            # Error code is not consulted with wire version >= 9
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
 
       context 'not a getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('problem: node is recovering', nil) }
-
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        let(:result) do
+          Mongo::Operation::Result.new(
+            Mongo::Protocol::Message.new, description)
         end
-      end
-    end
 
-    context 'when there is a resumable code' do
-      context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
-          :code => 91, :code_name => 'ShutdownInProgress') }
-
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to eql(true)
-        end
-      end
-
-      context 'not a getMore response' do
         let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
           :code => 91, :code_name => 'ShutdownInProgress') }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
     end
 
     context 'when there is a non-resumable code' do
       context 'getMore response' do
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
         let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
+          result,
           :code => 136, :code_name => 'CappedPositionLost') }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
+        end
+
+        context 'wire protocol version >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
 
       context 'not a getMore response' do
+        let(:result) do
+          Mongo::Operation::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
         let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
           :code => 136, :code_name => 'CappedPositionLost') }
 
@@ -151,46 +187,108 @@ describe Mongo::Error::OperationFailure do
 
     context 'when there is a non-resumable label' do
       context 'getMore response' do
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
         let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
+          result,
           :code => 91, :code_name => 'ShutdownInProgress',
           :labels => ['NonResumableChangeStreamError']) }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            # Error code is consulted => error is resumable
+            expect(error.change_stream_resumable?).to eql(true)
+          end
         end
-      end
 
-      context 'not a getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
-          :code => 91, :code_name => 'ShutdownInProgress',
-          :labels => ['NonResumableChangeStreamError']) }
-
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns false' do
+            # Error code is not consulted, there is no resumable label =>
+            # error is not resumable
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
-    end
 
-    context 'when there is another label' do
-      context 'getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message',
-          Mongo::Operation::GetMore::Result.new(nil),
-          :code => 91, :code_name => 'ShutdownInProgress',
-          :labels => %w(TransientTransactionError)) }
+      context 'when the error code is 43 (CursorNotFound)' do
+        let(:error) { Mongo::Error::OperationFailure.new(nil, result, code: 43, code_name: 'CursorNotFound') }
+        let(:result) do
+          Mongo::Operation::GetMore::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
+        context 'wire protocol < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns true' do
+            # CursorNotFound exceptions are resumable even if they don't have
+            # a ResumableChangeStreamError label because the server is not aware
+            # of the cursor id, and thus cannot determine if it is a change stream.
+            expect(error.change_stream_resumable?).to be true
+          end
+        end
 
-        it 'returns true' do
-          expect(error.change_stream_resumable?).to eql(true)
+        context 'wire protocol >= 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 9,
+            )
+          end
+
+          it 'returns true' do
+            # CursorNotFound exceptions are resumable even if they don't have
+            # a ResumableChangeStreamError label because the server is not aware
+            # of the cursor id, and thus cannot determine if it is a change stream.
+            expect(error.change_stream_resumable?).to be true
+          end
         end
       end
 
       context 'not a getMore response' do
-        let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
+        let(:result) do
+          Mongo::Operation::Result.new(
+            Mongo::Protocol::Message.new, description)
+        end
+
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          result,
           :code => 91, :code_name => 'ShutdownInProgress',
-          :labels => %w(TransientTransactionError)) }
+          :labels => ['NonResumableChangeStreamError']) }
 
-        it 'returns false' do
-          expect(error.change_stream_resumable?).to eql(false)
+        context 'wire protocol version < 9' do
+          let(:description) do
+            Mongo::Server::Description.new('',
+              'minWireVersion' => 0,
+              'maxWireVersion' => 8,
+            )
+          end
+
+          it 'returns false' do
+            expect(error.change_stream_resumable?).to eql(false)
+          end
         end
       end
     end
@@ -230,7 +328,7 @@ describe Mongo::Error::OperationFailure do
       end
 
       let(:result) do
-        Mongo::Operation::Result.new(reply)
+        Mongo::Operation::Result.new(reply, Mongo::Server::Description.new(''))
       end
 
       subject do

data/spec/mongo/error/unsupported_option_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe Mongo::Error::UnsupportedOption do
+  describe '.hint_error' do
+    context 'with no options' do
+      let(:error) { described_class.hint_error }
+
+      it 'creates an error with a default message' do
+        expect(error.message).to eq(
+          "The MongoDB server handling this request does not support the hint " \
+          "option on this command. The hint option is supported on update commands " \
+          "on MongoDB server versions 4.2 and later and on findAndModify and delete " \
+          "commands on MongoDB server versions 4.4 and later"
+        )
+      end
+
+      context 'with unacknowledged_write: true' do
+        let(:error) { described_class.hint_error(unacknowledged_write: true) }
+
+        it 'creates an error with a default unacknowledged writes message' do
+          expect(error.message).to eq(
+            "The hint option cannot be specified on an unacknowledged " \
+            "write operation. Remove the hint option or perform this " \
+            "operation with a write concern of at least { w: 1 }"
+          )
+        end
+      end
+    end
+  end
+
+  describe '.allow_disk_use_error' do
+    let(:error) { described_class.allow_disk_use_error }
+
+    it 'creates an error with a default message' do
+      expect(error.message).to eq(
+        "The MongoDB server handling this request does not support the allow_disk_use " \
+        "option on this command. The allow_disk_use option is supported on find commands " \
+        "on MongoDB server versions 4.4 and later"
+      )
+    end
+  end
+
+  describe '.commit_quorum_error' do
+    let(:error) { described_class.commit_quorum_error }
+
+    it 'creates an error with a default message' do
+      expect(error.message).to eq(
+        "The MongoDB server handling this request does not support the commit_quorum " \
+        "option on this command. The commit_quorum option is supported on createIndexes commands " \
+        "on MongoDB server versions 4.4 and later"
+      )
+    end
+  end
+end