mongo 2.11.1 → 2.11.6

data/spec/integration/grid_fs_bucket_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe 'GridFS bucket integration' do
+  let(:fs) do
+    authorized_client.database.fs
+  end
+
+  describe 'UTF-8 string write' do
+    let(:data) { "hello\u2210" }
+
+    before do
+      data.length.should_not == data.bytesize
+    end
+
+    shared_examples 'round-trips' do
+      it 'round-trips' do
+        stream = fs.open_upload_stream('test') do |stream|
+          stream.write(data_to_write)
+        end
+
+        actual = nil
+        fs.open_download_stream(stream.file_id) do |stream|
+          actual = stream.read
+        end
+
+        actual.encoding.name.should == 'ASCII-8BIT'
+        actual.should == data.dup.force_encoding('binary')
+      end
+    end
+
+    context 'in binary encoding' do
+      let(:data_to_write) do
+        data.force_encoding('binary').freeze
+      end
+
+      it_behaves_like 'round-trips'
+    end
+
+    context 'in UTF-8 encoding' do
+      let(:data_to_write) do
+        data.encoding.name.should == 'UTF-8'
+        data.freeze
+      end
+
+      it_behaves_like 'round-trips'
+    end
+  end
+end

data/spec/integration/retryable_errors_spec.rb

@@ -24,7 +24,7 @@ describe 'Failing retryable operations' do
     end
 
     after do
-      ClusterTools.instance.direct_client_for_each_server do |client|
+      ClusterTools.instance.direct_client_for_each_data_bearing_server do |client|
         client.use(:admin).database.command(clear_fail_point_command)
       end
     end
@@ -62,7 +62,7 @@ describe 'Failing retryable operations' do
           server.monitor.stop!
         end
 
-        ClusterTools.instance.direct_client_for_each_server do |client|
+        ClusterTools.instance.direct_client_for_each_data_bearing_server do |client|
           client.use(:admin).database.command(fail_point_command)
         end
       end

data/spec/integration/zlib_compression_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe 'Zlib compression' do
+  require_compression
+
+  before do
+    authorized_client['test'].drop
+  end
+
+  context 'when client has zlib compressor option enabled' do
+    it 'compresses the message to the server' do
+      # Double check that the client has zlib compression enabled
+      expect(authorized_client.options[:compressors]).to include('zlib')
+
+      expect(Mongo::Protocol::Compressed).to receive(:new).twice.and_call_original
+      expect(Zlib::Deflate).to receive(:deflate).twice.and_call_original
+      expect(Zlib::Inflate).to receive(:inflate).twice.and_call_original
+
+      authorized_client['test'].insert_one(_id: 1, text: 'hello world')
+      document = authorized_client['test'].find(_id: 1).first
+
+      expect(document['text']).to eq('hello world')
+    end
+  end
+end

data/spec/lite_spec_helper.rb

@@ -127,6 +127,7 @@ RSpec.configure do |config|
   end
 
   config.expect_with :rspec do |c|
+    c.syntax = [:should, :expect]
     c.max_formatted_output_length = 10000
   end
 end

data/spec/mongo/address_spec.rb

@@ -249,11 +249,7 @@ describe Mongo::Address do
       end
     end
 
-    context 'when creating a socket using the resolver' do
-
-      before do
-        address.send(:create_resolver, SpecConfig.instance.ssl_options)
-      end
+    context 'when creating a socket' do
 
       it 'uses the host, not the IP address' do
         expect(address.socket(0.0).host).to eq(socket_address_or_host)
@@ -285,6 +281,24 @@ describe Mongo::Address do
         end
       end
     end
+
+    describe ':connect_timeout option' do
+      clean_slate
+
+      let(:address) { Mongo::Address.new('127.0.0.1') }
+
+      it 'defaults to 10' do
+        RSpec::Mocks.with_temporary_scope do
+          resolved_address = double('address')
+          # This test's expectation
+          expect(resolved_address).to receive(:socket).with(0, {}, connect_timeout: 10)
+
+          expect(Mongo::Address::IPv4).to receive(:new).and_return(resolved_address)
+
+          address.socket(0)
+        end
+      end
+    end
   end
 
   describe '#to_s' do
@@ -320,12 +334,4 @@ describe Mongo::Address do
       end
     end
   end
-
-  describe '#connect_timeout' do
-    let(:address) { Mongo::Address.new('127.0.0.1') }
-
-    it 'defaults to 10' do
-      expect(address.send(:connect_timeout)).to eq(10)
-    end
-  end
 end

data/spec/mongo/auth/ldap/conversation_spec.rb

@@ -17,7 +17,7 @@ describe Mongo::Auth::LDAP::Conversation do
   describe '#start' do
 
     let(:query) do
-      conversation.start
+      conversation.start(nil)
     end
 
     let(:selector) do

data/spec/mongo/auth/scram/conversation_spec.rb

@@ -7,6 +7,15 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
     described_class.new(user, mechanism)
   end
 
+  let(:connection) do
+    double('connection').tap do |connection|
+      features = double('features')
+      allow(features).to receive(:op_msg_enabled?)
+      allow(connection).to receive(:features).and_return(features)
+      allow(connection).to receive(:server)
+    end
+  end
+
   context 'when SCRAM-SHA-1 is used' do
     min_server_fcv '3.0'
 
@@ -26,9 +35,11 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
     end
 
     describe '#start' do
+      # Test uses global assertions
+      clean_slate
 
       let(:query) do
-        conversation.start
+        conversation.start(nil)
       end
 
       before do
@@ -85,7 +96,7 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
         end
 
         let(:query) do
-          conversation.continue(reply)
+          conversation.continue(reply, connection)
         end
 
         let(:selector) do
@@ -117,7 +128,7 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
 
         it 'raises an error' do
           expect {
-            conversation.continue(reply)
+            conversation.continue(reply, connection)
           }.to raise_error(Mongo::Error::InvalidNonce)
         end
       end
@@ -170,8 +181,8 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
         end
 
         let(:query) do
-          conversation.continue(continue_reply)
-          conversation.finalize(reply)
+          conversation.continue(continue_reply, connection)
+          conversation.finalize(reply, connection)
         end
 
         let(:selector) do
@@ -199,8 +210,8 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
 
         it 'raises an error' do
           expect {
-            conversation.continue(continue_reply)
-            conversation.finalize(reply)
+            conversation.continue(continue_reply, connection)
+            conversation.finalize(reply, connection)
           }.to raise_error(Mongo::Error::InvalidSignature)
         end
       end
@@ -226,7 +237,7 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
     describe '#start' do
 
       let(:query) do
-        conversation.start
+        conversation.start(nil)
       end
 
       before do
@@ -283,7 +294,7 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
         end
 
         let(:query) do
-          conversation.continue(reply)
+          conversation.continue(reply, connection)
         end
 
         let(:selector) do
@@ -315,7 +326,7 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
 
         it 'raises an error' do
           expect {
-            conversation.continue(reply)
+            conversation.continue(reply, connection)
           }.to raise_error(Mongo::Error::InvalidNonce)
         end
       end
@@ -368,8 +379,8 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
         end
 
         let(:query) do
-          conversation.continue(continue_reply)
-          conversation.finalize(reply)
+          conversation.continue(continue_reply, connection)
+          conversation.finalize(reply, connection)
         end
 
         let(:selector) do
@@ -397,8 +408,8 @@ describe Mongo::Auth::SCRAM::Conversation, retry: 3 do
 
         it 'raises an error' do
           expect {
-            conversation.continue(continue_reply)
-            conversation.finalize(reply)
+            conversation.continue(continue_reply, connection)
+            conversation.finalize(reply, connection)
           }.to raise_error(Mongo::Error::InvalidSignature)
         end
       end

data/spec/mongo/auth/user/view_spec.rb

@@ -2,8 +2,10 @@ require 'spec_helper'
 
 describe Mongo::Auth::User::View do
 
+  let(:database) { root_authorized_client.database }
+
   let(:view) do
-    described_class.new(root_authorized_client.database)
+    described_class.new(database)
   end
 
   before do
@@ -51,6 +53,39 @@ describe Mongo::Auth::User::View do
 
   describe '#create' do
 
+    context 'when password is not provided' do
+
+      let(:database) { root_authorized_client.use('$external').database }
+
+      let(:username) { 'passwordless-user' }
+
+      let(:response) do
+        view.create(
+          username,
+          # https://stackoverflow.com/questions/55939832/mongodb-external-database-cannot-create-new-user-with-user-defined-role
+          roles: [{role: 'read', db: 'admin'}],
+        )
+      end
+
+      before do
+        begin
+          view.remove(username)
+        rescue Mongo::Error::OperationFailure
+          # can be user not found, ignore
+        end
+      end
+
+      it 'creates the user' do
+        view.info(username).should == []
+
+        lambda do
+          response
+        end.should_not raise_error
+
+        view.info(username).first['user'].should == username
+      end
+    end
+
     context 'when a session is not used' do
 
       let!(:response) do
@@ -74,8 +109,7 @@ describe Mongo::Auth::User::View do
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end
@@ -162,8 +196,7 @@ describe Mongo::Auth::User::View do
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end
@@ -212,8 +245,7 @@ describe Mongo::Auth::User::View do
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end

data/spec/mongo/auth/user_spec.rb

@@ -325,4 +325,16 @@ describe Mongo::Auth::User do
       end
     end
   end
+
+  describe '#spec' do
+    context 'when no password and no roles are set' do
+      let(:user) do
+        described_class.new(user: 'foo')
+      end
+
+      it 'is a hash with empty roles' do
+        user.spec.should == {roles: []}
+      end
+    end
+  end
 end

data/spec/mongo/auth/x509/conversation_spec.rb

@@ -16,7 +16,7 @@ describe Mongo::Auth::X509::Conversation do
   describe '#start' do
 
     let(:query) do
-      conversation.start
+      conversation.start(nil)
     end
 
     let(:selector) do

data/spec/mongo/bulk_write_spec.rb

@@ -1924,11 +1924,11 @@ describe Mongo::BulkWrite do
             end
 
             let(:first_txn_number) do
-              started_events[-2].command['txnNumber'].value
+              Utils.int64_value(started_events[-2].command['txnNumber'])
             end
 
             let(:second_txn_number) do
-              started_events[-1].command['txnNumber'].value
+              Utils.int64_value(started_events[-1].command['txnNumber'])
             end
 
             it 'inserts the documents' do

data/spec/mongo/client_construction_spec.rb

@@ -94,27 +94,7 @@ describe Mongo::Client do
       # cluster during SDAM
       context 'me mismatch on the only initial seed' do
         let(:address) do
-          address = SpecConfig.instance.addresses.first
-          port = address.sub(/^.*:/, '').to_i
-          address = address.sub(/:.*/, '')
-          case address
-          when '127.0.0.1'
-            'localhost'
-          when /^(\d+\.){3}\d+$/
-            skip 'This test requires a hostname or 127.0.0.1 as address'
-          else
-            # We don't know if mongod is listening on ipv4 or ipv6,
-            # in principle.
-            # Our tests use ipv4, so hardcode that for now.
-            # To support both we need to try both addresses
-            # which will make this test more complicated.
-            resolved_address = Addrinfo.getaddrinfo(address, port, Socket::PF_INET).first.ip_address
-            if resolved_address.include?(':')
-              "[#{resolved_address}]"
-            else
-              resolved_address
-            end + ":#{port}"
-          end
+          ClusterConfig.instance.alternate_address.to_s
         end
 
         let(:logger) do
@@ -255,7 +235,8 @@ describe Mongo::Client do
             min_server_fcv '3.6'
 
             it 'uses compression for messages' do
-              expect(Mongo::Protocol::Compressed).to receive(:new).and_call_original
+              # A Compressed object will be created for both the request and the response
+              expect(Mongo::Protocol::Compressed).to receive(:new).twice.and_call_original
               client[TEST_COLL].find({}, limit: 1).first
             end
           end

data/spec/mongo/cluster_spec.rb

@@ -20,6 +20,25 @@ describe Mongo::Cluster do
 
   let(:cluster) { cluster_without_io }
 
+  describe 'initialize' do
+
+    context 'when there are duplicate addresses' do
+
+      let(:addresses) do
+        SpecConfig.instance.addresses + SpecConfig.instance.addresses
+      end
+      let(:cluster_with_dup_addresses) do
+        register_cluster(
+          described_class.new(addresses, monitoring, SpecConfig.instance.test_options))
+      end
+
+      it 'does not raise an exception' do
+        expect { cluster_with_dup_addresses }.not_to raise_error
+      end
+    end
+
+  end
+
   describe '#==' do
 
     context 'when the other is a cluster' do
@@ -575,6 +594,44 @@ describe Mongo::Cluster do
   end
 
   describe '#sessions_supported?' do
+    context 'when client has not contacted any servers' do
+
+      let(:cluster) do
+        described_class.new(SpecConfig.instance.addresses, monitoring,
+          SpecConfig.instance.test_options.merge(
+            monitoring_io: false, server_selection_timeout: 0.183))
+      end
+
+      it 'is false' do
+        expect(cluster.send(:sessions_supported?)).to be false
+      end
+    end
+
+    context 'when client has contacted servers and then disconnected' do
+      min_server_fcv '3.6'
+      require_wired_tiger
+      require_topology :sharded, :replica_set
+
+      let(:cluster) do
+        described_class.new(SpecConfig.instance.addresses, monitoring,
+          SpecConfig.instance.test_options.merge(
+            server_selection_timeout: 0.183)
+        ).tap do |cluster|
+          register_cluster(cluster)
+        end
+      end
+
+      before do
+        cluster.next_primary
+        cluster.servers_list.map(&:disconnect!)
+        cluster.servers_list.map(&:unknown!)
+      end
+
+      it 'is true' do
+        expect(cluster.send(:sessions_supported?)).to be true
+      end
+    end
+
     context 'in server < 3.6' do
       max_server_version '3.4'