mongo 2.11.0 → 2.11.5

data/spec/mongo/auth/user/view_spec.rb

@@ -2,8 +2,10 @@ require 'spec_helper'
 
 describe Mongo::Auth::User::View do
 
+  let(:database) { root_authorized_client.database }
+
   let(:view) do
-    described_class.new(root_authorized_client.database)
+    described_class.new(database)
   end
 
   before do
@@ -51,6 +53,39 @@ describe Mongo::Auth::User::View do
 
   describe '#create' do
 
+    context 'when password is not provided' do
+
+      let(:database) { root_authorized_client.use('$external').database }
+
+      let(:username) { 'passwordless-user' }
+
+      let(:response) do
+        view.create(
+          username,
+          # https://stackoverflow.com/questions/55939832/mongodb-external-database-cannot-create-new-user-with-user-defined-role
+          roles: [{role: 'read', db: 'admin'}],
+        )
+      end
+
+      before do
+        begin
+          view.remove(username)
+        rescue Mongo::Error::OperationFailure
+          # can be user not found, ignore
+        end
+      end
+
+      it 'creates the user' do
+        view.info(username).should == []
+
+        lambda do
+          response
+        end.should_not raise_error
+
+        view.info(username).first['user'].should == username
+      end
+    end
+
     context 'when a session is not used' do
 
       let!(:response) do

data/spec/mongo/auth/user_spec.rb

@@ -325,4 +325,16 @@ describe Mongo::Auth::User do
       end
     end
   end
+
+  describe '#spec' do
+    context 'when no password and no roles are set' do
+      let(:user) do
+        described_class.new(user: 'foo')
+      end
+
+      it 'is a hash with empty roles' do
+        user.spec.should == {roles: []}
+      end
+    end
+  end
 end

data/spec/mongo/auth/x509/conversation_spec.rb

@@ -16,7 +16,7 @@ describe Mongo::Auth::X509::Conversation do
   describe '#start' do
 
     let(:query) do
-      conversation.start
+      conversation.start(nil)
     end
 
     let(:selector) do

data/spec/mongo/bulk_write_spec.rb

@@ -1924,11 +1924,11 @@ describe Mongo::BulkWrite do
             end
 
             let(:first_txn_number) do
-              started_events[-2].command['txnNumber'].value
+              Utils.int64_value(started_events[-2].command['txnNumber'])
             end
 
             let(:second_txn_number) do
-              started_events[-1].command['txnNumber'].value
+              Utils.int64_value(started_events[-1].command['txnNumber'])
             end
 
             it 'inserts the documents' do

data/spec/mongo/client_construction_spec.rb

@@ -94,27 +94,7 @@ describe Mongo::Client do
       # cluster during SDAM
       context 'me mismatch on the only initial seed' do
         let(:address) do
-          address = SpecConfig.instance.addresses.first
-          port = address.sub(/^.*:/, '').to_i
-          address = address.sub(/:.*/, '')
-          case address
-          when '127.0.0.1'
-            'localhost'
-          when /^(\d+\.){3}\d+$/
-            skip 'This test requires a hostname or 127.0.0.1 as address'
-          else
-            # We don't know if mongod is listening on ipv4 or ipv6,
-            # in principle.
-            # Our tests use ipv4, so hardcode that for now.
-            # To support both we need to try both addresses
-            # which will make this test more complicated.
-            resolved_address = Addrinfo.getaddrinfo(address, port, Socket::PF_INET).first.ip_address
-            if resolved_address.include?(':')
-              "[#{resolved_address}]"
-            else
-              resolved_address
-            end + ":#{port}"
-          end
+          ClusterConfig.instance.alternate_address.to_s
         end
 
         let(:logger) do

data/spec/mongo/cluster_spec.rb

@@ -20,6 +20,25 @@ describe Mongo::Cluster do
 
   let(:cluster) { cluster_without_io }
 
+  describe 'initialize' do
+
+    context 'when there are duplicate addresses' do
+
+      let(:addresses) do
+        SpecConfig.instance.addresses + SpecConfig.instance.addresses
+      end
+      let(:cluster_with_dup_addresses) do
+        register_cluster(
+          described_class.new(addresses, monitoring, SpecConfig.instance.test_options))
+      end
+
+      it 'does not raise an exception' do
+        expect { cluster_with_dup_addresses }.not_to raise_error
+      end
+    end
+
+  end
+
   describe '#==' do
 
     context 'when the other is a cluster' do
@@ -575,6 +594,44 @@ describe Mongo::Cluster do
   end
 
   describe '#sessions_supported?' do
+    context 'when client has not contacted any servers' do
+
+      let(:cluster) do
+        described_class.new(SpecConfig.instance.addresses, monitoring,
+          SpecConfig.instance.test_options.merge(
+            monitoring_io: false, server_selection_timeout: 0.183))
+      end
+
+      it 'is false' do
+        expect(cluster.send(:sessions_supported?)).to be false
+      end
+    end
+
+    context 'when client has contacted servers and then disconnected' do
+      min_server_fcv '3.6'
+      require_wired_tiger
+      require_topology :sharded, :replica_set
+
+      let(:cluster) do
+        described_class.new(SpecConfig.instance.addresses, monitoring,
+          SpecConfig.instance.test_options.merge(
+            server_selection_timeout: 0.183)
+        ).tap do |cluster|
+          register_cluster(cluster)
+        end
+      end
+
+      before do
+        cluster.next_primary
+        cluster.servers_list.map(&:disconnect!)
+        cluster.servers_list.map(&:unknown!)
+      end
+
+      it 'is true' do
+        expect(cluster.send(:sessions_supported?)).to be true
+      end
+    end
+
     context 'in server < 3.6' do
       max_server_version '3.4'
 

data/spec/mongo/collection/view/map_reduce_spec.rb

@@ -575,7 +575,7 @@ describe Mongo::Collection::View::MapReduce do
         expect(map_reduce.send(:secondary_ok?)).to be false
       end
 
-      context 'when the server is not a valid for writing' do
+      context 'when the server is not valid for writing' do
         clean_slate
 
         before do

data/spec/mongo/collection_spec.rb

@@ -278,9 +278,9 @@ describe Mongo::Collection do
           require_topology :replica_set
 
           let(:client_options) do
-            {
+            SpecConfig.instance.auth_options.merge(
               read: { mode: :primary_preferred },
-            }
+            )
           end
 
           let(:subscriber) { EventSubscriber.new }
@@ -945,6 +945,30 @@ describe Mongo::Collection do
         it_behaves_like 'a failed operation using a session'
       end
     end
+
+    context 'when collation has a strength' do
+      min_server_fcv '3.4'
+
+      let(:band_collection) do
+        described_class.new(database, :bands)
+      end
+
+      before do
+        band_collection.delete_many
+        band_collection.insert_many([{ name: "Depeche Mode" }, { name: "New Order" }])
+      end
+
+      let(:options) do
+        { collation: { locale: 'en_US', strength: 2 } }
+      end
+      let(:band_result) do
+        band_collection.find({ name: 'DEPECHE MODE' }, options)
+      end
+
+      it 'finds Capitalize from UPPER CASE' do
+        expect(band_result.count_documents).to eq(1)
+      end
+    end
   end
 
   describe '#drop' do

data/spec/mongo/cursor/builder/op_kill_cursors_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe Mongo::Cursor::Builder::OpKillCursors do
+
+  let(:reply) do
+    Mongo::Protocol::Reply.allocate.tap do |reply|
+      allow(reply).to receive(:cursor_id).and_return(8000)
+    end
+  end
+
+  let(:result) do
+    Mongo::Operation::Result.new(reply)
+  end
+
+  let(:view) do
+    Mongo::Collection::View.new(
+      authorized_collection,
+      {},
+      tailable: true,
+      max_time_ms: 100
+    )
+  end
+
+  let(:cursor) do
+    Mongo::Cursor.new(view, result, authorized_primary)
+  end
+
+  let(:builder) do
+    described_class.new(cursor)
+  end
+
+  describe '#specification' do
+
+    let(:specification) do
+      builder.specification
+    end
+
+    it 'includes the cursor ids' do
+      expect(specification[:cursor_ids]).to eq([BSON::Int64.new(8000)])
+    end
+
+    it 'includes the database name' do
+      expect(specification[:db_name]).to eq(SpecConfig.instance.test_db)
+    end
+
+    it 'includes the collection name' do
+      expect(specification[:coll_name]).to eq(TEST_COLL)
+    end
+  end
+
+  describe '.get_cursors_list' do
+    it 'returns integer cursor ids' do
+      expect(described_class.get_cursors_list(builder.specification)).to eq([8000])
+    end
+  end
+end

data/spec/mongo/server/connection_spec.rb

@@ -137,12 +137,13 @@ describe Mongo::Server::Connection, retry: 3 do
 
         it 'logs a warning' do
           messages = []
-          # Straightforward expectations are not working here for some reason
           expect(Mongo::Logger.logger).to receive(:warn) do |msg|
             messages << msg
           end
+
           expect(error).not_to be nil
-          expect(messages).to include(expected_message)
+
+          messages.any? { |msg| msg.include?(expected_message) }.should be true
         end
 
       end
@@ -419,6 +420,73 @@ describe Mongo::Server::Connection, retry: 3 do
       end
     end
 
+    context 'connecting to arbiter' do
+      require_topology :replica_set
+
+      before(:all) do
+        unless ENV['HAVE_ARBITER']
+          skip 'Test requires an arbiter in the deployment'
+        end
+      end
+
+      let(:arbiter_server) do
+        authorized_client.cluster.servers_list.each do |server|
+          server.scan!
+        end
+        server = authorized_client.cluster.servers_list.detect do |server|
+          server.arbiter?
+        end.tap do |server|
+          raise 'No arbiter in the deployment' unless server
+        end
+      end
+
+      shared_examples_for 'does not authenticate' do
+        let(:client) do
+          new_local_client([address],
+            SpecConfig.instance.test_options.merge(
+              :user => 'bogus',
+              :password => 'bogus',
+              :database => 'bogus'
+            ).merge(connect: :direct),
+          )
+        end
+
+        let(:connection) do
+          described_class.new(
+            server,
+          )
+        end
+
+        let(:ping) do
+          client.database.command(ping: 1)
+        end
+
+        it 'does not authenticate' do
+          ClientRegistry.instance.close_all_clients
+
+          expect_any_instance_of(Mongo::Server::Connection).not_to receive(:authenticate!)
+
+          expect(ping.documents.first['ok']).to eq(1) rescue nil
+        end
+      end
+
+      context 'without me mismatch' do
+        let(:address) do
+          arbiter_server.address.to_s
+        end
+
+        it_behaves_like 'does not authenticate'
+      end
+
+      context 'with me mismatch' do
+        let(:address) do
+          "#{ClusterConfig.instance.alternate_address.host}:#{arbiter_server.address.port}"
+        end
+
+        it_behaves_like 'does not authenticate'
+      end
+    end
+
   end
 
   describe '#disconnect!' do
@@ -1012,7 +1080,7 @@ describe Mongo::Server::Connection, retry: 3 do
         end
 
         it 'uses the connect_timeout for the address' do
-          expect(connection.address.send(:connect_timeout)).to eq(3)
+          expect(connection.address.options[:connect_timeout]).to eq(3)
         end
 
         it 'uses the socket_timeout as the socket_timeout' do
@@ -1031,7 +1099,7 @@ describe Mongo::Server::Connection, retry: 3 do
         end
 
         it 'uses the connect_timeout for the address' do
-          expect(connection.address.send(:connect_timeout)).to eq(3)
+          expect(connection.address.options[:connect_timeout]).to eq(3)
         end
 
         it 'does not use a socket_timeout' do
@@ -1052,8 +1120,8 @@ describe Mongo::Server::Connection, retry: 3 do
           connection.connect!
         end
 
-        it 'uses the default connect_timeout for the address' do
-          expect(connection.address.send(:connect_timeout)).to eq(10)
+        it 'does not specify connect_timeout for the address' do
+          expect(connection.address.options[:connect_timeout]).to be nil
         end
 
         it 'uses the socket_timeout' do
@@ -1071,8 +1139,8 @@ describe Mongo::Server::Connection, retry: 3 do
           connection.connect!
         end
 
-        it 'uses the default connect_timeout for the address' do
-          expect(connection.address.send(:connect_timeout)).to eq(10)
+        it 'does not specify connect_timeout for the address' do
+          expect(connection.address.options[:connect_timeout]).to be nil
         end
 
         it 'does not use a socket_timeout' do

data/spec/mongo/server/monitor/connection_spec.rb

@@ -66,7 +66,7 @@ describe Mongo::Server::Monitor::Connection do
       end
 
       it 'uses the connect_timeout for the address' do
-        expect(connection.address.send(:connect_timeout)).to eq(3)
+        expect(connection.address.options[:connect_timeout]).to eq(3)
       end
 
       it 'uses the connect_timeout as the socket_timeout' do
@@ -81,7 +81,7 @@ describe Mongo::Server::Monitor::Connection do
       end
 
       it 'uses the connect_timeout for the address' do
-        expect(connection.address.send(:connect_timeout)).to eq(3)
+        expect(connection.address.options[:connect_timeout]).to eq(3)
       end
 
       it 'uses the connect_timeout as the socket_timeout' do
@@ -98,8 +98,8 @@ describe Mongo::Server::Monitor::Connection do
         SpecConfig.instance.test_options.merge(connect_timeout: nil, socket_timeout: 5)
       end
 
-      it 'uses the default connect_timeout for the address' do
-        expect(connection.address.send(:connect_timeout)).to eq(10)
+      it 'does not specify connect_timeout for the address' do
+        expect(connection.address.options[:connect_timeout]).to be nil
       end
 
       it 'uses the connect_timeout as the socket_timeout' do
@@ -113,8 +113,8 @@ describe Mongo::Server::Monitor::Connection do
         SpecConfig.instance.test_options.merge(connect_timeout: nil, socket_timeout: nil)
       end
 
-      it 'uses the default connect_timeout for the address' do
-        expect(connection.address.send(:connect_timeout)).to eq(10)
+      it 'does not specify connect_timeout for the address' do
+        expect(connection.address.options[:connect_timeout]).to be nil
       end
 
       it 'uses the connect_timeout as the socket_timeout' do
@@ -189,10 +189,17 @@ describe Mongo::Server::Monitor::Connection do
 
       it 'logs a warning' do
         expect_any_instance_of(Mongo::Socket).to receive(:write).and_raise(Mongo::Error::SocketError, 'test error')
-        expect(Mongo::Logger.logger).to receive(:warn).with(expected_message).and_call_original
+
+        messages = []
+        expect(Mongo::Logger.logger).to receive(:warn) do |msg|
+          messages << msg
+        end
+
         expect do
           monitor.connection.connect!
         end.to raise_error(Mongo::Error::SocketError, 'test error')
+
+        messages.any? { |msg| msg.include?(expected_message) }.should be true
       end
     end
   end