mongo 2.1.0.beta → 2.2.0

data/spec/support/sdam/rs/new_primary_new_electionid.yml

@@ -31,7 +31,6 @@ phases: [
             },
             topologyType: "ReplicaSetWithPrimary",
             setName: "rs",
-            maxElectionId: {"$oid": "000000000000000000000001"}
         }
     },
 
@@ -62,7 +61,6 @@ phases: [
             },
             topologyType: "ReplicaSetWithPrimary",
             setName: "rs",
-            maxElectionId: {"$oid": "000000000000000000000002"}
         }
     },
 
@@ -92,7 +90,6 @@ phases: [
             },
             topologyType: "ReplicaSetWithPrimary",
             setName: "rs",
-            maxElectionId: {"$oid": "000000000000000000000002"}
         }
     }
 ]

data/spec/support/sdam/rs/primary_mismatched_me.yml

@@ -0,0 +1,37 @@
+{
+    "description": "Primary mismatched me",
+    "phases": [
+        {
+            "outcome": {
+                "servers": {
+                    "a:27017": {
+                        "setName": null,
+                        "type": "Unknown"
+                    },
+                    "b:27017": {
+                        "setName": null,
+                        "type": "Unknown"
+                    }
+                },
+                "setName": "rs",
+                "topologyType": "ReplicaSetNoPrimary"
+            },
+            "responses": [
+                [
+                    "localhost:27017",
+                     {
+                         "me": "a:27017",
+                         "hosts": [
+                             "a:27017",
+                             "b:27017"
+                         ],
+                         "ismaster": true,
+                         "ok": 1,
+                         "setName": "rs"
+                     }
+                ]
+            ]
+        }
+    ],
+    "uri": "mongodb://localhost:27017/?replicaSet=rs"
+}

data/spec/support/sdam/rs/primary_to_no_primary_mismatched_me.yml

@@ -0,0 +1,75 @@
+description: "Primary to no primary with mismatched me"
+
+uri: "mongodb://a/?replicaSet=rs"
+
+phases: [
+
+    {
+        responses: [
+
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: true,
+                    hosts: ["a:27017", "b:27017"],
+                    me: "a:27017",
+                    setName: "rs"
+                }]
+        ],
+
+        outcome: {
+
+            servers: {
+
+                "a:27017": {
+
+                    type: "RSPrimary",
+                    setName: "rs"
+                },
+
+                "b:27017": {
+
+                    type: "Unknown",
+                    setName:
+                }
+            },
+
+            topologyType: "ReplicaSetWithPrimary",
+            setName: "rs"
+        }
+    },
+    {
+        responses: [
+
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: true,
+                    hosts: ["c:27017", "d:27017"],
+                    me : "c:27017",
+                    setName: "rs"
+                }]
+        ],
+
+        outcome: {
+
+            servers: {
+
+                "c:27017": {
+
+                    type: "Unknown",
+                    setName:
+                },
+
+                "d:27017": {
+
+                    type: "Unknown",
+                    setName:
+                }
+            },
+
+            topologyType: "ReplicaSetNoPrimary",
+            setName: "rs"
+        }
+    }
+]

data/spec/support/sdam/rs/rsother_discovered.yml

@@ -7,12 +7,21 @@ phases: [
     {
         responses: [
 
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: false,
+                    secondary: true,
+                    hidden: true,
+                    hosts: ["c:27017", "d:27017"],
+                    setName: "rs"
+                }],
                 ["b:27017", {
 
                     ok: 1,
                     ismaster: false,
                     secondary: false,
-                    hosts: ["a:27017", "b:27017"],
+                    hosts: ["c:27017", "d:27017"],
                     setName: "rs"
                 }]
         ],
@@ -23,14 +32,26 @@ phases: [
 
                 "a:27017": {
 
-                    type: "Unknown",
-                    setName:
+                    type: "RSOther",
+                    setName: "rs"
                 },
 
                 "b:27017": {
 
                     type: "RSOther",
                     setName: "rs"
+                },
+
+                "c:27017": {
+
+                    type: "Unknown",
+                    setName: 
+                },
+
+                "d:27017": {
+
+                    type: "Unknown",
+                    setName: 
                 }
             },
 

data/spec/support/sdam/rs/secondary_mismatched_me.yml

@@ -0,0 +1,37 @@
+{
+    "description": "Secondary mismatched me",
+    "phases": [
+        {
+            "outcome": {
+                "servers": {
+                    "a:27017": {
+                        "setName": null,
+                        "type": "Unknown"
+                    },
+                    "b:27017": {
+                        "setName": null,
+                        "type": "Unknown"
+                    }
+                },
+                "setName": "rs",
+                "topologyType": "ReplicaSetNoPrimary"
+            },
+            "responses": [
+                [
+                    "localhost:27017",
+                     {
+                         "me": "a:27017",
+                         "hosts": [
+                             "a:27017",
+                             "b:27017"
+                         ],
+                         "ismaster": false,
+                         "ok": 1,
+                         "setName": "rs"
+                     }
+                ]
+            ]
+        }
+    ],
+    "uri": "mongodb://localhost:27017/?replicaSet=rs"
+}

data/spec/support/sdam/rs/stepdown_change_set_name.yml

@@ -0,0 +1,59 @@
+description: "Primary becomes a secondary with wrong setName"
+
+uri: "mongodb://a/?replicaSet=rs"
+
+phases: [
+
+    # Primary is discovered normally.
+    {
+        responses: [
+
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: true,
+                    hosts: ["a:27017"],
+                    setName: "rs"
+                }]
+        ],
+
+        outcome: {
+
+            servers: {
+
+                "a:27017": {
+
+                    type: "RSPrimary",
+                    setName: "rs"
+                }
+            },
+
+            topologyType: "ReplicaSetWithPrimary",
+            setName: "rs"
+        }
+    },
+
+    # Primary changes its setName and becomes secondary.
+    # Remove it and change the topologyType.
+    {
+        responses: [
+
+                ["a:27017", {
+
+                    ok: 1,
+                    ismaster: false,
+                    secondary: true,
+                    hosts: ["a:27017"],
+                    setName: "wrong"
+                }]
+        ],
+
+        outcome: {
+
+            servers: {},
+
+            topologyType: "ReplicaSetNoPrimary",
+            setName: "rs"
+        }
+    }
+]

data/spec/support/sdam/single/direct_connection_rsarbiter.yml

@@ -12,7 +12,7 @@ phases: [
                    ok: 1,
                    ismaster: false,
                    arbiterOnly: true,
-                   hosts: ["a"],
+                   hosts: ["a:27017"],
                    setName: "rs"
                 }]
         ],

data/spec/support/sdam/single/direct_connection_rsprimary.yml

@@ -11,7 +11,7 @@ phases: [
 
                    ok: 1,
                    ismaster: true,
-                   hosts: ["a"],
+                   hosts: ["a:27017"],
                    setName: "rs"
                 }]
         ],

data/spec/support/sdam/single/direct_connection_rssecondary.yml

@@ -12,7 +12,7 @@ phases: [
                     ok: 1,
                     ismaster: false,
                     secondary: true,
-                    hosts: ["a"],
+                    hosts: ["a:27017"],
                     setName: "rs"
                 }]
         ],

data/spec/support/sdam/single/direct_connection_slave.yml

@@ -1,6 +1,6 @@
 description: "Direct connection to slave"
 
-uri: "mongodb://a/?connect=direct"
+uri: "mongodb://a"
 
 phases: [
 

data/spec/support/sdam/single/direct_connection_standalone.yml

@@ -1,6 +1,6 @@
 description: "Connect to standalone"
 
-uri: "mongodb://a/?connect=direct"
+uri: "mongodb://a"
 
 phases: [
 

data/spec/support/sdam/single/not_ok_response.yml

@@ -26,7 +26,6 @@ phases: [
 
                 "a:27017": {
 
-                    address: "a",
                     type: "Unknown",
                     setName:
                 }

data/spec/support/server_discovery_and_monitoring.rb

@@ -80,7 +80,9 @@ module Mongo
       #
       # @since 2.0.0
       def initialize(file)
-        @test = YAML.load(ERB.new(File.new(file).read).result)
+        file = File.new(file)
+        @test = YAML.load(ERB.new(file.read).result)
+        file.close
         @description = @test['description']
         @uri_string = @test['uri']
         @uri = URI.new(uri_string)

data/spec/support/server_selection.rb

@@ -70,7 +70,9 @@ module Mongo
         #
         # @since 2.0.0
         def initialize(file)
-          @test = YAML.load(ERB.new(File.new(file).read).result)
+          file = File.new(file)
+          @test = YAML.load(ERB.new(file.read).result)
+          file.close
           @description = "#{@test['topology_description']['type']}: #{File.basename(file)}"
           @read_preference = @test['read_preference']
           @read_preference['mode'] = READ_PREFERENCES[@read_preference['mode']]

data/spec/support/shared/bulk_write.rb

@@ -28,6 +28,19 @@ shared_examples 'a bulk write object' do
 
   context 'when an insert_one operation is provided' do
 
+    context 'when there is a write failure' do
+
+      let(:operations) do
+        [{ insert_one: { _id: 1 }}, { insert_one: { _id: 1 }}]
+      end
+
+      it 'raises a BulkWriteError' do
+        expect {
+          bulk.execute
+        }.to raise_error(Mongo::Error::BulkWriteError)
+      end
+    end
+
     context 'when a document is provided' do
 
       let(:operations) do
@@ -42,6 +55,27 @@ shared_examples 'a bulk write object' do
         bulk.execute
         expect(authorized_collection.find.first['name']).to eq('test')
       end
+
+      context 'when there is a write concern error' do
+
+        context 'when the server version is < 2.6' do
+
+          it 'raises a BulkWriteError', if: !write_command_enabled?  && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::BulkWriteError)
+          end
+        end
+
+        context 'when the server version has write commands enabled' do
+
+          it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::OperationFailure)
+          end
+        end
+      end
     end
 
     context 'when an invalid object is provided' do
@@ -101,6 +135,27 @@ shared_examples 'a bulk write object' do
         bulk.execute
         expect(authorized_collection.find.projection(_id: 0).to_a).to eq(expected)
       end
+
+      context 'when there is a write concern error' do
+
+        context 'when the server version is < 2.6' do
+
+          it 'raises a BulkWriteError', if: !write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::BulkWriteError)
+          end
+        end
+
+        context 'when the server version has write commands enabled' do
+
+          it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::OperationFailure)
+          end
+        end
+      end
     end
   end
 
@@ -143,6 +198,27 @@ shared_examples 'a bulk write object' do
           bulk.execute
           expect(authorized_collection.find.to_a).to be_empty
         end
+
+        context 'when there is a write concern error' do
+
+          context 'when the server version is < 2.6' do
+
+            it 'raises a BulkWriteError', if: !write_command_enabled? && standalone? do
+              expect {
+                bulk_invalid_write_concern.execute
+              }.to raise_error(Mongo::Error::BulkWriteError)
+            end
+          end
+
+          context 'when the server version has write commands enabled' do
+
+            it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+              expect {
+                bulk_invalid_write_concern.execute
+              }.to raise_error(Mongo::Error::OperationFailure)
+            end
+          end
+        end
       end
 
       context 'when only one document matches delete selector' do
@@ -241,6 +317,27 @@ shared_examples 'a bulk write object' do
         expect(authorized_collection.find.projection(_id: 0).to_a).to eq(expected)
       end
 
+      context 'when there is a write concern error' do
+
+        context 'when the server version is < 2.6' do
+
+          it 'raises a BulkWriteError', if: !write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::BulkWriteError)
+          end
+        end
+
+        context 'when the server version has write commands enabled' do
+
+          it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::OperationFailure)
+          end
+        end
+      end
+
       context 'when upsert is true' do
 
         let(:operations) do
@@ -296,6 +393,22 @@ shared_examples 'a bulk write object' do
       [{ 'a' => 2 },  { 'a' => 1 }]
     end
 
+    context 'when there is a write failure' do
+
+      let(:operations) do
+        [{ update_one: { find: { a: 1 },
+                         update: { '$st' => { field: 'blah' } },
+                         upsert: false }
+         }]
+      end
+
+      it 'raises a BulkWriteError' do
+        expect {
+          bulk.execute
+        }.to raise_error(Mongo::Error::BulkWriteError)
+      end
+    end
+
     context 'when an update document is not specified' do
 
       let(:operations) do
@@ -351,6 +464,27 @@ shared_examples 'a bulk write object' do
         expect(authorized_collection.find.projection(_id: 0).to_a).to eq(expected)
       end
 
+      context 'when there is a write concern error' do
+
+        context 'when the server version is < 2.6' do
+
+          it 'raises a BulkWriteError', if: !write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::BulkWriteError)
+          end
+        end
+
+        context 'when the server version has write commands enabled' do
+
+          it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::OperationFailure)
+          end
+        end
+      end
+
       context 'when upsert is true' do
 
         let(:operations) do
@@ -417,6 +551,22 @@ shared_examples 'a bulk write object' do
       authorized_collection.insert_many(docs)
     end
 
+    context 'when there is a write failure' do
+
+      let(:operations) do
+        [{ update_many: { find: { a: 1 },
+                          update: { '$st' => { field: 'blah' } },
+                          upsert: false }
+         }]
+      end
+
+      it 'raises an BulkWriteError' do
+        expect {
+          bulk.execute
+        }.to raise_error(Mongo::Error::BulkWriteError)
+      end
+    end
+
     context 'when an update document is not specified' do
 
       let(:operations) do
@@ -468,6 +618,27 @@ shared_examples 'a bulk write object' do
         expect(authorized_collection.find.projection(_id: 0).to_a).to eq(expected)
       end
 
+      context 'when there is a write concern error' do
+
+        context 'when the server version is < 2.6' do
+
+          it 'raises a BulkWriteError', if: !write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::BulkWriteError)
+          end
+        end
+
+        context 'when the server version has write commands enabled' do
+
+          it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+            expect {
+              bulk_invalid_write_concern.execute
+            }.to raise_error(Mongo::Error::OperationFailure)
+          end
+        end
+      end
+
       context 'when upsert is true' do
 
         let(:operations) do
@@ -535,5 +706,26 @@ shared_examples 'a bulk write object' do
       bulk.execute
       expect(authorized_collection.find(x: { '$lte' => 3000 }).to_a.size).to eq(3000)
     end
+
+    context 'when there is a write concern error' do
+
+      context 'when the server version is < 2.6' do
+
+        it 'raises a BulkWriteError', if: !write_command_enabled? && standalone? do
+          expect {
+            bulk_invalid_write_concern.execute
+          }.to raise_error(Mongo::Error::BulkWriteError)
+        end
+      end
+
+      context 'when the server version has write commands enabled' do
+
+        it 'raises an OperationFailure', if: write_command_enabled? && standalone? do
+          expect {
+            bulk_invalid_write_concern.execute
+          }.to raise_error(Mongo::Error::OperationFailure)
+        end
+      end
+    end
   end
 end

data/spec/support/shared/protocol.rb

@@ -1,28 +1,28 @@
 shared_examples 'message with a header' do
   describe 'header' do
     describe 'length' do
-      let(:field) { bytes[0..3] }
+      let(:field) { bytes.to_s[0..3] }
       it 'serializes the length' do
-        expect(field).to be_int32(bytes.size)
+        expect(field).to be_int32(bytes.length)
       end
     end
 
     describe 'request id' do
-      let(:field) { bytes[4..7] }
+      let(:field) { bytes.to_s[4..7] }
       it 'serializes the request id' do
         expect(field).to be_int32(message.request_id)
       end
     end
 
     describe 'response to' do
-      let(:field) { bytes[8..11] }
+      let(:field) { bytes.to_s[8..11] }
       it 'serializes the response to' do
         expect(field).to be_int32(0)
       end
     end
 
     describe 'op code' do
-      let(:field) { bytes[12..15] }
+      let(:field) { bytes.to_s[12..15] }
       it 'serializes the op code' do
         expect(field).to be_int32(opcode)
       end