mongo 1.3.0 → 1.12.5

data/test/unit/collection_test.rb

@@ -1,114 +1,125 @@
-require './test/test_helper'
+# Copyright (C) 2009-2013 MongoDB, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'test_helper'
+
+module Mongo
+  class Collection
+    attr_reader :operation_writer,
+                :command_writer
+  end
+end
 
-class CollectionTest < Test::Unit::TestCase
+class CollectionUnitTest < Test::Unit::TestCase
 
   context "Basic operations: " do
     setup do
       @logger = mock()
+      @logger.stubs(:level => 0)
       @logger.expects(:debug)
+
+      @client = MongoClient.new('localhost', 27017, :logger => @logger, :connect => false)
+      @db     = @client[TEST_DB]
+      @coll   = @db.collection('collection-unit-test')
     end
 
     should "send update message" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
-      @conn.expects(:send_message).with do |op, msg, log|
+      @client.expects(:send_message_with_gle).with do |op, msg, log|
         op == 2001
       end
-      @conn.stubs(:log_operation)
+      @coll.operation_writer.stubs(:log_operation)
       @coll.update({}, {:title => 'Moby Dick'})
     end
 
     should "send insert message" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
-      @conn.expects(:send_message).with do |op, msg, log|
+      @client.expects(:send_message_with_gle).with do |op, msg, log|
         op == 2002
       end
-      @conn.expects(:log_operation).with do |name, payload|
-        (name == :insert) && payload[:documents][0][:title].include?('Moby')
+      @coll.operation_writer.expects(:log_operation).with do |name, payload|
+        (name == :insert) && payload[:documents][:title].include?('Moby')
       end
       @coll.insert({:title => 'Moby Dick'})
     end
 
     should "send sort data" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
-      @conn.expects(:receive_message).with do |op, msg, log, sock|
+      @client.expects(:checkout_reader).returns(new_mock_socket)
+      @client.expects(:receive_message).with do |op, msg, log, sock|
         op == 2004
       end.returns([[], 0, 0])
-      @conn.expects(:log_operation).with do |name, payload|
-        (name == :find) && payload[:selector][:title].include?('Moby')
-      end
+      @logger.expects(:debug)
       @coll.find({:title => 'Moby Dick'}).sort([['title', 1], ['author', 1]]).next_document
     end
 
     should "not log binary data" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
       data = BSON::Binary.new(("BINARY " * 1000).unpack("c*"))
-      @conn.expects(:send_message).with do |op, msg, log|
+      @client.expects(:send_message_with_gle).with do |op, msg, log|
         op == 2002
       end
-      @conn.expects(:log_operation).with do |name, payload|
-        (name == :insert) && payload[:documents][0][:data].inspect.include?('Binary')
+      @coll.operation_writer.expects(:log_operation).with do |name, payload|
+        (name == :insert) && payload[:documents][:data].inspect.include?('Binary')
       end
       @coll.insert({:data => data})
     end
 
     should "send safe update message" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
-      @conn.expects(:send_message_with_safe_check).with do |op, msg, db_name, log|
+      @client.expects(:send_message_with_gle).with do |op, msg, db_name, log|
+        op == 2001
+      end
+      @coll.operation_writer.expects(:log_operation).with do |name, payload|
+        (name == :update) && payload[:documents][:title].include?('Moby')
+      end
+      @coll.update({}, {:title => 'Moby Dick'})
+    end
+
+    should "send safe update message with legacy" do
+      connection = Connection.new('localhost', 27017, :safe => true, :connect => false)
+      db         = connection[TEST_DB]
+      coll       = db.collection('collection-unit-test')
+      connection.expects(:send_message_with_gle).with do |op, msg, db_name, log|
         op == 2001
       end
-      @conn.expects(:log_operation).with do |name, payload|
-        (name == :update) && payload[:document][:title].include?('Moby')
+      coll.operation_writer.expects(:log_operation).with do |name, payload|
+        (name == :update) && payload[:documents][:title].include?('Moby')
       end
-      @coll.update({}, {:title => 'Moby Dick'}, :safe => true)
+      coll.update({}, {:title => 'Moby Dick'})
     end
 
     should "send safe insert message" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
-      @conn.expects(:send_message_with_safe_check).with do |op, msg, db_name, log|
+      @client.expects(:send_message_with_gle).with do |op, msg, db_name, log|
         op == 2001
       end
-      @conn.stubs(:log_operation)
-      @coll.update({}, {:title => 'Moby Dick'}, :safe => true)
+      @coll.operation_writer.stubs(:log_operation)
+      @coll.update({}, {:title => 'Moby Dick'})
     end
 
     should "not call insert for each ensure_index call" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
       @coll.expects(:generate_indexes).once
 
       @coll.ensure_index [["x", Mongo::DESCENDING]]
       @coll.ensure_index [["x", Mongo::DESCENDING]]
     end
 
-    should "call generate_indexes for a new direction on the same field for ensure_index" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
-      @coll = @db.collection('books')
+    should "call generate_indexes for a new type on the same field for ensure_index" do
       @coll.expects(:generate_indexes).twice
 
       @coll.ensure_index [["x", Mongo::DESCENDING]]
       @coll.ensure_index [["x", Mongo::ASCENDING]]
-
     end
 
     should "call generate_indexes twice because the cache time is 0 seconds" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
       @db.cache_time = 0
-      @coll = @db.collection('books')
+      @coll = @db.collection('collection-unit-test')
       @coll.expects(:generate_indexes).twice
 
       @coll.ensure_index [["x", Mongo::DESCENDING]]
@@ -116,15 +127,40 @@ class CollectionTest < Test::Unit::TestCase
     end
 
     should "call generate_indexes for each key when calling ensure_indexes" do
-      @conn = Connection.new('localhost', 27017, :logger => @logger, :connect => false)
-      @db   = @conn['testing']
       @db.cache_time = 300
-      @coll = @db.collection('books')
+      @coll = @db.collection('collection-unit-test')
       @coll.expects(:generate_indexes).once.with do |a, b, c|
         a == {"x"=>-1, "y"=>-1}
       end
 
       @coll.ensure_index [["x", Mongo::DESCENDING], ["y", Mongo::DESCENDING]]
     end
+
+    should "call generate_indexes for each key when calling ensure_indexes with a hash" do
+      @db.cache_time = 300
+      @coll = @db.collection('collection-unit-test')
+      oh = BSON::OrderedHash.new
+      oh['x'] = Mongo::DESCENDING
+      oh['y'] = Mongo::DESCENDING
+      @coll.expects(:generate_indexes).once.with do |a, b, c|
+        a == oh
+      end
+
+      if RUBY_VERSION > '1.9'
+          @coll.ensure_index({"x" => Mongo::DESCENDING, "y" => Mongo::DESCENDING})
+      else
+          ordered_hash = BSON::OrderedHash.new
+          ordered_hash['x'] = Mongo::DESCENDING
+          ordered_hash['y'] = Mongo::DESCENDING
+          @coll.ensure_index(ordered_hash)
+      end
+    end
+
+    should "use the connection's logger" do
+      @logger.expects(:warn).with do |msg|
+        msg == "MONGODB [WARNING] test warning"
+      end
+      @coll.log(:warn, "test warning")
+    end
   end
 end

data/test/unit/connection_test.rb

@@ -1,83 +1,333 @@
-require './test/test_helper'
-include Mongo
+# Copyright (C) 2009-2013 MongoDB, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 
-class ConnectionTest < Test::Unit::TestCase
-  context "Initialization: " do
+require 'test_helper'
+
+class ConnectionUnitTest < Test::Unit::TestCase
+  context "Mongo::MongoClient initialization " do
     context "given a single node" do
       setup do
-        @conn = Connection.new('localhost', 27017, :connect => false)
+        @connection = Mongo::Connection.new('localhost', 27017, :safe => true, :connect => false)
         TCPSocket.stubs(:new).returns(new_mock_socket)
 
         admin_db = new_mock_db
-        admin_db.expects(:command).returns({'ok' => 1, 'ismaster' => 1}).twice
-        @conn.expects(:[]).with('admin').returns(admin_db).twice
-        @conn.connect
+        admin_db.expects(:command).returns({'ok' => 1, 'ismaster' => 1})
+        @connection.expects(:[]).with('admin').returns(admin_db)
+        @connection.connect
+      end
+
+      should "set safe mode true" do
+        assert_equal true, @connection.safe
       end
 
       should "set localhost and port to master" do
-        assert_equal 'localhost', @conn.primary_pool.host
-        assert_equal 27017, @conn.primary_pool.port
+        assert_equal 'localhost', @connection.primary_pool.host
+        assert_equal 27017, @connection.primary_pool.port
       end
 
       should "set connection pool to 1" do
-        assert_equal 1, @conn.primary_pool.size
+        assert_equal 1, @connection.primary_pool.size
       end
 
       should "default slave_ok to false" do
-        assert !@conn.slave_ok?
+        assert !@connection.slave_ok?
+      end
+
+      should "not raise error if no host or port is supplied" do
+        assert_nothing_raised do
+          Mongo::Connection.new(:safe => true, :connect => false)
+        end
+        assert_nothing_raised do
+          Mongo::Connection.new('localhost', :safe => true, :connect => false)
+        end
+      end
+
+      should "warn if invalid options are specified" do
+        connection = Mongo::Connection.allocate
+        opts = {:connect => false}
+
+        Mongo::ReplSetConnection::REPL_SET_OPTS.each do |opt|
+          connection.expects(:warn).with("#{opt} is not a valid option for #{connection.class}")
+          opts[opt] = true
+        end
+
+        args = ['localhost', 27017, opts]
+        connection.send(:initialize, *args)
+      end
+
+    end
+
+    context "initializing with a unix socket" do
+      setup do
+        @connection = Mongo::Connection.new('/tmp/mongod.sock', :safe => true, :connect => false)
+        UNIXSocket.stubs(:new).returns(new_mock_unix_socket)
+      end
+      should "parse a unix socket" do
+        assert_equal "/tmp/mongod.sock", @connection.host_port.first
+      end
+    end
+
+    context "initializing with a unix socket in uri" do
+      setup do
+          @connection = Mongo::Connection.from_uri("mongodb:///tmp/mongod.sock", :connect => false)
+          UNIXSocket.stubs(:new).returns(new_mock_unix_socket)
+      end
+      should "parse a unix socket" do
+          assert_equal "/tmp/mongod.sock", @connection.host_port.first
       end
     end
 
     context "initializing with a mongodb uri" do
       should "parse a simple uri" do
-        @conn = Connection.from_uri("mongodb://localhost", :connect => false)
-        assert_equal ['localhost', 27017], @conn.host_to_try
+        @connection = Mongo::Connection.from_uri("mongodb://localhost", :connect => false)
+        assert_equal ['localhost', 27017], @connection.host_port
+      end
+
+      should "set auth source" do
+        @connection = Mongo::Connection.from_uri("mongodb://user:pass@localhost?authSource=foo", :connect => false)
+        assert_equal 'foo', @connection.auths.first[:source]
+      end
+
+      should "set auth mechanism" do
+        @connection = Mongo::Connection.from_uri("mongodb://user@localhost?authMechanism=MONGODB-X509", :connect => false)
+        assert_equal 'MONGODB-X509', @connection.auths.first[:mechanism]
+
+        assert_raise MongoArgumentError do
+          Mongo::Connection.from_uri("mongodb://localhost?authMechanism=INVALID", :connect => false)
+        end
       end
 
       should "allow a complex host names" do
         host_name = "foo.bar-12345.org"
-        @conn = Connection.from_uri("mongodb://#{host_name}", :connect => false)
-        assert_equal [host_name, 27017], @conn.host_to_try
+        @connection = Mongo::Connection.from_uri("mongodb://#{host_name}", :connect => false)
+        assert_equal [host_name, 27017], @connection.host_port
+      end
+
+      should "allow db without username and password" do
+        host_name = "foo.bar-12345.org"
+        @connection = Mongo::Connection.from_uri("mongodb://#{host_name}/foo", :connect => false)
+        assert_equal [host_name, 27017], @connection.host_port
+      end
+
+      should "set safe options on connection" do
+        host_name = "localhost"
+        opts = "safe=true&w=2&wtimeoutMS=1000&fsync=true&journal=true"
+        @connection = Mongo::Connection.from_uri("mongodb://#{host_name}/foo?#{opts}", :connect => false)
+        assert_equal({:w => 2, :wtimeout => 1000, :fsync => true, :j => true}, @connection.write_concern)
+      end
+
+      should "set timeout options on connection" do
+        host_name = "localhost"
+        opts = "connectTimeoutMS=1000&socketTimeoutMS=5000"
+        @connection = Mongo::Connection.from_uri("mongodb://#{host_name}/foo?#{opts}", :connect => false)
+        assert_equal 1, @connection.connect_timeout
+        assert_equal 5, @connection.op_timeout
       end
 
       should "parse a uri with a hyphen & underscore in the username or password" do
-        @conn = Connection.from_uri("mongodb://hyphen-user_name:p-s_s@localhost:27017/db", :connect => false)
-        assert_equal ['localhost', 27017], @conn.host_to_try
-        auth_hash = { 'db_name' => 'db', 'username' => 'hyphen-user_name', "password" => 'p-s_s' }
-        assert_equal auth_hash, @conn.auths[0]
+        @connection = Mongo::Connection.from_uri("mongodb://hyphen-user_name:p-s_s@localhost:27017/db", :connect => false)
+        assert_equal ['localhost', 27017], @connection.host_port
+
+        auth_hash = {
+          :db_name   => 'db',
+          :extra=>{},
+          :username  => 'hyphen-user_name',
+          :password  => 'p-s_s',
+          :source    => 'db',
+          :mechanism => nil
+        }
+        assert_equal auth_hash, @connection.auths.first
       end
 
       should "attempt to connect" do
         TCPSocket.stubs(:new).returns(new_mock_socket)
-        @conn = Connection.from_uri("mongodb://localhost", :connect => false)
+        @connection = Mongo::Connection.from_uri("mongodb://localhost", :connect => false)
 
         admin_db = new_mock_db
-        admin_db.expects(:command).returns({'ok' => 1, 'ismaster' => 1}).twice
-        @conn.expects(:[]).with('admin').returns(admin_db).twice
-        @conn.connect
+        admin_db.expects(:command).returns({'ok' => 1, 'ismaster' => 1})
+        @connection.expects(:[]).with('admin').returns(admin_db)
+        @connection.connect
       end
 
       should "raise an error on invalid uris" do
         assert_raise MongoArgumentError do
-          Connection.from_uri("mongo://localhost", :connect => false)
+          Mongo::Connection.from_uri("mongo://localhost", :connect => false)
         end
 
         assert_raise MongoArgumentError do
-          Connection.from_uri("mongodb://localhost:abc", :connect => false)
+          Mongo::Connection.from_uri("mongodb://localhost:abc", :connect => false)
         end
+      end
+
+      should "require password if using legacy auth and username present" do
+        assert Mongo::Connection.from_uri("mongodb://kyle:jones@localhost/db", :connect => false)
 
         assert_raise MongoArgumentError do
-          Connection.from_uri("mongodb://localhost:27017, my.db.com:27018, ", :connect => false)
+          Mongo::Connection.from_uri("mongodb://kyle:@localhost", :connect => false)
         end
-      end
 
-      should "require all of username, password, and database if any one is specified" do
         assert_raise MongoArgumentError do
-          Connection.from_uri("mongodb://localhost/db", :connect => false)
+          Mongo::Connection.from_uri("mongodb://kyle@localhost", :connect => false)
         end
+      end
+    end
 
-        assert_raise MongoArgumentError do
-          Connection.from_uri("mongodb://kyle:password@localhost", :connect => false)
+    context "initializing with ENV['MONGODB_URI']" do
+      should "parse a simple uri" do
+        uri = "mongodb://localhost?connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal ['localhost', 27017], @connection.host_port
+        end
+      end
+
+      should "set auth source" do
+        uri = "mongodb://user:pass@localhost?authSource=foo&connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal 'foo', @connection.auths.first[:source]
+        end
+      end
+
+      should "set auth mechanism" do
+        uri = "mongodb://user@localhost?authMechanism=MONGODB-X509&connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal 'MONGODB-X509', @connection.auths.first[:mechanism]
+
+          ENV['MONGODB_URI'] = "mongodb://user@localhost?authMechanism=INVALID&connect=false"
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
+        end
+      end
+
+      should "allow a complex host names" do
+        host_name = "foo.bar-12345.org"
+        uri = "mongodb://#{host_name}?connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal [host_name, 27017], @connection.host_port
+        end
+      end
+
+      should "allow db without username and password" do
+        host_name = "foo.bar-12345.org"
+        uri = "mongodb://#{host_name}/foo?connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal [host_name, 27017], @connection.host_port
+        end
+      end
+
+      should "set safe options on connection" do
+        host_name = "localhost"
+        opts = "safe=true&w=2&wtimeoutMS=1000&fsync=true&journal=true&connect=false"
+        uri = "mongodb://#{host_name}/foo?#{opts}"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal({:w => 2, :wtimeout => 1000, :fsync => true, :j => true}, @connection.safe)
+        end
+      end
+
+      should "set timeout options on connection" do
+        host_name = "localhost"
+        opts = "connectTimeoutMS=1000&socketTimeoutMS=5000&connect=false"
+        uri = "mongodb://#{host_name}/foo?#{opts}"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal 1, @connection.connect_timeout
+          assert_equal 5, @connection.op_timeout
+        end
+      end
+
+      should "parse a uri with a hyphen & underscore in the username or password" do
+        uri = "mongodb://hyphen-user_name:p-s_s@localhost:27017/db?connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+          assert_equal ['localhost', 27017], @connection.host_port
+
+          auth_hash = {
+            :db_name   => 'db',
+            :extra=>{},
+            :username  => 'hyphen-user_name',
+            :password  => 'p-s_s',
+            :source    => 'db',
+            :mechanism => nil
+          }
+          assert_equal auth_hash, @connection.auths.first
+        end
+      end
+
+      should "attempt to connect" do
+        TCPSocket.stubs(:new).returns(new_mock_socket)
+        uri = "mongodb://localhost?connect=false"
+        with_preserved_env_uri(uri) do
+          @connection = Mongo::Connection.new
+
+          admin_db = new_mock_db
+          admin_db.expects(:command).returns({'ok' => 1, 'ismaster' => 1})
+          @connection.expects(:[]).with('admin').returns(admin_db)
+          @connection.connect
+        end
+      end
+
+      should "raise an error on invalid uris" do
+        uri = "mongo://localhost"
+        with_preserved_env_uri(uri) do
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
+
+          ENV['MONGODB_URI'] = "mongodb://localhost:abc"
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
+        end
+      end
+
+      should "require password if using legacy auth and username present" do
+        uri = "mongodb://kyle:jones@localhost/db?connect=false"
+        with_preserved_env_uri(uri) do
+          assert Mongo::Connection.new
+
+          ENV['MONGODB_URI'] = "mongodb://kyle:@localhost?connect=false"
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
+
+          ENV['MONGODB_URI'] = "mongodb://kyle@localhost?connect=false"
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
+        end
+      end
+
+      should "require password if using PLAIN auth and username present" do
+        uri = "mongodb://kyle:jones@localhost/db?connect=false&authMechanism=PLAIN"
+        with_preserved_env_uri(uri) do
+          assert Mongo::Connection.new
+
+          ENV['MONGODB_URI'] = "mongodb://kyle:@localhost?connect=false&authMechanism=PLAIN"
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
+
+          ENV['MONGODB_URI'] = "mongodb://kyle@localhost?connect=false&authMechanism=PLAIN"
+          assert_raise MongoArgumentError do
+            Mongo::Connection.new
+          end
         end
       end
     end