moneyc 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a639091173a1ccfa70372a5e5e6ed64f785b0cb
-  data.tar.gz: 92f2f8dbd94a0362fb9a201dc5f678073102400c
+  metadata.gz: 562752007bca3c6d2449c6cd2d8b7b5b09c28630
+  data.tar.gz: 017fb81d13021581301b026b4aec1c28be38730e
 SHA512:
-  metadata.gz: 70d23f8677c62b449d7b5f5a028a955399097413936fe1248090f8e95ae69ddfee9cfab74f387a1c26dbb776b1a09c7b4b6478f3a494e19c42970738815d36f4
-  data.tar.gz: e9e83ebb21be17b4df5d4e5b1ae5bc5ebf3326d0ee92c0b48eebf4066f20f1b42257793e600e6dd57986afce5d59fb02ceebe0ce56ce438511104a0aa728f09b
+  metadata.gz: 9589e57c0451c68fe370e1dd6e559f45c0116cbf6569d38c8a1e4a4a8ef73f5753204d18d54ca986f3d6f3475733b2d866ee9c2fc6f89067be1aa82a7704edf6
+  data.tar.gz: 62b28904363442879eec38589ff2df838e988e53878f29bbed00049be366022a00528238f90a7efa1e6783bb91ed2b204f881a72d730247b9e2a64139bff575a

data/Gemfile

@@ -7,4 +7,4 @@ group :test do
   gem 'timecop'
 end
 
-gemspec
+gemspec

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    moneyc (1.0.0)
-      activesupport (~> 4.0)
+    moneyc (1.0.1)
+      activesupport (~> 4.2)
       rake (~> 10.4, >= 10.4)
 
 GEM
@@ -63,3 +63,6 @@ DEPENDENCIES
   pry (~> 0.10)
   rspec (~> 3.1)
   timecop
+
+BUNDLED WITH
+   1.10.6

data/README.md

@@ -32,11 +32,11 @@ gem install moneyc
 require 'moneyc'
 
 # Convert 7.55 EUR to USD
-Moneyc::Converter.new(money: 7.55, from: 'EUR', to: 'USD').convert
+Moneyc::Converter.new(from: 'EUR', to: 'USD').convert(7.55)
 # => Float
 
 # Convert with specific date 7.55 EUR to USD
-Moneyc::Converter.new(money: 7.55, from: 'EUR', to: 'USD', at: Time.now).convert
+Moneyc::Converter.new(from: 'EUR', to: 'USD', at: Time.now).convert(7.55)
 # => Float
 
 # Get today rate (EUR to USD)

data/Rakefile

@@ -1,5 +1,5 @@
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
-task :default => :spec
+task default: :spec
 
-Dir.glob('tasks/*.rake').each { |r| load r}
+Dir.glob('tasks/*.rake').each { |task| load task }

data/lib/moneyc.rb

@@ -4,14 +4,12 @@ require 'json'
 require 'active_support/all'
 
 module Moneyc
- AVAILABLE_CURRENCY = [ :AUD, :BGN, :BRL, :CAD, :CHF,
-                        :CNY, :CZK, :DKK, :GBP, :HKD,
-                        :HRK, :HUF, :IDR, :ILS, :INR,
-                        :JPY, :KRW, :MXN, :MYR, :NOK,
-                        :NZD, :PHP, :PLN, :RON, :RUB,
-                        :SEK, :SGD, :THB, :TRY, :USD,
-                        :ZAR, :EUR ]
+  AVAILABLE_CURRENCY = [:AUD, :BGN, :BRL, :CAD, :CHF,
+    :CNY, :CZK, :DKK, :GBP, :HKD, :HRK, :HUF, :IDR,
+    :ILS, :INR, :JPY, :KRW, :MXN, :MYR, :NOK, :NZD,
+    :PHP, :PLN, :RON, :RUB, :SEK, :SGD, :THB, :TRY,
+    :USD, :ZAR, :EUR]
 
-  autoload :FixerHTTPClient,  'moneyc/fixer_http_client'
-  autoload :Converter,        'moneyc/converter'
-end
+  autoload :FixerHTTPClient, 'moneyc/fixer_http_client'
+  autoload :Converter,       'moneyc/converter'
+end

data/lib/moneyc/converter.rb

@@ -1,25 +1,23 @@
 module Moneyc
   class Converter
-
-    def initialize(options = {})
-      @money_in_reference_currency  = options[:money]
-      @reference_currency           = options.fetch(:from)
-      @target_currency              = options[:to].present? ? options[:to] : @reference_currency
-      @conversion_date              = options[:at].present? ? options[:at] : Time.now
+    def initialize(from:, to: nil, at: nil)
+      @reference_currency = from
+      @target_currency = to.presence || @reference_currency
+      @conversion_date = at.presence || Time.now
     end
 
     def rate
-      reference_and_target_is_same? ? 1 : retrieve_taget_currency_rate
-    end
-
-    def convert
-      if @money_in_reference_currency.present?
-        @money_in_reference_currency.to_f * rate
+      if reference_and_target_is_same?
+        1
       else
-        raise ConverterError.new("You need enter an value to convert")
+        retrieve_taget_currency_rate
       end
     end
 
+    def convert(total_in_reference_currency)
+      total_in_reference_currency.to_f * rate
+    end
+
     private
 
     def reference_and_target_is_same?
@@ -27,20 +25,24 @@ module Moneyc
     end
 
     def retrieve_taget_currency_rate
-      if http_response.present? && http_response[@target_currency.to_sym].present? 
+      if http_response.present? &&
+          http_response[@target_currency.to_sym].present?
+
         http_response[@target_currency.to_sym]
       else
-        raise ConverterError.new("#{@target_currency} or #{@reference_currency} is not available currency")
+        fail ArgumentError, argument_error_message
       end
     end
 
+    def argument_error_message
+      "#@target_currency or #@reference_currency is not available currency"
+    end
+
     def http_response
       FixerHTTPClient.new(
         conversion_date: @conversion_date,
         reference_currency: @reference_currency
       ).fetch_currency_rate
     end
-
-    class ConverterError < StandardError; end
   end
 end

data/lib/moneyc/fixer_http_client.rb

@@ -6,27 +6,27 @@ module Moneyc
     def initialize(conversion_date:, reference_currency:)
       @conversion_date = conversion_date.strftime('%Y-%m-%d')
       @reference_currency = reference_currency.to_s
+      @uri = construct_uri
     end
 
     def fetch_currency_rate
-      construct_uri
       retrieve_rate
     end
 
     private
 
-    attr_reader :uri
-
     def construct_uri
-      @uri = URI("#{API_PROTOCOL}#{BASE_API_URL}/#{@conversion_date}/?base=#{@reference_currency}")
+      URI("#{ API_PROTOCOL }#{ BASE_API_URL }/#@conversion_date/?base=#@reference_currency")
     end
 
     def retrieve_rate
-      JSON.parse(call_api, { symbolize_names: true})[:rates]
+      JSON.parse(call_api, { symbolize_names: true }).fetch(:rates)
+    rescue KeyError
+      fail ArgumentError, 'target currency is not available'
     end
 
     def call_api
-      http_client.get(uri)
+      http_client.get(@uri)
     end
 
     def http_client

data/lib/moneyc/version.rb

@@ -1,3 +1,3 @@
 module Moneyc
-	VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/moneyc.gemspec

@@ -3,14 +3,14 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'moneyc/version'
 
 Gem::Specification.new do |gem|
-    gem.name          = "moneyc"
+    gem.name          = 'moneyc'
     gem.version       = Moneyc::VERSION
-    gem.authors       = ["Bryan FRIMIN"]
-    gem.email         = ["bfrimin@student.42.fr"]
-    gem.description   = %q{Convert your currency with simple lib}
-    gem.summary       = %q{Convert et retrive rate of your currency with simple lib}
-    gem.homepage      = "https://github.com/gearnode/moneyc"
-    gem.license       = "MIT"
+    gem.authors       = %w(Bryan FRIMIN)
+    gem.email         = %w(bfrimin@student.42.fr)
+    gem.description   = 'Convert your currency with simple lib'
+    gem.summary       = 'Convert et retrive rate of your currency with simple lib'
+    gem.homepage      = 'https://github.com/gearnode/moneyc'
+    gem.license       = 'MIT'
 
     gem.required_ruby_version     = '>= 2.2'
     gem.required_rubygems_version = '>= 1.8.11'
@@ -18,12 +18,12 @@ Gem::Specification.new do |gem|
     gem.files         = `git ls-files`.split($/)
     gem.executables   = gem.files.grep(%r{^bin/}) { |f| File.basename(f) }
     gem.test_files    = gem.files.grep(%r{^(spec)/})
-    gem.require_paths = ["lib"]
+    gem.require_paths = ['lib']
 
     gem.add_runtime_dependency 'rake', '~> 10.4', '>= 10.4'
 
     gem.add_development_dependency 'bundler', '~> 1.7'
     gem.add_development_dependency 'rspec', '~> 3.1'
     gem.add_development_dependency 'pry', '~> 0.10'
-    gem.add_dependency 'activesupport', '~> 4.0'
+    gem.add_dependency 'activesupport', '~> 4.2'
 end

data/spec/lib/money/converter_spec.rb

@@ -4,7 +4,7 @@ describe Moneyc::Converter do
 
   describe '#rate' do
     subject{ described_class.new(from: reference_currency, to: target_currency, at: date).rate }
-    
+
     let(:date){ Time.new('2015', '8', '20') }
 
     context 'when reference and target currency is same' do
@@ -57,13 +57,13 @@ describe Moneyc::Converter do
       let(:target_currency){ 'ISNOTACURRENCY' }
 
       it 'raises a error' do
-        expect{ subject }.to raise_error(Moneyc::Converter::ConverterError)
+        expect{ subject }.to raise_error(ArgumentError)
       end
     end
   end
 
   describe '#convert' do
-    subject{ described_class.new(money: 7, from: reference_currency, to: target_currency, at: date).convert }
+    subject{ described_class.new(from: reference_currency, to: target_currency, at: date).convert(7) }
 
     let(:date){ Time.new('2015', '8', '20') }
 
@@ -116,9 +116,9 @@ describe Moneyc::Converter do
       let(:reference_currency){ 'ISNOTACURRENCY' }
       let(:target_currency){ 'USD' }
 
-      it 'raises error' do
-        expect{ subject }.to raise_error(Moneyc::Converter::ConverterError)
+      it 'returns nil' do
+        expect{ subject }.to raise_error(ArgumentError)
       end
     end
   end
-end
+end

data/spec/lib/money/fixer_http_client_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Moneyc::FixerHTTPClient do
-  
+
   describe '#fetch_currency_rate' do
     subject{ described_class.new(conversion_date: conversion_date, reference_currency: reference_currency).fetch_currency_rate }
 
@@ -14,7 +14,7 @@ describe Moneyc::FixerHTTPClient do
         expect(subject).to be_a(Hash)
       end
 
-      it 'return hash with eur' do
+      it 'returns hash with eur' do
         expect(subject[:EUR]).not_to be_nil
       end
     end
@@ -22,9 +22,9 @@ describe Moneyc::FixerHTTPClient do
     context 'when reference_currency is not available' do
       let(:reference_currency){ :WDFGYUJI }
 
-      it 'returns nil' do
-        expect(subject).to be_nil
-      end      
+      it 'raises error' do
+        expect{ subject }.to raise_error(ArgumentError)
+      end
     end
   end
-end
+end

data/tasks/debug.rake

@@ -1,4 +1,4 @@
 desc 'Open an irb session preloaded with this library'
 task :console do
-	sh 'irb -rubygems -I lib -r moneyc.rb'
-end
+  sh 'irb -rubygems -I lib -r moneyc.rb'
+end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: moneyc
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
-- Bryan FRIMIN
+- Bryan
+- FRIMIN
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-24 00:00:00.000000000 Z
+date: 2015-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -78,14 +79,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '4.2'
 description: Convert your currency with simple lib
 email:
 - bfrimin@student.42.fr
@@ -129,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.8.11
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Convert et retrive rate of your currency with simple lib