money_mover 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 539a311851902d5ab85946c0722879850cd5c8b7
-  data.tar.gz: c6147bebb234f5b70abc1c5b276c1c22eadbc5d2
+  metadata.gz: 1162d4b84c5bc053a5d4b6c702a13d832850db1d
+  data.tar.gz: 4376d2b5614cb5fa36519fdf3c72c3eac2cf811a
 SHA512:
-  metadata.gz: 204cb3879e4d423c4d65717c0ec4a40de1038b5f76daa6f7c64d88757270386221b35eaa69a6ee99222ad8f7c9f02fb8decc8be45e53fdf14d1c68f666d1e603
-  data.tar.gz: cc3a3b581cfe26aa293bbd06de1d30d36c3fd7350b9646c995051d0d921384f73ec0a4f705798f7cd9cdb271352ce54ddfa1511afdf6f9ba1da092320a24d281
+  metadata.gz: 3071621908ec13dc0130ed7734a371b6ec0923ab5fe3dd8a8b6cba0f1c661f0d79d7e9356b536d9a60d146de163eb40d17b4a2ba61e2a11e1fed712fbb8317df
+  data.tar.gz: 762d42ea1cff1d371af3acde40dd4a3e05434958aba3ab46e7d7d66ea43d5d2235ec50f308ab09adf9f11626b4dc8bc5d93ac5992263b022e05b64dcfbc2a2c0

data/lib/money_mover/dwolla/models/customer.rb

@@ -1,6 +1,7 @@
 module MoneyMover
   module Dwolla
     class Customer < ApiResource
+      COMPANY_TYPES = %w( soleproprietorship llc partnership corporation )
 
       attr_accessor :firstName,
         :lastName,
@@ -24,8 +25,6 @@ module MoneyMover
         :status,
         :created
 
-      validates_presence_of :type
-
       def self.find(id)
         client = AccountClient.new
 

data/lib/money_mover/dwolla/models/{funding_source.rb → customer_funding_source.rb}

@@ -1,6 +1,6 @@
 module MoneyMover
   module Dwolla
-    class FundingSource < ApiResource
+    class CustomerFundingSource < ApiResource
       attr_accessor :name, :type, :routingNumber, :accountNumber
 
       validates_presence_of :name, :type, :routingNumber, :accountNumber

data/lib/money_mover/dwolla/models/unverified_business_customer.rb

@@ -2,6 +2,7 @@ module MoneyMover
   module Dwolla
     class UnverifiedBusinessCustomer < Customer
       validates_presence_of :businessName
+      validates_inclusion_of :businessType, in: COMPANY_TYPES
 
       def initialize(attrs = {})
         attrs[:type] = 'unverified'

data/lib/money_mover/dwolla/models/unverified_customer.rb

@@ -5,10 +5,6 @@ module MoneyMover
 
       validates_presence_of :firstName, :lastName, :email
 
-      def initialize(attrs={})
-        super attrs.merge(type: 'unverified')
-      end
-
       def create_params
         create_attrs = {
           firstName: firstName,
@@ -18,7 +14,7 @@ module MoneyMover
 
         create_attrs[:businessName] = businessName if businessName.present?
         create_attrs[:ipAddress] = ipAddress if ipAddress.present?
-        #create_attrs[:type] = 'unverified'
+        create_attrs[:type] = 'unverified'
 
         create_attrs
       end

data/lib/money_mover/dwolla/models/verified_business_customer.rb

@@ -13,10 +13,7 @@ module MoneyMover
         :businessName,
         :ein
 
-      def initialize(attrs = {})
-        attrs[:type] = 'business'
-        super attrs
-      end
+      validates_inclusion_of :businessType, in: COMPANY_TYPES
 
       private
 
@@ -39,7 +36,7 @@ module MoneyMover
           ein: ein,
           doingBusinessAs: doingBusinessAs,
           website: website,
-          type: type,
+          type: 'business',
         }
 
         # hack to fix bug on dwolla's side with funding sources being removed if no dba is sent

data/lib/money_mover/dwolla.rb

@@ -17,7 +17,7 @@ require 'money_mover/dwolla/models/api_resource'
 # models
 require 'money_mover/dwolla/models/account_funding_source'
 require 'money_mover/dwolla/models/document'
-require 'money_mover/dwolla/models/funding_source'
+require 'money_mover/dwolla/models/customer_funding_source'
 require 'money_mover/dwolla/models/micro_deposit_initiation'
 require 'money_mover/dwolla/models/micro_deposit_verification'
 require 'money_mover/dwolla/models/transfer'

data/lib/money_mover/version.rb

@@ -1,3 +1,3 @@
 module MoneyMover
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/integration/money_mover/dwolla/customers/create_spec.rb

@@ -21,7 +21,8 @@ describe MoneyMover::Dwolla::UnverifiedCustomer do
     firstName: firstName,
     lastName: lastName,
     email: email,
-    ipAddress: ipAddress
+    ipAddress: ipAddress,
+    type: 'unverified'
   }}
 
   before do

data/spec/integration/money_mover/dwolla/customers/funding-sources/create_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe MoneyMover::Dwolla::FundingSource do
+describe MoneyMover::Dwolla::CustomerFundingSource do
   let(:name) { 'my checking account' }
   let(:type) { 'checking' }
   let(:routingNumber) { '222222226' }

data/spec/lib/money_mover/dwolla/funding_source_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe MoneyMover::Dwolla::FundingSource do
+describe MoneyMover::Dwolla::CustomerFundingSource do
   let(:customer_id) { double 'customer id' }
 
   let(:name) { 'some name' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money_mover
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Daniel Errante
@@ -193,8 +193,8 @@ files:
 - lib/money_mover/dwolla/models/account_funding_source.rb
 - lib/money_mover/dwolla/models/api_resource.rb
 - lib/money_mover/dwolla/models/customer.rb
+- lib/money_mover/dwolla/models/customer_funding_source.rb
 - lib/money_mover/dwolla/models/document.rb
-- lib/money_mover/dwolla/models/funding_source.rb
 - lib/money_mover/dwolla/models/micro_deposit_initiation.rb
 - lib/money_mover/dwolla/models/micro_deposit_verification.rb
 - lib/money_mover/dwolla/models/receive_only_business_customer.rb