money 6.7.1 → 6.13.0

data/spec/money/locale_backend_spec.rb

@@ -0,0 +1,14 @@
+# encoding: utf-8
+
+describe Money::LocaleBackend do
+  describe '.find' do
+    it 'returns an initialized backend' do
+      expect(described_class.find(:legacy)).to be_a(Money::LocaleBackend::Legacy)
+      expect(described_class.find(:i18n)).to be_a(Money::LocaleBackend::I18n)
+    end
+
+    it 'raises an error if a backend is unknown' do
+      expect { described_class.find(:foo) }.to raise_error(Money::LocaleBackend::Unknown)
+    end
+  end
+end

data/spec/money_spec.rb

@@ -1,6 +1,22 @@
 # encoding: utf-8
 
 describe Money do
+  describe '.locale_backend' do
+    after { Money.locale_backend = :legacy }
+
+    it 'sets the locale_backend' do
+      Money.locale_backend = :i18n
+
+      expect(Money.locale_backend).to be_a(Money::LocaleBackend::I18n)
+    end
+
+    it 'sets the locale_backend to nil' do
+      Money.locale_backend = nil
+
+      expect(Money.locale_backend).to eq(nil)
+    end
+  end
+
   describe ".new" do
     let(:initializing_value) { 1 }
     subject(:money) { Money.new(initializing_value) }
@@ -169,6 +185,16 @@ describe Money do
         Money.from_amount(1.999).to_d
       end).to eq 1.99
     end
+
+    context 'given a currency is provided' do
+      context 'and the currency is nil' do
+        let(:currency) { nil }
+
+        it "should have the default currency" do
+          expect(Money.from_amount(1, currency).currency).to eq Money.default_currency
+        end
+      end
+    end
   end
 
   %w[cents pence].each do |units|
@@ -191,7 +217,7 @@ describe Money do
     it "stores fractional as an integer regardless of what is passed into the constructor" do
       m = Money.new(100)
       expect(m.fractional).to eq 100
-      expect(m.fractional).to be_a(Fixnum)
+      expect(m.fractional).to be_a(Integer)
     end
 
     context "loading a serialized Money via YAML" do
@@ -349,9 +375,9 @@ YAML
       expect {money.round_to_nearest_cash_value}.to raise_error(Money::UndefinedSmallestDenomination)
     end
 
-    it "returns a Fixnum when infinite_precision is not set" do
+    it "returns a Integer when infinite_precision is not set" do
       money = Money.new(100, "USD")
-      expect(money.round_to_nearest_cash_value).to be_a Fixnum
+      expect(money.round_to_nearest_cash_value).to be_a Integer
     end
 
     it "returns a BigDecimal when infinite_precision is set", :infinite_precision do
@@ -408,12 +434,16 @@ YAML
   end
 
   describe "#currency_as_string=" do
-    it "sets the currency object using the provided string" do
+    it "sets the currency object using the provided string leaving cents intact" do
       money = Money.new(100_00, "USD")
+
       money.currency_as_string = "EUR"
       expect(money.currency).to eq Money::Currency.new("EUR")
+      expect(money.cents).to eq 100_00
+
       money.currency_as_string = "YEN"
       expect(money.currency).to eq Money::Currency.new("YEN")
+      expect(money.cents).to eq 100_00
     end
   end
 
@@ -468,6 +498,24 @@ YAML
       expect(Money.new(10_00, "BRL").to_s).to eq "10,00"
     end
 
+    context "using i18n" do
+      before { I18n.backend.store_translations(:en, number: { format: { separator: "." } }) }
+      after { reset_i18n }
+
+      it "respects decimal mark" do
+        expect(Money.new(10_00, "BRL").to_s).to eq "10.00"
+      end
+    end
+
+    context "with defaults set" do
+      before { Money.default_formatting_rules = { with_currency: true } }
+      after { Money.default_formatting_rules = nil }
+
+      it "ignores defaults" do
+        expect(Money.new(10_00, 'USD').to_s).to eq '10.00'
+      end
+    end
+
     context "with infinite_precision", :infinite_precision do
       it "shows fractional cents" do
         expect(Money.new(1.05, "USD").to_s).to eq "0.0105"
@@ -536,6 +584,25 @@ YAML
     end
   end
 
+  describe "#with_currency" do
+    it 'returns self if currency is the same' do
+      money = Money.new(10_00, 'USD')
+
+      expect(money.with_currency('USD')).to eq(money)
+      expect(money.with_currency('USD').object_id).to eq(money.object_id)
+    end
+
+    it 'returns a new instance in a given currency' do
+      money = Money.new(10_00, 'USD')
+      new_money = money.with_currency('EUR')
+
+      expect(new_money).to eq(Money.new(10_00, 'EUR'))
+      expect(money.fractional).to eq(new_money.fractional)
+      expect(money.bank).to eq(new_money.bank)
+      expect(money.object_id).not_to eq(new_money.object_id)
+    end
+  end
+
   describe "#exchange_to" do
     it "exchanges the amount via its exchange bank" do
       money = Money.new(100_00, "USD")
@@ -577,6 +644,18 @@ YAML
       expect(moneys[1]).to eq Money.us_dollar(3)
     end
 
+    it "handles small splits" do
+      moneys = Money.us_dollar(5).allocate([0.03, 0.07])
+      expect(moneys[0]).to eq Money.us_dollar(2)
+      expect(moneys[1]).to eq Money.us_dollar(3)
+    end
+
+    it "handles large splits" do
+      moneys = Money.us_dollar(5).allocate([3, 7])
+      expect(moneys[0]).to eq Money.us_dollar(2)
+      expect(moneys[1]).to eq Money.us_dollar(3)
+    end
+
     it "does not lose pennies" do
       moneys = Money.us_dollar(100).allocate([0.333, 0.333, 0.333])
       expect(moneys[0].cents).to eq 34
@@ -584,8 +663,37 @@ YAML
       expect(moneys[2].cents).to eq 33
     end
 
-    it "requires total to be less then 1" do
-      expect { Money.us_dollar(0.05).allocate([0.5, 0.6]) }.to raise_error(ArgumentError)
+    it "does not round rationals" do
+      splits = 7.times.map { Rational(950, 6650) }
+      moneys = Money.us_dollar(6650).allocate(splits)
+      moneys.each do |money|
+        expect(money.cents).to eq 950
+      end
+    end
+
+    it "handles mixed split types" do
+      splits = [Rational(1, 4), 0.25, 0.25, BigDecimal('0.25')]
+      moneys = Money.us_dollar(100).allocate(splits)
+      moneys.each do |money|
+        expect(money.cents).to eq 25
+      end
+    end
+
+    context "negative amount" do
+      it "does not lose pennies" do
+        moneys = Money.us_dollar(-100).allocate([0.333, 0.333, 0.333])
+
+        expect(moneys[0].cents).to eq(-34)
+        expect(moneys[1].cents).to eq(-33)
+        expect(moneys[2].cents).to eq(-33)
+      end
+
+      it "allocates the same way as positive amounts" do
+        ratios = [0.6667, 0.3333]
+
+        expect(Money.us_dollar(10_00).allocate(ratios).map(&:fractional)).to eq([6_67, 3_33])
+        expect(Money.us_dollar(-10_00).allocate(ratios).map(&:fractional)).to eq([-6_67, -3_33])
+      end
     end
 
     it "keeps subclasses intact" do
@@ -595,12 +703,8 @@ YAML
 
     context "with infinite_precision", :infinite_precision do
       it "allows for fractional cents allocation" do
-        one_third = BigDecimal("1") / BigDecimal("3")
-
-        moneys = Money.new(100).allocate([one_third, one_third, one_third])
-        expect(moneys[0].cents).to eq one_third * BigDecimal("100")
-        expect(moneys[1].cents).to eq one_third * BigDecimal("100")
-        expect(moneys[2].cents).to eq one_third * BigDecimal("100")
+        moneys = Money.new(100).allocate([1, 1, 1])
+        expect(moneys.inject(0, :+)).to eq(Money.new(100))
       end
     end
   end
@@ -637,27 +741,40 @@ YAML
 
     context "with infinite_precision", :infinite_precision do
       it "allows for splitting by fractional cents" do
-        thirty_three_and_one_third = BigDecimal("100") / BigDecimal("3")
-
         moneys = Money.new(100).split(3)
-        expect(moneys[0].cents).to eq thirty_three_and_one_third
-        expect(moneys[1].cents).to eq thirty_three_and_one_third
-        expect(moneys[2].cents).to eq thirty_three_and_one_third
+        expect(moneys.inject(0, :+)).to eq(Money.new(100))
       end
     end
   end
 
   describe "#round" do
-
     let(:money) { Money.new(15.75, 'NZD') }
     subject(:rounded) { money.round }
 
     context "without infinite_precision" do
-      it "returns self (as it is already rounded)" do
-        rounded = money.round
-        expect(rounded).to be money
+      it "returns a different money" do
+        expect(rounded).not_to be money
+      end
+
+      it "rounds the cents" do
         expect(rounded.cents).to eq 16
       end
+
+      it "maintains the currency" do
+        expect(rounded.currency).to eq Money::Currency.new('NZD')
+      end
+
+      it "uses a provided rounding strategy" do
+        rounded = money.round(BigDecimal::ROUND_DOWN)
+        expect(rounded.cents).to eq 15
+      end
+
+      it "does not accumulate rounding error" do
+        money_1 = Money.new(10.9).round(BigDecimal::ROUND_DOWN)
+        money_2 = Money.new(10.9).round(BigDecimal::ROUND_DOWN)
+
+        expect(money_1 + money_2).to eq(Money.new(20))
+      end
     end
 
     context "with infinite_precision", :infinite_precision do
@@ -678,15 +795,31 @@ YAML
         expect(rounded.cents).to eq 15
       end
 
-      context "when using a subclass of Money" do
-        let(:special_money_class) { Class.new(Money) }
-        let(:money) { special_money_class.new(15.75, 'NZD') }
+      context "when using a specific rounding precision" do
+        let(:money) { Money.new(15.7526, 'NZD') }
 
-        it "preserves the class in the result" do
-          expect(rounded).to be_a special_money_class
+        it "uses the provided rounding precision" do
+          rounded = money.round(BigDecimal::ROUND_DOWN, 3)
+          expect(rounded.fractional).to eq 15.752
         end
       end
     end
+
+    it 'preserves assigned bank' do
+      bank = Money::Bank::VariableExchange.new
+      rounded = Money.new(1_00, 'USD', bank).round
+
+      expect(rounded.bank).to eq(bank)
+    end
+
+    context "when using a subclass of Money" do
+      let(:special_money_class) { Class.new(Money) }
+      let(:money) { special_money_class.new(15.75, 'NZD') }
+
+      it "preserves the class in the result" do
+        expect(rounded).to be_a special_money_class
+      end
+    end
   end
 
   describe "#inspect" do

data/spec/rates_store/memory_spec.rb

@@ -15,7 +15,7 @@ describe Money::RatesStore::Memory do
     end
 
     context ':without_mutex' do
-      let(:subject) { Money::RatesStore::Memory.new(:without_mutex => true) }
+      let(:subject) { Money::RatesStore::Memory.new(without_mutex: true) }
 
       it "doesn't use mutex if requested not to" do
         expect(subject.instance_variable_get(:@mutex)).not_to receive(:synchronize)
@@ -58,7 +58,7 @@ describe Money::RatesStore::Memory do
     end
 
     context 'no mutex' do
-      let(:subject) { Money::RatesStore::Memory.new(:without_mutex => true) }
+      let(:subject) { Money::RatesStore::Memory.new(without_mutex: true) }
 
       it 'does not use mutex' do
         expect(subject.instance_variable_get('@mutex')).not_to receive(:synchronize)
@@ -66,4 +66,15 @@ describe Money::RatesStore::Memory do
       end
     end
   end
+
+  describe '#marshal_dump' do
+    let(:subject) { Money::RatesStore::Memory.new(optional: true) }
+
+    it 'can reload' do
+      bank = Money::Bank::VariableExchange.new(subject)
+      bank = Marshal.load(Marshal.dump(bank))
+      expect(bank.store.instance_variable_get(:@options)).to eq subject.instance_variable_get(:@options)
+      expect(bank.store.instance_variable_get(:@index)).to eq subject.instance_variable_get(:@index)
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -5,6 +5,8 @@ $LOAD_PATH.unshift File.dirname(__FILE__)
 require "rspec"
 require "money"
 
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
+
 I18n.enforce_available_locales = false
 
 RSpec.configure do |c|

data/spec/support/shared_examples/money_examples.rb

@@ -0,0 +1,14 @@
+RSpec.shared_examples 'instance with custom bank' do |operation, value|
+  let(:custom_bank) { Money::Bank::VariableExchange.new }
+  let(:instance) { Money.new(1, :usd, custom_bank) }
+
+  subject { value ? instance.send(operation, value) : instance.send(operation) }
+
+  it "returns custom bank from new instance" do
+    new_money_instances = Array(subject).select { |el| el.is_a?(Money) }
+
+    new_money_instances.each do |money_instance|
+      expect(money_instance.bank).to eq(custom_bank)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: money
 version: !ruby/object:Gem::Version
-  version: 6.7.1
+  version: 6.13.0
 platform: ruby
 authors:
 - Shane Emmons
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-08 00:00:00.000000000 Z
+date: 2018-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -19,7 +19,7 @@ dependencies:
         version: 0.6.4
     - - "<="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -28,26 +28,6 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.6.4
     - - "<="
-      - !ruby/object:Gem::Version
-        version: 0.7.0
-- !ruby/object:Gem::Dependency
-  name: sixarm_ruby_unaccent
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-    - - "<"
       - !ruby/object:Gem::Version
         version: '2'
 - !ruby/object:Gem::Dependency
@@ -84,28 +64,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: '3.4'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
@@ -148,10 +128,17 @@ files:
 - lib/money/currency.rb
 - lib/money/currency/heuristics.rb
 - lib/money/currency/loader.rb
+- lib/money/locale_backend/base.rb
+- lib/money/locale_backend/errors.rb
+- lib/money/locale_backend/i18n.rb
+- lib/money/locale_backend/legacy.rb
 - lib/money/money.rb
+- lib/money/money/allocation.rb
 - lib/money/money/arithmetic.rb
 - lib/money/money/constructors.rb
-- lib/money/money/formatting.rb
+- lib/money/money/formatter.rb
+- lib/money/money/formatting_rules.rb
+- lib/money/money/locale_backend.rb
 - lib/money/rates_store/memory.rb
 - lib/money/version.rb
 - money.gemspec
@@ -161,25 +148,25 @@ files:
 - spec/currency/heuristics_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
+- spec/locale_backend/i18n_spec.rb
+- spec/locale_backend/legacy_spec.rb
+- spec/money/allocation_spec.rb
 - spec/money/arithmetic_spec.rb
 - spec/money/constructors_spec.rb
 - spec/money/formatting_spec.rb
+- spec/money/locale_backend_spec.rb
 - spec/money_spec.rb
 - spec/rates_store/memory_spec.rb
 - spec/spec_helper.rb
-homepage: http://rubymoney.github.io/money
+- spec/support/shared_examples/money_examples.rb
+homepage: https://rubymoney.github.io/money
 licenses:
 - MIT
-metadata: {}
-post_install_message: |
-  Please note the following API changes in Money version 6
-
-   - Money#amount, Money#dollars methods now return instances of BigDecimal (rather than Float).
-
-  Please read the migration notes at https://github.com/RubyMoney/money#migration-notes
-  and choose the migration that best suits your application.
-
-  Test responsibly :-)
+metadata:
+  changelog_uri: https://github.com/RubyMoney/money/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/RubyMoney/money/
+  bug_tracker_uri: https://github.com/RubyMoney/money/issues
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -195,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: A Ruby Library for dealing with money and currency conversion.
@@ -206,9 +193,14 @@ test_files:
 - spec/currency/heuristics_spec.rb
 - spec/currency/loader_spec.rb
 - spec/currency_spec.rb
+- spec/locale_backend/i18n_spec.rb
+- spec/locale_backend/legacy_spec.rb
+- spec/money/allocation_spec.rb
 - spec/money/arithmetic_spec.rb
 - spec/money/constructors_spec.rb
 - spec/money/formatting_spec.rb
+- spec/money/locale_backend_spec.rb
 - spec/money_spec.rb
 - spec/rates_store/memory_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/money_examples.rb