money-open-exchange-rates 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a04f2f4222945d437a7c84bfed72c8fbc36188644d00da13528a677eda9515a
-  data.tar.gz: eb7c523fb8d74a9573ea65f8779fa5a41748b477dbc6f7ca9ceef5cde50de59a
+  metadata.gz: 3b5f63af5ef2482e223249c50e9972e84c4f9aaa3bcec4b3052089ee3b60a237
+  data.tar.gz: aa6a135ef6dea76c5ca26739dcdabfe5ba2eac6bf83eba3c8b060f54c5357dc6
 SHA512:
-  metadata.gz: 508710569f6c2ca135fc5f09047ab20137b5c6ed6e93496c4b02925bdcc85e6f6fbb0a31b7d959534e82649f1302e50a0f6a7e4c06106c8bfc41cc170ee9b1ae
-  data.tar.gz: f2dc857c17c69a5c4faec4bd432bdd3ff89091a24642715c56a0f1f99525118e3199653f1729d33227938ad6d3c943914405b893674be2258650cb65632371bb
+  metadata.gz: a78deced5445998e4fd6dd9cfa442753dca96bdbeabae0fbf0611e8c1274542030de8ed5be8f7b20a670693095370cb4a72e9a205ac556c1ce075f987ed128e5
+  data.tar.gz: b865cbfd1b40ab43f186aa99e1af7b01314eb90a46cecd586634b2b9e4a83614c99f555bf2aa3c7dd8419aa4faea85429026814f6c5299e657fba015c9d728a8

data/History.md

@@ -1,4 +1,10 @@
 
+2.0.1 / 2026-01-21
+==================
+
+  * Merge pull request #75 from @ps-97 / adarsh/preserve-rates-on-partial-api-response
+    * fix: preserve rates for currencies missing from API response
+
 2.0.0 / 2025-12-23
 ==================
 

data/lib/money/bank/open_exchange_rates_bank.rb

@@ -187,15 +187,14 @@ class Money
       # @return [Array] Array of exchange rates
       def update_rates
         store.transaction do
-          clear_rates!
-          exchange_rates.each do |exchange_rate|
-            rate = exchange_rate.last
-            currency = exchange_rate.first
+          new_rates = exchange_rates
+          new_rates.each do |currency, rate|
             next unless Money::Currency.find(currency)
 
             set_rate(source, currency, rate)
             set_rate(currency, source, 1.0 / rate)
           end
+          clear_cross_rates_for(new_rates)
         end
       end
 
@@ -438,6 +437,20 @@ class Money
           add_rate(iso_from, iso_to, nil)
         end
       end
+
+      # Clears cross-rates for currencies present in new_rates
+      # Cross-rates are calculated on next access via calc_pair_rate_using_base
+      # Direct rates (source -> X) are not cleared, just overwritten
+      #
+      # @param new_rates [Hash] Rates hash from API response
+      def clear_cross_rates_for(new_rates)
+        store.each_rate do |iso_from, iso_to|
+          next if iso_from == source || iso_to == source
+          next unless new_rates.key?(iso_from) || new_rates.key?(iso_to)
+
+          add_rate(iso_from, iso_to, nil)
+        end
+      end
     end
   end
 end

data/lib/open_exchange_rates_bank/version.rb

@@ -2,5 +2,5 @@
 
 # Module for version constant
 module OpenExchangeRatesBank
-  VERSION = '2.0.0'
+  VERSION = '2.0.1'
 end

data/test/data/partial_latest.json

@@ -0,0 +1,16 @@
+{
+  "disclaimer": "Exchange rates are provided for informational purposes only.",
+  "license": "Data sourced from various providers.",
+  "timestamp": 1414008100,
+  "base": "USD",
+  "rates": {
+    "AED": 3.67304,
+    "AUD": 1.139103,
+    "BBD": 2,
+    "CAD": 1.124161,
+    "CHF": 0.951922,
+    "GBP": 0.62292,
+    "JPY": 107.0718,
+    "USD": 1
+  }
+}

data/test/open_exchange_rates_bank_test.rb

@@ -533,5 +533,48 @@ describe Money::Bank::OpenExchangeRatesBank do
       end
     end
   end
+
+  describe 'missing currencies' do
+    let(:oer_partial_path) do
+      data_file('partial_latest.json')
+    end
+
+    before do
+      add_to_webmock(subject)
+      # see test/data/latest.json +52
+      @latest_usd_eur_rate = 0.79085
+      # see test/data/latest.json +33
+      @latest_usd_cad_rate = 1.124161
+      subject.update_rates
+    end
+
+    it 'should preserve direct rates' do
+      _(subject.get_rate('USD', 'EUR')).must_equal @latest_usd_eur_rate
+      subject.cache = nil
+      stub_request(:get, subject.source_url)
+        .to_return(status: 200, body: File.read(oer_partial_path))
+      subject.update_rates
+      _(subject.get_rate('USD', 'EUR')).must_equal @latest_usd_eur_rate
+    end
+
+    it 'should update rates for currencies in response' do
+      _(subject.get_rate('USD', 'CAD')).must_equal @latest_usd_cad_rate
+      subject.cache = nil
+      stub_request(:get, subject.source_url)
+        .to_return(status: 200, body: File.read(oer_partial_path))
+      subject.update_rates
+      _(subject.get_rate('USD', 'CAD')).must_equal @latest_usd_cad_rate
+    end
+
+    it 'should exchange with preserved rates' do
+      money = Money.new(100, 'USD')
+      _(subject.exchange_with(money, 'EUR')).must_equal Money.new(79, 'EUR')
+      subject.cache = nil
+      stub_request(:get, subject.source_url)
+        .to_return(status: 200, body: File.read(oer_partial_path))
+      subject.update_rates
+      _(subject.exchange_with(money, 'EUR')).must_equal Money.new(79, 'EUR')
+    end
+  end
 end
 # rubocop:enable Metrics/BlockLength

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money-open-exchange-rates
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Laurent Arnoud
@@ -153,6 +153,7 @@ files:
 - test/data/access_restricted_error.json
 - test/data/app_id_inactive.json
 - test/data/latest.json
+- test/data/partial_latest.json
 - test/integration/Gemfile
 - test/integration/Gemfile.lock
 - test/integration/api.rb