money-open-exchange-rates 1.1.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ca083dbf9fddf98dd83014ecfdd3ab592d30edcfe96b9a6b6086b66f5e99eadd
-  data.tar.gz: 3c3e381dea270d1c19843833d2c426ced7e8986678adb3ea1e3b2efcc521751d
+  metadata.gz: 213847dd55f3bbc717a20dc056e61510f4b00ede31bce5b1c7022b16eedc875e
+  data.tar.gz: e245e87886f4c2fc2d8ae6fcf25c80d5f7797ffc3d877eaafab18abd2f911050
 SHA512:
-  metadata.gz: 4737d36a2bc739e9594ab3a1ecf744c242aa694c3c44f216c17969cfa188f9e635621c28dea9ba12abcf1a8e1eb6af4ffb59f3a828d10beeac678da70a003c68
-  data.tar.gz: 80aa7a95bf5b2d01562726b0cbbe95b7dbae45103632cf722469a03b521d75c284112970f8bd5603de5be7895bea890d605c061559ab94db0aa5ea85200896e2
+  metadata.gz: 7a63501cb0baad531f152bedc2a232697f9c64da9bfeef9dd576ecbcda9dceaed83aba902f272c5cd4d44af20e9a55bd7654e1c244a60a5620b9db6f033c6f4b
+  data.tar.gz: 0c5466657cac8fb4e826d7d9e24ac354778eca529ac156385d3dc44070ed78d3e9278ffc2e17ccad705311195fdaa2822d17855cbcd2e721d90cab37ebe1c0c2

data/Gemfile

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'simplecov', require: false

data/History.md

@@ -1,4 +1,71 @@
 
+1.4.0 / 2020-09-11
+==================
+
+  * Fix jruby test for cross courses
+  * Fix deprecation global use of must_equal
+  * Merge pull request #66 from @korun / clear-cross-courses
+    * Update rates inside transaction, to prevent RC issues
+  * Merge pull request #65 from @korun / ensure-file-closed
+    * Fix unclosed file descriptor after read_from_cache
+  * Merge pull request #64 from @anton-smagin / clear-cross-courses
+    * Set old rates to nil on #update_rates before set new one to expire pair rates using base
+  * Add coverage stage on ci
+  * Remove Ruby 2.3 support
+  * Switch to gitlab ci
+  * Update README
+  * Fix rubocop to 0.76.0 and remove minitest-focus
+  * Update gitlab ci gem install does not have --no-ri anymore
+  * README add more doc about update_rates
+  * Fix deprecation for minitest 6
+  * Fix flaky test about Money::Bank::NoAppId
+  * Support Pathname for cache
+  * Update rubocop to 0.76
+  * Remove Ruby 2.2 support and update rubocop
+  * Update travis list
+  * README: improve refresh doc
+
+1.3.0 / 2019-01-20
+==================
+
+  * Update webmock to 3.5
+  * Update rubocop to 0.63
+  * Switch from rr to mocha/minitest
+  * Add prettyprint option
+  * README: add info about tests
+  * Remove deprecated secure_connection= option
+  * Merge pull request #54 from @LinkUpStudioUA / symbols-doc-link-fix
+    * Fix link to filtering by symbols doc
+  * Fix bundler to <2 on travis (dropped support Ruby < 2.3)
+  * Fix bundler to 1.17.3 (2.0 dropped support Ruby < 2.3)
+  * Merge pull request #52 from @thejchap / feature/symbols
+    * add support for symbols query param
+  * Remove ruby 2.0/2.1 support and fix rubocop offenses
+  * Add minitest-focus gem
+  * Avoid redefine json_response method
+
+v1.2.2 / 2018-03-31
+===================
+
+  * Warn secure_connection= is deprecated
+  * More simple code on calc_pair_rate_using_base
+  * Increase code coverage on source_url
+  * Fix parse error specs on refresh_rates
+  * Use Coveralls for coverage
+  * Add tests for rates_timestamp issue
+
+v1.2.1 / 2018-03-31
+===================
+
+  * Fix rates_timestamp should be now per default
+
+v1.2.0 / 2018-03-31
+===================
+
+  * Merge pull request #51 from spk/fix-expire_rates
+    * Add force_refresh_rate_on_expire option and use api timestamp
+  * README: info currency-exchange
+
 v1.1.1 / 2018-03-30
 ===================
 

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright (c) 2011-2018 Laurent Arnoud <laurent@spkdev.net>
+Copyright (c) 2011-2020 Laurent Arnoud <laurent@spkdev.net>
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,7 +1,9 @@
 # Money Open Exchange Rates
 
 A gem that calculates the exchange rate using published rates from
-[open-exchange-rates](https://openexchangerates.org/)
+[open-exchange-rates](https://openexchangerates.org/). Compatible with
+[Money](https://github.com/RubyMoney/money#currency-exchange) [currency
+exchange](http://www.rubydoc.info/gems/money/Money/Bank/VariableExchange).
 
 Check [api documentation](https://docs.openexchangerates.org/)
 
@@ -22,69 +24,125 @@ Check [api documentation](https://docs.openexchangerates.org/)
 
 Add this line to your application's Gemfile:
 
-~~~ ruby
+``` ruby
 gem 'money-open-exchange-rates'
-~~~
+```
 
 And then execute:
 
-~~~
+```
 bundle
-~~~
+```
 
 Or install it yourself as:
 
-~~~
+```
 gem install money-open-exchange-rates
-~~~
+```
 
 ## Usage
 
-~~~ ruby
+``` ruby
 require 'money/bank/open_exchange_rates_bank'
-oxr = Money::Bank::OpenExchangeRatesBank.new
-# see https://github.com/spk/money-open-exchange-rates#cache for more info
-oxr.cache = 'path/to/file/cache.json'
+
+# Memory store per default; for others just pass as argument a class like
+# explained in https://github.com/RubyMoney/money#exchange-rate-stores
+oxr = Money::Bank::OpenExchangeRatesBank.new(Money::RatesStore::Memory.new)
 oxr.app_id = 'your app id from https://openexchangerates.org/signup'
+
+# Update the rates for the current rates storage
+# If the storage is memory you will have to restart the server to be taken into
+# account.
+# If the storage is a database, file, this can be added to
+# crontab/worker/scheduler `Money.default_bank.update_rates`
 oxr.update_rates
 
 # (optional)
-# set the seconds after than the current rates are automatically expired
+# See https://github.com/spk/money-open-exchange-rates#cache for more info
+# Updated only when `refresh_rates` is called
+oxr.cache = 'path/to/file/cache.json'
+
+# (optional)
+# Set the seconds after than the current rates are automatically expired
 # by default, they never expire, in this example 1 day.
+# This ttl is about money store (memory, database ...) passed though
+# `Money::Bank::OpenExchangeRatesBank` as argument not about `cache` option.
+# The base time is the timestamp fetched from API.
 oxr.ttl_in_seconds = 86400
+
 # (optional)
-# set historical date of the rate
+# Set historical date of the rate
 # see https://openexchangerates.org/documentation#historical-data
 oxr.date = '2015-01-01'
+
 # (optional)
 # Set the base currency for all rates. By default, USD is used.
 # OpenExchangeRates only allows USD as base currency
 # for the free plan users.
 oxr.source = 'USD'
+
 # (optional)
 # Extend returned values with alternative, black market and digital currency
 # rates. By default, false is used
 # see: https://docs.openexchangerates.org/docs/alternative-currencies
 oxr.show_alternative = true
+
 # (optional)
-# Store in cache
-# Force rates storage in cache, this is done automaticly after TTL is expire.
+# Minified Response ('prettyprint')
+# see https://docs.openexchangerates.org/docs/prettyprint
+oxr.prettyprint = false
+
+# (optional)
+# Refresh rates, store in cache and update rates
+# Should be used on crontab/worker/scheduler `Money.default_bank.refresh_rates`
 # If you are using unicorn-worker-killer gem or on Heroku like platform,
 # you should avoid to put this on the initializer of your Rails application,
 # because will increase your OXR API usage.
-oxr.save_rates
+oxr.refresh_rates
+
+# (optional)
+# Force refresh rates cache and store on the fly when ttl is expired
+# This will slow down request on get_rate, so use at your on risk, if you don't
+# want to setup crontab/worker/scheduler for your application.
+# Again this is not safe with multiple servers and could increase API usage.
+oxr.force_refresh_rate_on_expire = true
 
 Money.default_bank = oxr
 
 Money.default_bank.get_rate('USD', 'CAD')
-~~~
+```
+
+## Refresh rates
+
+### With [whenever](https://github.com/javan/whenever)
+
+``` ruby
+every :hour do
+  runner "Money.default_bank.refresh_rates"
+  # you will have to restart the server if you are using memory rate store
+  runner "Money.default_bank.update_rates"
+end
+```
+
+### With rake task
+
+``` ruby
+namespace :open_exchange_rates do
+  desc "Refresh rates from cache and update rates"
+  task :refresh_rates => :environment do
+    Money.default_bank.refresh_rates
+    # you will have to restart the server if you are using memory rate store
+    Money.default_bank.update_rates
+  end
+end
+```
 
 ## Cache
 
 You can also provide a `Proc` as a cache to provide your own caching mechanism
 perhaps with Redis or just a thread safe `Hash` (global). For example:
 
-~~~ ruby
+``` ruby
 oxr.cache = Proc.new do |v|
   key = 'money:exchange_rates'
   if v
@@ -93,12 +151,12 @@ oxr.cache = Proc.new do |v|
     Thread.current[key]
   end
 end
-~~~
+```
 
 With `Rails` cache example:
 
-~~~ ruby
-OXR_CACHE_KEY = 'money:exchange_rates'.freeze
+``` ruby
+OXR_CACHE_KEY = "#{Rails.env}:money:exchange_rates".freeze
 oxr.ttl_in_seconds = 86400
 oxr.cache = Proc.new do |text|
   if text
@@ -107,28 +165,63 @@ oxr.cache = Proc.new do |text|
     Rails.cache.read(OXR_CACHE_KEY)
   end
 end
-~~~
+```
+
+To update the cache call `Money.default_bank.refresh_rates` on
+crontab/worker/scheduler. This have to be done this way because the fetch can
+take some time (HTTP call) and can fail.
 
 ## Full example configuration initializer with Rails and cache
 
-~~~ ruby
+``` ruby
 require 'money/bank/open_exchange_rates_bank'
 
-OXR_CACHE_KEY = 'money:exchange_rates'.freeze
-oxr = Money::Bank::OpenExchangeRatesBank.new
+OXR_CACHE_KEY = "#{Rails.env}:money:exchange_rates".freeze
+# ExchangeRate is an ActiveRecord model
+# more info at https://github.com/RubyMoney/money#exchange-rate-stores
+oxr = Money::Bank::OpenExchangeRatesBank.new(ExchangeRate)
 oxr.ttl_in_seconds = 86400
 oxr.cache = Proc.new do |text|
   if text
+    # only expire when refresh_rates is called or `force_refresh_rate_on_expire`
+    # option is enabled
+    # you can also set `expires_in` option on write to force fetch new rates
     Rails.cache.write(OXR_CACHE_KEY, text)
   else
     Rails.cache.read(OXR_CACHE_KEY)
   end
 end
 oxr.app_id = ENV['OXR_API_KEY']
+oxr.show_alternative = true
+oxr.prettyprint = false
+
+# This can be removed if you have data to avoid http call on boot for production
 oxr.update_rates
 
 Money.default_bank = oxr
-~~~
+```
+
+See also how to [refresh and update rates](#refresh-rates)
+
+### Tests
+
+To avoid to hit the API we can use the cache option with a saved file like this:
+
+``` ruby
+OXR_CACHE_KEY = "#{Rails.env}:money:exchange_rates".freeze
+if Rails.env.test?
+  oxr.cache = Rails.root.join("test/fixtures/currency-rates.json").to_s
+else
+  oxr.ttl_in_seconds = 5.minutes.to_i
+  oxr.cache = Proc.new do |text|
+    if text
+      Rails.cache.write(OXR_CACHE_KEY, text)
+    else
+      Rails.cache.read(OXR_CACHE_KEY)
+    end
+  end
+end
+```
 
 ## Pair rates
 
@@ -137,9 +230,9 @@ or using base currency rate to both currencies forming the pair.
 
 ## Tests
 
-~~~
+```
 bundle exec rake
-~~~
+```
 
 ## Refs
 
@@ -156,12 +249,12 @@ See [GitHub](https://github.com/spk/money-open-exchange-rates/graphs/contributor
 
 The MIT License
 
-Copyright © 2011-2018 Laurent Arnoud <laurent@spkdev.net>
+Copyright © 2011-2020 Laurent Arnoud <laurent@spkdev.net>
 
 ---
-[![Build](https://img.shields.io/travis-ci/spk/money-open-exchange-rates.svg)](https://travis-ci.org/spk/money-open-exchange-rates)
+[![Build](https://img.shields.io/gitlab/pipeline/spkdev/money-open-exchange-rates/master)](https://gitlab.com/spkdev/money-open-exchange-rates/-/commits/master)
+[![Coverage](https://gitlab.com/spkdev/money-open-exchange-rates/badges/master/coverage.svg)](https://gitlab.com/spkdev/money-open-exchange-rates/-/commits/master)
 [![Version](https://img.shields.io/gem/v/money-open-exchange-rates.svg)](https://rubygems.org/gems/money-open-exchange-rates)
 [![Documentation](https://img.shields.io/badge/doc-rubydoc-blue.svg)](http://www.rubydoc.info/gems/money-open-exchange-rates)
 [![License](https://img.shields.io/badge/license-MIT-blue.svg)](http://opensource.org/licenses/MIT "MIT")
-[![Code Climate](https://img.shields.io/codeclimate/github/spk/money-open-exchange-rates.svg)](https://codeclimate.com/github/spk/money-open-exchange-rates)
 [![Inline docs](https://inch-ci.org/github/spk/money-open-exchange-rates.svg?branch=master)](http://inch-ci.org/github/spk/money-open-exchange-rates)

data/lib/money/bank/open_exchange_rates_bank.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
+require 'net/http'
 require 'uri'
-require 'open-uri'
 require 'money'
 require 'json'
-require File.expand_path('../../../open_exchange_rates_bank/version', __FILE__)
+require File.expand_path('../../open_exchange_rates_bank/version', __dir__)
 
 # Money gem class
-# rubocop:disable ClassLength
+# rubocop:disable Metrics/ClassLength
 class Money
   # https://github.com/RubyMoney/money#exchange-rate-stores
   module Bank
@@ -20,19 +20,16 @@ class Money
     # OpenExchangeRatesBank base class
     class OpenExchangeRatesBank < Money::Bank::VariableExchange
       VERSION = ::OpenExchangeRatesBank::VERSION
-      BASE_URL = 'https://openexchangerates.org/api/'.freeze
+      BASE_URL = 'https://openexchangerates.org/api/'
 
       # OpenExchangeRates urls
       OER_URL = URI.join(BASE_URL, 'latest.json')
       OER_HISTORICAL_URL = URI.join(BASE_URL, 'historical/')
 
       # Default base currency "base": "USD"
-      OE_SOURCE = 'USD'.freeze
-
-      # @deprecated secure_connection is deprecated and has no effect
-      def secure_connection=(*)
-        'secure_connection is deprecated and has no effect'
-      end
+      OE_SOURCE = 'USD'
+      RATES_KEY = 'rates'
+      TIMESTAMP_KEY = 'timestamp'
 
       # As of the end of August 2012 all requests to the Open Exchange Rates
       # API must have a valid app_id
@@ -64,6 +61,13 @@ class Money
       # @return [String] The requested date in YYYY-MM-DD format
       attr_accessor :date
 
+      # Force refresh rates cache and store on the fly when ttl is expired
+      # This will slow down request on get_rate, so use at your on risk, if you
+      # don't want to setup crontab/worker/scheduler for your application
+      #
+      # @param [Boolean]
+      attr_accessor :force_refresh_rate_on_expire
+
       # Rates expiration Time
       #
       # @return [Time] expiration time
@@ -93,6 +97,38 @@ class Money
       # @return [Boolean] Setted show alternative
       attr_writer :show_alternative
 
+      # Filter response to a list of symbols
+      # see https://docs.openexchangerates.org/docs/get-specific-currencies
+      # @example
+      #   oxr.symbols = [:usd, :cad]
+      #
+      # @param [Array] list of symbols
+      # @return [Array] Setted list of symbols
+      attr_writer :symbols
+
+      # Minified Response ('prettyprint')
+      # see https://docs.openexchangerates.org/docs/prettyprint
+      # @example
+      #   oxr.prettyprint = false
+      #
+      # @param [Boolean] Set to false to receive minified (default: true)
+      # @return [Boolean]
+      attr_writer :prettyprint
+
+      # Set current rates timestamp
+      #
+      # @return [Time]
+      def rates_timestamp=(at)
+        @rates_timestamp = Time.at(at)
+      end
+
+      # Current rates timestamp
+      #
+      # @return [Time]
+      def rates_timestamp
+        @rates_timestamp || Time.now
+      end
+
       # Set the seconds after than the current rates are automatically expired
       # by default, they never expire.
       #
@@ -105,7 +141,7 @@ class Money
       def ttl_in_seconds=(value)
         @ttl_in_seconds = value
         refresh_rates_expiration if ttl_in_seconds
-        @ttl_in_seconds
+        ttl_in_seconds
       end
 
       # Set the base currency for all rates. By default, USD is used.
@@ -119,9 +155,12 @@ class Money
       #
       # @return [String] chosen base currency
       def source=(value)
-        @source = Money::Currency.find(value.to_s).iso_code
-      rescue
-        @source = OE_SOURCE
+        scurrency = Money::Currency.find(value.to_s)
+        @source = if scurrency
+                    scurrency.iso_code
+                  else
+                    OE_SOURCE
+                  end
       end
 
       # Get the base currency for all rates. By default, USD is used.
@@ -135,26 +174,19 @@ class Money
       #
       # @return [Array] Array of exchange rates
       def update_rates
-        exchange_rates.each do |exchange_rate|
-          rate = exchange_rate.last
-          currency = exchange_rate.first
-          next unless Money::Currency.find(currency)
-          set_rate(source, currency, rate)
-          set_rate(currency, source, 1.0 / rate)
+        store.transaction do
+          clear_rates!
+          exchange_rates.each do |exchange_rate|
+            rate = exchange_rate.last
+            currency = exchange_rate.first
+            next unless Money::Currency.find(currency)
+
+            set_rate(source, currency, rate)
+            set_rate(currency, source, 1.0 / rate)
+          end
         end
       end
 
-      # Save rates on cache
-      # Can raise InvalidCache
-      #
-      # @return [Proc,File]
-      def save_rates
-        return nil unless cache
-        store_in_cache(@json_response) if valid_rates?(@json_response)
-      rescue Errno::ENOENT
-        raise InvalidCache
-      end
-
       # Alias super method
       alias super_get_rate get_rate
 
@@ -171,13 +203,24 @@ class Money
         rate || calc_pair_rate_using_base(from_currency, to_currency, opts)
       end
 
+      # Fetch from url and save cache
+      #
+      # @return [Array] Array of exchange rates
+      def refresh_rates
+        read_from_url
+      end
+
+      # Alias refresh_rates method
+      alias save_rates refresh_rates
+
       # Expire rates when expired
       #
       # @return [NilClass, Time] nil if not expired or new expiration time
       def expire_rates
         return unless ttl_in_seconds
         return if rates_expiration > Time.now
-        read_from_url
+
+        refresh_rates if force_refresh_rate_on_expire
         update_rates
         refresh_rates_expiration
       end
@@ -189,22 +232,48 @@ class Money
         @show_alternative ||= false
       end
 
+      # Get prettyprint option
+      #
+      # @return [Boolean]
+      def prettyprint
+        return true unless defined? @prettyprint
+        return true if @prettyprint.nil?
+
+        @prettyprint
+      end
+
+      # Get symbols
+      #
+      # @return [Array] list of symbols to filter by
+      def symbols
+        @symbols ||= nil
+      end
+
       # Source url of openexchangerates
       # defined with app_id
       #
       # @return [String] URL
       def source_url
-        if source == OE_SOURCE
-          "#{oer_url}?app_id=#{app_id}" \
-          "&show_alternative=#{show_alternative}"
-        else
-          "#{oer_url}?app_id=#{app_id}&base=#{source}" \
-          "&show_alternative=#{show_alternative}"
-        end
+        str = "#{oer_url}?app_id=#{app_id}"
+        str = "#{str}&base=#{source}" unless source == OE_SOURCE
+        str = "#{str}&show_alternative=#{show_alternative}"
+        str = "#{str}&prettyprint=#{prettyprint}"
+        str = "#{str}&symbols=#{symbols.join(',')}" if symbols&.is_a?(Array)
+        str
       end
 
       protected
 
+      # Save rates on cache
+      # Can raise InvalidCache
+      #
+      # @return [Proc,File]
+      def save_cache
+        store_in_cache(@json_response) if valid_rates?(@json_response)
+      rescue Errno::ENOENT
+        raise InvalidCache
+      end
+
       # Latest url if no date given
       #
       # @return [String] URL
@@ -232,6 +301,7 @@ class Money
 
       # Store the provided text data by calling the proc method provided
       # for the cache, or write to the cache file.
+      # Can raise InvalidCache
       #
       # @example
       #   oxr.store_in_cache("{\"rates\": {\"AED\": 3.67304}}")
@@ -241,10 +311,12 @@ class Money
       def store_in_cache(text)
         if cache.is_a?(Proc)
           cache.call(text)
-        elsif cache.is_a?(String)
-          open(cache, 'w') do |f|
+        elsif cache.is_a?(String) || cache.is_a?(Pathname)
+          File.open(cache.to_s, 'w') do |f|
             f.write(text)
           end
+        else
+          raise InvalidCache
         end
       end
 
@@ -254,19 +326,27 @@ class Money
       def read_from_cache
         result = if cache.is_a?(Proc)
                    cache.call(nil)
-                 elsif cache.is_a?(String) && File.exist?(cache)
-                   open(cache).read
+                 elsif File.exist?(cache.to_s)
+                   File.read(cache)
                  end
         result if valid_rates?(result)
       end
 
+      # Read API
+      #
+      # @return [String]
+      def api_response
+        Net::HTTP.get(URI(source_url))
+      end
+
       # Read from url
       #
       # @return [String] JSON content
       def read_from_url
         raise NoAppId if app_id.nil? || app_id.empty?
-        @json_response = open(source_url).read
-        save_rates
+
+        @json_response = api_response
+        save_cache if cache
         @json_response
       end
 
@@ -279,8 +359,9 @@ class Money
       # @return [Boolean] valid or not
       def valid_rates?(text)
         return false unless text
+
         parsed = JSON.parse(text)
-        parsed && parsed.key?('rates')
+        parsed&.key?(RATES_KEY) && parsed&.key?(TIMESTAMP_KEY)
       rescue JSON::ParserError
         false
       end
@@ -290,14 +371,15 @@ class Money
       # @return [Hash] key is country code (ISO 3166-1 alpha-3) value Float
       def exchange_rates
         doc = JSON.parse(read_from_cache || read_from_url)
-        @oer_rates = doc['rates']
+        self.rates_timestamp = doc[TIMESTAMP_KEY]
+        @oer_rates = doc[RATES_KEY]
       end
 
       # Refresh expiration from now
       #
       # @return [Time] new expiration time
       def refresh_rates_expiration
-        @rates_expiration = Time.now + ttl_in_seconds
+        @rates_expiration = rates_timestamp + ttl_in_seconds
       end
 
       # Get rate or calculate it as inverse rate
@@ -328,13 +410,23 @@ class Money
       def calc_pair_rate_using_base(from_currency, to_currency, opts)
         from_base_rate = get_rate_or_calc_inverse(source, from_currency, opts)
         to_base_rate   = get_rate_or_calc_inverse(source, to_currency, opts)
-        if to_base_rate && from_base_rate
-          rate = BigDecimal(to_base_rate.to_s) / from_base_rate
-          add_rate(from_currency, to_currency, rate)
-          return rate
+        return unless to_base_rate
+        return unless from_base_rate
+
+        rate = BigDecimal(to_base_rate.to_s) / from_base_rate
+        add_rate(from_currency, to_currency, rate)
+        rate
+      end
+
+      # Clears cached rates in store
+      #
+      # @return [Hash] All rates from store as Hash
+      def clear_rates!
+        store.each_rate do |iso_from, iso_to|
+          add_rate(iso_from, iso_to, nil)
         end
-        nil
       end
     end
   end
 end
+# rubocop:enable Metrics/ClassLength