money-open-exchange-rates 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1cbadeb275d02260424c03168a97965ac705de08b518e2310a58b7dd649a8b53
-  data.tar.gz: 85467d626de3da3637f10a2e9113899ea3ca40df60c845f3fef2b251c618810b
+  metadata.gz: 9409fd168f31d0335f71e0713e1a014ff3d23ae9abe908d6a78b1d13d05b579f
+  data.tar.gz: e49b7cecf6992a5a5a08d4998ce5f060dd7dd0d286bbca34dbade198669f12ce
 SHA512:
-  metadata.gz: 2082ea6e2ec8df6b788bda461537b1dd70896d1f849b3b4e644b9fd30a2ee3c5fa1c8168999e4555dabd9b2cf4d2a2b1c714b6c0ec61ee730236c7cd6f7426e9
-  data.tar.gz: 5128bf8ee272026571487a92828550b7e3de82f9d7bd409d014048f1cb2413a26b21fd4261e07df9bfa3105cc0ef1700686427adcfae7adfa37125199a2b056f
+  metadata.gz: 5450e1dcb1f9e856d21efa06f02200bbf606b0299727a3c844f44e0709ae5efae2172128420eaaf8dec956793e589bdfb34a7103ba78708a25c24c2c112888c8
+  data.tar.gz: 5728bf847be03d84e0c2191cf4f9da05ba2c6b2219aacb11a55f957f14dd207b751258e99518c7a164b8ae91f10f951d9f2566807de4b2e61c8874cd0d03aea2

data/History.md

@@ -1,4 +1,9 @@
 
+v1.0.1 / 2018-03-25
+===================
+
+  * Use BigDecimal instead of Float
+
 v1.0.0 / 2018-03-25
 ===================
 

data/README.md

@@ -96,7 +96,7 @@ With `Rails` cache example:
 
 ~~~ ruby
 OXR_CACHE_KEY = 'money:exchange_rates'.freeze
-OXR_CACHE_TTL = 10
+OXR_CACHE_TTL = 86400
 # using same ttl with refreshing current rates and cache
 oxr.ttl_in_seconds = OXR_CACHE_TTL
 oxr.cache = Proc.new do |text|
@@ -113,11 +113,11 @@ or using base currency rate to both currencies forming the pair.
 
 ## Full example configuration initializer with Rails and cache
 
-~~~
+~~~ ruby
 require 'money/bank/open_exchange_rates_bank'
 
 OXR_CACHE_KEY = 'money:exchange_rates'.freeze
-OXR_CACHE_TTL = 10
+OXR_CACHE_TTL = 86400
 oxr = Money::Bank::OpenExchangeRatesBank.new
 oxr.ttl_in_seconds = OXR_CACHE_TTL
 oxr.cache = Proc.new do |text|

data/lib/money/bank/open_exchange_rates_bank.rb

@@ -326,7 +326,7 @@ class Money
         from_base_rate = get_rate_or_calc_inverse(source, from_currency, opts)
         to_base_rate   = get_rate_or_calc_inverse(source, to_currency, opts)
         if to_base_rate && from_base_rate
-          rate = to_base_rate.to_f / from_base_rate
+          rate = BigDecimal(to_base_rate) / from_base_rate
           add_rate(from_currency, to_currency, rate)
           return rate
         end

data/lib/open_exchange_rates_bank/version.rb

@@ -2,5 +2,5 @@
 
 # Module for version constant
 module OpenExchangeRatesBank
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.0.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money-open-exchange-rates
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Laurent Arnoud
@@ -142,7 +142,6 @@ files:
 - test/integration/Gemfile.lock
 - test/integration/api.rb
 - test/open_exchange_rates_bank_test.rb
-- test/open_exchange_rates_bank_test.rb.orig
 - test/test_helper.rb
 homepage: http://github.com/spk/money-open-exchange-rates
 licenses:

data/test/open_exchange_rates_bank_test.rb.orig

@@ -1,393 +0,0 @@
-require File.expand_path(File.join(File.dirname(__FILE__), 'test_helper'))
-
-# rubocop:disable Metrics/BlockLength
-describe Money::Bank::OpenExchangeRatesBank do
-  subject { Money::Bank::OpenExchangeRatesBank.new }
-  let(:oer_url) { Money::Bank::OpenExchangeRatesBank::OER_URL }
-  let(:oer_historical_url) do
-    Money::Bank::OpenExchangeRatesBank::OER_HISTORICAL_URL
-  end
-
-  let(:temp_cache_path) do
-    data_file('tmp.json')
-  end
-  let(:oer_latest_path) do
-    data_file('latest.json')
-  end
-  let(:oer_historical_path) do
-    data_file('2015-01-01.json')
-  end
-
-  describe 'exchange' do
-    before do
-      add_to_webmock(subject)
-      subject.cache = temp_cache_path
-      subject.save_rates
-    end
-
-    after do
-      File.unlink(temp_cache_path)
-    end
-
-    describe 'without rates' do
-      it 'able to exchange a money to its own currency even without rates' do
-        money = Money.new(0, 'USD')
-        subject.exchange_with(money, 'USD').must_equal money
-      end
-
-      it "raise if it can't find an exchange rate" do
-        money = Money.new(0, 'USD')
-        proc { subject.exchange_with(money, 'SSP') }
-          .must_raise Money::Bank::UnknownRate
-      end
-    end
-
-    describe 'with rates' do
-      before do
-        subject.update_rates
-      end
-
-      it 'should be able to exchange money from USD to a known exchange rate' do
-        money = Money.new(100, 'USD')
-        subject.exchange_with(money, 'BBD').must_equal Money.new(200, 'BBD')
-      end
-
-      it 'should be able to exchange money from a known exchange rate to USD' do
-        money = Money.new(200, 'BBD')
-        subject.exchange_with(money, 'USD').must_equal Money.new(100, 'USD')
-      end
-
-      it 'should be able to exchange money when direct rate is unknown' do
-        money = Money.new(100, 'BBD')
-        subject.exchange_with(money, 'BMD').must_equal Money.new(50, 'BMD')
-      end
-
-      it "should raise if it can't find an exchange rate" do
-        money = Money.new(0, 'USD')
-        proc { subject.exchange_with(money, 'SSP') }
-          .must_raise Money::Bank::UnknownRate
-      end
-    end
-  end
-
-  describe 'update_rates' do
-    before do
-      subject.app_id = TEST_APP_ID
-      subject.cache = oer_latest_path
-      subject.update_rates
-    end
-
-    it 'should update itself with exchange rates from OpenExchangeRates' do
-      subject.oer_rates.keys.each do |currency|
-        next unless Money::Currency.find(currency)
-        subject.get_rate('USD', currency).must_be :>, 0
-      end
-    end
-
-    it 'should not return 0 with integer rate' do
-      wtf = {
-        priority: 1,
-        iso_code: 'WTF',
-        name: 'WTF',
-        symbol: 'WTF',
-        subunit: 'Cent',
-        subunit_to_unit: 1000,
-        separator: '.',
-        delimiter: ','
-      }
-      Money::Currency.register(wtf)
-      subject.add_rate('USD', 'WTF', 2)
-      subject.add_rate('WTF', 'USD', 2)
-      subject.exchange_with(5000.to_money('WTF'), 'USD').cents.wont_equal 0
-    end
-
-    # in response to #4
-    it 'should exchange btc' do
-      btc = {
-        priority: 1,
-        iso_code: 'BTC',
-        name: 'Bitcoin',
-        symbol: 'BTC',
-        subunit: 'Cent',
-        subunit_to_unit: 1000,
-        separator: '.',
-        delimiter: ','
-      }
-      Money::Currency.register(btc)
-      rate = 13.7603
-      subject.add_rate('USD', 'BTC', 1 / 13.7603)
-      subject.add_rate('BTC', 'USD', rate)
-      subject.exchange_with(100.to_money('BTC'), 'USD').cents.must_equal 137_603
-    end
-  end
-
-  describe 'App ID' do
-    before do
-      subject.cache = temp_cache_path
-    end
-
-    it 'should raise an error if no App ID is set' do
-      proc { subject.save_rates }.must_raise Money::Bank::NoAppId
-    end
-
-    # TODO: As App IDs are compulsory soon, need to add more tests handle
-    # app_id-specific errors from
-    # https://openexchangerates.org/documentation#errors
-  end
-
-  describe 'no cache' do
-    before do
-      subject.cache = nil
-      add_to_webmock(subject)
-    end
-
-    it 'should get from url' do
-      subject.update_rates
-      subject.oer_rates.wont_be_empty
-    end
-
-    it 'should raise an error if invalid path is given to save_rates' do
-      proc { subject.save_rates }.must_raise Money::Bank::InvalidCache
-    end
-  end
-
-  describe 'secure_connection' do
-    before do
-      subject.app_id = TEST_APP_ID
-    end
-
-    describe 'historical' do
-      before do
-        subject.date = '2015-01-01'
-      end
-
-<<<<<<< HEAD
-      let(:historical_url) do
-        "#{oer_historical_url}#{subject.date}.json?app_id=#{TEST_APP_ID}&show_alternative=false"
-      end
-
-      it 'should use the secure https url' do
-=======
-      def historical_url
-        "#{oer_historical_url}#{subject.date}.json?" \
-        "app_id=#{TEST_APP_ID}&show_alternative=false"
-      end
-
-      def historical_secure_url
-        "#{oer_historical_secure_url}#{subject.date}.json?" \
-        "app_id=#{TEST_APP_ID}&show_alternative=false"
-      end
-
-      it 'should use the non-secure http url if secure_connection is nil' do
-        subject.secure_connection = nil
-        subject.source_url.must_equal historical_url
-        subject.source_url.must_include 'http://'
-        subject.source_url.must_include "/api/historical/#{subject.date}.json"
-      end
-
-      it 'should use the non-secure http url if secure_connection is false' do
-        subject.secure_connection = false
->>>>>>> Fix offenses
-        subject.source_url.must_equal historical_url
-        subject.source_url.must_include 'https://'
-        subject.source_url.must_include "/api/historical/#{subject.date}.json"
-      end
-    end
-
-    describe 'latest' do
-      it 'should use the secure https url' do
-        subject.source_url.must_equal source_secure_url
-        subject.source_url.must_include 'https://'
-        subject.source_url.must_include '/api/latest.json'
-      end
-    end
-  end
-
-  describe 'no valid file for cache' do
-    before do
-      subject.cache = "space_dir#{rand(999_999_999)}/out_space_file.json"
-      add_to_webmock(subject)
-    end
-
-    it 'should get from url' do
-      subject.update_rates
-      subject.oer_rates.wont_be_empty
-    end
-
-    it 'should raise an error if invalid path is given to save_rates' do
-      proc { subject.save_rates }.must_raise Money::Bank::InvalidCache
-    end
-  end
-
-  describe 'using proc for cache' do
-    before do
-      @global_rates = nil
-      subject.cache = proc do |v|
-        if v
-          @global_rates = v
-        else
-          @global_rates
-        end
-      end
-      add_to_webmock(subject)
-    end
-
-    it 'should get from url normally' do
-      subject.update_rates
-      subject.oer_rates.wont_be_empty
-    end
-
-    it 'should save from url and get from cache' do
-      subject.save_rates
-      @global_rates.wont_be_empty
-      dont_allow(subject).source_url
-      subject.update_rates
-      subject.oer_rates.wont_be_empty
-    end
-  end
-
-  describe 'save rates' do
-    before do
-      add_to_webmock(subject)
-      subject.cache = temp_cache_path
-      subject.save_rates
-    end
-
-    after do
-      File.unlink(temp_cache_path)
-    end
-
-    it 'should allow update after save' do
-      begin
-        subject.update_rates
-      rescue
-        assert false, 'Should allow updating after saving'
-      end
-    end
-
-    it 'should not break an existing file if save fails to read' do
-      initial_size = File.read(temp_cache_path).size
-      stub(subject).read_from_url { '' }
-      subject.save_rates
-      File.open(temp_cache_path).read.size.must_equal initial_size
-    end
-
-    it 'should not break an existing file if save returns json without rates' do
-      initial_size = File.read(temp_cache_path).size
-      stub(subject).read_from_url { '{"error": "An error"}' }
-      subject.save_rates
-      File.open(temp_cache_path).read.size.must_equal initial_size
-    end
-
-    it 'should not break an existing file if save returns a invalid json' do
-      initial_size = File.read(temp_cache_path).size
-      stub(subject).read_from_url { '{invalid_json: "An error"}' }
-      subject.save_rates
-      File.open(temp_cache_path).read.size.must_equal initial_size
-    end
-  end
-
-  describe '#expire_rates' do
-    before do
-      add_to_webmock(subject)
-      subject.ttl_in_seconds = 1000
-      @old_usd_eur_rate = 0.655
-      # see test/latest.json +52
-      @new_usd_eur_rate = 0.79085
-      subject.add_rate('USD', 'EUR', @old_usd_eur_rate)
-      subject.cache = temp_cache_path
-      subject.save_rates
-    end
-
-    after do
-      File.unlink(temp_cache_path)
-    end
-
-    describe 'when the ttl has expired' do
-      it 'should update the rates' do
-        subject.get_rate('USD', 'EUR').must_equal @old_usd_eur_rate
-        Timecop.freeze(Time.now + 1001) do
-          subject.get_rate('USD', 'EUR').wont_equal @old_usd_eur_rate
-          subject.get_rate('USD', 'EUR').must_equal @new_usd_eur_rate
-        end
-      end
-
-      it 'updates the next expiration time' do
-        Timecop.freeze(Time.now + 1001) do
-          exp_time = Time.now + 1000
-          subject.expire_rates
-          subject.rates_expiration.must_equal exp_time
-        end
-      end
-    end
-
-    describe 'when the ttl has not expired' do
-      it 'not should update the rates' do
-        exp_time = subject.rates_expiration
-        subject.expire_rates
-        subject.rates_expiration.must_equal exp_time
-      end
-    end
-  end
-
-  describe 'historical' do
-    before do
-      add_to_webmock(subject)
-      # see test/latest.json +52
-      @latest_usd_eur_rate = 0.79085
-      # see test/2015-01-01.json +52
-      @old_usd_eur_rate = 0.830151
-      subject.update_rates
-    end
-
-    it 'should be different than the latest' do
-      subject.get_rate('USD', 'EUR').must_equal @latest_usd_eur_rate
-      subject.date = '2015-01-01'
-      add_to_webmock(subject, oer_historical_path)
-      subject.update_rates
-      subject.get_rate('USD', 'EUR').must_equal @old_usd_eur_rate
-    end
-  end
-
-  describe 'source currency' do
-    it 'should be changed when a known currency is given' do
-      subject.source = 'EUR'
-      subject.source.must_equal 'EUR'
-    end
-
-    it 'should use USD when given unknown currency' do
-      subject.source = 'invalid'
-      subject.source.must_equal 'USD'
-    end
-  end
-
-  describe 'show alternative' do
-    describe 'when no value given' do
-      before do
-        subject.show_alternative = nil
-      end
-
-      it 'should return the default value' do
-        subject.show_alternative.must_equal false
-      end
-
-      it 'should include show_alternative param as false' do
-        subject.source_url.must_include 'show_alternative=false'
-      end
-    end
-
-    describe 'when value is given' do
-      before do
-        subject.show_alternative = true
-      end
-
-      it 'should return the value' do
-        subject.show_alternative.must_equal true
-      end
-
-      it 'should include show_alternative param as true' do
-        subject.source_url.must_include 'show_alternative=true'
-      end
-    end
-  end
-end