money-open-exchange-rates 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5a908e851c07a69ab0aca84da9edb9c1f596112
-  data.tar.gz: d63b70c7f7bd0300e44bdee7b723c558e862ef62
+  metadata.gz: 5d4627d2362f3d25776f0c16eac6dc34cd2b5ff9
+  data.tar.gz: cbeee2c8c0ba9be2e6b14104f72b13b18f4f2ad0
 SHA512:
-  metadata.gz: d4dfe2d85a96e772b193cfc8bd2986c2caf8e02e56fa1eb46ce86e9993d47b80d00a26eb243a1d6a3b51de56d8259a8de674217e99e89731e94a8665415c9c95
-  data.tar.gz: bd056b885c383fa246593a57685c61a2f33001ad1a120f5415d9d982272a03942af9bb9599976078912a424cf2626e0cb687fc8cce2064a728e175bad4b2ea99
+  metadata.gz: 78e27850a154eec72b5ba6effbd4cdc0fcecaa23d75a4f2fc77b7e6da885cff9026ece0d2fa9cecca10c0d00921b11a64ddaf7011717fd5fbf79f6172f8d6fe0
+  data.tar.gz: 359705aa410f98fdd525f5d91da0b9437178461568725f1b12e2d7ffe53f8e5b91ac8a89e3b4470a0d853e1ce674d35f16d0baf9fba447f1779325b41ed7ae5a

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright (c) 2011 Laurent Arnoud <laurent@spkdev.net>
+Copyright (c) 2011-2015 Laurent Arnoud <laurent@spkdev.net>
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.markdown

@@ -73,7 +73,7 @@ shpupti (1)
 
 The MIT License
 
-Copyright © 2014 Laurent Arnoud <laurent@spkdev.net>
+Copyright © 2011-2015 Laurent Arnoud <laurent@spkdev.net>
 
 ---
 [![Gem Version](https://badge.fury.io/rb/money-open-exchange-rates.svg)](https://rubygems.org/gems/money-open-exchange-rates)

data/lib/money/bank/open_exchange_rates_bank.rb

@@ -12,7 +12,7 @@ class Money
     # OpenExchangeRatesBank base class
     class OpenExchangeRatesBank < Money::Bank::VariableExchange
       OER_URL = 'http://openexchangerates.org/latest.json'
-      SECURE_OER_URL = OER_URL.tr('http:', 'https:')
+      SECURE_OER_URL = OER_URL.gsub('http:', 'https:')
 
       attr_accessor :cache, :app_id, :secure_connection
       attr_reader :doc, :oer_rates, :rates_expiration, :ttl_in_seconds

data/test/open_exchange_rates_bank_test.rb

@@ -161,6 +161,7 @@ describe Money::Bank::OpenExchangeRatesBank do
       subject.secure_connection = true
       subject.app_id = TEST_APP_ID
       subject.source_url.must_equal "#{secure_url}?app_id=#{TEST_APP_ID}"
+      subject.source_url.must_include "https://"
     end
   end
 
@@ -256,34 +257,34 @@ describe Money::Bank::OpenExchangeRatesBank do
     before do
       subject.app_id = TEST_APP_ID
       subject.ttl_in_seconds = 1000
-      @usd_eur_rate = 0.655
-      subject.add_rate('USD', 'EUR', @usd_eur_rate)
+      @old_usd_eur_rate = 0.655
+      # see test/latest.json +52
+      @new_usd_eur_rate = 0.79085
+      subject.add_rate('USD', 'EUR', @old_usd_eur_rate)
       subject.cache = temp_cache_path
-      stub(OpenURI::OpenRead).open(url) do
-        File.read cache_path
-      end
+      stub(subject).read_from_url { File.read cache_path }
+      subject.save_rates
     end
 
-    describe 'when the ttl has expired' do
-      before do
-        new_time = Time.now + 1001
-        Timecop.freeze(new_time)
-      end
-
-      after do
-        Timecop.return
-      end
+    after do
+      File.delete temp_cache_path
+    end
 
+    describe 'when the ttl has expired' do
       it 'should update the rates' do
-        subject.update_rates
-        subject.get_rate('USD', 'EUR').wont_equal @usd_eur_rate
+        subject.get_rate('USD', 'EUR').must_equal @old_usd_eur_rate
+        Timecop.freeze(Time.now + 1001) do
+          subject.get_rate('USD', 'EUR').wont_equal @old_usd_eur_rate
+          subject.get_rate('USD', 'EUR').must_equal @new_usd_eur_rate
+        end
       end
 
       it 'updates the next expiration time' do
-        exp_time = Time.now + 1000
-
-        subject.expire_rates
-        subject.rates_expiration.must_equal exp_time
+        Timecop.freeze(Time.now + 1001) do
+          exp_time = Time.now + 1000
+          subject.expire_rates
+          subject.rates_expiration.must_equal exp_time
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: money-open-exchange-rates
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Laurent Arnoud
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-14 00:00:00.000000000 Z
+date: 2015-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.5'
+- !ruby/object:Gem::Dependency
+  name: minitest-line
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement