money-open-exchange-rates 0.0.1 → 0.0.2

data/lib/money/bank/open_exchange_rates_bank.rb

@@ -23,7 +23,7 @@ class Money
       end
 
       def save_rates
-        raise InvalidCache unless cache
+        raise InvalidCache unless cache && File.exist?(cache)
         open(cache, 'w').write(open(OER_URL).read)
       end
 
@@ -43,8 +43,16 @@ class Money
 
       protected
 
+      def find_rates_source
+        if !!cache && File.exist?(cache)
+          @rates_source = cache
+        else
+          OER_URL
+        end
+      end
+
       def exchange_rates
-        @rates_source = !!cache ? cache : OER_URL
+        @rates_source = find_rates_source
         @doc = Yajl::Parser.parse(open(rates_source).read)
         @oer_rates = @doc['rates']
         @doc['rates']

data/test/open_exchange_rates_bank_test.rb

@@ -73,4 +73,22 @@ describe Money::Bank::OpenExchangeRatesBank do
     end
   end
 
+  describe 'no valid file for cache' do
+    include RR::Adapters::TestUnit
+    before do
+      @bank = Money::Bank::OpenExchangeRatesBank.new
+      @bank.cache = "space_dir#{rand(999999999)}/out_space_file.json"
+    end
+
+    it 'should get from url' do
+      stub(OpenURI::OpenRead).open(Money::Bank::OpenExchangeRatesBank::OER_URL) { File.read @cache_path }
+      @bank.update_rates
+      @bank.rates_source.must_equal Money::Bank::OpenExchangeRatesBank::OER_URL
+    end
+
+    it 'should raise an error if invalid path is given to save_rates' do
+      proc { @bank.save_rates }.must_raise Money::Bank::InvalidCache
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money-open-exchange-rates
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-18 00:00:00.000000000Z
+date: 2011-10-19 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &19606860 !ruby/object:Gem::Requirement
+  requirement: &9917460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.8.3
   type: :runtime
   prerelease: false
-  version_requirements: *19606860
+  version_requirements: *9917460
 - !ruby/object:Gem::Dependency
   name: money
-  requirement: &19605560 !ruby/object:Gem::Requirement
+  requirement: &9916040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 3.7.1
   type: :runtime
   prerelease: false
-  version_requirements: *19605560
+  version_requirements: *9916040
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &19604500 !ruby/object:Gem::Requirement
+  requirement: &9915020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *19604500
+  version_requirements: *9915020
 - !ruby/object:Gem::Dependency
   name: rr
-  requirement: &19603220 !ruby/object:Gem::Requirement
+  requirement: &9913600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: 1.0.4
   type: :development
   prerelease: false
-  version_requirements: *19603220
+  version_requirements: *9913600
 description: A gem that calculates the exchange rate using published rates from open-exchange-rates.
   Compatible with the money gem.
 email: laurent@spkdev.net