money-json-rates 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 65ad4a66cac1f91eace625bf55473fbae8356b2f
-  data.tar.gz: a04375b33cfda6acff2cf067f0880c42cdaa0b48
+  metadata.gz: 1b63e5f5f41854159f3ecb37f9991e5891898fe5
+  data.tar.gz: 96fc0b87e080bff3f62c30ebc4e3afa2efa1b2b7
 SHA512:
-  metadata.gz: 98957c324ccc5d62d1a34e578c47af66c371a156dea0e86afa099dcdde3e145c1ac1a6b9d55465620e44712852d00e69755f94589e62bb0f4061b0154a392ecb
-  data.tar.gz: 94af90123b47dbee64d935833c2fc34200d0468d3d20cacd4b16864dd0df91492d313debf5925483a785d1d560cadc32a0b417f5766b100dbd52a4fc8c586990
+  metadata.gz: 7b37c69c827bcfb47886bf95cf8bfae6642ca143546c6d9e81a059689fbd019648262af044270f0faf6b90e41a658b0bda503e3552b266114cdded18be45a91e
+  data.tar.gz: 41f5fa8841aa3f436539326d7c024a380a356a45c5222493ec9349ccf24db5e8151b55cc048c9a4ab0fabf18de911ce726ef0213433da5f7331cb5670c96af62

data/lib/money/bank/json_rates.rb

@@ -141,7 +141,7 @@ class Money
       #
       # @return [URI::HTTP]
       def build_uri(from, to)
-        raise NoApiKey if api_key.blank?
+        raise NoApiKey if api_key.nil? || api_key.blank?
         uri = URI::HTTP.build(
           :host  => SERVICE_HOST,
           :path  => SERVICE_PATH,

data/spec/json_rates_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+
+describe "JsonRates" do
+  before :each do
+    @bank = Money::Bank::JsonRates.new
+  end
+
+  it "should accept a ttl_in_seconds option" do
+    Money::Bank::JsonRates.ttl_in_seconds = 86400
+    expect(Money::Bank::JsonRates.ttl_in_seconds).to eq(86400)
+  end
+
+  describe ".refresh_rates_expiration!" do
+    it "set the .rates_expiration using the TTL and the current time" do
+      Money::Bank::JsonRates.ttl_in_seconds = 86400
+      new_time = Time.now
+      Timecop.freeze(new_time)
+      Money::Bank::JsonRates.refresh_rates_expiration!
+      expect(Money::Bank::JsonRates.rates_expiration).to eq(new_time + 86400)
+    end
+  end
+
+  describe ".flush_rates" do
+    it "should empty @rates" do
+      @bank.add_rate("USD", "CAD", 1.24515)
+      @bank.flush_rates
+      expect(@bank.rates).to eq({})
+    end
+  end
+
+  describe ".flush_rate" do
+    it "should remove a specific rate from @rates" do
+      @bank.add_rate('USD', 'EUR', 1.4)
+      @bank.add_rate('USD', 'JPY', 0.3)
+      @bank.flush_rate('USD', 'EUR')
+      expect(@bank.rates).to include('USD_TO_JPY')
+      expect(@bank.rates).to_not include('USD_TO_EUR')
+    end
+  end
+
+  describe ".expire_rates" do
+    before do
+      Money::Bank::JsonRates.ttl_in_seconds = 1000
+    end
+
+    context "when the ttl has expired" do
+      before do
+        new_time = Time.now + 1001
+        Timecop.freeze(new_time)
+      end
+
+      it "should flush all rates" do
+        expect(@bank).to receive(:flush_rates)
+        @bank.expire_rates
+      end
+
+      it "updates the next expiration time" do
+        exp_time = Time.now + 1000
+
+        @bank.expire_rates
+        expect(Money::Bank::JsonRates.rates_expiration).to eq(exp_time)
+      end
+    end
+
+    context "when the ttl has not expired" do
+      it "not should flush all rates" do
+        expect(@bank).to_not receive(:flush_rates)
+        @bank.expire_rates
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+require 'timecop'
+require 'money'
+require 'money/bank/json_rates'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: money-json-rates
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Andrey Skuratovsky
@@ -38,8 +38,36 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-description: MoneyJsonRates extends Money::Bank::Base and gives access to the current
-  exchange rates using http://jsonrates.com/ api.
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+description: JsonRates extends Money::Bank::Base and gives access to the current exchange
+  rates using http://jsonrates.com/ api.
 email:
 - skuratowsky@gmail.com
 executables: []
@@ -47,6 +75,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/money/bank/json_rates.rb
+- spec/json_rates_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/askuratovsky/money-json-rates
 licenses:
 - MIT