money-fixer-io 0.0.0 → 0.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d81fd4bcd190187d09ae4dfb34353f2085ac5248
-  data.tar.gz: b62fb58ab92382d54fd48507ea52df941ae82db6
+  metadata.gz: c21f00db45612059aa6e22318ca1e0235575fb23
+  data.tar.gz: acc00e17238140e59115f630ede9e490535fd28d
 SHA512:
-  metadata.gz: fcdb71085d4d6bc9e0ae99629180a56930bae9dd5df43b39c926c2dcd40382cf5f419a2e1196b5d1397e4ecae72cf98087a96bd31d9c4601d4fc0ea034918b0e
-  data.tar.gz: 290d4f2f43125aebed80691728bd7433c7e1faace82c758b97d3f6dfe4e54ab61651795ffd7cbb4c136b1fef9e32ac9cf0efc2526644f1b6a7678f41f552bc3c
+  metadata.gz: cf258b0f407c631c21bf028b0552a107541c2381f15aa81d32a852e422ec5b1493b2e3d9b41f1cde3ad97efef24a23bffa2569544d9b345127a6edf15d9a5e69
+  data.tar.gz: 67d09df341bace5f6e626d6ed42169b20f5dbe94c9c9a2f9727b5a7846e97e8d4ff63dc888824aab85ed33b7ffb415d532adc63a1c033dcf1e0c190c1d40a03d

data/.rubocop.yml

@@ -2,8 +2,7 @@ AllCops:
   DisplayCopNames: true
   DisplayStyleGuide: true
   Exclude:
-    - db/schema.rb
-    - spec/dummy/db/schema.rb
+    - money-fixer-io.gemspec
 
 # https://github.com/AtomLinter/linter-rubocop/issues/2
 Style/FileName:

data/Gemfile

@@ -1,15 +1,14 @@
 source "https://rubygems.org"
-# Add dependencies required to use your gem here.
-# Example:
-#   gem "activesupport", ">= 2.3.5"
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
+ruby "2.3.1"
+
 group :development do
-  gem "rspec", "~> 2.8.0"
+  gem "rspec", "3.5.0"
   gem "rdoc", "~> 3.12"
   gem "bundler", "~> 1.0"
   gem "jeweler", "2.1.1"
-  gem "simplecov", ">= 0"
+
+  gem "money", "6.7.1"
+
   gem "rubocop", "0.43.0"
 end

data/Gemfile.lock

@@ -6,8 +6,7 @@ GEM
     builder (3.2.2)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.1.3)
-    docile (1.1.5)
+    diff-lcs (1.2.5)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     git (1.3.0)
@@ -19,6 +18,7 @@ GEM
       oauth2 (~> 1.0)
     hashie (3.4.6)
     highline (1.7.8)
+    i18n (0.7.0)
     jeweler (2.1.1)
       builder
       bundler (>= 1.0)
@@ -32,6 +32,9 @@ GEM
     json (1.8.3)
     jwt (1.5.6)
     mini_portile2 (2.1.0)
+    money (6.7.1)
+      i18n (>= 0.6.4, <= 0.7.0)
+      sixarm_ruby_unaccent (>= 1.1.1, < 2)
     multi_json (1.12.1)
     multi_xml (0.5.5)
     multipart-post (2.0.0)
@@ -53,14 +56,19 @@ GEM
     rake (11.3.0)
     rdoc (3.12.2)
       json (~> 1.4)
-    rspec (2.8.0)
-      rspec-core (~> 2.8.0)
-      rspec-expectations (~> 2.8.0)
-      rspec-mocks (~> 2.8.0)
-    rspec-core (2.8.0)
-    rspec-expectations (2.8.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.8.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.3)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
     rubocop (0.43.0)
       parser (>= 2.3.1.1, < 3.0)
       powerpack (~> 0.1)
@@ -69,11 +77,7 @@ GEM
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.8.1)
     semver (1.0.1)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
+    sixarm_ruby_unaccent (1.1.1)
     thread_safe (0.3.5)
     unicode-display_width (1.1.1)
 
@@ -83,10 +87,10 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.0)
   jeweler (= 2.1.1)
+  money (= 6.7.1)
   rdoc (~> 3.12)
-  rspec (~> 2.8.0)
+  rspec (= 3.5.0)
   rubocop (= 0.43.0)
-  simplecov
 
 BUNDLED WITH
    1.12.5

data/{README.rdoc → README.md}

@@ -1,9 +1,9 @@
-= money-fixer-io
+# money-fixer-io
 
 Description goes here.
 
-== Contributing to money-fixer-io
- 
+## Contributing to money-fixer-io
+
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
 * Fork the project.
@@ -12,7 +12,7 @@ Description goes here.
 * Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
 * Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
 
-== Copyright
+## Copyright
 
 Copyright (c) 2016 kaspernj. See LICENSE.txt for
 further details.

data/VERSION

@@ -1 +1 @@
-0.0.0
+0.0.1

data/lib/money-fixer-io.rb

@@ -1,10 +1,8 @@
 require "money"
-require "money/rates_store/rate_removal_support"
 require "open-uri"
 
 class Money::Bank::FixerIo < Money::Bank::VariableExchange
   SERVICE_HOST = "api.fixer.io".freeze
-  SERVICE_PATH = "/".freeze
 
   # @return [Hash] Stores the currently known rates.
   attr_reader :rates
@@ -34,9 +32,8 @@ class Money::Bank::FixerIo < Money::Bank::VariableExchange
     end
   end
 
-  def initialize(*)
-    super
-    @store.extend Money::RatesStore::RateRemovalSupport
+  def cache
+    @@money_bank_fixer_io_cache ||= {} # rubocop:disable Style/ClassVars
   end
 
   ##
@@ -87,13 +84,24 @@ class Money::Bank::FixerIo < Money::Bank::VariableExchange
     expire_rates
 
     if args[:exchanged_at]
-      fetch_rate(from, to, exchanged_at: args.fetch(:exchanged_at))
-      raise "stub"
+      get_rate_with_exchange_rate(from, to, args)
     else
       store.get_rate(from, to) || store.add_rate(from, to, fetch_rate(from, to))
     end
   end
 
+  def get_rate_with_exchange_rate(from, to, args = {})
+    exchanged_at = args.fetch(:exchanged_at).strftime("%Y-%m-%d")
+
+    if cache[from] && cache[from][to] && cache[from][to][exchanged_at]
+      cache[from][to][exchanged_at]
+    else
+      cache[from] ||= {}
+      cache[from][to] ||= {}
+      cache[from][to][exchanged_at] = fetch_rate(from, to, exchanged_at: exchanged_at)
+    end
+  end
+
   ##
   # Flushes all the rates if they are expired.
   #
@@ -118,11 +126,12 @@ private
   #
   # @return [BigDecimal] The requested rate.
   def fetch_rate(from, to, args = {})
-    from = Currency.wrap(from)
-    to = Currency.wrap(to)
+    from = Money::Currency.wrap(from)
+    to = Money::Currency.wrap(to)
+    uri = build_uri(from, to, args)
 
-    data = JSON.parse(build_uri(from, to, args).read)
-    rate = data.fetch("rates").fetch(to)
+    data = JSON.parse(uri.read)
+    rate = data.fetch("rates").fetch(to.iso_code)
     rate = 1 / extract_rate(build_uri(to, from).read) if rate < 0.1
     rate
   end
@@ -134,13 +143,18 @@ private
   # @param [Currency] to The currency to convert to.
   #
   # @return [URI::HTTP]
-  def build_uri(from, _to, _args = {})
+  def build_uri(from, _to, args = {})
+    if args[:exchanged_at]
+      path = "/#{args.fetch(:exchanged_at)}"
+    else
+      path = "/latest"
+    end
+
     query = "base=#{from.iso_code}"
-    query << "&date=#{args.fetch(:exchange_at).strftime("%Y-%m-%D")}"
 
     uri = URI::HTTP.build(
       host: SERVICE_HOST,
-      path: SERVICE_PATH,
+      path: path,
       query: query
     )
     uri

data/money-fixer-io.gemspec

@@ -0,0 +1,69 @@
+# Generated by jeweler
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# -*- encoding: utf-8 -*-
+# stub: money-fixer-io 0.0.1 ruby lib
+
+Gem::Specification.new do |s|
+  s.name = "money-fixer-io"
+  s.version = "0.0.1"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
+  s.authors = ["kaspernj"]
+  s.date = "2016-10-01"
+  s.description = "fixer.io support for money"
+  s.email = "k@spernj.org"
+  s.extra_rdoc_files = [
+    "LICENSE.txt",
+    "README.md"
+  ]
+  s.files = [
+    ".document",
+    ".rspec",
+    ".rubocop.yml",
+    "Gemfile",
+    "Gemfile.lock",
+    "LICENSE.txt",
+    "README.md",
+    "Rakefile",
+    "VERSION",
+    "lib/money-fixer-io.rb",
+    "money-fixer-io.gemspec",
+    "shippable.yml",
+    "spec/money-fixer-io_spec.rb",
+    "spec/spec_helper.rb"
+  ]
+  s.homepage = "http://github.com/kaspernj/money-fixer-io"
+  s.licenses = ["MIT"]
+  s.rubygems_version = "2.5.1"
+  s.summary = "fixer.io support for money"
+
+  if s.respond_to? :specification_version then
+    s.specification_version = 4
+
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_development_dependency(%q<rspec>, ["= 3.5.0"])
+      s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0"])
+      s.add_development_dependency(%q<jeweler>, ["= 2.1.1"])
+      s.add_development_dependency(%q<money>, ["= 6.7.1"])
+      s.add_development_dependency(%q<rubocop>, ["= 0.43.0"])
+    else
+      s.add_dependency(%q<rspec>, ["= 3.5.0"])
+      s.add_dependency(%q<rdoc>, ["~> 3.12"])
+      s.add_dependency(%q<bundler>, ["~> 1.0"])
+      s.add_dependency(%q<jeweler>, ["= 2.1.1"])
+      s.add_dependency(%q<money>, ["= 6.7.1"])
+      s.add_dependency(%q<rubocop>, ["= 0.43.0"])
+    end
+  else
+    s.add_dependency(%q<rspec>, ["= 3.5.0"])
+    s.add_dependency(%q<rdoc>, ["~> 3.12"])
+    s.add_dependency(%q<bundler>, ["~> 1.0"])
+    s.add_dependency(%q<jeweler>, ["= 2.1.1"])
+    s.add_dependency(%q<money>, ["= 6.7.1"])
+    s.add_dependency(%q<rubocop>, ["= 0.43.0"])
+  end
+end
+

data/shippable.yml

@@ -0,0 +1,3 @@
+script:
+  - bundle exec rspec
+  - bundle exec rubocop

data/spec/money-fixer-io_spec.rb

@@ -1,7 +1,34 @@
-require File.expand_path(File.dirname(__FILE__) + "/spec_helper")
+require "spec_helper"
 
-describe "MoneyFixerIo" do
-  it "fails" do
-    raise "hey buddy, you should probably rename this file and start specing for real"
+describe Money::Bank::FixerIo do
+  let(:bank) { Money::Bank::FixerIo.new }
+  let(:currency_eur) { Money::Currency.new("EUR") }
+  let(:currency_dkk) { Money::Currency.new("DKK") }
+
+  describe "#get_rate" do
+    it "returns the right rates" do
+      result = bank.get_rate(currency_eur, currency_dkk, exchanged_at: Time.new(2004, 1, 1))
+      result = format("%.2f", result).to_f
+
+      expect(result).to eq 7.45
+
+      result = bank.get_rate(currency_eur, currency_dkk, exchanged_at: Time.new(2016, 1, 1))
+      result = format("%.2f", result).to_f
+
+      expect(result).to eq 7.46
+    end
+
+    it "does caching" do
+      bank.get_rate(currency_eur, currency_dkk, exchanged_at: Time.new(2004, 1, 1))
+
+      expect(bank.cache).to have_key currency_eur
+      expect(bank.cache.fetch(currency_eur)).to have_key currency_dkk
+      expect(bank.cache.fetch(currency_eur).fetch(currency_dkk)).to have_key "2004-01-01"
+
+      result = bank.cache.fetch(currency_eur).fetch(currency_dkk).fetch("2004-01-01")
+      result = format("%.2f", result).to_f
+
+      expect(result).to eq 7.45
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,19 +1,3 @@
-require "simplecov"
-
-module SimpleCov::Configuration
-  def clean_filters
-    @filters = []
-  end
-end
-
-SimpleCov.configure do
-  clean_filters
-  load_adapter "test_frameworks"
-end
-
-ENV["COVERAGE"] && SimpleCov.start do
-  add_filter "/.rvm/"
-end
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: money-fixer-io
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.0.1
 platform: ruby
 authors:
 - kaspernj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2016-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 2.8.0
+        version: 3.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 2.8.0
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -67,19 +67,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.1.1
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.7.1
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -100,7 +100,7 @@ executables: []
 extensions: []
 extra_rdoc_files:
 - LICENSE.txt
-- README.rdoc
+- README.md
 files:
 - ".document"
 - ".rspec"
@@ -108,10 +108,12 @@ files:
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
-- README.rdoc
+- README.md
 - Rakefile
 - VERSION
 - lib/money-fixer-io.rb
+- money-fixer-io.gemspec
+- shippable.yml
 - spec/money-fixer-io_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/kaspernj/money-fixer-io