monetize 1.9.0 → 1.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e26348a04058d672c804c80a19beb2c4615f9a33
-  data.tar.gz: 68697cc2d144f4e6ce17e7784e0dcb5188a482fb
+  metadata.gz: 7c921047a6f291ae61ceb19db130de7b0288d8e2
+  data.tar.gz: f48eb20c8582b1453ef6114df30793f9367d934e
 SHA512:
-  metadata.gz: 452be2be436b0ea57611a2a32b3230486f8f3de40cb74e4286931528a6db05fd2cddc114ca5373be7a92f4680a0f50a3992af373920b09f65c233fd0f9cb0007
-  data.tar.gz: db4134e4c44bb2b58fd12d6c7ff2d5e3259b76ba6971215cbdd61759d715cf98b014066f165dfea5cf79ac5c7997937ca1fc3ff0ceae8ce604424c41370def1f
+  metadata.gz: 9b4a49126c30cfd92968d6fed6cd43a806e5cda807f8dfd0c8956d434e0e3a3331191d9e228e5648c4d11157f01d3c3fcdb72f72f21e52f96002ab803b70265a
+  data.tar.gz: 571ec0ec170014d408f4ba0208a1b40f04cdf3436b2939e7d43b922cfe2ce3e981fb5a51a6dc79eab8d07ccad4ecfbc270548e15b4293428df87dbc0c912d277

data/.travis.yml

@@ -8,7 +8,10 @@ rvm:
   - 2.3.7
   - 2.4.4
   - 2.5.1
+  - 2.6.0
   - jruby-9.0.5.0
+before_install:
+  - gem install bundler --version '~> 1.17'
 script: bundle exec rspec spec
 notifications:
   recipients:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 1.9.1
+- Ruby 2.6 support
+
 ## 1.9.0
 - Relax Money gem dependency to ~> 6.12
 - Refactor `Monetize::Parser`

data/Gemfile

@@ -2,13 +2,14 @@ source 'https://rubygems.org'
 
 gem 'coveralls', '>= 0.8.20', require: false
 
-# JSON gem no longer supports ruby < 2.0.0
+# JSON and I18n gem no longer supports ruby < 2.0.0
 if defined?(JRUBY_VERSION)
   gem 'json'
 elsif RUBY_VERSION =~ /^1/
   gem 'json', '~> 1.8.3'
   gem 'tins', '~> 1.6.0'
   gem 'term-ansicolor', '~> 1.3.0'
+  gem 'i18n', '~> 0.9'
 end
 
 gemspec

data/lib/monetize.rb

@@ -43,7 +43,7 @@ module Monetize
     end
 
     def from_string(value, currency = Money.default_currency)
-      value = BigDecimal.new(value.to_s)
+      value = BigDecimal(value.to_s)
       Money.from_amount(value, currency)
     end
 

data/lib/monetize/parser.rb

@@ -152,7 +152,7 @@ module Monetize
 
     def set_minor_precision(minor, currency)
       if Money.infinite_precision
-        (BigDecimal.new(minor) / (10**minor.size)) * currency.subunit_to_unit
+        (BigDecimal(minor) / (10**minor.size)) * currency.subunit_to_unit
       elsif minor.size < currency.decimal_places
         (minor + ('0' * currency.decimal_places))[0, currency.decimal_places].to_i
       elsif minor.size > currency.decimal_places

data/lib/monetize/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module Monetize
-  VERSION = '1.9.0'
+  VERSION = '1.9.1'
 end

data/monetize.gemspec

@@ -21,7 +21,13 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'money', '~> 6.12'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake', '~> 10.2'
   spec.add_development_dependency 'rspec', '~> 3.0'
+
+  if spec.respond_to?(:metadata)
+    spec.metadata['changelog_uri'] = 'https://github.com/RubyMoney/monetize/blob/master/CHANGELOG.md'
+    spec.metadata['source_code_uri'] = 'https://github.com/RubyMoney/monetize/'
+    spec.metadata['bug_tracker_uri'] = 'https://github.com/RubyMoney/monetize/issues'
+  end
 end

data/spec/core_extensions_spec.rb

@@ -31,7 +31,7 @@ describe Monetize, 'core extensions' do
         expect(money.cents).to eq 100_37
         expect(money.currency).to eq Money.default_currency
 
-        money = BigDecimal.new('1234').to_money
+        money = BigDecimal('1234').to_money
         expect(money.cents).to eq 1_234_00
         expect(money.currency).to eq Money.default_currency
       end

data/spec/monetize_spec.rb

@@ -212,6 +212,14 @@ describe Monetize do
       expect(Monetize.parse('-$5.95-')).to be_nil
     end
 
+    it 'returns nil when more than 2 digit separators are used' do
+      expect(Monetize.parse("123.34,56'89 EUR")).to be_nil
+    end
+
+    it 'parses correctly strings with repeated digit separator' do
+      expect(Monetize.parse('19.12.89', 'EUR')).to eq Money.new(191_289_00, 'EUR')
+    end
+
     it 'parses correctly strings with exactly 3 decimal digits' do
       expect(Monetize.parse('6,534', 'EUR')).to eq Money.new(653, 'EUR')
       expect(Monetize.parse('6.534', 'EUR')).to eq Money.new(653, 'EUR')
@@ -234,7 +242,7 @@ describe Monetize do
     context 'parsing an instance of Numeric class' do
       let(:integer)     { 10 }
       let(:float)       { 10.0 }
-      let(:big_decimal) { BigDecimal.new('10') }
+      let(:big_decimal) { BigDecimal('10') }
 
       [:integer, :float, :big_decimal].each do |type|
         it "returns a new Money object based on the #{type} input" do
@@ -336,6 +344,10 @@ describe Monetize do
       expect(collection.first).to eq Monetize.parse('$4')
       expect(collection.last).to eq Monetize.parse('$10')
     end
+
+    it 'raises an error if argument is invalid' do
+      expect { Monetize.parse_collection(nil) }.to raise_error Monetize::ArgumentError
+    end
   end
 
   describe '.from_string' do
@@ -419,31 +431,31 @@ describe Monetize do
 
   describe '.from_bigdecimal' do
     it 'converts given amount to cents' do
-      expect(Monetize.from_bigdecimal(BigDecimal.new('1'))).to eq Money.new(1_00)
-      expect(Monetize.from_bigdecimal(BigDecimal.new('1'))).to eq Money.new(1_00, 'USD')
-      expect(Monetize.from_bigdecimal(BigDecimal.new('1'), 'EUR')).to eq Money.new(1_00, 'EUR')
+      expect(Monetize.from_bigdecimal(BigDecimal('1'))).to eq Money.new(1_00)
+      expect(Monetize.from_bigdecimal(BigDecimal('1'))).to eq Money.new(1_00, 'USD')
+      expect(Monetize.from_bigdecimal(BigDecimal('1'), 'EUR')).to eq Money.new(1_00, 'EUR')
     end
 
     it 'respects :subunit_to_unit currency property' do
-      expect(Monetize.from_bigdecimal(BigDecimal.new('1'), 'USD')).to eq Money.new(1_00, 'USD')
-      expect(Monetize.from_bigdecimal(BigDecimal.new('1'), 'TND')).to eq Money.new(1_000, 'TND')
-      expect(Monetize.from_bigdecimal(BigDecimal.new('1'), 'JPY')).to eq Money.new(1, 'JPY')
+      expect(Monetize.from_bigdecimal(BigDecimal('1'), 'USD')).to eq Money.new(1_00, 'USD')
+      expect(Monetize.from_bigdecimal(BigDecimal('1'), 'TND')).to eq Money.new(1_000, 'TND')
+      expect(Monetize.from_bigdecimal(BigDecimal('1'), 'JPY')).to eq Money.new(1, 'JPY')
     end
 
     it 'respects rounding mode when rounding amount to the nearest cent' do
-      amount = BigDecimal.new('1.005')
+      amount = BigDecimal('1.005')
 
       expect(Monetize.from_bigdecimal(amount, 'USD')).to eq Money.from_amount(amount, 'USD')
     end
 
     it 'accepts a currency options' do
-      m = Monetize.from_bigdecimal(BigDecimal.new('1'))
+      m = Monetize.from_bigdecimal(BigDecimal('1'))
       expect(m.currency).to eq Money.default_currency
 
-      m = Monetize.from_bigdecimal(BigDecimal.new('1'), Money::Currency.wrap('EUR'))
+      m = Monetize.from_bigdecimal(BigDecimal('1'), Money::Currency.wrap('EUR'))
       expect(m.currency).to eq Money::Currency.wrap('EUR')
 
-      m = Monetize.from_bigdecimal(BigDecimal.new('1'), 'EUR')
+      m = Monetize.from_bigdecimal(BigDecimal('1'), 'EUR')
       expect(m.currency).to eq Money::Currency.wrap('EUR')
     end
 
@@ -457,11 +469,11 @@ describe Monetize do
       end
 
       it 'keeps precision' do
-        expect(Monetize.from_bigdecimal(BigDecimal.new('1'))).to eq Money.new(100)
-        expect(Monetize.from_bigdecimal(BigDecimal.new('1.23456'))).to eq Money.new(123.456)
-        expect(Monetize.from_bigdecimal(BigDecimal.new('-1.23456'))).to eq Money.new(-123.456)
-        expect(Monetize.from_bigdecimal(BigDecimal.new('1.23456'))).to eq Money.new(123.456, 'USD')
-        expect(Monetize.from_bigdecimal(BigDecimal.new('1.23456'), 'EUR')).to eq Money.new(123.456, 'EUR')
+        expect(Monetize.from_bigdecimal(BigDecimal('1'))).to eq Money.new(100)
+        expect(Monetize.from_bigdecimal(BigDecimal('1.23456'))).to eq Money.new(123.456)
+        expect(Monetize.from_bigdecimal(BigDecimal('-1.23456'))).to eq Money.new(-123.456)
+        expect(Monetize.from_bigdecimal(BigDecimal('1.23456'))).to eq Money.new(123.456, 'USD')
+        expect(Monetize.from_bigdecimal(BigDecimal('1.23456'), 'EUR')).to eq Money.new(123.456, 'EUR')
 
         expect('1'.to_money).to eq Money.new(100)
         expect('1.23456'.to_money).to eq Money.new(123.456)
@@ -476,7 +488,7 @@ describe Monetize do
     it 'converts given amount to cents' do
       expect(Monetize.from_numeric(1)).to eq Money.new(1_00)
       expect(Monetize.from_numeric(1.0)).to eq Money.new(1_00)
-      expect(Monetize.from_numeric(BigDecimal.new('1'))).to eq Money.new(1_00)
+      expect(Monetize.from_numeric(BigDecimal('1'))).to eq Money.new(1_00)
     end
 
     it 'raises ArgumentError with unsupported argument' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: monetize
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.9.1
 platform: ruby
 authors:
 - Shane Emmons
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-11 00:00:00.000000000 Z
+date: 2019-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -28,30 +28,30 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,7 +101,10 @@ files:
 homepage: https://github.com/RubyMoney/monetize
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/RubyMoney/monetize/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/RubyMoney/monetize/
+  bug_tracker_uri: https://github.com/RubyMoney/monetize/issues
 post_install_message: 
 rdoc_options: []
 require_paths: