mondido 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38e6de19a52348345f2dbf4bd5d70c87e22a0c91
-  data.tar.gz: b1b872b2642b5e20137dee77339701658e03440a
+  metadata.gz: 2844bcc3718fa1e1e93c9b3fc35f62c9430c2251
+  data.tar.gz: 40c734aff3acc4c0375551efe1663d501a33ff35
 SHA512:
-  metadata.gz: cce179185b1a6636409286aa925daea01baa98ca5086b9bad3e0074337f63100f017fdfe1c703eab76a2a0503c3ddacd083eef07848f5756c7cfe5a130d67852
-  data.tar.gz: d70be22746fe80499c75767eaecee37b7437844dbb4ec814a3e0e3bb417d7cde4db629093b8b8288aa1ea843af3db95b26f572e4190b1019960e7836439ca354
+  metadata.gz: f6b82c440260a10b0912c904865bf3ed64ca13431428458db56379c1d4dddd0d688b66695e307e37298f2122429ee46621d679e9e6f7b8c5d5c4f4eaa7946d6d
+  data.tar.gz: ef7263f2b40e9c32162c87b1eb7960c7185e2400564d40e58fa9e1cfa6219b14d71f1f1dd061a1a9fad2b9fb03be8f9405d6f0bde442101d28fa375a8ddfc87e

data/lib/mondido.rb

@@ -1,6 +1,7 @@
 module Mondido
   require 'active_support'
   require 'active_model'
+  require 'mondido/credentials'
   require 'mondido/config'
   require 'mondido/exceptions/exceptions'
   require 'mondido/rest_client'
@@ -8,12 +9,6 @@ module Mondido
   require 'mondido/credit_card/transaction'
   require 'mondido/credit_card/refund'
   require 'mondido/credit_card/stored_card'
-
-  class Railtie < Rails::Railtie
-    initializer 'require credentials after rails is initialized' do
-      require 'mondido/credentials'
-    end
-  end
 end
 
 

data/lib/mondido/config.rb

@@ -1,5 +1,5 @@
 module Mondido
   class Config
-    URI = 'http://api.localmondido.com:3000/v1'
+    URI = 'http://api.mondido.com/v1'
   end
 end

data/lib/mondido/credentials.rb

@@ -1,16 +1,37 @@
 module Mondido
   class Credentials
-    unless Rails.root.nil?
+    @@merchant_id = nil
+    @@secret = nil
+    @@password = nil
+
+    def self.merchant_id
+      setup if @@merchant_id.nil?
+      @@merchant_id
+    end
+
+    def self.secret
+      setup if @@secret.nil?
+      @@secret
+    end
+
+    def self.password
+      setup if @@password.nil?
+      @@password
+    end
+
+    private
+
+    def self.setup
       config_file = File.join(Rails.root, 'config', 'mondido.yml')
       if File.exist?(config_file)
         yaml = YAML.load(File.read(config_file))
+        @@merchant_id = yaml['merchant_id'] 
+        @@secret = yaml['secret'] 
+        @@password = yaml['password'] 
       else
-        raise 'Could not find app/mondido.yml'
+        raise Mondido::Exceptions::MissingFile.new 'Could not locate config/mondido.yml'
       end
-
-      MERCHANT_ID ||= yaml['merchant_id'] or raise 'Mondido merchant ID not set in config/mondido.yml'
-      SECRET ||= yaml['secret'] or raise 'Mondido secret not set in config/mondido.yml'
-      PASSWORD ||= yaml['password'] or raise 'Mondido password not set in config/mondido.yml'
     end
+
   end
 end

data/lib/mondido/credit_card/transaction.rb

@@ -63,7 +63,7 @@ module Mondido
       end
 
       def set_hash!
-        unhashed = [Mondido::Credentials::MERCHANT_ID, payment_ref, amount, currency, Mondido::Credentials::SECRET]
+        unhashed = [Mondido::Credentials.merchant_id, payment_ref, amount, currency, Mondido::Credentials.secret]
         self.hash = Digest::MD5.hexdigest(unhashed.join)
       end
 

data/lib/mondido/exceptions/exceptions.rb

@@ -2,5 +2,6 @@ module Mondido
   module Exceptions
     require 'mondido/exceptions/validation_exception'
     require 'mondido/exceptions/api_exception'
+    require 'mondido/exceptions/missing_file'
   end
 end

data/lib/mondido/exceptions/missing_file.rb

@@ -0,0 +1,7 @@
+
+module Mondido
+  module Exceptions
+    class MissingFile < StandardError
+    end
+  end
+end

data/lib/mondido/rest_client.rb

@@ -23,7 +23,7 @@ module Mondido
         when :get
           request = Net::HTTP::Get.new(uri.path)
       end
-      request.basic_auth(Mondido::Credentials::MERCHANT_ID, Mondido::Credentials::PASSWORD)
+      request.basic_auth(Mondido::Credentials.merchant_id, Mondido::Credentials.password)
       request.set_form_data(args[:data]) if args.has_key?(:data)
       response = http.start { |http| http.request(request) }
       unless (200..299).include?(response.code.to_i)

data/lib/mondido/version.rb

@@ -1,3 +1,3 @@
 module Mondido
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/credit_card/refund_spec.rb

@@ -5,8 +5,8 @@ describe Mondido::CreditCard::Refund do
     context 'valid' do
       before(:all) do
         uri = URI.parse(Mondido::Config::URI + '/refunds')
-        uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-        uri.password = Mondido::Credentials::PASSWORD.to_s
+        uri.user = Mondido::Credentials.merchant_id.to_s
+        uri.password = Mondido::Credentials.password.to_s
         json_refund = File.read('spec/stubs/refund.json')
         @refund_hash = JSON.parse(json_refund)
 

data/spec/credit_card/stored_card_spec.rb

@@ -5,8 +5,8 @@ describe Mondido::CreditCard::StoredCard do
     context 'valid call' do
       before(:all) do
         uri = URI.parse(Mondido::Config::URI + '/stored_cards/300')
-        uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-        uri.password = Mondido::Credentials::PASSWORD.to_s
+        uri.user = Mondido::Credentials.merchant_id.to_s
+        uri.password = Mondido::Credentials.password.to_s
         json_stored_card = File.read('spec/stubs/stored_card.json')
         @stored_card_hash = JSON.parse(json_stored_card)
         stub_request(:get, uri.to_s)
@@ -37,8 +37,8 @@ describe Mondido::CreditCard::StoredCard do
   context '#create' do
     before(:all) do
       uri = URI.parse(Mondido::Config::URI + '/stored_cards')
-      uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-      uri.password = Mondido::Credentials::PASSWORD.to_s
+      uri.user = Mondido::Credentials.merchant_id.to_s
+      uri.password = Mondido::Credentials.password.to_s
       json_transaction = File.read('spec/stubs/stored_card.json')
       @transaction_hash = JSON.parse(json_transaction)
 

data/spec/credit_card/transaction_spec.rb

@@ -5,8 +5,8 @@ describe Mondido::CreditCard::Transaction do
   context 'list transactions' do
     before(:all) do
       uri = URI.parse(Mondido::Config::URI + '/transactions')
-      uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-      uri.password = Mondido::Credentials::PASSWORD.to_s
+      uri.user = Mondido::Credentials.merchant_id.to_s
+      uri.password = Mondido::Credentials.password.to_s
       json_transactions = File.read('spec/stubs/transactions.json')
       @transactions_array = JSON.parse(json_transactions)
 
@@ -25,8 +25,8 @@ describe Mondido::CreditCard::Transaction do
   context 'get transaction' do
     before(:all) do
       uri = URI.parse(Mondido::Config::URI + '/transactions/200')
-      uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-      uri.password = Mondido::Credentials::PASSWORD.to_s
+      uri.user = Mondido::Credentials.merchant_id.to_s
+      uri.password = Mondido::Credentials.password.to_s
       json_transaction = File.read('spec/stubs/transaction.json')
       @transaction_hash = JSON.parse(json_transaction)
 
@@ -65,8 +65,8 @@ describe Mondido::CreditCard::Transaction do
       before(:all) do
 
         uri = URI.parse(Mondido::Config::URI + '/transactions/201')
-        uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-        uri.password = Mondido::Credentials::PASSWORD.to_s
+        uri.user = Mondido::Credentials.merchant_id.to_s
+        uri.password = Mondido::Credentials.password.to_s
 
         json_error = {
           code: 128,
@@ -147,8 +147,8 @@ describe Mondido::CreditCard::Transaction do
 
       it 'raises ApiException errors.payment.declined' do
         uri = URI.parse(Mondido::Config::URI + '/transactions')
-        uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-        uri.password = Mondido::Credentials::PASSWORD.to_s
+        uri.user = Mondido::Credentials.merchant_id.to_s
+        uri.password = Mondido::Credentials.password.to_s
         json_transaction = File.read('spec/stubs/transaction.json')
         stub_request(:post, uri.to_s)
           .with(body: hash_including({card_cvv: '201'}))
@@ -168,8 +168,8 @@ describe Mondido::CreditCard::Transaction do
 
       before(:all) do
         uri = URI.parse(Mondido::Config::URI + '/transactions')
-        uri.user = Mondido::Credentials::MERCHANT_ID.to_s
-        uri.password = Mondido::Credentials::PASSWORD.to_s
+        uri.user = Mondido::Credentials.merchant_id.to_s
+        uri.password = Mondido::Credentials.password.to_s
         json_transaction = File.read('spec/stubs/transaction.json')
 
         stub_request(:post, uri.to_s)

data/spec/spec_helper.rb

@@ -12,8 +12,8 @@ end
 # Monkeymock the config class
 module Mondido
   class Credentials
-    MERCHANT_ID = 1
-    SECRET = 'secret'
-    PASSWORD = 'password'
+    def self.merchant_id; 1; end
+    def self.secret; 'secret'; end
+    def self.password; 'password'; end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mondido
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Robert Falkén
@@ -68,6 +68,7 @@ files:
 - lib/mondido/credit_card/transaction.rb
 - lib/mondido/exceptions/api_exception.rb
 - lib/mondido/exceptions/exceptions.rb
+- lib/mondido/exceptions/missing_file.rb
 - lib/mondido/exceptions/validation_exception.rb
 - lib/mondido/rest_client.rb
 - lib/mondido/version.rb