monban 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61a099fb20745246c9094ac5c9957119180cb452
-  data.tar.gz: 4f8aec070188cccfcb27c51692e2942dd67fafe6
+  metadata.gz: a4882c70c08f77f8bee4a55815cb3021bdae77dc
+  data.tar.gz: 1d9890913a18365a2fcc6b0399cf14c7f9c03689
 SHA512:
-  metadata.gz: 809a7eec54aa4327fd7c383088cd2a1a91cc53a4cc96eda43917f070a55c1b41986dce8bd58e7a6f3e0feefb42f25b119f31bf819ce4f07618693e536f0904f6
-  data.tar.gz: e7fc64a1393b18b6525962004143c3c82978c41fb4f0712c36186fccccb4da2675ec7db31a289742e33cef7ea1754c747e5ac9b9dcd26753f46dc0a78dbacc3d
+  metadata.gz: efbf4a103f0a617c39360272b77cd4f34a58426ad7964e3906fedea7e57e47ac684c02b19e608a10c4ec3f0326648ba6060987287ba45fa9b2257136e5a1109c
+  data.tar.gz: dad1fc0d96b979bef0337472c99e22ca4b8b8b8afdfdee0f7c058201ac485abf25694a60313db44887f418d6f6464e70275a1c44ade7f307b365a23254c423b3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    monban (1.0.0)
+    monban (1.1.0)
       bcrypt
       rails
       warden
@@ -120,10 +120,10 @@ GEM
       rspec-mocks (~> 3.3.0)
       rspec-support (~> 3.3.0)
     rspec-support (3.3.0)
-    sprockets (3.6.0)
+    sprockets (3.6.3)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
-    sprockets-rails (3.0.4)
+    sprockets-rails (3.1.1)
       actionpack (>= 4.0)
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
@@ -150,4 +150,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   1.11.2
+   1.12.5

data/NEWS.rdoc

@@ -1,3 +1,7 @@
+== 1.1.0
+* `Monban.config.sign_in_notice` should now be a callable object in order for I18n to work correctly
+* [DEPRECATED] you should no longer set `Monban.config.sign_in_notice` to a string value
+
 == 1.0.1
 * Wrap helper_method calls in respond_to?(:helper_method)
 * param_transformations now correctly use string keys

data/README.md

@@ -63,7 +63,7 @@ If you're trying to sign up a User in a console you won't be able to call User#n
 You should instead use the sign up service in order to create the user:
 
 ```ruby
-Monban.config.sign_up_service.new(email: "foo@example.com", password: "password").perform 
+Monban.config.sign_up_service.new(email: "foo@example.com", password: "password").perform
 ```
 
 #### Validations
@@ -122,6 +122,18 @@ end
 
 This article on the [Null Object Pattern](http://robots.thoughtbot.com/handling-associations-on-null-objects) provides a good explanation of why you might want to do this.
 
+#### Using I18n for sign in notice
+
+If you want to use I18n for the notice instructing users to sign in when they try to access an unauthorized page you can do so with the following configuration:
+
+```ruby
+Monban.configure do |config|
+  config.sign_in_notice = -> { I18n.t("sign_in_notice") }
+end
+```
+
+It is suggested to store this file at `config/initializers/monban.rb`
+
 ### Controller Additions
 
 Monban provides the following controller methods:
@@ -328,7 +340,7 @@ Monban::Configuration has lots of options for changing how monban works. Current
 * **user_lookup_field**: (default `:email`) Field in the database to lookup a user by.
 * **user_token_field**: (default `:password`) Field the form submits containing the undigested password.
 * **user_token_store_field**: (default: `:password_digest`) Field in the database that stores the user's digested password.
-* **user_class**: (default: `User`) The user class.
+* **user_class**: (default: `'User'`) The user class.
 
 ### Services
 
@@ -363,7 +375,7 @@ Here are a few of the current limitations of monban:
 
 ## Contributing
 
-1. Fork it
+1. [Fork it](https://github.com/halogenandtoast/monban/fork)
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/monban/configuration.rb

@@ -75,7 +75,15 @@ module Monban
     # @see #no_login_redirect
     def default_no_login_handler
       ->(controller) do
-        controller.flash.notice = Monban.config.sign_in_notice
+        notice = Monban.config.sign_in_notice
+
+        if notice.respond_to?(:call)
+          controller.flash.notice = notice.call
+        else
+          warn "[DEPRECATION] `Monban.config.sign_in_notice` should be a lambda instead of a string"
+          controller.flash.notice = notice
+        end
+
         controller.redirect_to Monban.config.no_login_redirect
       end
     end
@@ -95,7 +103,7 @@ module Monban
     end
 
     def setup_notices
-      @sign_in_notice = 'You must be signed in'
+      @sign_in_notice = -> { 'You must be signed in' }
     end
 
     def setup_class_defaults

data/lib/monban/version.rb

@@ -1,4 +1,4 @@
 module Monban
-  # 1.0.1
-  VERSION = "1.0.1"
+  # 1.1.0
+  VERSION = "1.1.0"
 end

data/spec/monban/controller_helpers_spec.rb

@@ -148,7 +148,7 @@ module Monban
       @dummy.require_login
       expect(@dummy.redirected).to eq(true)
       expect(@dummy.redirected_to).to eq(Monban.config.no_login_redirect)
-      expect(@dummy.flash.notice).to eq(Monban.config.sign_in_notice)
+      expect(@dummy.flash.notice).to eq(Monban.config.sign_in_notice.call)
     end
 
     it 'does not redirect when signed_in' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: monban
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - halogenandtoast
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-08 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails